task #3560
openfeature request #7491: [MASTER] Withheld unpublished taxa from webservice results and in DAOs
Withheld unpublished taxa from webservice used in E+M dataportal
70%
Description
see also #1780, #3740, #3739
the following services have been secured.
AbstractIdentifiableController:
- open:
- doGetTitleCache (not E+M)
BaseController:
- doGet
- open:
- doGetMethod
- doGetMethod
TaxonController:
- doGetClassifications
- doGetDescriptionElementsByType
- doGetDescriptions
- doGetFieldUnits
- doGetTaggedName (not yet correct)
- doGetTaxonNodes (not yet correct)
- open:
- doGetIncludedTaxa
- doGetTaxonNodeAgentRelations
- doListSpecimensOrObservations
- getAcceptedFor
TaxonPortalController:
- doGetSynonymy
- doGetTaxonNodes
- doGetTaxonRelations
- doGetMedia
- doGetSubtreeMedia
- doGetFromNameRelations
- doGetToNameRelations
TaxonListController
- doFind
- dofindByEverythingFullText
- doFindByFullText
- doSearch
- open:
- doFindBestMatchingTaxon
- dofindByDescriptionElementFullText
- doFindByIdentifier
- doFindByMarker
- doFindByNameParts
TaxonPortalListController
- no services
TaxonNodeController
- doPageChildNodes
- open:
- getParent()
ClassificationController
- getChildNodes
- getChildNodesAtRank
- getTaxonInContext
- open:
- getGroupedTaxaByHigherTaxon (not E+M)
- getGroupedTaxaByMarkedParents (not E+M)
ClassificationPortalController
- not relevant:
- getClassificationRootNode
ClassificationPortalListController
- getChildNodes
- getChildNodesAtRank
- getChildNodesOfTaxon
- getPathFromTaxon
- getPathFromTaxonToRank
- getSiblingsOfTaxon
ClassificationListController
- no services
DwcA-Controller:
- doDwcaTaxExport
General:
- open:
- check property paths in all controllers if they include taxa
- web-services from other controllers that return taxa as part of there result
Files
Related issues
Updated by Andreas Kohlbecker about 9 years ago
- Category changed from cdmserver to cdmlib-remote
Updated by Andreas Kohlbecker about 9 years ago
- Severity changed from critical to blocker
Updated by Andreas Kohlbecker about 9 years ago
- Priority changed from Priority08 to Highest
This must be implemented at the persistence level
TaxonDao
SpecimenDao
Search functions
can we use Hibernate filtered collections for this?
Updated by Andreas Kohlbecker about 9 years ago
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- Category changed from cdmlib-remote to cdmlib
- Subject changed from Withheld unpublished taxa and specimen from webservice results to Withheld unpublished taxa and specimen from webservice results and in DAOs
Updated by Andreas Kohlbecker about 9 years ago
- Severity changed from blocker to critical
for now we will use a second database for publishing, the entities marked as unpublished can be filtered out at the database level, so this issue is no longer a blocker.
Updated by Andreas Müller almost 7 years ago
- Target version changed from CDM UML 3.3/3.4 - Postprocessing to Unassigned CDM tickets
Updated by Andreas Müller almost 7 years ago
- Target version changed from Unassigned CDM tickets to Euro+Med Portal Release
Updated by Andreas Kohlbecker over 6 years ago
- Tags set to phycobank, Euro+Med
- Description updated (diff)
- Due date set to 03/31/2016
this is crucial for the phycobank.
Updated by Andreas Kohlbecker almost 6 years ago
- Related to feature request #3709: [E+M][Editor] sufficient rights management for E+M workflow added
Updated by Andreas Müller over 5 years ago
- Related to feature request #3740: Allow recursively setting the publish bit for TaxonBase added
Updated by Andreas Müller almost 5 years ago
- Priority changed from Highest to Priority14
- Estimated time set to 15:00 h
Updated by Andreas Müller almost 5 years ago
- Due date deleted (
03/31/2016) - Status changed from New to In Progress
- Priority changed from Priority14 to Highest
Updated by Andreas Müller almost 5 years ago
- Description updated (diff)
- % Done changed from 0 to 10
Updated by Andreas Müller almost 5 years ago
- Description updated (diff)
- % Done changed from 10 to 20
Updated by Andreas Müller almost 5 years ago
- Subject changed from Withheld unpublished taxa and specimen from webservice results and in DAOs to Withheld unpublished taxa from webservice results and in DAOs
Updated by Andreas Müller almost 5 years ago
- Precedes feature request #7457: E+M: Allow filtering for only published in search added
Updated by Andreas Müller almost 5 years ago
- Tags changed from phycobank, euro+med to phycobank, euro+med, search
Updated by Andreas Müller almost 5 years ago
- Target version changed from Euro+Med Portal Release to Release 5.1
Updated by Andreas Müller almost 5 years ago
- Subject changed from Withheld unpublished taxa from webservice results and in DAOs to Withheld unpublished taxa from webservice used in E+M dataportal
Updated by Andreas Müller almost 5 years ago
- Precedes feature request #7492: Withheld unpublished taxa from webservice used in other webservices added
Updated by Andreas Müller almost 5 years ago
- Category changed from cdmlib to cdmlib-remote
Updated by Andreas Müller almost 5 years ago
- % Done changed from 60 to 70
- Estimated time changed from 15:00 h to 2:00 h
Updated by Andreas Müller almost 5 years ago
- Description updated (diff)
- Status changed from In Progress to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
I still want to unify the handling of unpublished a bit, but maybe you can already start testing if there some services that urgently need to be protected to not show unpublished data in the data portal.
The general usecase to protect ALL webservices to not show unpublished data is handled in #7492 and is not part of this ticket.
Updated by Andreas Kohlbecker almost 5 years ago
Hi Andreas,
first of all I analyzed the logfile on the production server and created a statistics on all webservice calls that are send to the cdm-server.
By this we now have an overview on the webservice endpoints that are really used together with a usage count. The count corresponds to the number of calls to this endpoint as seen in the logfile.
I quickly went over the logfile and marked all webservice endpoints which potentially need filtering by the publish flag. Endpoints marked yellow needs further investigation, grey ones are ok. Other colors are explained in the sheet.
Updated by Andreas Kohlbecker almost 5 years ago
- File ws-endpoint-usage.ods added
Updated by Andreas Müller almost 5 years ago
Andreas Kohlbecker wrote:
first of all I analyzed the logfile on the production server and created a statistics on all webservice calls that are send to the cdm-server.
By this we now have an overview on the webservice endpoints that are really used together with a usage count. The count corresponds to the number of calls to this endpoint as seen in the logfile.I quickly went over the logfile and marked all webservice endpoints which potentially need filtering by the publish flag. Endpoints marked yellow needs further investigation, grey ones are ok. Other colors are explained in the sheet.
How do we want report further results/improvements? Handling in ods is not comfortable if 2 people work on it.
Some of the yellow services are already checked. See the overview in the ticket description.
Updated by Andreas Kohlbecker almost 5 years ago
- File ws-endpoint-usage.ods added
I updated the ws-endpoint-usage.ods spread sheet by the information from the issue description.
There are now only few controller methods left which need to be checked.
Andreas
Updated by Andreas Kohlbecker almost 5 years ago
- File deleted (
ws-endpoint-usage.ods)
Updated by Andreas Kohlbecker almost 5 years ago
- File ws-endpoint-usage.ods added
Updated by Andreas Kohlbecker almost 5 years ago
- File deleted (
ws-endpoint-usage.ods)
Updated by Andreas Müller almost 5 years ago
- Description updated (diff)
secured TaxonPortalController.doGetMedia and doGetSubtreeMedia
Updated by Andreas Müller almost 5 years ago
- Description updated (diff)
secured TaxonPortalController.doGetFromNameRelations and doGetToNameRelations
Updated by Andreas Müller almost 5 years ago
- Assignee changed from Andreas Kohlbecker to Andreas Müller
Updated by Andreas Müller over 4 years ago
- File ws-endpoint-usage.ods ws-endpoint-usage.ods added
Updated by Andreas Müller over 4 years ago
- File deleted (
ws-endpoint-usage.ods)
Updated by Andreas Müller over 4 years ago
- Related to bug #7745: Subtree filter for dataportal services added
Updated by Andreas Kohlbecker over 4 years ago
- Related to bug #7756: org.hibernate.QueryException in portal/taxon/{uuid}/subtree/media.json webservice related to relation direction param in prepareTaxonRelationshipQuery() added
Updated by Andreas Kohlbecker about 4 years ago
- Tags changed from phycobank, euro+med, search to phycobank, euro+med, search, security, permission
Updated by Andreas Müller almost 4 years ago
Can you please adapt the new information on doPageByRestrictions to the logic of the rest of the list? In general we follow the logic that the list shows the already secured web-services. Explicitly open issues are listed in an open: list. Same for not relevant:
Updated by Andreas Müller almost 4 years ago
Also this ticket is only about E+M data portal relevant webservices. For other webservices please use #7492.
Updated by Andreas Müller almost 4 years ago
Be aware that this ticket has already status resolved in 5.1. It's task description should not be enlarged anymore if not absolutely needed.
Updated by Andreas Kohlbecker almost 4 years ago
I cleaned the ticket up as requested
Updated by Andreas Müller over 3 years ago
- Related to task #8424: evaluate publish flags in the full derivative path added
Updated by Andreas Müller over 3 years ago
- Related to feature request #4484: Evaluate publish flag for derivates in data portal added
Updated by Andreas Müller about 3 years ago
- Related to feature request #8875: Filter data portal by taxonomic rank added
Updated by Andreas Müller about 2 years ago
- Related to bug #9559: OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units added