EDIT

Note: the selection dialog for the target taxon does show the "start" taxon too. This is not needed and should be filtered.

Moving the full description seems to work correctly.

Note: ~when moving full description to another taxon the new label of the description is: "Elements moved from ...". Can we remove "Elements" bei "Facts"? Is shorter and more according to our current terminology.~

Andreas Müller wrote:

Now, the fact is not removed from the old taxon. Only closing and reopening the taxon removes it.
I tested this for moving a single fact (being a single fact in a description).

Closing does not work if the taxon still needs to be saved. By save the fact is reattached to it without warning

If the target taxon is dirty and unsaved and gives a warning. It says ".... all other unsaved changes will be saved". It does not say, that ONLY the target taxon name editor will be saved.
If the later is the case we should clearly state this. E.g. "Warning - the target taxon is open in another window with unsaved changes. These changes will be saved automatically. To prevent ..."

We may also think about a triple choice "Save", "Discard changes", "Cancel". Than we need to adapt the above text slightly.

this fix was only for the menu entry in taxonnavigator, but I will have a look at the problems in factual data view.

Katja Luther wrote:

this fix was only for the menu entry in taxonnavigator, but I will have a look at the problems in factual data view.

OK.
If calling from navigator the facts and media view of the source taxon stays grey. Even if the warning comes that it has changes that need to be saved first, which should simply finish the operation without any changes.
But even if no changes existed in source the facts stay grey and you can't see if they were all removed... and you can't add some new facts if you want.

By the way, moving facts also moves image galleries. For the user this might be unexpected as for the user it is not clear that image galleries are handled same as DescriptionBases.

Maybe we should change this behavior or allow configuration.

Andreas Müller wrote:

By the way, moving facts also moves image galleries. For the user this might be unexpected as for the user it is not clear that image galleries are handled same as DescriptionBases.

Maybe we should change this behavior or allow configuration.

+1 for "change this behavior"

But then we should separately allow to also move media/image galleries. Otherwise it is difficult to handle images when a taxon is split, synonym swapt or any taxonomic operation takes place.

At least for the Media View we should offer a similar funtionality as for the facts view.

new ticket?

By the way, media galleries sooner or later will become an own class, not beeing DescriptionBase anymore. Then it will be handled sepatately anyway. But this still needs discussion.

Andreas Müller wrote:

Katja Luther wrote:

this fix was only for the menu entry in taxonnavigator, but I will have a look at the problems in factual data view.

OK.
If calling from navigator the facts and media view of the source taxon stays grey. Even if the warning comes that it has changes that need to be saved first, which should simply finish the operation without any changes.
But even if no changes existed in source the facts stay grey and you can't see if they were all removed... and you can't add some new facts if you want.

I can't reproduce this, the operation takes some time but if it is finished the facts view becomes white and you can see the facts.

Andreas Müller wrote:

Note: the selection dialog for the target taxon does show the "start" taxon too. This is not needed and should be filtered.

this is fixed

Andreas Müller wrote:

Now, the fact is not removed from the old taxon. Only closing and reopening the taxon removes it.
I tested this for moving a single fact (being a single fact in a description).

this is fixed

Andreas Müller wrote:

Note: when moving full description to another taxon the new label of the description is: "Elements moved from ...". Can we remove "Elements" bei "Facts"? Is shorter and more according to our current terminology.

fixed

this ticket is fixed, created a new ticket for not moving image galleries ( #7731) and for the same moving functionality in media view (#7730)

A minor issue: the processes often take time which is acceptable but an hourglass that the process is still ongoing is missing. So the user does not really know why he can not see a change yet.

Is it possible to add an hourglass?

It would be nice if the tap order of the editors could be the same as before saving. Currently the order changes which is confusing for the user (as he doesn't know that the editor is closed and reopened)

Now, changes in the source are saved properly. Changes in the target are not saved even when choosing "OK"

Also the request for saving now appears twice if both taxa are dirty. Once before selecting the target, and then after selecting the target. I think we should change the workflow.

• first select the target
• then warn if any of source or target is dirty (adapt test of warning, either "target taxon has..." or "source taxon..." "source and target taxa have..." unsaved changes
• use the same warning text for both (actually it will be only 1 text then so it must be more or less the same), currently it are completely differnt texts and even the button labels are different.

Note: The text "... ebnso werd alle weiteren ungespeicherten Änderunge gespeichert" of the current second warning is misleading. As far as I understand only the 2 taxa are saved, not ALL. Maybe better use the text of the first warning (note: I changed it slightly, so update code first)

Andreas Müller wrote:

Now, changes in the source are saved properly. Changes in the target are not saved even when choosing "OK"

missed to commit, is fixed now.