Project

General

Profile

Actions

feature request #3097

closed

disable editors if a user has insufficient grants for a taxon or taxon node.

Added by Andreas Kohlbecker over 10 years ago. Updated over 2 years ago.

Status:
Worksforme
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
-
Start date:
Due date:
% Done:

30%

Estimated time:
Severity:
normal

Description

belongs to #3095

TaxonNodes must only be enabled if a user has the full CRUD permissions on the classification subtree.

Formerly it was not possible to test this feature ("Currently this can not be tested due to the bug #3098 "CdmPermissionEvaluator can test for multiple permissions"), but this requirement is no longer valid, so testing is possible.

Still difficult to test due to #4300 (authority form does not work under windows)


Related issues

Related to EDIT - feature request #3095: protect taxa and nodesNewKatja Luther

Actions
Related to EDIT - bug #9021: Feedback for missing rights on TaxonNode missingNewKatja Luther

Actions
Related to EDIT - feature request #8239: Rights issues in TaxEditorNewKatja Luther

Actions
Actions #1

Updated by Andreas Kohlbecker over 10 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Andreas Kohlbecker over 10 years ago

for now the user will be granted to edit taxa the user has the permission UPDATE on the cdm entities in question. This can be easily changed afterwards to full CRUD permissions ALL}} since the required permissions are centralized in {{{eu.etaxonomy.taxeditor.security.RequiredPermissions

Actions #3

Updated by Andreas Kohlbecker over 10 years ago

first bits implemented TaxonEditor disabled, views still to do: r16009

Actions #4

Updated by Andreas Kohlbecker over 10 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

done r16012 r16013

Actions #5

Updated by Andreas Müller over 8 years ago

  • Priority changed from Priority08 to Highest
Actions #6

Updated by Andreas Müller almost 3 years ago

Actions #7

Updated by Andreas Müller almost 3 years ago

  • Tags set to security, permission
  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • Target version changed from 120 to Release 5.15

I am not sure if I understand what is meant here with "enabled".
Currently it seems possible to open a taxon but not to enter data in the details view for the name editor.

But it is possible to add new factual data but not all of them are editable in the details view (e.g. TextData text is not editable while Time scope is editable).
So there seem to be open issues. This is maybe also related to the problem that 2 dimensional rights are currently not yet fully implemented (e.g. rights to enter only factual data for a certain taxonomic subtree).

I give this ticket to KL as she is currently in charge for TaxEditor issues. Please discuss who should work on it. I also change milestone as the old milestone should be removed.

Actions #8

Updated by Andreas Müller almost 3 years ago

  • % Done changed from 0 to 30
Actions #9

Updated by Andreas Müller almost 3 years ago

  • Private changed from Yes to No
Actions #10

Updated by Katja Luther almost 3 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #11

Updated by Andreas Müller over 2 years ago

  • Related to bug #9021: Feedback for missing rights on TaxonNode missing added
Actions #12

Updated by Katja Luther over 2 years ago

  • Status changed from Feedback to Worksforme
  • Target version deleted (Release 5.18)

Andreas Müller wrote:

I am not sure if I understand what is meant here with "enabled".
Currently it seems possible to open a taxon but not to enter data in the details view for the name editor.

But it is possible to add new factual data but not all of them are editable in the details view (e.g. TextData text is not editable while Time scope is editable).
So there seem to be open issues. This is maybe also related to the problem that 2 dimensional rights are currently not yet fully implemented (e.g. rights to enter only factual data for a certain taxonomic subtree).

I give this ticket to KL as she is currently in charge for TaxEditor issues. Please discuss who should work on it. I also change milestone as the old milestone should be removed.

Now it is not possible to enter factual data anymore (this was tested for a user with Editor and Allow_for_Polygonaceae rights in Caryophyllales_spp) it was implemented for #8239

Actions #13

Updated by Katja Luther over 2 years ago

Actions #14

Updated by Andreas Kohlbecker over 2 years ago

  • Description updated (diff)
Actions

Also available in: Atom PDF