Project

General

Profile

Actions
Copy link

task #2925

closed

[DISCUSS]Do we need newly created objects for EntityCollectionSection

Added by Andreas Müller almost 12 years ago. Updated almost 6 years ago.

Status:
Worksforme
Priority:
Priority12
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

In AbstractEntityCollectionSection.createToolbar the add-Action requries createNewElement().

Is this really needed?

It creates strange looking result e.g. for adding a Scope to a DescriptionBase

Actions
Copy link
 #1

Updated by Andreas Müller almost 12 years ago

The Scope object itself is created in ScopeSection.createNewElement()

Actions
Copy link
 #2

Updated by Andreas Müller almost 6 years ago

  • Description updated (diff)
  • Status changed from New to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • Target version changed from TaxEditor Next Major Release to Release 5.1

To me this seems to be fixed, but not sure. Can you please double check in the code? If solved close as worksforme.

Actions
Copy link
 #3

Updated by Patrick Plitzner almost 6 years ago

  • Status changed from Feedback to Worksforme

The createNewElement() is needed to show the new (empty) element in the details view.

Actions
Copy link
 #4

Updated by Andreas Müller almost 6 years ago

  • Private changed from Yes to No
Actions
Copy link
 #5

Updated by Andreas Müller almost 6 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Andreas Müller almost 6 years ago

  • Target version deleted (Release 5.1)
Actions
Copy link

Also available in: Atom PDF