Project

General

Profile

Actions

task #2859

open

TaxonNameBase.getReferenceYear does not return inRef year

Added by Andreas Müller almost 10 years ago. Updated 7 months ago.

Status:
New
Priority:
Priority14
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal

Description

If nomRef doesn't have a date attached but inReference does we may think about returning the inReference year. However, we need to check first if this brakes any logic.

If we do implement it we may also use the new code within TaxonComparator.getIntegerDate() - see #2858

Actions #1

Updated by Andreas Müller 7 months ago

  • Description updated (diff)
  • Priority changed from Priority12 to Priority14
  • Target version changed from cdmlib - Old Next Major Release to Release 5.29

Generally this exact method does not seem to be used at all (I checked in cdmlib, vaadin and imports by call hiearchy and in TaxEditor by search for "getReferenceYear", so it could be deleted.

But at the same time the called method Reference.getYear() is called multiple times in cdmlib (and maybe others) and it has the same problem of not being recursive. At least for book sections (or other sections) it seems to make sense to make it recursive.

However, each call needs to be checked.

E.g. OriginalSourceFormatter.getShortCitationsDate() already does such a recursion. Maybe this can be merged then.

Actions #2

Updated by Andreas Müller 7 months ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF