Actions
task #2250
openTODO use AbstractPagerImpl.hasResultsInRange() where possible
Start date:
Due date:
% Done:
0%
Estimated time:
Severity:
normal
Description
in all service methods returning lists or pagers the following statement is being used to check if the query would return any records.
if(numberOfResults > 0) { // no point checking again
this should be replaced by
if(AbstractPagerImpl.hasResultsInRange(numberOfResults, pageNumber, pageSize){ // no point checking again
I added according TODO comments to most of these cases.
The reason for this actually is a bug which did the calculation of hasResultsInRange
incorrectly. So I decided that this should be done centrally in static method. The AbtractPagerImpl seems a good place for it since it is anyway planned to implement such functionality into it #691
Updated by Andreas Müller about 13 years ago
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Updated by Andreas Müller over 2 years ago
- Description updated (diff)
- Status changed from New to Feedback
- Target version changed from cdmlib - Old Next Major Release to Release 5.45
Is this still an open issue?
Updated by Andreas Kohlbecker over 2 years ago
- Status changed from Feedback to New
Andreas Müller wrote:
Is this still an open issue?
yepp!
Actions