Project

General

Profile

Actions

task #2250

open

TODO use AbstractPagerImpl.hasResultsInRange() where possible

Added by Andreas Kohlbecker almost 11 years ago. Updated about 2 months ago.

Status:
New
Priority:
Priority12
Category:
cdmlib
Target version:
Start date:
02/18/2011
Due date:
% Done:

0%

Estimated time:
Severity:
normal

Description

in all service methods returning lists or pagers the following statement is being used to check if the query would return any records.

if(numberOfResults > 0) { // no point checking again

this should be replaced by

if(AbstractPagerImpl.hasResultsInRange(numberOfResults, pageNumber, pageSize){ // no point checking again

I added according TODO comments to most of these cases.

The reason for this actually is a bug which did the calculation of hasResultsInRange incorrectly. So I decided that this should be done centrally in static method. The AbtractPagerImpl seems a good place for it since it is anyway planned to implement such functionality into it #691

Actions #1

Updated by Andreas Müller almost 11 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker
Actions #2

Updated by Andreas Müller 2 months ago

  • Description updated (diff)
  • Status changed from New to Feedback
  • Target version changed from cdmlib - Old Next Major Release to Release 5.29

Is this still an open issue?

Actions #3

Updated by Andreas Kohlbecker about 2 months ago

  • Status changed from Feedback to New

Andreas Müller wrote:

Is this still an open issue?

yepp!

Actions #4

Updated by Andreas Kohlbecker about 2 months ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF