Project

General

Profile

Actions

bug #10494

closed

Taxon child node computation still uses model instances

Added by Andreas Müller 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
major
Found in Version:
Tags:

Description

This results in low performance when recomputing the navigator tree in TaxEditor (and maybe others).

This creates problems in larger classifications (e.g. Hierarcium).

The finally called method is TaxonNodeDaoHibernateImpl.listChildNodesAsTaxonNodeDto() which loads a TaxonNode first before transforming it to a DTO. This may have been different when TaxonNodeDaoHibernateImpl.listChildNodesAsUuidAndTitleCache() still has been used in the past. This does not load a model instance.

Actions #1

Updated by Andreas Müller 3 months ago

  • Description updated (diff)
Actions #2

Updated by Katja Luther 3 months ago

  • Status changed from New to Resolved

This should be fixed, please review.

Actions #3

Updated by Andreas Müller 3 months ago

  • % Done changed from 0 to 70
Actions #4

Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Could you please check if the outer join for the sec reference is needed. This may be a performance issue (not sure). Maybe we should use different service layer methods for different use-cases that all load TaxonNodeDTOs.

Actions #5

Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

removed the outer join for the TaxonNodeDto creation of taxon navigator

Actions #6

Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 80

Katja Luther wrote in #note-5:

removed the outer join for the TaxonNodeDto creation of taxon navigator

Good! Can you do some performance testing with some critical taxa (e.g. E+M/Hierarcium species)? Quantitative or qualitative.

Just to get an idea if it looks like the performance really improved / is uncritical now.

Actions #7

Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Closed

Andreas Müller wrote in #note-6:

Katja Luther wrote in #note-5:

removed the outer join for the TaxonNodeDto creation of taxon navigator

Good! Can you do some performance testing with some critical taxa (e.g. E+M/Hierarcium species)? Quantitative or qualitative.

Just to get an idea if it looks like the performance really improved / is uncritical now.

tested it on test with Hieracium and the children where available immediately, so I think we can close this ticket.

Actions #8

Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.47 to Release 5.43
Actions

Also available in: Atom PDF