Project

General

Profile

Actions

bug #10411

closed

Show subareas of area trees in area selection dialogue for distribution editor

Added by Andreas Müller 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Found in Version:

Description

For area trees the subareas are not shown. This was observed in Flora of Georgia:

For vocabularies subareas are shown.


Files

clipboard-202310051737-7sz52.png (25.4 KB) clipboard-202310051737-7sz52.png Andreas Müller, 10/05/2023 05:37 PM
clipboard-202310271048-p1lch.png (10.2 KB) clipboard-202310271048-p1lch.png Andreas Müller, 10/27/2023 10:48 AM
Actions #1

Updated by Andreas Müller 11 months ago

Please also check if the tree order is taken from the term tree in case of selecting areas from the tree and having "natural order" selected. However, implementing this might be not so easy so probably we will need to create a new ticket for this.

Actions #2

Updated by Andreas Müller 11 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

I think this is already in progress.

Actions #3

Updated by Katja Luther 11 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 10 to 50

This is implemented. If a term is checked, which is also available in a tree, this node is checked as well and the other way round. Also for the buttons "select all children" and "select the subtree" it is implemented. Please review.

Actions #4

Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Feedback
  • % Done changed from 50 to 70

In most cases it works as expected. But loading the subareas does not work correctl. If I seclect e.g. Georgia and a subarea and e.g Caucasus and save. When reopening and removing Caucasus without opening the Georgia subtree the Georgian subarea after saving disappears from table. In case I open the subtree before saving second time it works as expected.

Actions #5

Updated by Andreas Müller 11 months ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions #6

Updated by Katja Luther 11 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-4:

In most cases it works as expected. But loading the subareas does not work correctl. If I seclect e.g. Georgia and a subarea and e.g Caucasus and save. When reopening and removing Caucasus without opening the Georgia subtree the Georgian subarea after saving disappears from table. In case I open the subtree before saving second time it works as expected.

The setCheckedElements for the viewer seems to quit the not visible elements therefore now the array of checked elements of the composite is used.
Please review.

Actions #7

Updated by Andreas Müller 11 months ago

Now when pressing the finish button a warning is shown "please check at least one item". Though these are checked - but not visible.

Actions #8

Updated by Katja Luther 11 months ago

  • Status changed from Feedback to In Progress

Andreas Müller wrote in #note-7:

Now when pressing the finish button a warning is shown "please check at least one item". Though these are checked - but not visible.

Ah, this is again because the treeViewer only knows about the visible checked elements... I adapted that.

Actions #9

Updated by Katja Luther 11 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

And the size is adapted, too. Please review.

Actions #10

Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

Now it works as expected.

Actions

Also available in: Atom PDF