Project

General

Profile

Actions

bug #10379

closed

Error in Portal if collection code is part of the accession number

Added by Wolf-Henning Kusber 12 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

Seen: http://phycobank.org/102935
The Collection code is B (correctly databased in PhycoBank)
The accession number is B 40 0045157 (correctly databased in PhycoBank)

The output (as of 08 August 2023) is
(B: 40 0045157)
This is incorrect because B is part of the accession number, thus duplication of the information is mandatory.
This collon "Doppelpunkt" is not common sense in the different botanical communities and should be topic for further discussion.

Technically this is a minor issue, but for the acceptance of PhycoBank this is major.


Files

Screenshot 2023-08-29 105106.png (110 KB) Screenshot 2023-08-29 105106.png Katja Luther, 08/29/2023 10:51 AM
Actions #1

Updated by Andreas Müller 11 months ago

  • Tags set to type designation, phycobank
  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from Priority14 to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.40

This seems to be a dataportal issue. The webservice returns the correct value: https://api.phycobank.org/phycobank/portal/typedesignation/5dd7c8b7-df47-4b8b-915c-1b71cc199ef9.json .
KL, can you have a look if this can be fixed easily. I guess we only need to remove the deduplication code which is generally unwanted now. Is this phycobank specific code or is it the same code which is also used for general taxon pages?

Actions #2

Updated by Katja Luther 11 months ago

Currently the titleCache and specimenlabel of the derivedUnit_dto are used, so we can adapt it in the webservice or we create a new string on portal side.

Actions #4

Updated by Katja Luther 11 months ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #5

Updated by Andreas Müller 11 months ago

  • Subject changed from Error in Portal if Collection code is part of the accession number to Error in Portal if collection code is part of the accession number
Actions #6

Updated by Andreas Müller 11 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 70
Actions #7

Updated by Andreas Müller 11 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Please review and afterwards pass to WHK for further review.

Maybe open new ticket for simplifying webservice calls for phycobank registration page.

Actions #8

Updated by Katja Luther 11 months ago

  • Assignee changed from Katja Luther to Wolf-Henning Kusber

Works as expected.

@WHK: Please do the final review.

Actions #9

Updated by Wolf-Henning Kusber 11 months ago

  • Assignee changed from Wolf-Henning Kusber to Katja Luther
  • % Done changed from 70 to 90

Review for http://phycobank.org/100352
Gomphonella coxiae in the Test portal:

SearchPreview (coming from a seached term in the portal): fine
http://phycobank.org/100352 Registration on 2019-07-09 13:24:32 +0200
Gomphonella coxiae R.Jahn & N.Abarca – Type: Germany, Brandenburg, Helenesee, alt. 40 m, 52°16'3.349"N, 14°30'11.876"E, 12 Jul 2017, R. Jahn & J. Zimmermann D201 (holotype: B 40 0042914)

Registration (Preview?) coming from the link above: Barcode with B okay, but there is a ":" between collection code and barcode
Gomphonella coxiae R.Jahn & N.Abarca in Pl. Ecol. Evol. 152(2): 236, fig. 13A-O, 14C. 20191
Holotype: Germany, Brandenburg, Helenesee, alt. 40 m, 52°16'3.349"N, 14°30'11.876"E, 12 Jul 2017, R. Jahn & J. Zimmermann D201 (B: B 40 0042914) http://herbarium.bgbm.org/object/B400042914

Name (coming from the linked name above): Barcode with B okay, but there is a ":" between collection code and barcode
Gomphonella coxiae R.Jahn & N.Abarca in Pl. Ecol. Evol. 152(2): 236, fig. 13A-O, 14C. 20191
Holotype: Germany, Brandenburg, Helenesee, alt. 40 m, 52°16'3.349"N, 14°30'11.876"E, 12 Jul 2017, R. Jahn & J. Zimmermann D201 (B: B 40 0042914) http://herbarium.bgbm.org/object/B400042914

Specimen page (coming from the linked barcode above): correctly displayed, fine!

Conclusion: the main problem that there was a ":" within the barcode is perfectly resolved.
A minor issue is that there is a ":" between Collection Code and Barcode. This is a minor layout issue, that works notfalls for me.

Actions #10

Updated by Katja Luther 11 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF