EDIT

This is generally fixed now. Please review.

During implementation I realized that in ModifierElement.setEntity() the combo_modifier != null part is never called.
So it looks like we can delete it. Do you agree.

In this code it was originally tried to set the recommende modifiers (but unsuccessful as it was not called).

Or should we adapt the code so this code is called (again)?

Can you please decide what is more consistent with other code?

What is missing in the current code is

combo_modifier.removeEmptyElement();

which is not nice as we do not need an empty element as soon as the value is set for the first time.

Is there a way to integrate this again?

Also we need to check if the recommended modifiers only mean the single states/values or for the complete categorical/numerical data record (which is the same modifier implementation as for all DescriptionElementBase subclasses. The later in general is missing a possibility of defining a list to take the modifiers from as far as I can see. This might be another ticket.

Andreas Müller wrote in #note-3:

This is generally fixed now. Please review.

During implementation I realized that in ModifierElement.setEntity() the combo_modifier != null part is never called.
So it looks like we can delete it. Do you agree.

In this code it was originally tried to set the recommende modifiers (but unsuccessful as it was not called).

Or should we adapt the code so this code is called (again)?

Can you please decide what is more consistent with other code?

What is missing in the current code is

combo_modifier.removeEmptyElement();

which is not nice as we do not need an empty element as soon as the value is set for the first time.

Is there a way to integrate this again?

You are right this part of the code is never reached. I will clean up the code and reintegrate the combo_modifier.removeEmptyElement().
-> this can be done by calling createDefinedTermComboElement() with a parameter defining the presence of an empty element.

Andreas Müller wrote in #note-5:

Also we need to check if the recommended modifiers only mean the single states/values or for the complete categorical/numerical data record (which is the same modifier implementation as for all DescriptionElementBase subclasses. The later in general is missing a possibility of defining a list to take the modifiers from as far as I can see. This might be another ticket.

I would move this to a new ticket.