Project

General

Profile

Actions

feature request #10337

closed

Allow supportedCategoricalEnumeration and recommendedModfiers for term collection

Added by Andreas Müller 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm
Target version:
Start date:
Due date:
% Done:

70%

Estimated time:
Severity:
normal

Description

... not only for vocabularies

These lists should be adapted as good as possible to the needs of a given project, so it should be much more flexibel then when using vocabularies only.


Related issues

Related to EDIT - bug #10340: Categorical and Quantitative Data details view must only show recommended modifiersClosedAndreas Müller

Actions
Related to EDIT - bug #10377: Changing recommended state collection in Character editor throws NPEClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller 10 months ago

  • Related to bug #10340: Categorical and Quantitative Data details view must only show recommended modifiers added
Actions #2

Updated by Andreas Müller 10 months ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 0 to 70

This should be fixed. Please review (especially if all functionality still works and if the code looks correct). I also did some renaming of classes in taxEditor to have it more consistent.

Can you also check if all classes are still needed?

There are e.g. classes like

RecommendedModifierCollectionsCollectionSection/RecommendedModifierCollectionsDtoCollectionSection
RecommendedModifierCollectionsElement/RecommendedModifierDtoCollectionsElement
RecommendedStateCollectionElement/RecommendedStateCollectionsDtoElement
RecommendedStateCollectionSection/RecommendedStateDtoCollectionsSection

Can the non-dto classes be deleted?

Actions #3

Updated by Andreas Müller 10 months ago

Please also check if #10340 can easily be fixed as it is related to this ticket.

Actions #4

Updated by Katja Luther 10 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-2:

This should be fixed. Please review (especially if all functionality still works and if the code looks correct). I also did some renaming of classes in taxEditor to have it more consistent.

Can you also check if all classes are still needed?

There are e.g. classes like

RecommendedModifierCollectionsCollectionSection/RecommendedModifierCollectionsDtoCollectionSection
RecommendedModifierCollectionsElement/RecommendedModifierDtoCollectionsElement
RecommendedStateCollectionElement/RecommendedStateCollectionsDtoElement
RecommendedStateCollectionSection/RecommendedStateDtoCollectionsSection

Can the non-dto classes be deleted?

I tested to add a tree as recommended state collection and as recommended modifier collection, this worked as expected.

Currently we need the dto and the non-dto elements because the vocabulary view still uses cdm entities

Actions #5

Updated by Andreas Müller 8 months ago

  • Related to bug #10377: Changing recommended state collection in Character editor throws NPE added
Actions

Also available in: Atom PDF