Project

General

Profile

Actions

feature request #10330

closed

Handle term tree distribution status for distributionInfo in dataportal

Added by Andreas Müller 11 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Priority14
Assignee:
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

split from #9503

See also blocked by information there.


Files

clipboard-202401161159-5ox1j.png (60.6 KB) clipboard-202401161159-5ox1j.png Andreas Müller, 01/16/2024 11:59 AM
clipboard-202401161159-plkuo.png (94.5 KB) clipboard-202401161159-plkuo.png Andreas Müller, 01/16/2024 11:59 AM
clipboard-202401161210-xk7x0.png (54.8 KB) clipboard-202401161210-xk7x0.png Andreas Müller, 01/16/2024 12:10 PM
clipboard-202401191403-ppv2o.png (3.99 KB) clipboard-202401191403-ppv2o.png Andreas Müller, 01/19/2024 02:03 PM
Screenshot 2024-01-30 095217.png (29 KB) Screenshot 2024-01-30 095217.png Katja Luther, 01/30/2024 09:53 AM
Screenshot 2024-01-30 095410.png (12.3 KB) Screenshot 2024-01-30 095410.png Katja Luther, 01/30/2024 09:54 AM
Screenshot 2024-01-30 095234.png (39.5 KB) Screenshot 2024-01-30 095234.png Katja Luther, 01/30/2024 09:55 AM
clipboard-202401312353-oywoo.png (123 KB) clipboard-202401312353-oywoo.png Andreas Müller, 01/31/2024 11:53 PM

Related issues

Related to EDIT - feature request #10322: Use DTOs for portal taxon page (cont.)In ProgressAndreas Müller

Actions
Related to EDIT - bug #8297: Fix condensed distribution string for E+MClosedAndreas Müller

Actions
Related to EDIT - feature request #9500: Allow removing certain distribution status from distribution publicationFeedbackAndreas Müller

Actions
Related to EDIT - feature request #10467: Distribution status filter for exportsNewAndreas Müller

Actions
Copied from EDIT - feature request #9503: Handle term tree of areas and distribution status for distributionInfo in dataportalClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller 11 months ago

  • Copied from feature request #9503: Handle term tree of areas and distribution status for distributionInfo in dataportal added
Actions #2

Updated by Andreas Müller 11 months ago

Actions #3

Updated by Andreas Müller 11 months ago

  • Related to bug #8297: Fix condensed distribution string for E+M added
Actions #4

Updated by Andreas Müller 7 months ago

  • Target version changed from Release 5.44 to Release 5.41
Actions #5

Updated by Andreas Müller 7 months ago

  • Related to feature request #9500: Allow removing certain distribution status from distribution publication added
Actions #6

Updated by Andreas Müller 6 months ago

  • Target version changed from Release 5.41 to Release 5.42
Actions #7

Updated by Katja Luther 5 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 0 to 50

This should be fixed.

Actions #8

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Please remove " (including hierarchical order)" from the documentation. I don't think that status hierarchy is considered somehow for the ordering. In general ordering is not so much done by the status tree. However, there are cases for which the status influences the ordering so in general we can keep the "ordering" in the documentation.

Actions #9

Updated by Andreas Müller 3 months ago

Tree is passed to the webservice but the result still shows areas for all status:

From test/E+M/Abies alba: https://test.e-taxonomy.eu/dataportal/preview/euromed/?q=cdm_dataportal/taxon/6a8e85bd-5e52-4ae2-9444-99128c87a672 (with use DTO/new taxon page switched off)

Actions #10

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-8:

Please remove " (including hierarchical order)" from the documentation. I don't think that status hierarchy is considered somehow for the ordering. In general ordering is not so much done by the status tree. However, there are cases for which the status influences the ordering so in general we can keep the "ordering" in the documentation.

done

Actions #11

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-9:

Tree is passed to the webservice but the result still shows areas for all status:

From test/E+M/Abies alba: https://test.e-taxonomy.eu/dataportal/preview/euromed/?q=cdm_dataportal/taxon/6a8e85bd-5e52-4ae2-9444-99128c87a672

This is a problem of the webservice, isn't it?

Actions #12

Updated by Andreas Müller 3 months ago

The status tree parameter does not seem to be available for old taxon pages:

We need to discuss if this is wanted. For now we need it primarily for E+M which uses the new taxon pages. Also depends on how difficult implementation is for old taxon pages.

Actions #13

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-11:

Andreas Müller wrote in #note-9:

...
This is a problem of the webservice, isn't it?

Probably yes, needs to be checked.

Actions #14

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-13:

Katja Luther wrote in #note-11:

Andreas Müller wrote in #note-9:

...
This is a problem of the webservice, isn't it?

Probably yes, needs to be checked.

I checked. And yes, it still needs to be implemented in the webservice: #9500

Actions #15

Updated by Andreas Müller 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #16

Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote in #note-14:

Andreas Müller wrote in #note-13:

Katja Luther wrote in #note-11:

Andreas Müller wrote in #note-9:

...
This is a problem of the webservice, isn't it?

Probably yes, needs to be checked.

I checked. And yes, it still needs to be implemented in the webservice: #9500

It is implemented now. Please review. For test see A. alba link in note-11

Actions #17

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-9:

Tree is passed to the webservice but the result still shows areas for all status:

From test/E+M/Abies alba: https://test.e-taxonomy.eu/dataportal/preview/euromed/?q=cdm_dataportal/taxon/6a8e85bd-5e52-4ae2-9444-99128c87a672 (with use DTO/new taxon page switched off)

Andreas Müller wrote in #note-12:

The status tree parameter does not seem to be available for old taxon pages:

We need to discuss if this is wanted. For now we need it primarily for E+M which uses the new taxon pages. Also depends on how difficult implementation is for old taxon pages.

This is implemented also on server side, now. So could you please add the parameter statusTree to this webservice, too?

Actions #18

Updated by Andreas Müller 3 months ago

  • % Done changed from 50 to 70

Katja Luther wrote in #note-10:

Andreas Müller wrote in #note-8:

Please remove " (including hierarchical order)" from the documentation. I don't think that status hierarchy is considered somehow for the ordering. In general ordering is not so much done by the status tree. However, there are cases for which the status influences the ordering so in general we can keep the "ordering" in the documentation.

done

I just realized that we should fully remove "ordering" from documentation as the status tree is currently never used for any ordering of the areas.

Actions #19

Updated by Andreas Müller 3 months ago

After release we need to add the parameter to the E+M dataportal.

Actions #20

Updated by Katja Luther 3 months ago

This is implemented also on server side, now. So could you please add the parameter statusTree to this webservice, too?

This is implemented with rev f91075bf6fcc89857a265eec4802a7f1532e46cb

Actions #21

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-10:

Andreas Müller wrote in #note-8:

Please remove " (including hierarchical order)" from the documentation. I don't think that status hierarchy is considered somehow for the ordering. In general ordering is not so much done by the status tree. However, there are cases for which the status influences the ordering so in general we can keep the "ordering" in the documentation.

done

It was still there. You removed it from area tree, not status tree. I reverted area tree and adapted status tree accordingly.

Actions #22

Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 70 to 100

Works as expected, now.

Actions #23

Updated by Andreas Müller 3 months ago

For some reason the maps are not shown if one removes any of the terms in use from the "Distribution status filter tree" (test/E+M) - except for the "undefined" term. The filter works correctly on the textual representations (full text and condensed string) but the map continously shows the loading symbol:

Actions #24

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-23:

For some reason the maps are not shown if one removes any of the terms in use from the "Distribution status filter tree" (test/E+M) - except for the "undefined" term. The filter works correctly on the textual representations (full text and condensed string) but the map continously shows the loading symbol:

I compared the mapUriParams and they are identical except for the one missing param (which is expected):

"as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:ffed6f,,0.1,|e:fdb462,,0.1,|f:c8c800,,0.1,|g:77ed6f,,0.1,|h:ffff00,,0.1,|i:00c8b4,,0.1,&ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Cy|e:Tu%28A%29|f:Da,Fe|h:Be,Fa,Lu,Sa|i:Tu%28E%29&title=g:endemic|a:native|b:naturalised|f:casual|c:introduced|d:introduced%3A+doubtfully+introduced+%28perhaps+cultivated+only%29|i:native%3A+presence+questionable|h:cultivated|e:native%3A+reported+in+error"
"as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:ffed6f,,0.1,|e:fdb462,,0.1,|f:c8c800,,0.1,|g:77ed6f,,0.1,|h:ffff00,,0.1,               &ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Cy|e:Tu%28A%29|f:Da,Fe|h:Be,Fa,Lu,Sa            &title=g:endemic|a:native|b:naturalised|f:casual|c:introduced|d:introduced%3A+doubtfully+introduced+%28perhaps+cultivated+only%29                                  |h:cultivated|e:native%3A+reported+in+error"
Actions #25

Updated by Andreas Müller 3 months ago

  • Priority changed from Highest to Priority14
Actions #26

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-23:

For some reason the maps are not shown if one removes any of the terms in use from the "Distribution status filter tree" (test/E+M) - except for the "undefined" term. The filter works correctly on the textual representations (full text and condensed string) but the map continously shows the loading symbol:

I tested it with euro+med test instance (removed "absent") but could not reproduce the problem. It takes some time but then shows the map.

Actions #27

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-26:

Andreas Müller wrote in #note-23:

For some reason the maps are not shown if one removes any of the terms in use from the "Distribution status filter tree" (test/E+M) - except for the "undefined" term. The filter works correctly on the textual representations (full text and condensed string) but the map continously shows the loading symbol:

I tested it with euro+med test instance (removed "absent") but could not reproduce the problem. It takes some time but then shows the map.

"Absent" is not a status that is in use in E+M. You should remove (or move to another tree) a status that is in use on the page you test.

Actions #28

Updated by Katja Luther 3 months ago

I could reproduce the problem, but still don't know why. The webservice is called, but it is no answer available and an error is shown in the debug window: "Uncaught TypeError: mapResponseArray is null"

the answer should look like this:

Actions #29

Updated by Katja Luther 3 months ago

Franck Theeten found out that a parameter is missing:

It seems that the parameter in “ad” was missing for the “f” class (see example below with fake values : f:Da,Fe| )

https://edit.africamuseum.be/edit_wp5/v1.4_dev/rest_gen.php?as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:fdb462,,0.1,|e:c8c800,,0.1,|f:77ed6f,,0.1,|g:ffff00,,0.1,|h:00c8b4,,0.1,&ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Tu%28A%29|e:Da,Fe|g:Be,Fa,Lu,Sa|f:Da,Fe|g:Be,Fa,Lu,Sa|h:Tu%28E%29&title=f:endemic|a:native|b:naturalised|e:casual|c:introduced|h:native%3A+presence+questionable|g:cultivated|d:native%3A+reported+in+error&&img=false&ms=512&recalculate=false&bbox=-73.75154791300535,13.198842406627175,107.31978601126292,71.652204700555

(original: )

https://edit.africamuseum.be/edit_wp5/v1.4_dev/rest_gen.php?as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:fdb462,,0.1,|e:c8c800,,0.1,|f:77ed6f,,0.1,|g:ffff00,,0.1,|h:00c8b4,,0.1,&ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Tu%28A%29|e:Da,Fe|g:Be,Fa,Lu,Sa|h:Tu%28E%29&title=f:endemic|a:native|b:naturalised|e:casual|c:introduced|h:native%3A+presence+questionable|g:cultivated|d:native%3A+reported+in+error&&img=false&ms=512&recalculate=false&bbox=-73.75154791300535,13.198842406627175,107.31978601126292,71.652204700555

Best regards,

Franck

Actions #30

Updated by Andreas Müller 3 months ago

Can you add information which taxon you checked and which status you removed?

Actions #31

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-24:

Andreas Müller wrote in #note-23:

For some reason the maps are not shown if one removes any of the terms in use from the "Distribution status filter tree" (test/E+M) - except for the "undefined" term. The filter works correctly on the textual representations (full text and condensed string) but the map continously shows the loading symbol:

I compared the mapUriParams and they are identical except for the one missing param (which is expected):

"as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:ffed6f,,0.1,|e:fdb462,,0.1,|f:c8c800,,0.1,|g:77ed6f,,0.1,|h:ffff00,,0.1,|i:00c8b4,,0.1,&ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Cy|e:Tu%28A%29|f:Da,Fe|h:Be,Fa,Lu,Sa|i:Tu%28E%29&title=g:endemic|a:native|b:naturalised|f:casual|c:introduced|d:introduced%3A+doubtfully+introduced+%28perhaps+cultivated+only%29|i:native%3A+presence+questionable|h:cultivated|e:native%3A+reported+in+error"
"as=a:008000,,0.1,|b:c86400,,0.1,|c:c89600,,0.1,|d:ffed6f,,0.1,|e:fdb462,,0.1,|f:c8c800,,0.1,|g:77ed6f,,0.1,|h:ffff00,,0.1,               &ad=euromed_2013%3Aemarea:a:Mk,Ge,Rm,Ga%28F%29,Cg,He,By,Ct,Sk,Uk%28U%29,Au%28A%29,Sl,It,Hs%28S%29,Al,Cs,Hs%28A%29,Ko,Po,Co,Bu,BH,Au%28L%29,Gr,Hu,Se|b:Br,Hb%28N%29,No,Su,Hb%28E%29|c:Es,Lt,Ho,La,Si%28S%29|d:Cy|e:Tu%28A%29|f:Da,Fe|h:Be,Fa,Lu,Sa            &title=g:endemic|a:native|b:naturalised|f:casual|c:introduced|d:introduced%3A+doubtfully+introduced+%28perhaps+cultivated+only%29                                  |h:cultivated|e:native%3A+reported+in+error"

As I described here the webservice itself did (in this example) not return incorrect data. So I wonder if it is really a distributionInfo webservice based error.

Actions #32

Updated by Andreas Müller 3 months ago

I could now reproduce by using the above (note-17) Abies alba link and removing "native" from the status tree. Again "endemic" is missing in ad (this time it is style "g").

    "as=a:c86400,,0.1,|b:c89600,,0.1,|c:ffed6f,,0.1,|d:ffff00,,0.1,|e:fdb462,,0.1,|f:c8c800,,0.1,|g:77ed6f,,0.1,|h:00c8b4,,0.1,&ad=euromed_2013%3Aemarea:a:Br,Hb%28N%29,No,Su,Hb%28E%29|b:Es,Lt,Ho,La,Si%28S%29|c:Cy|d:Be,Fa,Sa,Lu,Ga%28F%29|e:Tu%28A%29|f:Da,Fe|h:Tu%28E%29&title=g:endemic|a:naturalised|f:casual|b:introduced|c:introduced%3A+doubtfully+introduced+%28perhaps+cultivated+only%29|h:native%3A+presence+questionable|d:cultivated|e:native%3A+reported+in+error"

Interesting is that once "endemic" is also removed from the status it works again.

Also important to understand the "endemic" is only used by the area "Euro+Med" which is not shown on the map as it is a higher level area.

Actions #33

Updated by Andreas Müller 3 months ago

This should be fixed now. See #9500#note-34.

The above example works now with removing status "native"

Actions #34

Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

So I guess we can close this ticket.

Actions #35

Updated by Andreas Müller 3 months ago

Actions

Also available in: Atom PDF