Project

General

Profile

Actions

bug #10191

closed

Error message on taxon specimen page for non-atomized specimens

Added by Katja Luther 2 months ago. Updated 30 days ago.

Status:
Closed
Priority:
Priority13
Assignee:
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

Message is: Uninitialized string offset: -1 in drupal_substr() (line 640 of /var/www/drupal-7-cdm-dataportal/web/includes/unicode.inc

example:

https://cichorieae.e-taxonomy.net/portal/cdm_dataportal/taxon/b335ceee-d6c1-4c93-841d-3b4bd279d855/specimens


Files

Screenshot 2022-11-30 161421.png (20.5 KB) Screenshot 2022-11-30 161421.png Katja Luther, 11/30/2022 04:14 PM
Actions #1

Updated by Andreas Müller 2 months ago

  • Target version changed from Release 5.36 to Release 5.35
Actions #2

Updated by Katja Luther 2 months ago

This is caused by not atomised specimen, so the fields of the dto are not filled. We could use the summarylabel of the fieldunit dto, but that is not always a nice looking string. For the example mentioned above it would be the location, see screenshot

Actions #3

Updated by Katja Luther 2 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #4

Updated by Andreas Müller about 2 months ago

  • Subject changed from Uninitialized string offset: -1 in drupal_substr() (line 640 of /var/www/drupal-7-cdm-dataportal/web/includes/unicode.inc to Error message on taxon specimen page for non-atomized specimens
  • Description updated (diff)
  • % Done changed from 0 to 70
Actions #5

Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

This is definetely much better than before as the error messages are not shown anymore and the fields are filled with some information at least.

@Norbert: as this is your data (and I think there are many such partly atomized data in Cichorieae), what do you think about the solution?

@Katja: is there a reason why you span the text also over Herbaria and Types ? As Herbaria and Types is usually a preserved specimen information and not a field unit information this might be a bit confusing. Especially if there is Herbaria information available which is not shown this way.

Actions #6

Updated by Andreas Müller about 2 months ago

NoK:

https://test.e-taxonomy.eu/dataportal/preview/cichorieae/cdm_dataportal/taxon/b335ceee-d6c1-4c93-841d-3b4bd279d855/specimens looks OK for the time being.
The number of only partly atomized specimen data should be manageable.

Actions #7

Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

For unatomized field unit informations the label covers only the rows of field unit information, please review.

Actions #8

Updated by Andreas Müller about 2 months ago

  • Tags set to specimens-view-table
  • Priority changed from New to Priority13
  • % Done changed from 70 to 90

Looks fine.

We should do a final review on production after release.

Actions #9

Updated by Andreas Müller 30 days ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 90 to 100

This looks fine also on production so we close the ticket.

The data itself should still be cleaned up.

Actions

Also available in: Atom PDF