Project

General

Profile

Actions
Copy link

bug #10167

closed

Selecting an existing name and adding a new journal does not work for phycobank registration

Added by Andreas Müller about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Priority14
Assignee:
Andreas Müller
Category:
cdm-vaadin
Target version:
Release 5.36
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
critical
Found in Version:
Tags:
phycobank phycobank-ready-for-submitters

Description

copied from #10116#note-15

Not working as expected (user):

User wants to use an existing name to insert a new lecto-, neo- or epitype designation in a current workingset.

This is blocked because the user gets only the protected view of an existing name.
It is expected to have a button "save" to be availabele to use the given name for a new typification.

Step one: select a given name OK
Push "existing name" OK
See: existing name OK
Safe this existing name: not possible (this is the main problem).

Files

SubmitterNewJournal.PNG (62.3 KB) SubmitterNewJournal.PNG Andreas Müller, 10/11/2022 05:45 PM

Related issues

Related to EDIT - task #10268: Selecting an existing name as basionymFeedbackWolf-Henning Kusber

Actions
Related to EDIT - bug #10269: Selecting existing name for typificationClosedAndreas Müller

Actions
Actions
Copy link
 #1

Updated by Andreas Müller about 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20
Actions
Copy link
 #2

Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.33 to Release 5.35
Actions
Copy link
 #3

Updated by Andreas Müller about 1 year ago

  • Priority changed from New to Highest
  • Severity changed from normal to critical

WHK:

Ich habe jetzt als Submitter mit beschränkten Rechten ein paar Fälle getestet. Inzwischen geht dort Einiges aber noch nicht alles.
Probleme sind die Anlage eines neuen Journals (das kann immer mal wieder vorkomme, immer dann wenn in einem unbekannten Journal das erste mal ein Submitter publizieren will)
Probleme macht auch (wir sprachen darüber) für Submitter wenn ein vorhandener Name typisiert wird: nur read-only Ansicht ohne „speichern“, Du hattest den Sinn dieser Funktion heute in Frage gestellt.

User „testsuerWHK“ im Test System PhycoBank, nur Fehler, die mit Curator-Rechten inzwischen gefixt sind, aber mit Submitter-Rechten noch bestehen

Referenz neu anlegen:
Wenn Journal/Book in list: okay
Wenn Journal/Book neu anzulegen: Fehlermeldung. Referenz mit neuem Journal nicht speicherbar.

Aber neuer Journaltitel trotzdem gespeichert.
Wenn ich die Referenz wegwerfe und neu anlege, ist der neue Journaltitel auswählbar.

Vorhandenen Namen nutzen. Bekomme nur „read only“ Ansicht und kann nicht speichern.

Was ohne Probleme geht:

  • Neueingabe Referenz in bekannter Zeitschrift
  • Neueingabe von Autorenteam mit bekannten und unbekannten Autoren
  • Neueingae Taxon, Art, Gattung etc.
  • Neueingabe Gattungsname mit Namenstypus aus derselben Referenz
  • Auswahl eines Basionyms
  • Recht des Nutzers von „preparation“ auf „curation“ zu gehen womit die Bearbeitung nur noch durch Kuratorrecht möglich ist (ist so gewollt).
Actions
Copy link
 #5

Updated by Andreas Müller 11 months ago

  • Target version changed from Release 5.35 to Release 5.43
Actions
Copy link
 #6

Updated by Andreas Müller 9 months ago

New Journal: problem is, that variable crud is not set for the in-reference presenter. This is missing in ReferenceEditorPresenter.onReferenceEditorAction()

Actions
Copy link
 #7

Updated by Andreas Müller 9 months ago

  • Subject changed from Selecting an existing name does not work for phycobank registration to Selecting an existing name and adding a new journal does not work for phycobank registration
Actions
Copy link
 #8

Updated by Andreas Müller 9 months ago

  • % Done changed from 20 to 40

Andreas Müller wrote in #note-3:

WHK:

Wenn Journal/Book neu anzulegen: Fehlermeldung. Referenz mit neuem Journal nicht speicherbar.

This should be fixed now. Please review.

Actions
Copy link
 #9

Updated by Andreas Müller 9 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 60

Should generally work now. Some fine tuning still necessary (e.g. status message and which fields are read-only etc.)

Please start reviewing.

Actions
Copy link
 #10

Updated by Andreas Müller 9 months ago

  • Assignee changed from Andreas Müller to Wolf-Henning Kusber
Actions
Copy link
 #11

Updated by Andreas Müller 9 months ago

  • Related to task #10268: Selecting an existing name as basionym added
Actions
Copy link
 #12

Updated by Wolf-Henning Kusber 9 months ago

Main descripton related to #10269

Actions
Copy link
 #13

Updated by Andreas Müller 9 months ago

  • Related to bug #10269: Selecting existing name for typification added
Actions
Copy link
 #14

Updated by Wolf-Henning Kusber 9 months ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Müller
  • % Done changed from 60 to 100

The bugs mentioned in this Ticket are fixed. This ticket can be closed. (The linked tickets are extra tasks). This ticket can be closed.

Actions
Copy link
 #15

Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #16

Updated by Andreas Müller 9 months ago

  • Status changed from Closed to Resolved
  • % Done changed from 100 to 90

Maybe we still need to check if the journal editing rights are taken away from the submitter again appropriately.

Actions
Copy link
 #17

Updated by Andreas Müller 9 months ago

  • Target version changed from Release 5.43 to Release 5.36
Actions
Copy link
 #18

Updated by Andreas Müller 9 months ago

  • Priority changed from Highest to Priority14
Actions
Copy link
 #20

Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

Andreas Müller wrote in #note-16:

Maybe we still need to check if the journal editing rights are taken away from the submitter again appropriately.

I created a general rights removal checking ticket: #10290.

So we can close this one here.

Actions
Copy link

Also available in: Atom PDF