Project

General

Profile

Actions
Copy link

feature request #10081

closed

Show name in source for sec ref of accepted taxon

Added by Andreas Müller over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Priority14
Assignee:
Katja Luther
Category:
cdm-dataportal
Target version:
Release 5.32
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal
Tags:
formatting

Description

WGB:

ich finde kein Setting, mit dem ich den Name in Source bei der sec. Ref. des [akzeptierten] Taxons ausgeben kann.

===

Needs to implemented in all publications (at least in dataportal and CDM light). We need to discuss if this should be done in the formatter or in some other way. Probably the formatter is the best place.

Files

Download all files
clipboard-202207051340-9pmf5.png (7.18 KB) clipboard-202207051340-9pmf5.png Andreas Müller, 07/05/2022 01:40 PM
clipboard-202207051340-xxlus.png (1.64 KB) clipboard-202207051340-xxlus.png Andreas Müller, 07/05/2022 01:40 PM

Related issues

Related to EDIT - feature request #9327: Make taxon secundum reference an original sourceClosedAndreas Müller

Actions
Related to EDIT - feature request #9329: Implement sec reference as original source in dataportalClosedAndreas Kohlbecker

Actions
Actions
Copy link
 #1

Updated by Andreas Müller over 1 year ago

Actions
Copy link
 #2

Updated by Andreas Müller over 1 year ago

Actions
Copy link
 #3

Updated by Andreas Müller over 1 year ago

AM:

Könntest du kurz ein Beispiel geben, wie das genau formattiert werden soll? Also ob mit eckiger(?) Klammer drum herum, mit Namensautor, wenn vorhanden, und an welcher Stelle genau (komplett ans Ende?), etc.

WGB:

im Portal am liebsten so:
Achyranthes sandwicensis (A.Gray ex H.Mann) Di Vincenzo, M.Wondafrash, Berendsohn & Borsch sec. Wagner & al. 2005+: 23 jun 2022 (sub Nototrichium sandwicensis).
Autor muss nicht sein, da der Name ja in der Synonymie zu finden sein sollte.

Actions
Copy link
 #4

Updated by Andreas Müller over 1 year ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

I implemented the cache strategy part. Katja, can you please take over and check what needs to be done for the portals and the CDMlight to show it there (if it is not yet shown).

Actions
Copy link
 #5

Updated by Andreas Müller over 1 year ago

... and can you also please review my implementation.

Actions
Copy link
 #6

Updated by Andreas Müller over 1 year ago

  • Tags set to formatting
Actions
Copy link
 #7

Updated by Andreas Müller over 1 year ago

  • Category changed from cdmlib to cdm-dataportal
Actions
Copy link
 #8

Updated by Katja Luther over 1 year ago

Actions
Copy link
 #9

Updated by Katja Luther over 1 year ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 30 to 60
Actions
Copy link
 #10

Updated by Andreas Müller over 1 year ago

The current formatting shows brackets and "sub" in italics but only the name parts should be in italics.

This is because italics is inherited from span class="name" which is a parent of the separator span.

We should compare how this is done e.g. for infra specific markers in trinomials (these markers are not in italics). Also we need to check if the hierarchy is generally correct. The sub... part is not part of the taxon name but of the source. Therefore it should maybe not be a child of the TaxonName span.

Actions
Copy link
 #11

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Set the font-style for separator to normal, this is the way it is done for markers. Please review.
I also will have a look whether we should do the only for the taxonname and add a separate tag for the sub xxx string.

Actions
Copy link
 #12

Updated by Katja Luther about 1 year ago

Added a new tag for the separators surrounding the name used in source, this is extracted from the taggedTaxon and if secundum reference should be displayed (), also the name used in source is displayed.
A follow up ticket should handle the possibility to show the name in source for secundum or not.

Actions
Copy link
 #13

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 60 to 80

Generally works but there is an unwanted whitespace after the closing bracket.

See https://test.e-taxonomy.eu/dataportal/preview/cyprus/cdm_dataportal/taxon/cc4d0f64-6279-46ef-b098-1633f2afd584/synonymy as an example (I created this example as the above example from int-server does not work anymore - secundum part is not switched on there). Originally the secundum part is not switched on for cyprus so we may want to remove it after closing this ticket.

Actions
Copy link
 #14

Updated by Andreas Müller about 1 year ago

Tests and improved handling of secundum part is handled in #10085

Actions
Copy link
 #15

Updated by Andreas Müller about 1 year ago

I also implemented for CDM light (9e545c61). This was still missing as CDM light does not use the TaxonDefaultCacheStrategy for taxon related output.

As asked by WGB in separate Mail I added the following 3 columns in Taxon.csv:

No label description
8 SecSubName_Fk Uuid of the accepted name in the sec. reference
9 SecSubName Accepted name in the sec. reference w/o authors
10 SecSubNameAuthors Author string of the accepted name in the sec. ref.
Actions
Copy link
 #16

Updated by Andreas Müller about 1 year ago

  • Status changed from Feedback to Resolved
  • Priority changed from New to Priority14

Please still remove the whitespace (see #note-13 and review the cdmlight implementation). Then we can close the ticket.

Actions
Copy link
 #17

Updated by Katja Luther about 1 year ago

  • Status changed from Resolved to Closed

The whitespace is removed, so I close this ticket

Actions
Copy link

Also available in: Atom PDF