Andreas Kohlbecker's activity
From 07/25/2019 to 08/23/2019
08/23/2019
- 01:12 PM EDIT bug #8482 (Feedback): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
- The problems obviously is fixed and the implementation looks good. Why did you comment the commit with "workaround"? ...
- 01:06 PM EDIT task #8437 (Resolved): ITermTreeService provides a list method which supports filtering by TermTree.termType,
- my implementation now is generic.
> Also it might be nice to have a little test that it works. Have you tested in ... - 12:59 PM EDIT Revision acdfa184 (cdmlib): ref #8437 using TermType.getGeneralizationOf() to expand the termType restriction
- 12:07 PM EDIT task #8406 (Closed): specimens and occurrence code cleaning and harmonization
- dead code removed.
I think we can close this issue now since all open tasks have been copied to other tickets. - 12:05 PM EDIT Revision c1639218 (cdm-dataportal): ref #8406 removing commented dead code
08/22/2019
- 06:24 PM PhycoBank Wiki edit: RegistrationWorkflow (#10)
- 12:12 PM PhycoBank Wiki edit: RegistrationWorkflow (#9)
- 12:11 PM PhycoBank Wiki edit: RegistrationWorkflow (#8)
- 12:06 PM PhycoBank Wiki edit: RegistrationWorkflow (#7)
- 11:40 AM PhycoBank Wiki edit: RegistrationWorkflow (#6)
- 11:39 AM PhycoBank Wiki edit: RegistrationWorkflow (#5)
- 11:39 AM PhycoBank Wiki edit: RegistrationWorkflow (#4)
- 11:37 AM PhycoBank Wiki edit: RegistrationWorkflow (#3)
- 11:36 AM PhycoBank Wiki edit: RegistrationWorkflow (#2)
- 11:08 AM PhycoBank Wiki edit: RegistrationWorkflow (#1)
- 06:16 PM PhycoBank Wiki edit: RegistrationWorkflowWithPensoftPublishers (#1)
- 11:34 AM EDIT Revision 7f9d6ac4 (cdm-vaadin): removing vaading testbench test
- 11:33 AM EDIT Revision c4ce17b3 (cdm-vaadin): removing runtime artifact
- 11:07 AM PhycoBank Wiki edit: Wiki (#8)
- 11:07 AM PhycoBank Wiki edit: Wiki (#7)
- 11:04 AM PhycoBank Wiki edit: Wiki (#6)
08/21/2019
- 11:18 AM EDIT bug #8482 (Closed): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
- Can be reproduced by:
http://int.e-taxonomy.eu/cdmserver/integration_palmae/portal/taxon/ce870eca-0422-4a3c-b849-0... - 09:17 AM EDIT feature request #8339: Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
- Hallo Andreas,
danke für deine Einschätzung. Da du mich in meiner Auffassung bestätigst, werde ich das "is accept... - 09:17 AM EDIT feature request #8339: Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
- Hallo Andreas,
das war mir völlig unbekannt, dass wir sowas überhaupt haben/hatten. Daher hatte ich das ganze...
08/13/2019
- 12:02 PM EDIT bug #8462 (Closed): NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
- Reported by Henning on 04.08.19 19:17
**Fehler in PhycoBank, 102010, Treptacantha ballesterosii**
Beim Specie...
08/12/2019
- 05:44 PM EDIT bug #8448 (Closed): Maps settings > Bounding box inconsistent
- works
- 05:43 PM EDIT task #8414 (Closed): occurrence controller code cleaning and harmonization
- all remaining tasks copied to new tickets
- 05:39 PM EDIT task #8458 (Closed): document FieldUnitDTOOccurrenceServiceImpl.findFieldUnitDTO()
- `FieldUnitDTO OccurrenceServiceImpl.findFieldUnitDTO(DerivateDTO derivedUnitDTO, Collection<FieldUnitDTO> fieldUnits,...
- 05:36 PM EDIT task #8457 (Duplicate): FieldUnitDTO: remove taxonRelatedDerivedUnits
- duplicates #8425
- 05:33 PM EDIT task #8457 (Duplicate): FieldUnitDTO: remove taxonRelatedDerivedUnits
- copied from #8414
FieldUnitDTO.taxonRelatedDerivedUnits is an obsolete remain from an older implementation an ne... - 05:31 PM EDIT task #8456 (Closed): FieldUnitDTO: remove newInstanceMethod
- copied from #8414
FieldUnitDTO providing a newInstance method. This has to be removed:
~~~
/**
* @pa... - 05:08 PM EDIT task #8166 (Closed): Adapt dataportal to term structure changes
- profile settings are working in the above test portals (palmweb has not been tested, since there is no cdm test insta...
- 04:47 PM EDIT bug #8440 (Closed): specimen accession numbers link to specimen page
- Wolf-Henning Kusber wrote:
>
> Warning in Test portal
> Notice: Array to string conversion in theme_item_list(... - 04:46 PM EDIT task #8455 (New): Show specimen preferredStableURL as external link icon?
- copied from #8440 , needs discussion.
- 04:27 PM EDIT task #8449 (Closed): improve layout of registration page to clearly show the nomencaltural act
- 04:26 PM EDIT task #8436 (Closed): featureTree/* services should filter the termTrees by the TermType Feature
- 04:18 PM EDIT Revision 1a5b2194 (cdmlib): ref #8437 fixing LIE in DerivedUnitFacadeController
- 01:38 PM EDIT task #8406 (Feedback): specimens and occurrence code cleaning and harmonization
- thank you for fixing this.
there are two commented code parts in this method:
~~~php
// $specimen_t... - 01:27 PM EDIT Revision f41c2b5e (cdm-dataportal): avoid accessing uninitialized variable
- 01:27 PM EDIT Revision 1f2c4dcf (cdm-dataportal): ref #8449 adapting test
- 01:27 PM EDIT Revision d80b3059 (cdm-dataportal): ref #8440 adapting and extending tests
- 12:06 PM EDIT task #8437 (Resolved): ITermTreeService provides a list method which supports filtering by TermTree.termType,
- Agreed ... and implemented in the way you pointed out.
- 12:05 PM EDIT Revision 19b30c4f (cdmlib): ref #8437 ITermTreeService termType Feature as filter includes also Character
08/07/2019
- 10:00 PM EDIT task #8449 (Resolved): improve layout of registration page to clearly show the nomencaltural act
- please review
- 09:44 PM EDIT task #8449 (Closed): improve layout of registration page to clearly show the nomencaltural act
- As discussed with Henning on Friday 2nd of August 2019, we decided for the following solution:
* the nomenclatural... - 09:47 PM EDIT Revision c5abae79 (cdm-dataportal): ref #8449 registration page: better emphasizing the nomenclatural act to make clear what has been registered
- 04:54 PM EDIT feature request #8403 (Rejected): name page: show types specimens as expandable derivate tree
- 04:54 PM EDIT feature request #8403 (Closed): name page: show types specimens as expandable derivate tree
- Andreas Kohlbecker wrote:
> code need to be cleaned up
done!
- 04:53 PM EDIT Revision a44d210c (cdm-dataportal): ref #8403 removing rejected implementation
- 04:50 PM EDIT bug #8440 (Resolved): specimen accession numbers link to specimen page
- please review
- 04:48 PM EDIT Revision e69c4103 (cdm-dataportal): ref #8440 consistent display of type specimens: link to specimen page and showing preferredStableUri
- 03:52 PM EDIT bug #8448 (Resolved): Maps settings > Bounding box inconsistent
- 03:37 PM EDIT bug #8448 (Closed): Maps settings > Bounding box inconsistent
- according to the settings documentation the *Bounding box* needs to be entered in degree.
After fixing #8430 using... - 03:51 PM EDIT Revision 8e2d0259 (cdm-dataportal): ref #8448 changing the map setting to use the projection conform bbox
- 03:07 PM EDIT Revision 2e63da0d (cdm-dataportal): Merge tag '5.8.3' into develop
- tagging hotfix 5.8.3
- 03:07 PM EDIT Revision 51624a65 (cdm-dataportal): Merge branch 'hotfix/5.8.3'
- 03:06 PM EDIT Revision e39effec (cdm-dataportal): ref #8430 fixing pojection definition for epsg:7777777 (euromed)
- 02:43 PM EDIT Wiki edit: MapRestServiceApi (#66)
- 02:39 PM EDIT Revision 49c7b44e (cdm-dataportal): ref #8430 fixing pojection definition for epsg:7777777 (euromed)
- 12:15 PM EDIT task #8445 (Closed): improve service description
- a.mueller wrote:
„UTIS connects the web services of the Pan-European Species directories Infrastructure (EU-Nomen)... - 09:31 AM EDIT Revision 5593cba0 (cdmlib): fixing NPE in DerivedUnitFacadeCacheStrategy.getUnitNumber()
08/05/2019
- 10:37 AM EDIT task #8437: ITermTreeService provides a list method which supports filtering by TermTree.termType,
- Andreas Müller wrote:
> Have you tested with termType = Character which is a subtype for Feature. I don't think the ...
08/02/2019
- 05:54 PM EDIT Revision 48468c67 (cdm-dataportal): ref #8440 specimen accession numbers link to specimen page
- 05:53 PM EDIT feature request #8403 (In Progress): name page: show types specimens as expandable derivate tree
- code need to be cleaned up
- 05:52 PM EDIT feature request #8403 (Rejected): name page: show types specimens as expandable derivate tree
- This feature request has been rejected in favor of #8440
- 05:51 PM EDIT bug #8440 (Closed): specimen accession numbers link to specimen page
- The specimen accession numbers, aka specimen labels, should be clickable links to the specimen page.
This is neede... - 05:47 PM EDIT Revision 7449720a (cdmlib): ref #8365 adding combination of collection code and unit number as specimenLabel to DerivedUnitFacade
- 12:01 PM EDIT task #8438 (Closed): remove featureTree/* web services in August 2021 if they are unused
- If the featureTree/* web services are no longer used since 2 years we can safely remove them.
Check the cdm-server... - 11:56 AM EDIT task #8434 (Closed): Change FeatureTree contollers to TermTree controllers
- 11:55 AM EDIT task #8166 (Resolved): Adapt dataportal to term structure changes
- check taxon profile settings in a couple of test portals:
* Cichorieae
* Corvidea
* Palmweb
* Cyprus - 11:54 AM EDIT Revision 9725f08e (cdm-dataportal): ref #8166 using ternmType filter to restrict to feature trees only
- 11:19 AM EDIT task #8437 (Resolved): ITermTreeService provides a list method which supports filtering by TermTree.termType,
- please can you review my changes?
- 11:18 AM EDIT task #8436 (Resolved): featureTree/* services should filter the termTrees by the TermType Feature
- Applied in changeset commit:cdmlib|0f5323457637b6f2214287eb3101c7db121540f5.
- 11:18 AM EDIT Revision 0f532345 (cdmlib): fix #8436 termTree/* services with termType filter and featureTree/* services restricted to feature trees only
- 11:18 AM EDIT Revision 2ef4c225 (cdmlib): ref #8437 using the listByRestriction method in favour of a new untested dao method & implementing page method in ITermTreeService
08/01/2019
- 06:01 PM EDIT Revision 8cf6974b (cdmlib): ref #8434 removing deprecated featureNode/* web service mapping as this was never used since one year
- 05:58 PM EDIT Revision 9dddc68a (cdm-dataportal): ref #8166 adapting dataportal to TermTree novelties: using new term tree controller endpoints
- 12:26 PM EDIT task #8437 (Resolved): ITermTreeService provides a list method which supports filtering by TermTree.termType,
- e.g.:
~~~java
public List<TermTree> list(TermType termType, Integer limit, Integer start, List<OrderHint> orde... - 12:23 PM EDIT task #8436 (Closed): featureTree/* services should filter the termTrees by the TermType Feature
- Die featureTree/* Service-Endpunkte sollte selbe Verhalten anzubieten wie zuvor (#8434). In diesem Fall sollte hinter...
- 11:36 AM EDIT task #8435 (New): Reduce logging amount of exports and other long running tasks
- One single CDMLight export of the euromed database produces 49173 lines of logging like :
~~~
[euromed] 2019-07-3... - 08:49 AM EDIT Revision 50369001 (cdmlib): ref #8434 turing FeatureTree contollers into TermTree controllers
- 08:28 AM EDIT task #8434 (Closed): Change FeatureTree contollers to TermTree controllers
- The `FeatureTree` contollers need to be adapted to the changes which have been applied for #6794:
* rename Featur...
07/31/2019
- 07:09 PM EDIT Revision 062686a1 (cdm-dataportal): adding missing quotes which broke the profile image
- 06:54 PM EDIT Revision 34852f2d (cdm-dataportal): ref #8415 using accepted name uuid to get the types if no other taxa are in the homotypical group
- 06:43 PM EDIT Revision 02e8615c (cdm-dataportal): refactoring cdm_dataportal_taxon_page_specimens() to compose function
- 03:06 PM EDIT task #8405 (Rejected): Adapt cdm-vaadin to term structure changes
- I deed, there is nothing to do about this in the cdm-vaadin project.
- 03:01 PM EDIT task #8406 (Resolved): specimens and occurrence code cleaning and harmonization
- Hi Katja,
can you please have a look if everything is as it was intended? - 02:58 PM EDIT bug #8395 (Closed): NullPointerException (NPE) in NameCatalogueController
- This is fully solved.
- 02:57 PM EDIT task #8414 (In Progress): occurrence controller code cleaning and harmonization
- 02:53 PM EDIT Revision 3d14fdcf (cdm-dataportal): ref #8415 avoiding uninitialized variable
- 02:40 PM EDIT Revision a41f5463 (cdm-dataportal): Merge tag '5.8.2' into develop
- tagging hotfix 5.8.2
- 02:40 PM EDIT Revision 4050c450 (cdm-dataportal): Merge branch 'hotfix/5.8.2'
- 02:40 PM EDIT Revision a77b6a1d (cdm-dataportal): fix #8430 fixing bbox transformation from data layer to base layer projection
- 02:32 PM EDIT bug #8426 (Closed): IndexOutOfBoundsException during serialization of RegistrationWorkingSet
- findFirst() will returns an Optional describing the first element of this stream, or an empty Optional if the stream ...
- 02:15 PM EDIT Revision af8e4c4e (cdmlib): ref #8414 adding cycle detection to loadFieldUnitDTO()
- 09:04 AM EDIT bug #8430: maps zoom to wrong bbox with some layers
- This should now be fixed for all situations. Could you please take a second look?
- 08:45 AM EDIT bug #8430 (Resolved): maps zoom to wrong bbox with some layers
- Applied in changeset commit:cdm-dataportal|779840f48519040a2ab59db5b7881ef0a265d6a8.
- 08:43 AM EDIT bug #8430 (Closed): maps zoom to wrong bbox with some layers
- This problem has been fixed for `POINT` maps (#8347) but is not yet fully solved for `AREA` maps.
`openlayers_map.... - 08:45 AM EDIT Revision 779840f4 (cdm-dataportal): fix #8430 fixing bbox transformation from data layer to base layer projection
07/30/2019
- 05:25 PM EDIT bug #8429 (Closed): Rename DeterminationEvent_Reference.setOfReferences_id
- ~~~
[algaterra_new] 2019-07-30 15:49:23,008 INFO [qtp532445947-4997] [eu.etaxonomy.cdm.remote.controller.BaseControl... - 05:19 PM EDIT bug #8428 (Closed): NPE in ClassificationServiceImpl.loadTreeBranchToTaxon()
~~~
[euromed] 2019-07-30 16:07:08,780 INFO [qtp532445947-5019] [eu.etaxonomy.cdm.remote.controller.ClassificationP...- 05:11 PM EDIT bug #8427 (Closed): LazyInitializationException in NameController.doGetTaggedFullTitle()
- found in production server log:
* /cichorieae/name/ddf9cc53-cdfc-45d5-98f9-1e5ef9a8e4df/taggedFullTitle
* /cichor... - 05:09 PM EDIT bug #8426 (Closed): IndexOutOfBoundsException during serialization of RegistrationWorkingSet
IndexOutOfBoundsException during serialization of RegistrationWorkingSet:
~~~
[flora-central-africa] 2019-07-...- 03:27 PM EDIT feature request #8403: name page: show types specimens as expandable derivate tree
- please see http://test.e-taxonomy.eu/dataportal/preview/phycobank/cdm_dataportal/name/f5048e6e-303a-41f6-933b-84c678e...
- 11:35 AM EDIT feature request #8403 (Resolved): name page: show types specimens as expandable derivate tree
- 03:16 PM EDIT task #8425 (Closed): FieldUnitDTO: remove taxonRelatedDerivedUnits
- FieldUnitDTO has the field `taxonRelatedDerivedUnits`. This can be removed, this is a relict of a first approach to ...
- 03:12 PM EDIT task #8424 (New): evaluate publish flags in the full derivative path
- eu.etaxonomy.cdm.remote.controller.OccurrenceController.doGetOccurencesDTO(@PathVariable(value="uuid") UUID uuid, Htt...
- 03:01 PM EDIT bug #8423 (Closed): OccurrenceServiceImpl.findFieldUnitDTO() fails to merge derivation paths when a FieldUnit has two derivatives
- OccurrenceServiceImpl.findFieldUnitDTO(DerivateDTO derivedUnitDTO, Collection<FieldUnitDTO> fieldUnits, HashMap<UUID,...
- 02:25 PM EDIT task #8406 (In Progress): specimens and occurrence code cleaning and harmonization
- 02:25 PM EDIT Revision a0be8d7e (cdm-dataportal): ref #8406 dapting portal to renamed controller endpoint: taxon/{uuid}/specimensOrObservationDTOs --> taxon/{uuid}/fieldUnitDTOs
- 02:22 PM EDIT Revision 2e09903a (cdmlib): ref #8414 renaming taxon/{uuid}/specimensOrObservationDTOs to taxon/{uuid}/fieldUnitDTOs
- 01:52 PM EDIT feature request #8415 (Closed): use /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup to speed up type designation retrieval
- 01:52 PM EDIT feature request #8415 (Resolved): use /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup to speed up type designation retrieval
- Applied in changeset commit:cdm-dataportal|dfbc27b033a2eda86d74b57a4d14189f7d6e5cd0.
- 01:52 PM EDIT Revision dfbc27b0 (cdm-dataportal): fix #8415 using /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup service to speed up the type designation display
- 01:48 PM EDIT feature request #8390 (Closed): implement /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup
- 01:46 PM EDIT Revision 7dde6846 (cdmlib): ref #8390 uncommenting typeDesignationsInHomotypicalGroup service endpoints
- 12:09 PM EDIT Revision aa8cf7e6 (cdmlib): first implementation of /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup
- 11:35 AM EDIT bug #8421 (Rejected): icons in compose_specimen_table_top_down() are not visible
- in `compose_specimen_table_top_down()` font awesome icons are added to the render array, but these are not getting di...
- 11:28 AM EDIT task #8420 (Closed): improve admin settings for specimens representations
- * The kind of representation of specimens lists needs to be selectable via a set of radio buttons.
* should the sett... - 11:25 AM EDIT task #8419 (In Progress): Harmonization of the different specimen representations
- **There are different kinds of "views" for specimens lists**
* some of them provide a pager others do not
* do op... - 11:21 AM EDIT task #8418 (Closed): specimens and occurrence links must not have a target=_blank attribute
- 11:01 AM EDIT task #8418 (Closed): specimens and occurrence links must not have a target=_blank attribute
- Even is this was frequently requested by users using the target attribute is in general considered an UX anti-pattern...
- 11:02 AM EDIT Revision cea59762 (cdm-dataportal): ref #8418 removing all target=_blank attributes from specimen representations
- 08:58 AM EDIT Revision ae177dac (cdm-dataportal): ref #8403 types specimens as expandable derivate tree in name page finally working
- 08:57 AM EDIT Revision 4c158e4e (cdm-dataportal): ref #8414 adapting portal to modified service mapping
- 08:44 AM EDIT Revision d2cbce25 (cdmlib): ref #8414 refactoring OccurrenceController:
- - method to load a single FieldUnitDTO
- adding all intermediate derivatives to the FieldUnitDTO
- renaming servi...
07/29/2019
- 03:11 PM EDIT Wiki edit: EclipsePreferencesforTeams (#62)
- 03:07 PM EDIT Wiki edit: EclipsePreferencesforTeams (#61)
- 03:08 PM EDIT Wiki edit: CdmLibraryDev (#57)
- 02:21 PM EDIT Revision 10858926 (cdm-dataportal): using the /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup webservice to avoid fetching for each name in the group
- 02:20 PM EDIT Revision 961319fe (cdm-dataportal): ref #8406 clenaing and harmonization of the specimen related code in the dataportal
- 02:13 PM EDIT bug #8416 (Worksforme): Array to string conversion problem in render array produced for specimen page
- At least the specimen page for (B B GT 0024094) in phycobank ( http://edit.test/d7/phycobank/cdm_dataportal/occurrenc...
- 02:06 PM EDIT Revision 70b053e4 (cdmlib): ref #8406 cleaning up occurrence controller code
- 02:04 PM EDIT feature request #8415 (Closed): use /portal/name/{uuuid}/typeDesignationsInHomotypicalGroup to speed up type designation retrieval
- copied from #6380.
This webservice should be used to speed up `type_designations_for_synonymy_group($synonymy_grou... - 01:59 PM EDIT task #8414 (Closed): occurrence controller code cleaning and harmonization
- eu.etaxonomy.cdm.remote.controller.OccurrenceController.doGetOccurencesDTO(@PathVariable(value="uuid") UUID uuid, Htt...
07/26/2019
- 10:57 AM EDIT feature request #8409 (Closed): add nomenclatural code select to NameRelationField
- see #8398 for details
- 10:55 AM EDIT feature request #8408 (Closed): add nomenclatural code select to NomenclaturalStatusRow
- see #8398 for details
- 09:27 AM EDIT task #8166 (New): Adapt dataportal to term structure changes
- I am reopening this issue since the data portal code even if being fully functional might need to be adapted to the ...
- 08:53 AM EDIT task #8166 (Worksforme): Adapt dataportal to term structure changes
- Andreas Müller wrote:
> Are there any changes needed? Currently it looks like most things work (except maybe for the...
07/25/2019
- 01:16 PM EDIT task #8406 (Closed): specimens and occurrence code cleaning and harmonization
- ## cdmlib-remote
issues copied to #8414
## data portal
* There are different kinds of "views" on specimens l... - 12:51 PM EDIT Revision ca7468b6 (cdm-dataportal): ref #8403 moving compose_specimens_table_bottom_up() to occurences.inc and renaming parameter in compose_specimen_array()
- 12:48 PM EDIT Revision 84849c31 (cdm-dataportal): ref #8403 extracting method compose_specimens_table_bottom_up()
- 11:15 AM EDIT Revision 68467d82 (cdm-dataportal): name type designation status bold - adapting tests
- 11:04 AM EDIT Revision 1f00087f (cdm-dataportal): name type designation status bold
- 10:25 AM EDIT Revision 2d6c8502 (cdmlib): commenting doGetTypeDesignationsInHomotypicalGroup() methods which have been comitted too early
- 10:16 AM EDIT task #8405 (Rejected): Adapt cdm-vaadin to term structure changes
- the vaadin editor needs to be adapted to the changes applied in the context of #6794
- 10:13 AM EDIT bug #8395 (Resolved): NullPointerException (NPE) in NameCatalogueController
- Applied in changeset commit:cdmlib|dd4347b628d5737e2682c8d95fcb0e1aff9e7ad7.
- 10:13 AM EDIT Revision 10d502dc (cdmlib): ref #8394 adding nameUUIDs to NameCatalogueController responses
- 10:13 AM EDIT Revision 9c5bef97 (cdmlib): ref #8394 adding nameUuid to NameCatalogueController responses
- 10:13 AM EDIT Revision dd4347b6 (cdmlib): fix #8395 avoiding NPE in NameCatalogueController.getDatasetIdName()
Also available in: Atom