Project

General

Profile

Andreas Kohlbecker's activity

From 02/14/2019 to 03/15/2019

03/15/2019

03:30 PM EDIT Revision a296b200 (cdmlib): ref #8169 adding missing @Transactional to VersionableServiceBase.isDeletable()
Andreas Kohlbecker
03:29 PM EDIT bug #8169: avoid factory.openSession() in DaoBase
VersionableServiceBase.isDeletable misses the @Transactional(readOnly = true) annotation! Andreas Kohlbecker
03:25 PM EDIT bug #8169: avoid factory.openSession() in DaoBase
Here is a case found in the server log (occurred 6x in a couple of hours):
~~~
[phycobank] 2019-03-15 10:27:44,...
Andreas Kohlbecker

03/14/2019

04:05 PM EDIT Revision 63311bd9 (cdm-vaadin): multiple test datasources for tesing multiple test suites
Andreas Kohlbecker

03/13/2019

12:30 PM EDIT Revision a3c9dcce (cdm-server): cdmlib-developer.log to be ignored by git
Andreas Kohlbecker
12:29 PM EDIT Revision 14a235fc (cdm-server): ref #8173 setting spring.profiles.active in the cdm-sever bootloader if not defined otherwise
Andreas Kohlbecker
12:17 PM EDIT Revision 42b67a16 (cdmlib): Revert "ref #8173 removing 'remoting' profile activation from ide launchers"
This reverts commit 027eaf7c3181f62d725e7b5a677284f07cd5b43b. Andreas Kohlbecker
12:16 PM EDIT Revision dd0d18ea (cdmlib): Revert "ref #8173 activation of profile remoting in the web.xml"
This reverts commit f2d3f4d37174244ca577203d1228256c6f787a29. Andreas Kohlbecker
09:36 AM EDIT bug #8176 (Resolved): WeaklyRelatedEntityCombobox is slow
test TaxonNamePopupEditor Genus field, replaced Synonym and Basionym also some ToManyRelatedEntitiesComboboxes and T... Andreas Kohlbecker
09:31 AM EDIT Revision aec76ebb (cdm-vaadin): ref #8176 removing workaround with bad performance which was need for broken TaxonNameStringFilterablePagingProvider.idFor()
Andreas Kohlbecker
09:02 AM EDIT Revision eb8d2f54 (cdm-vaadin): ref #8176 bugfix in TaxonNameStringFilterablePagingProvider.idFor()
Andreas Kohlbecker

03/12/2019

05:57 PM EDIT bug #8176 (In Progress): WeaklyRelatedEntityCombobox is slow
Andreas Kohlbecker
02:15 PM EDIT bug #8176 (Closed): WeaklyRelatedEntityCombobox is slow
## on setting values
The WeaklyRelatedEntityCombobox needs to check if the value to set is at all contained in the...
Andreas Kohlbecker
05:57 PM EDIT Revision af0633ea (cdm-vaadin): ref #8176 WeaklyRelatedEntityCombobox solving minor performance on setValue
Andreas Kohlbecker
03:48 PM EDIT Revision f2d3f4d3 (cdmlib): ref #8173 activation of profile remoting in the web.xml
Andreas Kohlbecker
12:53 PM EDIT bug #8099: Error saving name type designation editor due to problem in poupeditor context
can not reproduce Andreas Kohlbecker
12:52 PM EDIT Revision 98db0610 (cdm-vaadin): ref #8132 fixin bug related to transaction rollback in CdmStore
Andreas Kohlbecker
10:14 AM EDIT Revision 408fe3ed (cdm-vaadin): avoiding LazyInitialitationException
Andreas Kohlbecker
09:09 AM EDIT Revision 8f2aad1d (cdm-server): ref #8173 removing 'remoting' profile activation from ide launchers
Andreas Kohlbecker
09:09 AM EDIT Revision 027eaf7c (cdmlib): ref #8173 removing 'remoting' profile activation from ide launchers
Andreas Kohlbecker
08:53 AM EDIT Revision df841466 (cdm-server): notes on commented settings regarding debugging of leaky db connections
Andreas Kohlbecker
08:36 AM EDIT bug #8105: better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
I did a brief research on the topic of hotfix branches:
1. git flow has the concept of ***support branches*** by whi...
Andreas Kohlbecker

03/11/2019

06:10 PM EDIT Revision 5261131c (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore - copied from hfx branch
Andreas Kohlbecker
02:23 PM EDIT Revision d201d8e5 (cdm-vaadin): Merge branch 'hotfix/5.5.3' into develop
Andreas Kohlbecker
02:18 PM EDIT Revision e98e8737 (cdm-vaadin): Revert "ref #8132 proper transaction rollback in CdmStore" which has been only been cherry-picked to avoid merge problems during the release later on
This reverts commit 278e8f9600956b6e8205337045815a153f0a05ac. Andreas Kohlbecker
02:16 PM EDIT Revision 278e8f96 (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore
merging Conflicts in src/main/java/eu/etaxonomy/cdm/service/CdmStore.java Andreas Kohlbecker
02:01 PM EDIT Revision 23025c30 (cdm-vaadin): ref #8132 proper transaction rollback in RegistrationWorkingsetPresenter
Andreas Kohlbecker
02:01 PM EDIT Revision 9f8b217c (cdm-vaadin): adding c3p0.properties to gitignore
Andreas Kohlbecker
01:53 PM EDIT bug #8170: javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
I opened issue #8171 only for fixing the most severe problem quickly by storing the new connection in the cache field... Andreas Kohlbecker
12:59 PM EDIT feature request #8173 (In Progress): spring profile remoting enabled by default
Andreas Kohlbecker
12:55 PM EDIT feature request #8173 (Resolved): spring profile remoting enabled by default
Applied in changeset commit:cdmlib|5ab0f6455f6cb83bfba0bb5ad6aee6e210d8dd14. Andreas Kohlbecker
12:48 PM EDIT feature request #8173 (In Progress): spring profile remoting enabled by default
Andreas Kohlbecker
12:40 PM EDIT feature request #8173 (Closed): spring profile remoting enabled by default
the spring profile still needs to be enabled by passing `-Dspring.profiles.active=remoting` to cdm-remote instances.... Andreas Kohlbecker
12:55 PM EDIT Revision 5ab0f645 (cdmlib): fix #8173 spring profile 'remoting' activated by default
Andreas Kohlbecker
12:55 PM EDIT Revision 7d340a47 (cdmlib): fix #8171 internally caching new connection in WrappedCdmDataSource to avoid connection leaks
Andreas Kohlbecker
12:55 PM EDIT Revision 80595b0d (cdmlib): ref #7106 proper transaction management in turn of solving the problem in CdmRepository.getSession()
Andreas Kohlbecker
12:55 PM EDIT Revision 8db30ca4 (cdmlib): log level for cdm caches to WARN to avoid constant noise from the TransientCdmCacher
Andreas Kohlbecker
12:54 PM EDIT bug #8171 (Resolved): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource fails to cache the connection which and leaves it unclosed
Applied in changeset commit:cdmlib|ddaf22cfc36cad56b677c8fecd8eb3e83db5cefb. Andreas Kohlbecker
12:53 PM EDIT Revision 99583d95 (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore
Andreas Kohlbecker
11:50 AM EDIT Revision 6f71379a (cdm-vaadin): ref #8132 proper transaction rollback in RegistrationWorkingsetPresenter
Andreas Kohlbecker
08:18 AM EDIT Revision 04819529 (cdm-vaadin): adding c3p0.properties to gitignore
Andreas Kohlbecker
08:18 AM EDIT Revision 8c1dd527 (cdm-vaadin): setting cdmlib version to 5.5.2-SNAPSHOT
Andreas Kohlbecker

03/08/2019

05:28 PM EDIT Revision e22b441a (cdmlib): log level for cdm caches to WARN to avoid constant noise from the TransientCdmCacher
Andreas Kohlbecker
05:27 PM EDIT Revision ddaf22cf (cdmlib): fix #8171 internally caching new connection in WrappedCdmDataSource to avoid connection leaks
Andreas Kohlbecker
05:17 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
Another situation in which a connection is being opened but not properly closed is occurring in the `DataSourceConfig... Andreas Kohlbecker
02:02 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
debugging the cdm-server to find connections that have been opened but which are not being closed properly (DebugC3P0... Andreas Kohlbecker
05:06 PM EDIT bug #8171 (Closed): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource fails to cache the connection which and leaves it unclosed
When the existing cached connection in the WrappedCdmDataSource is null a new connection will be created but is not s... Andreas Kohlbecker
04:59 PM EDIT bug #8170 (New): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
the documentation of `javax.sql.DataSource.getConnection()` reads like *"**Attempts to establish** a connection with ... Andreas Kohlbecker
02:26 PM EDIT Revision 5479cc9a (cdm-vaadin): ref #8132 fixing problem of uncommited transaction in RegistrationWorkingsetPresenter
Andreas Kohlbecker
02:21 PM EDIT Revision d2accd99 (cdm-vaadin): ref #8132 fixing problem of uncommited transaction in RegistrationWorkingsetPresenter
Andreas Kohlbecker
01:56 PM EDIT Wiki edit: DebugC3P0Connections (#17)
Andreas Kohlbecker
12:09 PM EDIT Wiki edit: DebugC3P0Connections (#16)
Andreas Kohlbecker
11:55 AM EDIT Wiki edit: DebugC3P0Connections (#15)
Andreas Kohlbecker

03/07/2019

05:37 PM EDIT Wiki edit: DebugC3P0Connections (#14)
Andreas Kohlbecker
04:58 PM EDIT Revision 998a72e0 (cdm-vaadin): ref #7106 refactoring CdmStore in turn of changed CdmRepository.getSession()
- CdmStore as Spring bean
- CdmStore managed transactions and sessions properly
Andreas Kohlbecker
03:26 PM EDIT bug #8169 (New): avoid factory.openSession() in DaoBase

In DaoBase using `factory.openSession()` is plain wrong, the HibernateTransactionManger should be used instead.
Andreas Kohlbecker
03:24 PM EDIT bug #7106 (In Progress): avoid factory.openSession() in CdmRepository
Andreas Kohlbecker
02:17 PM EDIT bug #7106: avoid factory.openSession() in CdmRepository
since February 25th there are only occurrences related to this issue in the log which affected the phycobank code.
W...
Andreas Kohlbecker
07:25 AM EDIT bug #7106: avoid factory.openSession() in CdmRepository
with the logging of the stacktrace it now becomes clear where the unmanaged sessions are being created:
~~~~
java...
Andreas Kohlbecker
02:57 PM EDIT Revision b7647a99 (cdm-vaadin): ref #7106 using new CdmRepository.clearSession() method
Andreas Kohlbecker
02:54 PM EDIT Revision 6d6ae033 (cdmlib): ref #7106 logging unintentially creation of unmanaged new session in DaoBase with stacktrace
Andreas Kohlbecker
02:54 PM EDIT Revision ff628107 (cdmlib): ref #7106 throwing Exception instead of unintentially creating unmanaged new session
Andreas Kohlbecker
12:37 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
The problem just occurred again. This time no one was using the Taxeditor since the instance has been started.
The...
Andreas Kohlbecker
11:21 AM EDIT task #8168 (New): Check if withdrawing of per entity permission is working correctly for inReferences
Andreas Kohlbecker
11:17 AM EDIT bug #8167 (Closed): Permission denied for Submitter when adding section to newly created journal

~~~
[phycobank] 2019-03-07 09:56:41,648 ERROR [qtp1510067370-69] [org.hibernate.internal.SessionImpl] - HHH000346:...
Andreas Kohlbecker

03/06/2019

06:20 PM EDIT Revision 3cee4d12 (cdm-server): ref #7729 suppress nasty ehcache OutOfMemory warnings to reduce clutter in the server log
Andreas Kohlbecker
06:07 PM EDIT Revision d75c4b91 (cdm-server): ref #8132 c3p0 settings for debugging lost jdbc connections
Andreas Kohlbecker
05:43 PM EDIT Revision 568fb7dc (cdmlib): ref #7106 logging stacktrace with 'Opening new session in turn of a HibernateException'
Andreas Kohlbecker
05:00 PM EDIT bug #7106: avoid factory.openSession() in CdmRepository
In a locally running cdmserver started vi the eclipse launcher *cdm-server - start from war* multiple occurrences can... Andreas Kohlbecker
02:23 PM EDIT Revision c5a114a8 (cdm-dataportal): ref #8166 adapting to change in FeatureNode property 'feature' becomes 'term' - 2
Andreas Kohlbecker
01:57 PM EDIT Revision b011743c (cdm-dataportal): ref #8166 adapting to change in FeatureNode property 'feature' becomes 'term'
Andreas Kohlbecker
01:56 PM EDIT task #8166 (Closed): Adapt dataportal to term structure changes
the dataportal needs to be adapted to the changes applied in the context of #6794 Andreas Kohlbecker
12:30 PM EDIT Revision 17ff12b9 (cdm-dataportal): Merge tag '5.5.1' into develop
tagging hotfix release 5.5.1 Andreas Kohlbecker
12:30 PM EDIT Revision 43bc8f03 (cdm-dataportal): Merge branch 'hotfix/5.5.1'
Andreas Kohlbecker
10:44 AM EDIT feature request #8165 (New): enable logback jmx for cdm-server
having the logback jmx beans enabled would be a great help during debugging of the production server and other system... Andreas Kohlbecker

03/05/2019

05:22 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
Results from the server log:
The problem occurred again. The jdbc connection which was being used by the tread `qt...
Andreas Kohlbecker
04:09 PM EDIT Revision e29a4a6e (cdm-server): loggin: eu.etaxonomy.cdm.cache.CdmTransientEntityCacher on level WARN
Andreas Kohlbecker
04:05 PM EDIT Revision 5976b46d (cdm-vaadin): Merge branch 'hotfix/5.5.2' into develop
Andreas Kohlbecker
03:49 PM EDIT Revision 09c85ccb (cdm-vaadin): ref #8160 CdmBeanItemContainerFactory @Transactional only where needed and clearing session before each service call
Andreas Kohlbecker
02:58 PM EDIT bug #8107 (Closed): NPE when throwing PopupEditorException in AbstractPopupEditor
issue is not reproducible - closing. Andreas Kohlbecker
11:49 AM EDIT feature request #8163 (Rejected): RegistrationService.setStatus() method implemented
This method need to be used by the RegistrationWorkingsetPresenter.saveRegistrationStatusChange() method in cdm-vaadi... Andreas Kohlbecker
11:21 AM EDIT bug #8161 (Rejected): *FilterablePagingProvider classes as transactional readonly spring beans
the *FilterablePagingProviders only are using service methods which are anyway annotated with `@Transactional(readOnl... Andreas Kohlbecker
11:21 AM EDIT bug #7945 (Rejected): TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
the *FilterablePagingProviders only are using service methods which are anyway annotated with `@Transactional(readOnl... Andreas Kohlbecker
11:14 AM EDIT bug #8075 (In Progress): multiple cascade all-delete-orphan exceptions related to DefinedTermBase.representations
Andreas Kohlbecker
10:55 AM EDIT bug #8158: cascade="all-delete-orphan" problem when ....
potentially duplicate of #8160 Andreas Kohlbecker

03/04/2019

03:36 PM EDIT Revision 52aa37ab (cdm-vaadin): ref #8161 TaxonNameStringFilterablePagingProvider as transactional readonly prototype bean
Andreas Kohlbecker
03:06 PM EDIT bug #7881: reference selection combobox broken after error in ...
potentially duplicate of #8161 Andreas Kohlbecker
03:04 PM EDIT bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
potentially duplicate of #8161 Andreas Kohlbecker
03:00 PM EDIT bug #8065: HibernateException: corrupt session problem breaks SpecimenTypeDesignationworkingsetEditor type designation table
potentially duplicate of #8160 Andreas Kohlbecker
02:07 PM EDIT bug #8160 (Resolved): CdmBeanItemContainerFactory as readonly service bean
Andreas Kohlbecker
12:43 PM EDIT bug #8160 (Closed): CdmBeanItemContainerFactory as readonly service bean
Turning the CdmBeanItemContainerFactory into a readonly service bean should solve the cascade="all-delete-orphan" pro... Andreas Kohlbecker
02:05 PM EDIT Revision 3506344d (cdm-vaadin): changing oder of resource in pom - only cosmetic
Andreas Kohlbecker
01:53 PM EDIT Revision f4f3c705 (cdm-vaadin): ref #8160 CdmBeanItemContainerFactory as service bean to load entities only in readyOnly transactions to avoid unintendet flushing
Andreas Kohlbecker
12:47 PM EDIT bug #8161 (Rejected): *FilterablePagingProvider classes as transactional readonly spring beans
Turing the TaxonNameStringFilterablePagingProvider into a readonly service bean should solve the cascade="all-delete-... Andreas Kohlbecker
11:52 AM EDIT task #4600 (New): Investigate and implement tests for security in cdm-vaadin
Andreas Kohlbecker
11:51 AM EDIT task #4600 (In Progress): Investigate and implement tests for security in cdm-vaadin
Andreas Kohlbecker
11:47 AM EDIT bug #7879: Book CacheStrategy does not show 'place published', 'publisher', 'editor'
Hi Andreas, I am passing this to you since it is a bug in the cache strategy and closely related to #1866 Andreas Kohlbecker

03/01/2019

10:00 PM EDIT Revision 217236bc (cdm-vaadin): adapting test to modified number of TaxonRelationshipTypes
Andreas Kohlbecker
08:29 PM EDIT Revision 8a8599be (cdmlib): fixing strange error logging in TestingTermInitializer and throwing RuntineException since error is unrecoverable
Andreas Kohlbecker
08:27 PM EDIT Revision f178b3fc (cdmlib): moving kindOfUnitTerms from cdm-vaadin:TermsDataSet-ui-registration-with_auditing_info.xml to edit-test:TermsDataSet-with_auditing_info.xml
Andreas Kohlbecker
08:26 PM EDIT Revision a4a47802 (cdm-vaadin): moving kindOfUnitTerms from cdm-vaadin:TermsDataSet-ui-registration-with_auditing_info.xml to edit-test:TermsDataSet-with_auditing_info.xml
Andreas Kohlbecker
04:05 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
It seems as if this problem is being cased by the CdmFilterablePagingProvider which might open an new Sesscion which ... Andreas Kohlbecker
02:46 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
this here https://stackoverflow.com/questions/34408362/c3p0-connection-pool-gives-connection-timeout-error-with-this-... Andreas Kohlbecker
01:58 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
Andreas Kohlbecker wrote:
> I set `testConnectionsOnCheckIn=true` temporarily via jmx in order to test if this helps...
Andreas Kohlbecker
11:13 AM EDIT task #615 (Closed): remove suns repository
the repository
~~~xml
<!-- sun repository -->
<repository>
<id>java.net</id>
<url>http:...
Andreas Kohlbecker
11:11 AM EDIT task #615 (Resolved): remove suns repository
Applied in changeset commit:cdmlib|d402220f823edfb01ec9385d20117d6afee9a77d. Andreas Kohlbecker
11:11 AM EDIT Revision d402220f (cdmlib): fix #615 removing unused sun maven repo
Andreas Kohlbecker
07:17 AM EDIT bug #8158 (Closed): cascade="all-delete-orphan" problem when ....
I seem to remember that I did the following:
1. RegistrationWorkingsetEditor at http://api.phycobank.org/phycobank...
Andreas Kohlbecker

02/28/2019

09:54 PM EDIT feature request #8157 (New): Registration list view: sort registrations by the same order as in the dataportal
newer registrations should come first.
Oder by created when! (agreed)
Andreas Kohlbecker
09:50 PM EDIT feature request #8156: Registration items show type status in bold letters
should be easy to implement, thus i am setting the priority to high Andreas Kohlbecker
09:50 PM EDIT feature request #8156 (Closed): Registration items show type status in bold letters
The type status in registration items is not easy to see. Making the status bold would improve the readability. Andreas Kohlbecker
09:47 PM EDIT feature request #8155 (Feedback): SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
Andreas Kohlbecker
09:47 PM EDIT feature request #8155: SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
For how urgent do you consider this feature, Henning? I guess this situation will occur quite frequently? Andreas Kohlbecker
09:42 PM EDIT feature request #8155 (Feedback): SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
In case of lecto-, epit- and neo-types the SpecimenTypeDesignationEditor should selecting the typified name from the ... Andreas Kohlbecker
05:30 PM EDIT bug #7514: Change direct and inverse symbol for pro parte synonym and misapplied name relationship types.
the test page http://int.e-taxonomy.eu/dataportal/integration/reference/cdm_dataportal/taxon/c6716cee-2039-4ba8-a239-... Andreas Kohlbecker
05:24 PM EDIT Revision 2ae1c797 (cdm-dataportal): ref #7514 adapting tests to conform to new misapplied name symbols
Andreas Kohlbecker
04:12 PM EDIT bug #8154 (Worksforme): NameController.doGetTaggedName fails due to [UPDATE] not permitted for 'anonymousUser' on Person
http://160.45.63.173:8081/phycobank/name/a2b01d35-fdcf-43fb-8376-f03f195c6e06/taggedName.json
fails every ~4 times...
Andreas Kohlbecker
03:05 PM EDIT bug #8152 (Duplicate): ReferencePopupEditor: inReference field allows to select references with type GEN but field validation fails in this case
Henning: References with type 'Generic' must not be in the list, filter only by matching type
So this is a duplica...
Andreas Kohlbecker
01:05 PM EDIT bug #8152 (Duplicate): ReferencePopupEditor: inReference field allows to select references with type GEN but field validation fails in this case
Heba reported an error which was due the Journal "Rickia" having the Referencetype 'Generic'
The reference could b...
Andreas Kohlbecker
11:57 AM EDIT bug #7107: "Omit level" (TDWG Level2) in distribution hierarchy should not supress distributions source reference
OK Andreas Kohlbecker
11:37 AM EDIT bug #7107 (Feedback): "Omit level" (TDWG Level2) in distribution hierarchy should not supress distributions source reference
Hallo Andreas, ich denke das ist auch für Euro+Med releveant, oder?
Wenn ja, sollten wir das Tag hinzufügen und di...
Andreas Kohlbecker

02/27/2019

03:52 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
I set `testConnectionsOnCheckIn=true` temporarily via jmx in order to test if this helps avoiding this connectivity p... Andreas Kohlbecker

02/26/2019

07:46 PM EDIT Revision 5bc58b89 (cdmlib): removing unused private fiels in H2DatabaseType
Andreas Kohlbecker
03:31 PM EDIT Revision c30d94b9 (cdm-vaadin): removing unused xsd files
Andreas Kohlbecker
02:37 PM EDIT feature request #3616: Show DescriptionElementBase.timeperiod in Dataportals
Andreas Müller wrote:
> Generally it looks fine.
>
> Only the formatting maybe needs discussion. It differs from...
Andreas Kohlbecker
01:00 PM EDIT feature request #3616 (Resolved): Show DescriptionElementBase.timeperiod in Dataportals
Implemented
please review, for the page used by the integration test, please see : http://int.e-taxonomy.eu/datapo...
Andreas Kohlbecker
01:42 PM EDIT task #7356: setup selenium test suite for cdm-vaadin
Adding master thesis on Vaadin TestBench Andreas Kohlbecker
12:12 PM EDIT feature request #8144: Check if modifiers and modifyingText is handled correctly for description elements in data portals
since modifiers and modifyingText can not be added to the database easily I need to wait until the issue #3836 is com... Andreas Kohlbecker
12:09 PM EDIT Revision 940bbcf2 (cdm-dataportal): ref #3616 implementing tests for DescriptionElementBase.timeperiod
Andreas Kohlbecker
11:54 AM EDIT Revision 90425089 (cdm-dataportal): ref #3616 implementing display of DescriptionElementBase.timeperiod
Andreas Kohlbecker
11:53 AM EDIT Revision d0e8e73c (cdm-dataportal): ref #3616 fixing multibyte character problem related to time periods
Andreas Kohlbecker
11:10 AM EDIT task #8118: Update MySQL drivers
Andreas Müller wrote:
> Starting with MySQL JDBC Driver 5.1.33 serverTimezone needs to be explicitly defined in conn...
Andreas Kohlbecker

02/25/2019

06:13 PM EDIT feature request #3747 (Closed): Check if time period is handled correctly for description elements in data portals
check for and modifiers and modifyingText copied to new ticket, closing this issue Andreas Kohlbecker
06:08 PM EDIT feature request #3747: Check if time period is handled correctly for description elements in data portals
since modifiers and modifyingText can not be added to the data easily I need to wait until the issue #3836 is complet... Andreas Kohlbecker
06:03 PM EDIT feature request #3747 (In Progress): Check if time period is handled correctly for description elements in data portals
The scope of this ticket includes modifiers and modifyingText ... reopening issue Andreas Kohlbecker
06:00 PM EDIT feature request #3747 (Closed): Check if time period is handled correctly for description elements in data portals
the output of timeperiod for DescriptionElements is missing so far in the Dataportal. So ticket #3616 becomes relevan... Andreas Kohlbecker
06:10 PM EDIT feature request #8144 (In Progress): Check if modifiers and modifyingText is handled correctly for description elements in data portals
not relevant for TextData as we expect that TextData will handle modifiers with its text (see #3836)
Andreas Kohlbecker
06:04 PM EDIT feature request #3616 (In Progress): Show DescriptionElementBase.timeperiod in Dataportals
Andreas Kohlbecker
05:28 PM EDIT feature request #3746: Implement time period scope for description elements in TaxEditor
The output in the taxeditor can very ugly depending on the partial fields being used:
* Timescope: start month: ...
Andreas Kohlbecker
04:00 PM EDIT bug #8105 (In Progress): better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
it turned out that it can happen that cherries need to be modified when picking them from hotfix to develop. This hap... Andreas Kohlbecker
03:48 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
Andreas Kohlbecker wrote:
> I added `autoReconnect=true` to the connection string of the phycobank datasource.
us...
Andreas Kohlbecker
03:21 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
I added `autoReconnect=true` to the connection string of the phycobank datasource. Andreas Kohlbecker
01:06 PM EDIT bug #8132: phycobank cdm-server instance problems with db connections
these connectivity problems should be prevented by c3p0 since the `idleConnectionTestPeriod` is set to `600` (10 minu... Andreas Kohlbecker

02/22/2019

06:38 PM EDIT bug #8132 (Worksforme): phycobank cdm-server instance problems with db connections

the phycobank cdm-server instance which is running in a docker container got problems with the db connections
P...
Andreas Kohlbecker
06:28 PM EDIT bug #8119 (Rejected): Link a PhycoBank Id in a Proof to Portal
this is only a side effect of as problem with the server which fails to respond sometimes Andreas Kohlbecker
05:54 PM EDIT bug #8119: Link a PhycoBank Id in a Proof to Portal
the requires status message seems to be visible only for logged in users:
![](picture198-1.png)
Andreas Kohlbecker
06:18 PM EDIT feature request #8093 (Closed): harmonize registrationId links and make tesing easier
Andreas Kohlbecker
06:17 PM EDIT feature request #8093 (Resolved): harmonize registrationId links and make tesing easier
Applied in changeset commit:cdm-dataportal|977bba78560ff1387b601420f9c55409ac19fd92. Andreas Kohlbecker
06:17 PM EDIT Revision 977bba78 (cdm-dataportal): fix #8093 registration identifier links configurable
Andreas Kohlbecker
05:22 PM EDIT bug #5774: cdmserver misses to detect some errors in failed instances
I guess you are right. I was lowering the priority that much because the issue has not been reported for 2 years, but... Andreas Kohlbecker
05:15 PM EDIT bug #7087 (Worksforme): description/accumulateDistributions webservice can not be triggered
tested by using httpie and it works again, it seems this has been fixed meanwhile Andreas Kohlbecker
05:05 PM EDIT Revision 3a973027 (cdmlib): ref #7106 logging if the worse case is actually happening
Andreas Kohlbecker
05:03 PM EDIT bug #7106 (Feedback): avoid factory.openSession() in CdmRepository
I am modifying the logging in mentioned case to allow us checking in the server logs if this case is actually happeni... Andreas Kohlbecker
04:45 PM EDIT feature request #5807 (New): Implement sub-distribution area inclusion in TaxonService.findTaxaAndNamesByFullText()
this is still not working:
http://test.e-taxonomy.eu/dataportal/preview/euromed/cdm_dataportal/search/results/taxo...
Andreas Kohlbecker
04:10 PM EDIT feature request #5807 (Feedback): Implement sub-distribution area inclusion in TaxonService.findTaxaAndNamesByFullText()
trying to reproduce this at the euro+med portal, since this taxon no longer is found in the caucasus portal:
http:...
Andreas Kohlbecker
04:22 PM EDIT bug #2074 (Rejected): network independend CdmUpdaterTest
I am no longer using eu.etaxonomy.cdm.database.update.CdmUpdaterTest since cdm-remote supports the `force-scheamupdat... Andreas Kohlbecker
04:18 PM EDIT bug #8131 (Rejected): reindexing fuction in dataportal setting reports fails
it was really the wrong credentials that i used Andreas Kohlbecker
04:09 PM EDIT bug #8131 (Rejected): reindexing fuction in dataportal setting reports fails
even with correct credentials "Error: Are your credentials correct?" is being reported Andreas Kohlbecker
03:52 PM EDIT bug #7938: cdmserver sub-processes (threads) with constant high cpu
this never occurred since 3 months, lowering priority Andreas Kohlbecker
03:41 PM EDIT bug #8105 (Closed): better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
Andreas Kohlbecker
03:39 PM EDIT Wiki edit: Release_Notes (#431)
Andreas Kohlbecker
10:01 AM EDIT bug #8099: Error saving name type designation editor due to problem in poupeditor context
AHH ich glaube jetzt habe ich es. Ein alter Dump der DB hat mir*Geitleriaceae Kilgore & J.R.Johans.* auf die Sprünge... Andreas Kohlbecker

02/21/2019

05:10 PM EDIT task #8118: Update MySQL drivers
I read through the change sets, all are looking as expected.
As next step we should run a test against a maria db ...
Andreas Kohlbecker
04:46 PM EDIT Revision b599ad36 (cdm-vaadin): ref #8117 commenting orthographic corrected names filter to prevent from unclear performance probelms, see ref #7899
Andreas Kohlbecker
03:50 PM EDIT bug #8105: better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
note for developers added to the ticket description ..... Andreas Kohlbecker
03:40 PM EDIT bug #8105 (Resolved): better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
by this the git-hfx-cherry-check should be executed for all HFX_FINISH jobs, in case of errors the job will FAIL sinc... Andreas Kohlbecker
03:36 PM EDIT bug #8105: better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
and ... using git-hfx-cherry-check.sh in gitflow-finish.sh and maven-gitflow-HOTFIX-finish.sh
Andreas Kohlbecker
03:22 PM EDIT bug #8105: better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
Script to check for cherries in the HFX Finish jobs created: https://dev.e-taxonomy.eu/svn/trunk/server-scripts/jenki... Andreas Kohlbecker
02:41 PM EDIT bug #8117: CdmFilterablePagingProviderFactory.taxonNamesWithoutOrthographicIncorrect() causes performance overhead
Correction: The sql query showing the problem is:
~~~sql
select
this_.id as id1_499_2_, this_.created as cr...
Andreas Kohlbecker
12:29 PM EDIT bug #8117: CdmFilterablePagingProviderFactory.taxonNamesWithoutOrthographicIncorrect() causes performance overhead
the most time is actually consumed by
![](picture588-1.png)
Do we need to update the mysql driver for some r...
Andreas Kohlbecker
12:24 PM EDIT bug #8117: CdmFilterablePagingProviderFactory.taxonNamesWithoutOrthographicIncorrect() causes performance overhead
The query created by the restriction performs not so bad (55ms):
~~~sql
select
this_.id as id1_499_2_, this_...
Andreas Kohlbecker
11:32 AM EDIT bug #8117 (New): CdmFilterablePagingProviderFactory.taxonNamesWithoutOrthographicIncorrect() causes performance overhead

in
CdmFilterablePagingProviderFactory.taxonNamesWithoutOrthophicIncorrect()
a restriction is being used whic...
Andreas Kohlbecker
02:38 PM EDIT Revision aeddf804 (cdm-vaadin): fixing probelm with unchecked optional
Andreas Kohlbecker
12:40 PM EDIT Revision 8d8da57a (cdm-vaadin): ref #8117 commenting orthographic corrected names filter to prevent from unclear performance probelms, see ref #7899
Andreas Kohlbecker
11:28 AM EDIT bug #8116 (New): ProgressMonitorManager: logging instead of System.err
In the ProgressMonitorManager an ignored error is logged to `System.err.println`
All logging should go to the logg...
Andreas Kohlbecker
11:06 AM EDIT bug #8099 (Feedback): Error saving name type designation editor due to problem in poupeditor context
Andreas Kohlbecker
11:05 AM EDIT bug #8099: Error saving name type designation editor due to problem in poupeditor context
Hakllo Henning
ich verstehe Step 2,3 oben nicht, was hat du da genau gemacht?
Andreas
Andreas Kohlbecker

02/19/2019

06:22 PM PhycoBank task #7012: Workflow with Pensoft
updating diagram with corections. (96dpi) Andreas Kohlbecker
05:46 PM EDIT bug #8097: Problem with inserting a section - inReference is "lost"
issue completed.
Please review.
Andreas Kohlbecker
05:46 PM EDIT bug #8097 (Resolved): Problem with inserting a section - inReference is "lost"
Applied in changeset commit:cdm-vaadin|2bcb1498b2db48c720edfcfcac25e733be35cfb8. Andreas Kohlbecker
05:07 PM EDIT bug #8097: Problem with inserting a section - inReference is "lost"
As first solution to this problem we decided on making the inReference field required for all iSection refernfence ty... Andreas Kohlbecker
05:46 PM EDIT Revision 2bcb1498 (cdm-vaadin): fix #8097 inReference field required for section reference types
Andreas Kohlbecker
04:48 PM EDIT bug #5699 (Closed): user profile settigs in cdm_dataportal module done wrong
Andreas Kohlbecker
04:48 PM EDIT bug #5699 (Resolved): user profile settigs in cdm_dataportal module done wrong
Applied in changeset commit:cdm-dataportal|bf31af5f546f2b686f6d05c1357ce41d4bf6d09c. Andreas Kohlbecker
04:46 PM EDIT bug #5699: user profile settigs in cdm_dataportal module done wrong
this feature isn't used in any of the portals can can be removed.
Andreas Kohlbecker
04:48 PM EDIT Revision bf31af5f (cdm-dataportal): fix #5699 complete removal of unused per user default tab settings
Andreas Kohlbecker
11:31 AM EDIT bug #8104: TaxonName.getLastNamePart erroneously renamed .getFamiliyNamePart
Please can you have a quick look on the reversion of your commit? Andreas Kohlbecker
11:30 AM EDIT bug #8104 (Resolved): TaxonName.getLastNamePart erroneously renamed .getFamiliyNamePart
Applied in changeset commit:cdmlib|6b548bff807c53bdc4e3676d4b74b83b8f31be4f. Andreas Kohlbecker
11:30 AM EDIT Revision 6b548bff (cdmlib): fix #8104 renaming familiyNamePart back to lastNamePart
Andreas Kohlbecker
11:02 AM EDIT feature request #4922: GrantedAuthorities not reusable anymore
I have concerns about duplicating GAs as this will complicate first data inserters and managing of default GAs in gen... Andreas Kohlbecker
09:29 AM EDIT task #8109 (New): Concept for linking from taxon entries to name pages
Taxon entries in the data portal do not allow to navigate to the according name page.
This will become important o...
Andreas Kohlbecker
09:18 AM EDIT feature request #8108: Name page shows complete name information (I)
Hallo,

...

Allerdings ist die Frage schon interessant: Das wirkliche Potential Taxon fehlt halt in >99% der F...
Andreas Kohlbecker
09:17 AM EDIT feature request #8108: Name page shows complete name information (I)
Hallo,
will ja nicht pingelig sein, aber ein „Name used in Source“ ist ja im Prinzip ein Potential Taxon und kann ...
Andreas Kohlbecker
09:16 AM EDIT feature request #8108: Name page shows complete name information (I)
AM:
Wichtig wäre hier auch die Frage, wie man diese expliziten Namensinformationen auf einer normalen Taxonpage ve...
Andreas Kohlbecker
09:15 AM EDIT feature request #8108 (Closed): Name page shows complete name information (I)
Derzeit ist diese Seite mehr oder weniger nur ein Weiterleitungsmechanismus zu den zugehörigen Taxa.

Die besser a...
Andreas Kohlbecker

02/18/2019

06:05 PM EDIT bug #8107 (Feedback): NPE when throwing PopupEditorException in AbstractPopupEditor
Andreas Kohlbecker
06:05 PM EDIT bug #8107: NPE when throwing PopupEditorException in AbstractPopupEditor
[Henning:]
> Hier waren Gattungsnamen vor dem Import nicht verfügbar, daher wurde das Pflichtfeld Gattungsname nic...
Andreas Kohlbecker
05:01 PM EDIT bug #8107 (In Progress): NPE when throwing PopupEditorException in AbstractPopupEditor
The NPE occurred during while creating the PopupEditorException to be thrown in turn of an other exception which has ... Andreas Kohlbecker
04:51 PM EDIT bug #8107 (Closed): NPE when throwing PopupEditorException in AbstractPopupEditor
Heba reported an NPE which occurred while saving a name popup editor:
Problem beim Speichern um 10:08 Uhr.
http:/...
Andreas Kohlbecker
05:25 PM EDIT Revision 592b9851 (cdm-vaadin): ref #8107 getFieldGroup() returns Optional<FieldGroup> to avoid NPEs and logging errors before rethrowing as PopupEditorException
Andreas Kohlbecker
04:11 PM EDIT feature request #8106 (Closed): improve image gallery settings labeling
done! Andreas Kohlbecker
04:11 PM EDIT feature request #8106 (Resolved): improve image gallery settings labeling
Applied in changeset commit:cdm-dataportal|5358baffb125a13d97910717acfcca8e978d63f5. Andreas Kohlbecker
04:03 PM EDIT feature request #8106 (Closed): improve image gallery settings labeling
requested by AM:
Vielleicht könnte man bei der Configuration den Text noch etwas anpassen, so dass klar ist was pa...
Andreas Kohlbecker
04:11 PM EDIT Revision 5358baff (cdm-dataportal): fix #8106 better labels for the imagegallery settings related to the thumbnail size
Andreas Kohlbecker
12:22 PM EDIT bug #8105 (In Progress): better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
During the release of the taxeditor 5.5.0 it turned out, that the `master`branch has received commits from the `hotfi... Andreas Kohlbecker
10:19 AM EDIT Revision 18190ef3 (taxongraph-view): switching base url to api.phycobank.org
Andreas Kohlbecker
10:16 AM EDIT Revision 7dcedec2 (taxongraph-view): non minified version of dagre.js
Andreas Kohlbecker
10:13 AM EDIT Revision ba56c9d7 (taxongraph-view): adding updated full test data set
Andreas Kohlbecker
09:51 AM EDIT bug #8104 (Closed): TaxonName.getLastNamePart erroneously renamed .getFamiliyNamePart
**The TaxonName property `lastNamePart` has erroneously been changed during the refactoring for #7238 to `familyNam... Andreas Kohlbecker

02/15/2019

06:52 PM PhycoBank feature request #8103 (Rejected): Feedback mechanism from curator to publisher and author team
As pointed out in #7012 "*Curatorial process in the registration office*" a feed back mechanism is need for the curat... Andreas Kohlbecker
05:33 PM PhycoBank task #8102 (New): typedsignations without status
es sind 95 Typedesignations betroffen 6 SpecimenTypeDesignations und 89 NameTypes
most important are the issues li...
Andreas Kohlbecker
04:57 PM EDIT bug #8101 (New): cdm-server docker container uses wrong timezone
The docker container uses UTC but should be in the same timezone as the host system.
~~~~
edit-production ~ # dat...
Andreas Kohlbecker
04:40 PM EDIT bug #8098 (Duplicate): Cache update for Portal view
I can no longer reproduce this problem, the reference looks ok now.
I thus will close this issue as duplicate of #...
Andreas Kohlbecker
04:37 PM EDIT bug #8100: Cache update in UI
It seems as if the updating of in-reference Article is not causing the contained reference section to be updated. Andreas Kohlbecker
04:29 PM EDIT bug #8100: Cache update in UI
Did you update the inreference "Fottea"? The Article was not touched? Andreas Kohlbecker
11:34 AM PhycoBank task #7012: Workflow with Pensoft
96dpi Andreas Kohlbecker
11:32 AM PhycoBank task #7012: Workflow with Pensoft
120 dpi Andreas Kohlbecker
11:30 AM PhycoBank task #7012: Workflow with Pensoft
higher dpi: 96 Andreas Kohlbecker
11:29 AM PhycoBank task #7012: Workflow with Pensoft
updating the workflow with curatorial review Andreas Kohlbecker

02/14/2019

10:50 PM EDIT Wiki edit: Release_Notes (#429)
Andreas Kohlbecker
03:03 PM EDIT Wiki edit: Release_Notes (#426)
Andreas Kohlbecker
03:01 PM EDIT Wiki edit: Release_Notes (#425)
Andreas Kohlbecker
09:52 AM EDIT Wiki edit: Release_Notes (#417)
Andreas Kohlbecker
09:51 AM EDIT Wiki edit: Release_Notes (#416)
Andreas Kohlbecker
09:41 AM EDIT Wiki edit: Release_Notes (#415)
Andreas Kohlbecker
04:20 PM EDIT task #8091: Discuss Referencetype PrintSeries with respect to user needs of PhycoBank and taxonomic projects
yes please Andreas Kohlbecker
02:39 PM EDIT Revision b3b49290 (taxeditor): deleting file to solve merge conflicts during the release which came with hotfix 5.4.3
Andreas Kohlbecker
08:56 AM EDIT feature request #8030 (Closed): Cache updater service methods externalized and base class specific
review completed, no issues found Andreas Kohlbecker
08:55 AM EDIT bug #7874 (Closed): TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters
looks like fixed by 100% Andreas Kohlbecker
 

Also available in: Atom