EDIT Project Management

12/21/2018

08:27 PM EDIT bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Submitter can currently view/update unpublished references and datasets entered by the curator or a. Wolf-Henning Kusber

05:37 PM EDIT bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Issue solved, please review. Andreas Kohlbecker

05:37 PM EDIT bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Wolf-Henning Kusber wrote:
> Unpublished references must be hidden from the select in the "New Registration" makes s... Andreas Kohlbecker

05:45 PM EDIT Revision 68369e5d (cdmlib): ref #7833 another method for UserHelper to scan for permissions

Andreas Kohlbecker

05:43 PM EDIT feature request #7968 (Closed): ReferenceEditor: optional validation for completenes of Partial values in datePublished

As consequence of the way #7833 was solved (see `RegistrationWorkingSetService.checkReferencePublished(Reference refe... Andreas Kohlbecker

05:33 PM EDIT Revision 99741bc0 (cdm-vaadin): ref #7833 registration start view excludes unpublished references

Andreas Kohlbecker

04:19 PM EDIT Revision 35a51c01 (cdm-vaadin): ref #7833 registration start view only shows references for which the user has permissions

Andreas Kohlbecker

04:15 PM EDIT Revision d81bb53b (cdm-vaadin): ref #7833 fixing inversly interpreted access denied

Andreas Kohlbecker

12:38 PM EDIT Revision b32150b1 (cdm-vaadin): ref #7833 restricting access to RegistrationWorkingsetView:

- AccessRestrictedViewControlBean to evaluate AccessRestrictedView.isAccessDenied()
- refactoring AccessRestricted... Andreas Kohlbecker

10:34 AM EDIT task #7964: Name and orthographic variant - were to link types

As a basis for discussion:
A given name must be available (selectable) for new Working sets.
That means: if an in... Wolf-Henning Kusber

10:04 AM EDIT Revision 581b3ae7 (taxeditor): ref #7589 Removed unnecessary sorting

Patrick Plitzner

10:04 AM EDIT Revision 598e33b7 (taxeditor): ref #7580 Add copy&paste configuration (not yet actually working)

Patrick Plitzner

10:04 AM EDIT Revision 787a37f1 (taxeditor): code cleanup

Patrick Plitzner

08:19 AM EDIT Revision 020445f3 (cdm-vaadin): ref #7967 referencing ticket in comment

Andreas Kohlbecker

08:16 AM EDIT task #7967 (New): AnnotationBasedAccessControlBean to implement ViewAccessControl

AnnotationBasedAccessControlBean should implement ViewAccessControl since the view class and its annotations can be a... Andreas Kohlbecker

12/20/2018

04:57 PM EDIT bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Unpublished references must be hidden from the select in the "New Registration" makes sense.
Question (2): creator =... Wolf-Henning Kusber

04:23 PM EDIT bug #7833 (Feedback): submitters can access see any registration in any RegistrationWorkingSet

Hallo Henning,
ich denke dieses Ticket sollten wir unbedingt noch lösen bevor wir externe Submitter zulassen.
A... Andreas Kohlbecker

04:34 PM EDIT task #7964: Name and orthographic variant - were to link types

Currently, I can link types to both names (see screen shot, by the way, I put in 1234 as number before the page was u... Wolf-Henning Kusber

04:04 PM EDIT task #7964 (Feedback): Name and orthographic variant - were to link types

Andreas Kohlbecker

04:03 PM EDIT task #7964: Name and orthographic variant - were to link types

once a name is known to be incorrect (has a name relation to the correcting name) it should no longer possible to
... Andreas Kohlbecker

02:32 PM EDIT task #7964 (Feedback): Name and orthographic variant - were to link types

Types can be linked to the corrected name or to the incorrect name (as published).
There are arguments to link a ... Wolf-Henning Kusber

04:25 PM EDIT bug #7897 (Duplicate): TeamOrPersonField: BindException: The given field is not part of this FieldBinder

this looks like a duplicate of #7867 Andreas Kohlbecker

04:19 PM EDIT bug #7956 (Closed): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

solved Andreas Kohlbecker

04:19 PM EDIT bug #7956 (Resolved): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

Applied in changeset commit:cdm-vaadin|6e995b1e3d57b22f0dbd925955d647fea233a985. Andreas Kohlbecker

04:19 PM EDIT Revision 6e995b1e (cdm-vaadin): fix #7956 adding lost refreshView

Andreas Kohlbecker

04:14 PM EDIT bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

"unranked" is fine as long it points to an uninominal. Wolf-Henning Kusber

03:54 PM EDIT bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

Why is it "unknown rank" and not "unranked". The other vague rank terms are labled "unranked infraspecific" and "unr... Andreas Kohlbecker

11:31 AM EDIT bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

"unknown rank" as uninominal might be important. The others are not in use and not expected to use. Wolf-Henning Kusber

08:25 AM EDIT bug #7963 (Feedback): TaxonNamePopEditor: name part field visibility not correct for all ranks

is there a rank which is highly relevant for phycobank for which this issue needs to be fixed immediately? Andreas Kohlbecker

08:24 AM EDIT bug #7963 (Closed): TaxonNamePopEditor: name part field visibility not correct for all ranks

[henning]
I checked the complete list. With some ranks (mostly not relevant for PhycoBank, I have problems).
"s... Andreas Kohlbecker

04:11 PM EDIT feature request #7966 (Closed): Registration search simplify type select options

The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker

04:11 PM EDIT feature request #7965 (Closed): Registration search simplify type select options

The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker

03:45 PM EDIT bug #7481 (Resolved): ReferenceEditor: filter inReferences by applicable reference type

Andreas Kohlbecker

03:44 PM EDIT bug #7481: ReferenceEditor: filter inReferences by applicable reference type

validator added
ready for reviewing Andreas Kohlbecker

11:01 AM EDIT bug #7481: ReferenceEditor: filter inReferences by applicable reference type

Wolf-Henning Kusber wrote:
> Two comments
>
> AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
... Andreas Kohlbecker

10:50 AM EDIT bug #7481: ReferenceEditor: filter inReferences by applicable reference type

Two comments
AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
W-H.K.: missing: inProceedings |... Wolf-Henning Kusber

09:30 AM EDIT bug #7481 (Feedback): ReferenceEditor: filter inReferences by applicable reference type

Hi Henning, do you agree with the constraints as mentioned in the issue description? Anything missing? Andreas Kohlbecker

03:41 PM EDIT Revision 5dd877d3 (cdm-vaadin): ref #7481 adding validator for in reference type constraints

Andreas Kohlbecker

03:21 PM EDIT Revision 2b73afd3 (taxeditor): ref #7854: minor changes

Katja Luther

03:19 PM EDIT bug #7941: Deduplication does not work in new taxon dialog

this should be fixed with the changing the parsing method to the same as in name editor. please review. Katja Luther

03:18 PM EDIT bug #7941 (Resolved): Deduplication does not work in new taxon dialog

Applied in changeset commit:taxeditor|2e5addbf1470b86b929e7e4ca4fc0f0eebb291f6. Katja Luther

03:17 PM EDIT Revision 2e5addbf (taxeditor): fix #7941: use the same parser method in new taxonnode wizard as in name editor

Katja Luther

03:16 PM EDIT bug #7940 (Feedback): "New" menu in navigator not available for certain users

I can't reproduce this, did you changed the rights of the user? Katja Luther

02:29 PM EDIT feature request #7718 (Closed): New Registration: Exclude irrelevant reference types from list of existing publications

Andreas Kohlbecker

02:13 PM EDIT feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications

The reference types Section, PrintSeries and Journal have been excluded from the options. Ticket can be closed. Wolf-Henning Kusber

02:14 PM EDIT bug #7950: ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

Solved!
Should be tested in IE / Edge also
Andreas Kohlbecker

02:13 PM EDIT bug #7950 (Resolved): ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

Applied in changeset commit:cdm-vaadin|403a0ebd2e7160ce26171894195e6a362f9048bd. Andreas Kohlbecker

02:13 PM EDIT Revision 403a0ebd (cdm-vaadin): fix #7950 fixing scss for icon button fields and adding variable for box-shadow-width

Andreas Kohlbecker

02:06 PM EDIT bug #7880 (Resolved): Implement centralized preference default loading strategy

this should be fixed. please review. Katja Luther

01:42 PM EDIT Revision 46ec4941 (taxeditor): fix navigator order preference page

Katja Luther

01:22 PM EDIT Revision fbd932cc (taxeditor): ref #7849: disable apply button until something was changed in preference page

Katja Luther

01:00 PM EDIT Revision 9eb3b85d (cdmlib): ref #7481 inReference constraints added as method to ReferenceType - making method static

Andreas Kohlbecker

12:50 PM EDIT bug #7639 (Closed): SpecimenTypeDesignationEditor: Altitude not saved and displayed properly

Andreas Kohlbecker

11:59 AM EDIT bug #7639: SpecimenTypeDesignationEditor: Altitude not saved and displayed properly

Altitude
200,5 is given as 200
2.5 or 2,5 is given as 2
Because altitudes can not be that exact this is okay wit... Wolf-Henning Kusber

11:59 AM EDIT feature request #7954 (Closed): protected vs. unproteced caches in TaxEditor

Katja Luther

10:18 AM EDIT feature request #7954: protected vs. unproteced caches in TaxEditor

The tooltip text for the button explains the functionality exactly for users.
Even though, I saw the German transla... Wolf-Henning Kusber

09:38 AM EDIT feature request #7954: protected vs. unproteced caches in TaxEditor

There is a tooltip for the button now. Please have a look if this clearify the usage of the lock.
Katja Luther

09:34 AM EDIT feature request #7954 (Resolved): protected vs. unproteced caches in TaxEditor

Applied in changeset commit:taxeditor|c42c4e417e482b08177318c7d155f58c314c8206. Katja Luther

11:58 AM EDIT bug #7856 (Resolved): Allow local override for distribution vocabularies

now it is possible to override the available vocabularies for the distribution editor.please review Katja Luther

11:56 AM EDIT Revision 5b9c1d33 (cdm-vaadin): ref #7481 moving inReference constraints to cdmlib-model

Andreas Kohlbecker

11:56 AM EDIT Revision 7ffc533f (taxeditor): ref #7856: fix allow override for namedArea vocabulary selection for distributions

Katja Luther

11:55 AM EDIT feature request #7218 (Closed): SpecimenTypedesignationsWorkingsetEditor: support for Reference system

Wolf-Henning Kusber wrote:
> good: WGS84 can be selected.
>
> not so good: other possible systems can not be sele... Andreas Kohlbecker

11:44 AM EDIT feature request #7218 (Feedback): SpecimenTypedesignationsWorkingsetEditor: support for Reference system

good: WGS84 can be selected.
not so good: other possible systems can not be selected (I do not need them).
not ... Wolf-Henning Kusber

11:49 AM EDIT Revision bc7a1271 (cdmlib): ref #7481 inReference constraints added as method to ReferenceType

Andreas Kohlbecker

11:21 AM EDIT Revision eade8b7d (taxeditor): ref #7856: fix allow override for namedArea vocabulary selection for distributions

Katja Luther

10:45 AM EDIT feature request #7912 (Feedback): Enhance checkbox tree viewer

this seems to work, but the checkboxes are not grayed when a child or some children are selected. Katja Luther

10:35 AM EDIT bug #7929 (Closed): after delete of not persisted object in bulkeditor the object is still in bulkeditor list

seems to work Patrick Plitzner

10:23 AM EDIT bug #7929 (Resolved): after delete of not persisted object in bulkeditor the object is still in bulkeditor list

Katja Luther

10:23 AM EDIT bug #7929: after delete of not persisted object in bulkeditor the object is still in bulkeditor list

please review Katja Luther

10:20 AM EDIT bug #7934 (Closed): sometimes the signs for deduplication are not shown

works fine now. Katja Luther

10:16 AM EDIT bug #7649 (Closed): Term editor loads/saves extremely slow

this is fixed with #7887 Katja Luther

10:16 AM EDIT feature request #7887 (Closed): Use DTOs in term editor

after creating a new namedArea the deletion does not work because it is referenced by its parent. This is fixed with ... Katja Luther

10:13 AM EDIT Revision c5802825 (cdmlib): ref #7887: fix deletion of terms

Katja Luther

09:38 AM EDIT Revision 99e47ce1 (taxeditor): fix #7954: update the english text for cache field tooltip

Katja Luther

09:37 AM EDIT Revision 9bbd60ec (cdm-vaadin): ref #7481 inReference options filtered by applicable type

Andreas Kohlbecker

09:33 AM EDIT Revision c42c4e41 (taxeditor): fix #7954: add tootltip to cache fields in editor to clearify the meaning of the lock

Katja Luther

07:57 AM EDIT bug #7878 (Closed): Edit CollectionCode not saved

Andreas Kohlbecker

07:56 AM EDIT task #7846 (Feedback): PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

DTO is an acronym for Data Transfer Object. The *DTO labels should be transformes into something more user friendly o... Andreas Kohlbecker

07:54 AM EDIT bug #7962 (Closed): PopupEditors: *DTO in context 'breadcrumbs' to be transformed into more humane labels

see #7846#note-4 Andreas Kohlbecker

12/19/2018

08:11 PM EDIT task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

What is "SpecimenTypeDesignationWorkingSetDTO" DTO? Wolf-Henning Kusber

07:52 PM EDIT task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

Tested for a new infraspecific name with new genus with new reference and new species epithet with new article in new... Wolf-Henning Kusber

08:09 PM EDIT bug #7878: Edit CollectionCode not saved

Works.
New feature "is part of" is helfull.
I took an entry "Code only" Edit Instute name "Institute of Botany" a... Wolf-Henning Kusber

07:38 PM EDIT bug #7944: TaxonNamePopEditor: name part fields are required

Review:
I agree, that this is needed for data integrity, but I think this will slow down data entry by users and cu... Wolf-Henning Kusber

06:44 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

label: what about the following label wording?
header: orthographical variant
above the cache: incorrect name (= ... Wolf-Henning Kusber

05:36 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

Comment on #15
according to the latest discussion, which is based on research in the ICBN, we came to the conclusi... Wolf-Henning Kusber

05:10 PM EDIT feature request #7899 (Resolved): enable orthographic name correction in Vaadin

please review Andreas Kohlbecker

05:00 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

according to the latest discussion, which is based on research in the ICBN, we came to the conclusion that `ORTHOGRAP... Andreas Kohlbecker

03:20 PM EDIT feature request #7899 (In Progress): enable orthographic name correction in Vaadin

After a discussion with Andreas Müller, the improved concept from 2018-12-11 has been revised and changed again:
1... Andreas Kohlbecker

06:14 PM EDIT task #7935 (In Progress): Discuss new solution to establish the communication between submitter and curator

Andreas Kohlbecker

06:00 PM EDIT Revision a58f31a1 (cdm-vaadin): Revert "ref #7899 adding MarkerType 'Incorrect name'"

This reverts commit 068197fd8dc908bd5c05ddd764e78027a564dbec. Andreas Kohlbecker

05:39 PM EDIT feature request #7954: protected vs. unproteced caches in TaxEditor

Ich finde Hennings Vorschlag prima, denn wirklich intuitiv verstädlich sind diese Schloß-Icons auch für mich nie gewe... Andreas Kohlbecker

05:13 PM EDIT Revision e561ae83 (cdm-vaadin): ref #7961 deprecating TaxonNamePopupEditorMode until decided on removal or not

Andreas Kohlbecker

05:08 PM EDIT task #7961 (New): Consider removal of the TaxonNamePopupEditorMode ORTHOGRAPHIC_CORRECTION

As of the latest discussion regarding the semantic of `NameRelationshipType.ORTHOGRAPHIC_VARIANT()` (#7899#note-15) i... Andreas Kohlbecker

04:51 PM EDIT task #7960 (New): Revision of NameRelationshipTypes

While working on #7899 a discussion on the semantics of the NameRelationshipTypes `ORTHOGRAPHIC_VARIANT` and `MISSPEL... Andreas Kohlbecker

04:45 PM EDIT bug #7951 (Closed): Reference Combobox option titles can be too long causing the select box to extend too much

Andreas Kohlbecker

04:32 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

This obviously comes from the vaadin combobox, the width of the div containing the table is set too wide:
~~~html
... Andreas Kohlbecker

04:22 PM EDIT bug #7951 (In Progress): Reference Combobox option titles can be too long causing the select box to extend too much

The data problems pointed out in comment 16 are not really relevant for this issue.
But there is still one situat... Andreas Kohlbecker

04:45 PM EDIT bug #7959: LazyCombobox popup over sizing problem

This is most probably a vaadin probelm, either in vaddin itself or in the viritin addon Andreas Kohlbecker

04:43 PM EDIT bug #7959 (Rejected): LazyCombobox popup over sizing problem

see #7951#note-18 Andreas Kohlbecker

03:23 PM EDIT Revision 3bf04fa1 (cdm-vaadin): ref #7899 excluding 'incorrect' names from name comboboxes by fitering by NameRelationshipType

Andreas Kohlbecker

02:04 PM EDIT feature request #7063 (Resolved): Improve the area selection wizard for distribution editor

I think this is solved with #7887.
Now the items in the tree have three states and it is possible to select and de... Katja Luther

01:49 PM EDIT Revision 5ab46e89 (taxeditor): ref #7854: show label corresponding to preferences

Katja Luther

01:32 PM EDIT Revision ad2e9ab4 (taxeditor): ref #7854: continue session handling in distribution editor

Katja Luther

01:28 PM EDIT Revision 3971a637 (cdmlib): ref #7854: adapt DTOs and merge Method for Distributions

Katja Luther

12:32 PM EDIT Revision 12cd46ae (taxeditor): ref #7589 Fix order of parent taxon nodes

Patrick Plitzner

12:05 PM EDIT bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

So this supports my thesis. Andreas Kohlbecker

10:31 AM EDIT bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

No reload, but open name again to look up if the not displayed data have been databased. Not sure if save or cancle w... Wolf-Henning Kusber

10:25 AM EDIT bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

This seems to be an update problem with the workingset. Didi you try a reload of the page after saving the editor, I ... Andreas Kohlbecker

12/18/2018

02:16 PM EDIT Revision 328bcdec (taxeditor): Rename utility method

Patrick Plitzner

02:16 PM EDIT Revision 076adbba (taxeditor): ref #7589 Check dirty state before executing handler or button actions

Patrick Plitzner

02:16 PM EDIT Revision e4f5a8e2 (taxeditor): ref #7589 Only allow one single default taxon description per taxon

Patrick Plitzner

02:16 PM EDIT Revision c2dff0ee (cdmlib): ref #7589 Add service method to find taxon description by marker

Patrick Plitzner

01:19 PM EDIT task #7854: Open issues in TaxDistributionEditor

the branch is now merged to develop.
There are still some problems with multiple representation exceptions. Katja Luther

12:56 PM EDIT Revision 16833e53 (cdmlib): ref #7854: adapt DTOs

Katja Luther

12:53 PM EDIT Revision 0747234f (taxeditor): ref #7854: continue session handling in distribution editor

Katja Luther

11:35 AM EDIT Revision 2e385b93 (taxeditor): ref #7854: session handling in distribution editor

Katja Luther

11:18 AM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

Die meisten Unstimmigkeiten kommen durch IAPT-Altdaten und Einträge aus dem ersten Jahr PhycoBank.
Dort wurden Serie... Wolf-Henning Kusber

08:51 AM EDIT bug #7951 (Feedback): Reference Combobox option titles can be too long causing the select box to extend too much

For me it looks like this:
I think we should discuss these diffe... Andreas Kohlbecker

09:40 AM EDIT Revision 530e4fec (taxeditor): revert changes in CharacterMatrix

Katja Luther

09:38 AM EDIT Revision 7bec20de (taxeditor): remove nebula.widget jar

Katja Luther

12/17/2018

05:16 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

"Greuter" Ref. solved. Layout problems not, see #11
A new layout problem occurred: Even if a long title shortened,... Wolf-Henning Kusber

03:55 PM EDIT bug #7951 (Resolved): Reference Combobox option titles can be too long causing the select box to extend too much

The test server was not yet up to date. After the server was buidl freshly I could not reproduce any of the above nam... Andreas Kohlbecker

10:20 AM EDIT bug #7951 (In Progress): Reference Combobox option titles can be too long causing the select box to extend too much

2018-12-17 no changes visible for me.
Normally the formatter works well.
Problems with long book titles are not s... Wolf-Henning Kusber

02:53 PM EDIT Revision 576b283c (cdmlib): ref #7854: changes in taxonDistributionDTO

Katja Luther

01:50 PM EDIT task #7958 (New): General concept for a flexible and generic entitiy and dto formatter framework in the cdmlib

Currently there are *CacheStrategies*, *Formatter*, *EllypsisFormatter*, *DtoFormatter*, ... all of these could be ha... Andreas Kohlbecker

01:49 PM EDIT Revision c5d906bd (taxeditor): ref #7854: implement getRootEnteties for the session view in distributioneditorPart

Katja Luther

01:35 PM EDIT Revision 97d21185 (taxeditor): ref #7854: minor changes in session handling

Katja Luther

01:34 PM EDIT Revision 278a5e0a (taxeditor): ref #7854 Implement NatTable for distribution editor

Katja Luther

01:18 PM EDIT Revision 229e074a (cdmlib): ref #7957 Change marker to avoid "Uses" details view

Patrick Plitzner

01:18 PM EDIT Revision 0770bcab (cdmlib): ref #7589 Use TaxonNodeDtos in row wrappers

Patrick Plitzner

01:18 PM EDIT Revision 6a6f0c52 (cdmlib): ref #7589 Add service method for description deletion for data sets

Patrick Plitzner

01:18 PM EDIT Revision 1b2a87f1 (cdmlib): ref #7589 Remove reference to default taxon desc from row wrapper

Patrick Plitzner

01:16 PM EDIT feature request #7957 (Closed): Add types for taxon description (as EnumSet)

When working on the Character Matrix there are 3 types of taxon descriptions:
1. default taxon description
1. tax... Patrick Plitzner

01:09 PM EDIT Revision 8d9c5176 (taxeditor): ref #7589 Move description deletion to service layer

Patrick Plitzner

01:08 PM EDIT Revision 1903cf2b (taxeditor): ref #7589 Remove UpdateResult handling from CharacterMatrix

Patrick Plitzner

01:07 PM EDIT Revision 11a549d1 (taxeditor): ref #7589 Use TaxonNodeDtos in character matrix

Patrick Plitzner

12:48 PM EDIT Revision ba755283 (cdmlib): fix wrong locality text in gatheringDTO

Katja Luther

12:45 PM EDIT Revision 8c8c0db0 (taxeditor): merge develop into branch distributionEditorNatTable

Katja Luther

11:51 AM EDIT bug #7956 (Closed): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

Reported by Heba (release version):
Working set: http://api.cybertaxonomy.org/phycobank/app/registration#!workings... Wolf-Henning Kusber

11:50 AM EDIT task #7955 (New): Conecept for centralizes init strategies

The same or very similar init strategies are often distributed redundantly in the code base of the cdmlib an dependen... Andreas Kohlbecker

11:10 AM EDIT feature request #7954: protected vs. unproteced caches in TaxEditor

Hintergrund des Tickets ist, dass ich als User nicht auf unprotected/protected geachtet habe... Wolf-Henning Kusber

11:07 AM EDIT feature request #7954 (Closed): protected vs. unproteced caches in TaxEditor

Problem: erst nach diversen Diskussionen mit Leuten aus dem EDIT-Team (und rumprobieren) habe ich verstanden, wie pro... Wolf-Henning Kusber

10:20 AM EDIT Revision 840bfe5f (cdmlib): fix error in geolocation in abcd import

Katja Luther

10:20 AM EDIT Revision 2afca98f (cdmlib): ref #7854: add taxon to descriptionDTO

Katja Luther

07:40 AM EDIT Revision 7b6b3222 (taxeditor): ref #7589 Remove reference to default taxon desc from row wrapper

Patrick Plitzner

07:38 AM EDIT Revision 2c28be6a (taxeditor): ref #7589 Remove UpdateResult handling from CharacterMatrix

Patrick Plitzner

12/14/2018

10:18 PM EDIT Revision 775c87a6 (cdm-vaadin): ref #7899 starting 'Incorrect name' editor without mode VALIDATE_AGAINST_HIGHER_NAME_PART and hiding 'Ortographic correction' toggle

Andreas Kohlbecker

09:56 PM EDIT Revision 068197fd (cdm-vaadin): ref #7899 adding MarkerType 'Incorrect name'

Andreas Kohlbecker

09:25 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

I improved the label `ReferenceEllypsisFormatter` so that it can deal with any title cache protection. thus the above... Andreas Kohlbecker

11:52 AM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

We should differentiate between atomized data and protected/unprotected caches and bibliographic/nomenclatural refere... Wolf-Henning Kusber

11:27 AM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

The Book "*Greuter, McNeill, Barrie, Burdet, Demoulin, Filg., Nicolson, P.C.Silva, J.E.Skog, Trehane, Turland, D.Hawk... Andreas Kohlbecker

09:21 PM EDIT Revision e8b9f0b2 (cdmlib): ref #7951 more complete generic ReferenceEllypsisFormatter

Andreas Kohlbecker

02:42 PM EDIT Revision 569b2942 (cdmlib): ref #7951 moving EllypsisFormatter to cdmlib/model/eu.etaxonomy.cdm.format

Andreas Kohlbecker

02:40 PM EDIT Revision 0ca40381 (cdm-vaadin): ref #7949renaming ComboboxLabelProvider to EllypsisFormatter and other classes accordingly, abstract base class introduced

Andreas Kohlbecker

02:38 PM EDIT Revision 2192ca65 (cdm-vaadin): ref #7949 renaming ComboboxLabelProvider to EllypsisFormatter and other classes accordingly, abstract base class introduced

Andreas Kohlbecker

02:18 PM EDIT bug #7953 (Feedback): Book in BookSeries: incomplete titleCache misses series title

Andreas Kohlbecker

02:18 PM EDIT bug #7953: Book in BookSeries: incomplete titleCache misses series title

@henning: please complete the "Expected titleCache" in the description Andreas Kohlbecker

02:17 PM EDIT bug #7953 (Feedback): Book in BookSeries: incomplete titleCache misses series title

BookSeries:
* titleCache: "Iconographia Diatomologica"
Book in this series:
* title: "Taxonomy - biogeograph... Andreas Kohlbecker

01:20 PM EDIT Revision 343fcdde (taxeditor): ref #7854: adapt to changes in DescriptionDTO

Katja Luther

12:26 PM EDIT Revision f5832048 (taxeditor): ref #7854: changes in details view and supplemental data view need to result in dirty state of the distribution editor

Katja Luther

11:34 AM EDIT Revision da628899 (taxeditor): ref #7854: add filter column to distribution columns

Katja Luther

11:14 AM EDIT feature request #7949 (Closed): New Registration: Reference combobox to offer two search modes

The option captions are changed as wished. Andreas Kohlbecker

11:13 AM EDIT Revision e46361bb (cdm-vaadin): ref #7949 changing option captions

Andreas Kohlbecker

10:00 AM EDIT Revision 31462908 (taxeditor): minor

Katja Luther

12/13/2018

06:53 PM EDIT feature request #7949: New Registration: Reference combobox to offer two search modes

Functionality perfect, this is what we need!
Wording and layout might be improved. "anywhere" has two problems (i)... Wolf-Henning Kusber

05:51 PM EDIT feature request #7949: New Registration: Reference combobox to offer two search modes

done, please review! Andreas Kohlbecker

05:51 PM EDIT feature request #7949 (Resolved): New Registration: Reference combobox to offer two search modes

Applied in changeset commit:cdm-vaadin|a7612c19f7272069354d69c68e3385220e6af556. Andreas Kohlbecker

06:42 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

Book title causes problems. Combobox longer than screen. Date not given AND title not shortened. See screen shot:
![... Wolf-Henning Kusber

05:23 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

Mit der Referenz hatte ich Probleme. Die Wiedergabe des Buches ist ungenügend (siehe Screen shot).
Editor fehlt, "23... Wolf-Henning Kusber

04:58 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

Ich habe nun noch einen Bug gefixt, es lang nicht an den BookSections sondern eine Stringersetzung hatte Probleme mi... Andreas Kohlbecker

04:53 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

[Henning:]
Überwiegenst hast Du die wichtigsten Keywords rausgefischt, was mir aufgefallen ist, dass das Kürzen ... Andreas Kohlbecker

03:20 PM EDIT bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

please review Andreas Kohlbecker

03:19 PM EDIT bug #7951 (Resolved): Reference Combobox option titles can be too long causing the select box to extend too much

Applied in changeset commit:cdm-vaadin|bf643f223676b7510d21e41dd3760f342696e4a4. Andreas Kohlbecker

05:51 PM EDIT Revision a7612c19 (cdm-vaadin): fix #7949 Reference combobox with begins and anywhere search mode

Andreas Kohlbecker

04:48 PM EDIT Revision 532d021f (cdm-vaadin): ref #7951 ReferenceLabelProvider: fixing wrong string replacement for more complete ellipsis

Andreas Kohlbecker

03:19 PM EDIT Revision bf643f22 (cdm-vaadin): fix #7951 ReferenceLabelProvider to ellipsis the reference labels

Andreas Kohlbecker

02:57 PM EDIT task #7854 (In Progress): Open issues in TaxDistributionEditor

in branch distributionEditorNatTable a first implementation of the distribution editor with NAT tables is available.
... Katja Luther

02:56 PM EDIT Revision ea92da24 (cdmlib): fixing wrong boolean operator combination for Restrictions with operator AND_NOT

Andreas Kohlbecker

02:28 PM EDIT Revision f32128b6 (taxeditor): ref #7854: add filter to taxon row

Katja Luther

09:48 AM EDIT Revision 9245724f (taxeditor): ref #7854: improve removing of distributions in NAT table distribution editor

Katja Luther

09:23 AM EDIT Revision b55fd194 (cdmlib): ref #7854: add methods to get DTOs for distribution editor

Katja Luther

09:19 AM EDIT Revision 29e1af1d (cdmlib): code cleaning

Katja Luther

09:00 AM EDIT Revision ee6e05c9 (cdmlib): adapt propertyPath for occurences in fieldUnitDto

Katja Luther

12/12/2018

02:41 PM EDIT Revision 331c7265 (taxeditor): ref #7854: freezing taxon column

Katja Luther

02:30 PM EDIT Revision 9d0707c1 (taxeditor): ref #7854: fix reload

Katja Luther

01:55 PM EDIT Revision 943e9b24 (taxeditor): ref #7854: show details for distributions and reload after changing the areas in distribution editor

Katja Luther

01:26 PM EDIT feature request #7952 (Rejected): Registration page Maps display in PhycoBank portal

In PhycoBank geo references for type localities are given.
In the new portal no maps are displayed.
Example: http... Wolf-Henning Kusber

12/11/2018

06:07 PM EDIT task #7948: Editor for Classification Fragments

After discussions with Andreas & Andreas the Excel form was slightly changed.
Collumn A contains the UUID of the ref... Wolf-Henning Kusber

04:50 PM EDIT task #7948 (Closed): Editor for Classification Fragments

The PhycoBank team agreed not to implement an (Vaadin) editor for classification fragments (= classification in a ref... Wolf-Henning Kusber

05:17 PM EDIT bug #7951 (Closed): Reference Combobox option titles can be too long causing the select box to extend too much

to reproduce go to the new registration view, enter "Kusber" in the combobox and use the mouse wheel to scroll the op... Andreas Kohlbecker

05:13 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

We discussed the above problems and came to a solution ... issue description updated accordingly Andreas Kohlbecker

11:59 AM EDIT feature request #7899: enable orthographic name correction in Vaadin

incorrect uninominals and epithets should only be searchable in the "incorrect name" section. Example is genus=Melose... Wolf-Henning Kusber

10:43 AM EDIT feature request #7899: enable orthographic name correction in Vaadin

Applied in changeset commit:cdm-vaadin|61b6ce4e6afcc2de48e66b2f8df68d30c799ca3c. Andreas Kohlbecker

05:01 PM EDIT bug #7950: ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

can not reproduce this issue at the moment. Andreas Kohlbecker

04:54 PM EDIT bug #7950 (Closed): ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

Andreas Kohlbecker

04:51 PM EDIT feature request #7949 (Closed): New Registration: Reference combobox to offer two search modes

by default the search should be done as `BEGINS_WITH` search. The `CONTAINS` search mode should be offered as option Andreas Kohlbecker

02:08 PM EDIT feature request #7947 (Closed): registration page shows name relations

Display of name relations in the reference page is urgently required Andreas Kohlbecker

01:15 PM EDIT task #7935: Discuss new solution to establish the communication between submitter and curator

We agreed on a pure email solution without any messaging system:
curation@phycobank.org sollte auf eine bgbm inter... Andreas Kohlbecker

12:04 PM EDIT feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications

completed, please review Andreas Kohlbecker

12:03 PM EDIT feature request #7718 (Resolved): New Registration: Exclude irrelevant reference types from list of existing publications

Applied in changeset commit:cdm-vaadin|39acd47c396d32b10bdd3791eca10e75104e8fd2. Andreas Kohlbecker

11:54 AM EDIT feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications

The reference types Section, PrintSeries and Journal should be excluded from the options. Andreas Kohlbecker

12:03 PM EDIT Revision 39acd47c (cdm-vaadin): fix #7718 excluding irrelavant reference types from combobox in new registration view

Andreas Kohlbecker

11:46 AM EDIT bug #7946 (Closed): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener

Andreas Kohlbecker

11:45 AM EDIT bug #7946 (Resolved): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener

Applied in changeset commit:cdm-vaadin|c4f3380a5b2c8c725e2d9899b4200edd19213855. Andreas Kohlbecker

11:44 AM EDIT bug #7946 (Closed): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener

Henning reported the following problem:
Beim Testen von: https://dev.e-taxonomy.eu/redmine/issues/7899

Hängt d... Andreas Kohlbecker

11:45 AM EDIT Revision c4f3380a (cdm-vaadin): fix #7946 setting the status value directly in the RegistrationStatusFieldInstantiator

Andreas Kohlbecker

11:07 AM EDIT Revision 48fb701d (taxeditor): ref #7854: correct saving, details view and default source handling

Katja Luther

10:43 AM EDIT Revision 61b6ce4e (cdm-vaadin): fix #7899 changing corrected name label to "Incorrect name"

Andreas Kohlbecker

12/10/2018

07:37 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

To handle an erroneously spelled genus name, I had to register the uncorrect spelled genus name. A workaround could b... Wolf-Henning Kusber

07:24 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

The normal usecase "new epithet incorrectly published" to be corrected according to ICN works well.
But problems a... Wolf-Henning Kusber

07:05 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

Forms and functionality implemented as discussed.
Working with orthographic variants reveals an error in the specifi... Wolf-Henning Kusber

01:33 PM EDIT feature request #7899: enable orthographic name correction in Vaadin

please review once test server is updated. Andreas Kohlbecker

01:26 PM EDIT feature request #7899 (Resolved): enable orthographic name correction in Vaadin

Applied in changeset commit:cdm-vaadin|e5237e50ef5bcd241d14a3667ca23ac46aec2b71. Andreas Kohlbecker

07:06 PM EDIT feature request #7942: SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

implemented as discussed, ready for reviewing as soon as the test-server has been rebuild. Andreas Kohlbecker

07:05 PM EDIT feature request #7942 (Resolved): SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

Applied in changeset commit:cdm-vaadin|5003e7af8f925c3c340a8f9c2fdd28ce735a9672. Andreas Kohlbecker

07:04 PM EDIT Revision 5003e7af (cdm-vaadin): fix #7942 using required flag and validation to prevent from saving without typedesignations

Andreas Kohlbecker

05:21 PM EDIT Revision 5618ca88 (cdmlib): ref #7854: add service method to merge a set of descriptionelements

Katja Luther

05:12 PM EDIT Revision 01d7c5e7 (taxeditor): ref #7854: add ComboBox for status selection and merge distributionElements

Katja Luther

03:22 PM EDIT bug #7944: TaxonNamePopEditor: name part fields are required

ready for review Andreas Kohlbecker

03:03 PM EDIT bug #7944 (Resolved): TaxonNamePopEditor: name part fields are required

Applied in changeset commit:cdm-vaadin|8647ca02a990685e381409ca7b127b438766eeae. Andreas Kohlbecker

08:21 AM EDIT bug #7944 (Closed): TaxonNamePopEditor: name part fields are required

Depending on the chosen rank, the name part fields 'Uninomial', 'Specific epithet', ... should be set required in ord... Andreas Kohlbecker

02:59 PM EDIT Revision 8647ca02 (cdm-vaadin): fix #7944 TaxonNamePopEditor: name part fields are required

Andreas Kohlbecker

02:49 PM EDIT Revision aaa63dad (cdm-vaadin): ref #7899 updating nameRelationField with newly created corrected name

Andreas Kohlbecker

02:43 PM EDIT Revision 4bae0768 (cdm-vaadin): ref #7899 validator for orthographic correction

Andreas Kohlbecker

01:55 PM EDIT Revision ade5a13e (cdm-vaadin): ref #7899 adding new name as orthographic correction with correct bean instantiator

Andreas Kohlbecker

01:42 PM EDIT bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility

This error can not be reproduced by saving a variety taxon name with blank genus. So the problem that causes the exce... Andreas Kohlbecker

08:22 AM EDIT bug #7945 (Rejected): TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility

Incomplete data (missing genus) can result in exceptions being thrown:
~~~
org.hibernate.HibernateException: A co... Andreas Kohlbecker

01:24 PM EDIT Revision e5237e50 (cdm-vaadin): fix #7899 orthographic variant and corrections implemented in taxon name popup editor

Andreas Kohlbecker

09:39 AM EDIT feature request #7575 (Closed): Implement advanced quantitative cell editor

This has already been implemented Patrick Plitzner

09:38 AM EDIT feature request #7509 (Closed): Aggregate and persist specimen character data from character matrix

This has already been solved.
Aggregated descriptions are saved in the DescriptiveDataSet and shown in the charact... Patrick Plitzner

09:32 AM EDIT feature request #7362 (Closed): Implement view for Gfbio terminology service

This has already been implemented Patrick Plitzner

09:12 AM EDIT Revision 5d42b875 (cdmlib-apps): Add more source information to plant glossary import

Patrick Plitzner

07:30 AM EDIT Revision e5d40c14 (cdmlib-apps): Add more source information to plant glossary import

Patrick Plitzner

07:13 AM EDIT Revision 3ecd8903 (taxeditor): ref #7923 Disabel details for structure and property viewers

Patrick Plitzner

07:04 AM EDIT Revision 5f3b85bc (taxeditor): ref #7923 Add drag listener to structures viewer

Patrick Plitzner

07:00 AM EDIT bug #7933 (Feedback): Adding a new Term to the "Country" vocabulary leads to corrupt data

@Andreas: Should it be allowed at all to add a new term to the Country vocabulary?
The problem is in the TermType ... Patrick Plitzner

12/07/2018

04:20 PM EDIT Revision 3cbea5bb (cdmlib-apps): E+M latest changes to taxon relations import

Andreas Müller

04:20 PM EDIT Revision c7178a2e (cdmlib-apps): Handle Willing, E as artist for media

Andreas Müller

04:20 PM EDIT Revision 1a63486c (cdmlib-apps): E+M latest changes to name import (mostly for unparsed refdetail handling)

Andreas Müller

04:20 PM EDIT Revision 7aeff4a9 (cdmlib-apps): E+M use uuids for Authors, Teams and references

Andreas Müller

04:20 PM EDIT Revision 07f242db (cdmlib-apps): minor

Andreas Müller

03:56 PM EDIT Revision a41e78d9 (cdmlib-apps): Adapt to coding convention

Patrick Plitzner

03:13 PM EDIT Revision 713cacdb (cdmlib-apps): Fix multiple vocabulary generation

Patrick Plitzner

03:01 PM EDIT Revision 43c3f7df (cdmlib-apps): Fix db connection

Patrick Plitzner

02:26 PM EDIT Revision 66768fff (cdmlib-apps): Add plant glossary import

Patrick Plitzner

02:12 PM EDIT bug #7943 (In Progress): TypeDesignationsEditor Select Reference for figure

it is not clear why this problem exists for the reference combobox and not for the collection combobox. Both are impl... Andreas Kohlbecker

12:04 PM EDIT bug #7943 (In Progress): TypeDesignationsEditor Select Reference for figure

Double selection of a reference needed to be saved as reference of a figure (Release & Test)
First selection of a ... Wolf-Henning Kusber

02:08 PM EDIT Revision b6b666d7 (cdm-vaadin): ref #7943 removing duplicate assignment of RelatedEntityButtonUpdaters

Andreas Kohlbecker

02:04 PM EDIT bug #7245 (Closed): validation of ToOneRelatedEntityCombobox not working

Tested:
Name can not be saved without a referene, warning is fine.
No problems.
Wolf-Henning Kusber

01:25 PM EDIT Revision e12ddaf5 (taxeditor): ref #7939: adapt TaxonNavigator to moved comparator

Katja Luther

01:25 PM EDIT Revision 0c625cd1 (taxeditor): ref #7923 Show character combination during drag&drop

Patrick Plitzner

01:25 PM EDIT Revision e3e487e3 (taxeditor): ref #7923 Set character representation during creation

Patrick Plitzner

01:25 PM EDIT Revision 9a212770 (taxeditor): ref #6774 Rename export handler

Patrick Plitzner

01:25 PM EDIT Revision ddc509bc (taxeditor): ref #6774 Add owl export to feature tree editor context menu

Patrick Plitzner

01:25 PM EDIT Revision 83fc192e (taxeditor): ref #7589 Only add characters as matrix columns

Patrick Plitzner

01:25 PM EDIT Revision c2849ea1 (taxeditor): Fix potential NPE

Patrick Plitzner

01:25 PM EDIT Revision a4063890 (taxeditor): ref #7923 Use character transfer instead of LocalSelectionTransfer

Patrick Plitzner

01:25 PM EDIT Revision fd79a16f (taxeditor): Clear candidates and target when saving + minor refactoring

Patrick Plitzner

01:03 PM EDIT task #7918 (Feedback): Revision of reference type specific properties

this should be complete now except of the fact that ISection inherits datePublished from IWithAuthorAndDate, which ma... Andreas Kohlbecker

01:01 PM EDIT Revision b62ebf52 (taxeditor): ref #7939: adapt TaxonNavigator to moved comparator

Katja Luther

01:01 PM EDIT Revision cfb05c06 (cdmlib): ref #7918 harmonizing ReferencePropertyDefinitions with latest changes in reference interface hierarchy

Andreas Kohlbecker

12:08 PM EDIT Revision 45cac117 (cdmlib): ref #7939: add oderInderComnparator and use it in taxonnodeDtoRankAndNameComparator

Katja Luther

12:04 PM EDIT feature request #7942 (In Progress): SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

Andreas Kohlbecker

12:03 PM EDIT feature request #7942: SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

We agreed on using the required flag of the "Type status", "Kind of unit" field ("Collection", "Accession number" mus... Andreas Kohlbecker

11:34 AM EDIT feature request #7942: SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

Den zweiten Text verstehe ich sprachlich nicht.
proposed wording: "Typedesignation editor can not be saved without... Wolf-Henning Kusber

11:26 AM EDIT feature request #7942 (Feedback): SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

We have two options:
1. Show a message in the footer of the editor as long as the save button is blocked: "Editor ... Andreas Kohlbecker

11:20 AM EDIT feature request #7942 (Closed): SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

Das Speichern eines TypedesignationWorkingsets geht erst wenn mind. ein Type angelegt ist.
Andernfalls würde die Sp... Andreas Kohlbecker

12:03 PM EDIT Revision 1312cd94 (cdmlib): Dto classes for distribution editor

Katja Luther

11:26 AM EDIT feature request #7937 (Closed): TaxoNamePopupEditor: Exclude current name from name relationship comboboxes

Wolf-Henning Kusber

11:22 AM EDIT feature request #7937: TaxoNamePopupEditor: Exclude current name from name relationship comboboxes

tested for validation: ok
tested for replaced synonym: ok
tested for basionym: ok Wolf-Henning Kusber

11:17 AM EDIT feature request #6869 (Closed): Reference editor: Advanced mode only available for curators

Test: reference in preparation can be changed by the submitter and curator
Reference by admin or curator can be chan... Wolf-Henning Kusber

09:24 AM EDIT Revision 0c523381 (taxeditor): continuing work on NAT tables for distribution editor

Katja Luther

12/06/2018

08:33 PM EDIT feature request #6869: Reference editor: Advanced mode only available for curators

please review once test-server is updated Andreas Kohlbecker

08:32 PM EDIT feature request #6869 (Resolved): Reference editor: Advanced mode only available for curators

Applied in changeset commit:cdm-vaadin|2ef98d3ee5667951a9c7402fa6b963e949125d9d. Andreas Kohlbecker

08:32 PM EDIT Revision 2ef98d3e (cdm-vaadin): fix #6869 ReferencePopupEditor: only admins and curation are allowed to edit advances fields, except for author team caches

Andreas Kohlbecker

04:58 PM EDIT feature request #7937: TaxoNamePopupEditor: Exclude current name from name relationship comboboxes

please review once test-server is updated Andreas Kohlbecker

04:58 PM EDIT feature request #7937 (Resolved): TaxoNamePopupEditor: Exclude current name from name relationship comboboxes

Applied in changeset commit:cdm-vaadin|1f016f085dbd0429382f8fb393ac53c81ed4a04b. Andreas Kohlbecker

04:58 PM EDIT Revision 1f016f08 (cdm-vaadin): fix #7937 excluding current name from name relation selects

Andreas Kohlbecker

04:39 PM EDIT bug #7245: validation of ToOneRelatedEntityCombobox not working

Please review once the test-server is updated Andreas Kohlbecker

04:37 PM EDIT bug #7245 (Resolved): validation of ToOneRelatedEntityCombobox not working

Applied in changeset commit:cdm-vaadin|98a2455f3da2841496b415bc1f402515a6e0b034. Andreas Kohlbecker

04:37 PM EDIT Revision 98a2455f (cdm-vaadin): fix #7245 fixing validation of ToOneRelatedEntityCombobox and re-enabling TaxonNamePopupEditorMode.REQUIRE_NOMENCLATURALREFERENCE

Andreas Kohlbecker

11:10 AM EDIT bug #7941 (Closed): Deduplication does not work in new taxon dialog

When creating a new taxon including nomenclatural reference via new taxon dialog the data is saved but it seems not t... Andreas Müller

10:59 AM EDIT bug #7940 (Feedback): "New" menu in navigator not available for certain users

g.fassou in caryo_spp had often (always ?) the problem that "new" did not show up. The taxon node she was working wit... Andreas Müller

10:53 AM EDIT bug #7939 (Closed): TaxonNodeDTO need sortIndex of Rank

To avoid a DB call for comparing the ranks of two TaxonNodeDTOs the sortIndex of the rank needs to be part of the DTO... Katja Luther

10:15 AM EDIT Revision e4ce2709 (taxeditor): ref #7923 Show character combination during drag&drop

Patrick Plitzner

10:05 AM EDIT Revision c872869c (taxeditor): ref #7923 Set character representation during creation

Patrick Plitzner

08:55 AM EDIT bug #7938: cdmserver sub-processes (threads) with constant high cpu

[Comment on bug report]:
Hi Andreas Kohlbecker,
Thanks for reporting this incident to Oracle.
This is with r... Andreas Kohlbecker

08:53 AM EDIT bug #7938: cdmserver sub-processes (threads) with constant high cpu

[Answer vom Oracle:]
Dear Java Developer,
We have finished evaluating your report and have assigned it a Bug ID... Andreas Kohlbecker

12/05/2018

05:06 PM EDIT bug #7938: cdmserver sub-processes (threads) with constant high cpu

I filed a bug report to oracle:
"We will review your report and have assigned it an internal review ID : 9058426. ... Andreas Kohlbecker

01:41 PM EDIT bug #7938: cdmserver sub-processes (threads) with constant high cpu

The cdm-server is running as subprocess of `jsvc` can this be a reason for the observed problem? Andreas Kohlbecker

11:58 AM EDIT bug #7938 (New): cdmserver sub-processes (threads) with constant high cpu

This performance problem was observed at the edit production server but might also affect other installations.
Use... Andreas Kohlbecker

02:02 PM EDIT Revision d1dd048b (taxeditor): ref #6774 Rename export handler

Patrick Plitzner

01:29 PM EDIT task #7921 (Closed): Create database for Caucasus distribution editing

Andreas Müller

01:29 PM EDIT task #7921: Create database for Caucasus distribution editing

Logfile:
~~~
14:08:44,013 INFO ResultSetPartitioner:153 - Saved 85 Authors
14:10:03,343 WARN BerlinModelAuthor... Andreas Müller

01:20 PM EDIT Revision 8e4eddeb (taxeditor): build layers for distribution editor

Katja Luther

11:26 AM EDIT feature request #6774 (In Progress): Implement OWL export

Patrick Plitzner

11:26 AM EDIT Revision 8315bf09 (taxeditor): ref #6774 Add owl export to feature tree editor context menu

Patrick Plitzner

11:13 AM EDIT Revision 6846dba7 (cdmlib): ref #6774 Fix owl export file generation

Patrick Plitzner

12/04/2018

03:38 PM EDIT Revision 353bb041 (taxeditor): ref #7589 Only add characters as matrix columns

Patrick Plitzner

03:23 PM EDIT Revision ecf88434 (taxeditor): Fix potential NPE

Patrick Plitzner

01:21 PM EDIT feature request #7937 (Closed): TaxoNamePopupEditor: Exclude current name from name relationship comboboxes

Andreas Kohlbecker

12:14 PM EDIT task #7935: Discuss new solution to establish the communication between submitter and curator

curation@phycobank.org wäre noch besser Andreas Kohlbecker

12:13 PM EDIT task #7935: Discuss new solution to establish the communication between submitter and curator

[Henning]
Normaler Weise würde man auf normalen E-Mail-Kontakt ausweichen und eine Funktions-Email einrichten, z.B... Andreas Kohlbecker

12:02 PM EDIT task #7935 (Closed): Discuss new solution to establish the communication between submitter and curator

As stated in #7785 the checking for messaged in the Redmine instance serving as communication hub slows down the disp... Andreas Kohlbecker

12:12 PM EDIT bug #7908 (Closed): Redmine communication hub slows down RegistrationWorkingSets

all open issues and tasks copied to other tickets. Andreas Kohlbecker

12:11 PM EDIT bug #7936 (Closed): Consider complete removal of redmine communication hub code

As stated in #7785 the checking for messaged in the Redmine instance serving as communication hub slows down the disp... Andreas Kohlbecker

10:17 AM EDIT Revision 53b63498 (taxeditor): ref #7923 Use character transfer instead of LocalSelectionTransfer

Patrick Plitzner

10:11 AM EDIT Revision 5b204e01 (taxeditor): Merge branch 'develop' into characterTransfer

Patrick Plitzner

10:08 AM EDIT Revision 51771c44 (taxeditor): ref #7923 Use character transfer instead of LocalSelectionTransfer

Patrick Plitzner

09:23 AM EDIT Revision 952ef0ec (taxeditor): first steps for using nat tables for distribution editor

Katja Luther

12/03/2018

05:15 PM EDIT bug #7245: validation of ToOneRelatedEntityCombobox not working

This issue becomes more important now that blocking registrations are created. Names with missing nom. references cau... Andreas Kohlbecker

04:07 PM EDIT Revision 307279d3 (taxeditor): Clear candidates and target when saving + minor refactoring

Patrick Plitzner

03:38 PM EDIT Revision 8842e357 (taxeditor): Merge branch 'develop' into characterTransfer

Patrick Plitzner

03:34 PM EDIT bug #7934 (Resolved): sometimes the signs for deduplication are not shown

Fixed by commit:taxeditor|8f7409d9e3e9cb3550f65e194a634543fc6aa94d Patrick Plitzner

02:42 PM EDIT bug #7934 (Closed): sometimes the signs for deduplication are not shown

in some cases the signs for deduplication are not shown, but the context menu is adapted, for example it shows only r... Katja Luther

03:33 PM EDIT Revision 8f7409d9 (taxeditor): Revert "ref #7847 Fixate deduplication icon to first column"

This reverts commit 6fde7721bdb9cca2640864544d9606f90c5064b0. Patrick Plitzner

02:33 PM EDIT Revision c8fc9715 (taxeditor): minor

Katja Luther

02:29 PM EDIT bug #7913: Remove authorship from IJournal and IPrintSeries

this is also implemented in taxeditor. Please review. Katja Luther

02:29 PM EDIT bug #7915: Remove date published from journals and print series

this is also implemented in taxeditor. please review. Katja Luther

02:28 PM EDIT Revision 87f7c0f5 (taxeditor): ref #7915: remove date published for journal, print series in taxeditor

Katja Luther

02:26 PM EDIT Revision cfbcbdcb (taxeditor): ref #7913: remove author for journal, print series in taxeditor

Katja Luther

02:22 PM EDIT bug #7737 (Resolved): Reference Details view does NOT give a multiple usage warning

this should be fixed. Please review Katja Luther

02:16 PM EDIT bug #7930: Remove DOI from journals, print series and person communications

for these three reference types the doi is removed. please review. Katja Luther

02:14 PM EDIT Revision b3f2ffb6 (taxeditor): ref #7930: remove doi for journal, print series and personal communications in taxeditor

Katja Luther

12:00 PM EDIT Revision e2d46f06 (cdmlib): remove predicates moved to TaxonEditorPredicates

Katja Luther

11:59 AM EDIT bug #5926: Update labels in TermEditor for Vocabularies

Andreas Müller wrote:
> give back to me for review. Has this been fixed with DTO version of term editor or before?
... Patrick Plitzner

11:59 AM EDIT Revision fe474060 (cdmlib): smaller changes in abcd import

Katja Luther

11:46 AM EDIT bug #7690 (In Progress): Adapt available typedesignation editors to name rank

Andreas Kohlbecker

11:28 AM EDIT feature request #7928: Name type should not be identical to typified name

Another option to avoid this is filtering the available taxon name in the combobox to exclude the typified name.
S... Andreas Kohlbecker

11:23 AM EDIT bug #7924 (Closed): LazyInitializationException (LIE) in taxon/{uuid}/synonymy.json when used with subtree filter

the bugfix works as expected Andreas Kohlbecker

10:26 AM EDIT Revision cb9801c1 (cdmlib): ref #7755: provide all data for specimen pages

Katja Luther

10:20 AM EDIT Revision a2acff0a (cdm-dataportal): ref #7755: implement detail pages for occurrences, add links to originals and derivates

Katja Luther

12/02/2018

10:56 PM EDIT bug #5926 (Resolved): Update labels in TermEditor for Vocabularies

give back to me for review. Has this been fixed with DTO version of term editor or before? Andreas Müller

10:54 PM EDIT bug #6231: Correctly handle failed term deletions in the editor

Shouldn't we always give tickets from other back for review or at least ask if they want to do review, before they ar... Andreas Müller

11/30/2018

05:02 PM EDIT bug #7933 (Closed): Adding a new Term to the "Country" vocabulary leads to corrupt data

After adding a new term to the "Country" vocabulary the cdm server throws an exception during startup Patrick Plitzner

05:01 PM EDIT Revision 8652abf4 (taxeditor): Experimental characterTransfer

Patrick Plitzner

05:00 PM EDIT Revision cbbdffcb (cdmlib): Generate character label in constructor

Patrick Plitzner

04:14 PM EDIT feature request #7847 (Closed): Use separate column for row state instead of symbol in titleCache column

Andreas Müller

02:34 PM EDIT feature request #7847: Use separate column for row state instead of symbol in titleCache column

If it is not possible to put the symbol beside the text we should better leave it where it is. Andreas Müller

01:46 PM EDIT feature request #7847: Use separate column for row state instead of symbol in titleCache column

The icon can be put in any corner or even centered. But, at least for now I haven't found an easy solution, if we put... Patrick Plitzner

01:19 PM EDIT feature request #7847: Use separate column for row state instead of symbol in titleCache column

I think we can will with this implementation though I still think that a separate column would be even better.
Is... Andreas Müller

03:36 PM EDIT Revision 794f1010 (taxeditor): Fix possible NPE

Patrick Plitzner

03:13 PM EDIT bug #4821: Changing order of terms not possible

review ping Patrick Plitzner

03:12 PM EDIT feature request #5474 (Resolved): TermEditor menu should be more structured

@Andreas: Can you please check if this is still open? For example, "Others" is now translated when language is switched. Patrick Plitzner

02:55 PM EDIT bug #5926 (Worksforme): Update labels in TermEditor for Vocabularies

This has been fixed in the meantime. Patrick Plitzner

02:52 PM EDIT bug #6231 (Worksforme): Correctly handle failed term deletions in the editor

This has been fixed in the meantime. A popup will show what entities are still references when deletion is impossible... Patrick Plitzner

02:48 PM EDIT bug #6765 (Worksforme): NonUnique exception when dragging and dropping a lot of terms in the term editor

This seems to be fixed by implementing DTOs in term editor #7887 Patrick Plitzner

02:31 PM EDIT Revision 6b834909 (cdmlib): fix #7367 Fix handling of referenced element in isDeletable() method

Patrick Plitzner

01:23 PM EDIT bug #6951 (Resolved): Drag and drop does not update term hierarchy in the UI

This issue is fixed with the implementation of DTOs in the term editor #7887 Patrick Plitzner

01:20 PM EDIT bug #6952 (Resolved): Deleting terms does not get reflected in the UI and in the DB

This issue is fixed with the implementation of DTOs in the term editor #7887 Patrick Plitzner

01:17 PM EDIT bug #7649: Term editor loads/saves extremely slow

true, I was just cleaning up tickets and there was actually no work done on this. But it makes sense to regard it as ... Patrick Plitzner

01:13 PM EDIT bug #7649: Term editor loads/saves extremely slow

why did you remove target version. It is a bug fix and needs to be reported for 5.5 I think. Andreas Müller

11:15 AM EDIT bug #7649 (Feedback): Term editor loads/saves extremely slow

This should be fixed with the implementation of using DTOs in #7887
@Katja: Can you close this once #7887 is revie... Patrick Plitzner

12:06 PM EDIT bug #7367 (Resolved): Deleting a term in the term editor does not update the UI

Applied in changeset commit:cdmlib|4f93bc356e3a3ebd6f427310a451ab30ea89cc62. Patrick Plitzner

11:59 AM EDIT bug #7367 (In Progress): Deleting a term in the term editor does not update the UI

Patrick Plitzner

12:06 PM EDIT Revision 4f93bc35 (cdmlib): fix #7367 Evaluate configurator in isDeletable()

Patrick Plitzner

12:05 PM EDIT Revision e00917d5 (taxeditor): ref #7367 Use TermDeletionConfigurator in term editor

Patrick Plitzner

11:19 AM EDIT bug #7634: Timeout/Performance problems in Taxeditor

The context menu performance should have improved with fixing #7792 Patrick Plitzner

11:15 AM EDIT feature request #7887: Use DTOs in term editor

@Katja: Please also check and close #7649 when this is reviewed. Patrick Plitzner

11:11 AM EDIT bug #7850: Further problems with term editor

@Andreas M.: Can you please check if this is still an issue? Patrick Plitzner

11:08 AM EDIT Revision ab71093a (taxeditor): ref #7887 Fix possible NPE when dropping on same term

Patrick Plitzner

08:55 AM EDIT feature request #6805 (Resolved): Implement drag and drop from Term Editor (Feature) to FeatureTreeEditor

Patrick Plitzner

08:54 AM EDIT Revision 4914816d (cdmlib): ref #6805 code cleanup

Patrick Plitzner

08:53 AM EDIT Revision 9092e20b (taxeditor): ref #6805 Fix term dragging into feature tree editor

Patrick Plitzner

11/29/2018

01:40 PM EDIT Revision aaeb1aaa (cdmlib-apps): Adapt palm import to new match strategy handling

Andreas Müller

01:39 PM EDIT Revision 32ec6ef6 (cdmlib): minor (reduce log level for inrefs not being books)

Andreas Müller

01:38 PM EDIT Revision a732ba17 (cdmlib): Add validation for journals with authors

Andreas Müller

01:37 PM EDIT Revision a44c8394 (cdmlib): ref #7699 Allow 3 representations for CdmImportBase.getImageMedia

Andreas Müller

01:35 PM EDIT Revision 7eba7072 (cdmlib-apps): minor chanes to PhycobankHigherClassificationActivator

Andreas Müller

01:34 PM EDIT Revision b718e9c2 (cdmlib-apps): minor changes to Greece image import Activator

Andreas Müller

01:33 PM EDIT Revision 106c8a4d (cdmlib-apps): ref #7669 improve Willing import

Andreas Müller

01:30 PM EDIT Revision afdbbd6e (cdmlib-apps): ref #3979 implement CdmPreferences for E+M Activator and some other changes for Activator

Andreas Müller

01:25 PM EDIT Revision a26a9112 (cdmlib-apps): ref #7921 Caucasus area import for E+M

Andreas Müller

01:20 PM EDIT Revision d7949dc1 (cdmlib): ref #7921 add Caucasus area voc uuids

Andreas Müller

01:18 PM EDIT Revision b45c1f2d (cdmlib): ref #7932 first implementation of PreferenceResolver and some adaption to PreferenceService API.

* Correct handling of subtree subjects still open.
* Also creation of user defined subjects still open. Andreas Müller

01:18 PM EDIT Revision 3986faa0 (cdmlib): cleanup

Andreas Müller

01:08 PM EDIT feature request #7932: Implement subject resolver for CdmPreferences

For now we implement solution 2. Andreas Müller

01:07 PM EDIT feature request #7932 (Resolved): Implement subject resolver for CdmPreferences

Finding the best matching preference for preferences with same predicates but differing subjects is currently not yet... Andreas Müller

12:54 PM EDIT Revision 4fa20463 (taxeditor): small layout changes

Patrick Plitzner

11:50 AM EDIT feature request #7847: Use separate column for row state instead of symbol in titleCache column

Patrick Plitzner wrote:
> It would also be possible to show the icon in the first column no matter what property is ... Patrick Plitzner

11:10 AM EDIT feature request #7847 (Feedback): Use separate column for row state instead of symbol in titleCache column

It would also be possible to show the icon in the first column no matter what property is shown in the first column. ... Patrick Plitzner

11:46 AM EDIT Revision 6fde7721 (taxeditor): ref #7847 Fixate deduplication icon to first column

Patrick Plitzner

09:03 AM EDIT Revision 3a082bf5 (taxeditor): ref #7887 Enable supplemental data view for term DTOs

Patrick Plitzner

08:53 AM EDIT Revision 16a5a5e5 (taxeditor): ref #7837 Update docx4j version

Patrick Plitzner

08:53 AM EDIT Revision b7c2be3a (cdmlib): ref #7837 Update docx4j version

Patrick Plitzner

11/28/2018

02:06 PM EDIT bug #7223: ReferenceEditor: disable fields depending on the Reference type

After discussion with Henning DOI should not be available for journals and print series.
And I guess also for pers... Andreas Müller

01:39 PM EDIT Revision 89ea7aed (cdmlib): ref #7930 remove IWithDoi from IAuthoredPublicationBase

Andreas Müller

01:38 PM EDIT Revision 1ef801b6 (cdmlib): revert unwanted last commit

Andreas Müller

01:37 PM EDIT Revision 2441a5df (cdmlib): ref #7930 remove IWithDoi from IAuthoredPublicationBase

Andreas Müller

01:32 PM EDIT bug #7930: Remove DOI from journals, print series and person communications

Please review and implement accordingly in TaxEditor (remove DOI from these 3 reference types if not yet done). Andreas Müller

01:30 PM EDIT bug #7930 (Resolved): Remove DOI from journals, print series and person communications

Applied in changeset commit:cdmlib|8bda418b4eea02e8a41111630a811719ab4ecc2f. Andreas Müller

01:02 PM EDIT bug #7930 (Closed): Remove DOI from journals, print series and person communications

Talking with WHK about DOIs we decided that journals and print series do not have DOIs. Therefore these should be rem... Andreas Müller

01:29 PM EDIT Revision 8bda418b (cdmlib): fix #7930 removed getDoi from IPublicationBase and IArticle and use IWithDoi instead (but not for journals, print series and personel communications)

Andreas Müller

01:25 PM EDIT Revision f81ce9c8 (cdmlib): add Identifier to CdmPermissionClass

Andreas Müller

01:03 PM EDIT feature request #7931 (Resolved): add symbol2 to term detailsview

Katja Luther

01:02 PM EDIT feature request #7931 (Closed): add symbol2 to term detailsview

Katja Luther

12:36 PM EDIT Revision f0fed63a (taxeditor): add symbol2 to term details view

Katja Luther

11/27/2018

03:42 PM EDIT task #7921 (Resolved): Create database for Caucasus distribution editing

Andreas Müller

03:28 PM EDIT bug #7924: LazyInitializationException (LIE) in taxon/{uuid}/synonymy.json when used with subtree filter

seems to be fixed correctly. I tested on test.E+M with http://test.e-taxonomy.eu/dataportal/preview/euromed/cdm_datap... Andreas Müller

02:35 PM EDIT bug #7924 (Resolved): LazyInitializationException (LIE) in taxon/{uuid}/synonymy.json when used with subtree filter

Applied in changeset commit:cdmlib|387f1cf1049dcda4829cbc80f230ba35de8eaceb. Andreas Müller

02:35 PM EDIT Revision 387f1cf1 (cdmlib): fix #7924 fix LIE in TaxonPortalController getSynonymy with subtree filter

Andreas Müller

02:35 PM EDIT Revision 763eed56 (cdmlib): some renamings and javadoc

Andreas Müller

02:11 PM EDIT Revision 78e3bcbc (cdmlib): ref #7929: clear the member list in group when deleting the group

Katja Luther

02:09 PM EDIT bug #7929 (Closed): after delete of not persisted object in bulkeditor the object is still in bulkeditor list

when deleting a not persisted objekt in bulk editor it is not removed from the list, this is because of the setting o... Katja Luther

01:41 PM EDIT Revision c11a2278 (taxeditor): fix delete of not persisted data in bulk editor

Katja Luther

12:05 PM EDIT feature request #7928 (New): Name type should not be identical to typified name

It is possible to typify a for example a genus name with itself.
There might be a warning, if typified and typifyin... Wolf-Henning Kusber

09:58 AM EDIT Revision 4736d50c (taxeditor): ref #3767: add DOI to reference detail element

Katja Luther

11/26/2018

07:57 PM EDIT feature request #7927 (Closed): Registration not found, Portal handling registrations in preparation

Problem: When http-Identifier are inserted in a manuscript, authors or editors or copy editors are checking the link.... Wolf-Henning Kusber

03:10 PM EDIT Revision 12d75812 (taxeditor): ref #7849: remove OVERRIDE constants from IPreferenceKeys and handle it by method

Katja Luther

01:22 PM EDIT Revision 9181d281 (taxeditor): ref #7849: continue adapt db and local preference pages

Katja Luther