From d3d01e43f8e77027e4660b9770a1c6f1ce1d8304 Mon Sep 17 00:00:00 2001 From: Katja Luther Date: Fri, 1 Apr 2016 11:28:43 +0200 Subject: [PATCH] minor changes for #4657 --- .../ApplicationWorkbenchAdvisor.java | 2 +- .../preference/DebugPreferences.java | 44 +++++++++++++++++++ .../taxeditor/preference/IPreferenceKeys.java | 2 +- .../taxeditor/preference/PreferencesUtil.java | 8 ++-- 4 files changed, 50 insertions(+), 6 deletions(-) create mode 100644 eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/DebugPreferences.java diff --git a/eu.etaxonomy.taxeditor.application/src/main/java/eu/etaxonomy/taxeditor/ApplicationWorkbenchAdvisor.java b/eu.etaxonomy.taxeditor.application/src/main/java/eu/etaxonomy/taxeditor/ApplicationWorkbenchAdvisor.java index 420eaf0b1..02d13bd9f 100644 --- a/eu.etaxonomy.taxeditor.application/src/main/java/eu/etaxonomy/taxeditor/ApplicationWorkbenchAdvisor.java +++ b/eu.etaxonomy.taxeditor.application/src/main/java/eu/etaxonomy/taxeditor/ApplicationWorkbenchAdvisor.java @@ -136,7 +136,7 @@ public class ApplicationWorkbenchAdvisor extends WorkbenchAdvisor { } else if (t != null && ("Widget is disposed".equals(t.getMessage()))){ MessagingUtils.warn(this.getClass(), t); - if (PreferencesUtil.isDebugMode()){ + if (PreferencesUtil.isShowUpWidgetIsDisposedMessages()){ MessagingUtils.errorDialog("Widget is disposed", null, MessagingUtils.WIDGET_IS_DISPOSED_MESSAGE, diff --git a/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/DebugPreferences.java b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/DebugPreferences.java new file mode 100644 index 000000000..328f8612e --- /dev/null +++ b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/DebugPreferences.java @@ -0,0 +1,44 @@ +// $Id$ +/** +* Copyright (C) 2016 EDIT +* European Distributed Institute of Taxonomy +* http://www.e-taxonomy.eu +* +* The contents of this file are subject to the Mozilla Public License Version 1.1 +* See LICENSE.TXT at the top of this package for the full license terms. +*/ +package eu.etaxonomy.taxeditor.preference; + +import org.eclipse.jface.preference.BooleanFieldEditor; +import org.eclipse.jface.preference.FieldEditorPreferencePage; +import org.eclipse.ui.IWorkbench; +import org.eclipse.ui.IWorkbenchPreferencePage; + +/** + * @author k.luther + * @date 01.04.2016 + * + */ +public class DebugPreferences extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { + + /* (non-Javadoc) + * @see org.eclipse.ui.IWorkbenchPreferencePage#init(org.eclipse.ui.IWorkbench) + */ + @Override + public void init(IWorkbench workbench) { + setPreferenceStore(PreferencesUtil.getPreferenceStore()); + + } + + /* (non-Javadoc) + * @see org.eclipse.jface.preference.FieldEditorPreferencePage#createFieldEditors() + */ + @Override + protected void createFieldEditors() { + addField(new BooleanFieldEditor(IPreferenceKeys.IS_SHOW_UP_WIDGET_IS_DISPOSED, + "Show up widget is disposed error messages.", + getFieldEditorParent())); + + } + +} diff --git a/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/IPreferenceKeys.java b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/IPreferenceKeys.java index d5f75d807..884cb678f 100644 --- a/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/IPreferenceKeys.java +++ b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/IPreferenceKeys.java @@ -155,7 +155,7 @@ public interface IPreferenceKeys { public static final String DEFAULT_LANGUAGE_EDITOR = "eu.etaxonomy.taxeditor.default.language"; - public static final String IS_DEBUG_MODE = "eu.etaxonomy.taxeditor.idDebugMode"; + public static final String IS_SHOW_UP_WIDGET_IS_DISPOSED = "eu.etaxonomy.taxeditor.isShowUpWidgetIsDisposed"; /** * Key for the saved P2 repositories diff --git a/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/PreferencesUtil.java b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/PreferencesUtil.java index 54a90627b..6e8733952 100644 --- a/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/PreferencesUtil.java +++ b/eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/PreferencesUtil.java @@ -828,10 +828,10 @@ public class PreferencesUtil implements IPreferenceKeys { /** * @return */ - public static boolean isDebugMode() { - return getPreferenceStore().getBoolean(IS_DEBUG_MODE); + public static boolean isShowUpWidgetIsDisposedMessages() { + return getPreferenceStore().getBoolean(IS_SHOW_UP_WIDGET_IS_DISPOSED); } - public static void setDebugMode(boolean selection) { - getPreferenceStore().setValue(IS_DEBUG_MODE, selection); + public static void setShowUpWidgetIsDisposedMessages(boolean selection) { + getPreferenceStore().setValue(IS_SHOW_UP_WIDGET_IS_DISPOSED, selection); } } -- 2.34.1