cleanup
authorAndreas Müller <a.mueller@bgbm.org>
Fri, 29 Jul 2022 13:18:32 +0000 (15:18 +0200)
committerAndreas Müller <a.mueller@bgbm.org>
Fri, 29 Jul 2022 13:18:32 +0000 (15:18 +0200)
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/key/polytomous/e4/handler/EditPolytomousKeyNodesHandlerE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/TaxonNodeNavigatorComparator.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/TaxonNavigatorE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/TaxonNavigatorLabelProviderE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/AbstractEntityCollectionElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/description/DescriptionSourceElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/util/TaxonTreeNodeContentProvider.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/util/TaxonTreeNodeLabelProvider.java
eu.etaxonomy.taxeditor.test/src/test/java/eu/etaxonomy/taxeditor/operation/BaseOperationTest.java
eu.etaxonomy.taxeditor.test/src/test/java/eu/etaxonomy/taxeditor/operation/TaxonNameEditorTest.java

index 2943a3921e45c6c57ba02521d19e99d1611efba3..9a37542f85a2c86666bc519ce2e5d5dbea4c9c50 100644 (file)
@@ -10,15 +10,12 @@ import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
 
 public class TaxonNodeNavigatorComparator extends ViewerComparator{
 
-       Comparator<TaxonNodeDto> comparator;
+       private Comparator<TaxonNodeDto> comparator;
 
        public TaxonNodeNavigatorComparator(Comparator<TaxonNodeDto> comparator){
-               super();
                this.comparator = comparator;
        }
 
-
-
        @Override
        public int compare(Viewer viewer, Object e1, Object e2){
                if ((e1 instanceof Classification && e2 instanceof Classification) ){
@@ -31,7 +28,6 @@ public class TaxonNodeNavigatorComparator extends ViewerComparator{
                        }else{
                                return comparator.compare((TaxonNodeDto)e1, (TaxonNodeDto)e2);
                        }
-
                }
        }
-}
+}
\ No newline at end of file
index a0f8e6d7a684f36d58426e19bd960a657fe40f2d..6b36ee4147d7bb866a7606a4d9c95aee1b28651c 100644 (file)
@@ -39,9 +39,7 @@ import org.eclipse.e4.ui.services.EMenuService;
 import org.eclipse.e4.ui.workbench.modeling.EModelService;
 import org.eclipse.e4.ui.workbench.modeling.EPartService;
 import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
-import org.eclipse.jface.util.IPropertyChangeListener;
 import org.eclipse.jface.util.LocalSelectionTransfer;
-import org.eclipse.jface.util.PropertyChangeEvent;
 import org.eclipse.jface.viewers.IElementComparer;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.ISelectionChangedListener;
@@ -70,9 +68,6 @@ import eu.etaxonomy.cdm.model.common.ICdmBase;
 import eu.etaxonomy.cdm.model.taxon.Classification;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
 import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
-import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDtoByNameComparator;
-import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDtoByRankAndNameComparator;
-import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDtoNaturalComparator;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.ITaxonEditor;
 import eu.etaxonomy.taxeditor.editor.name.e4.TaxonNameEditorE4;
@@ -89,7 +84,6 @@ import eu.etaxonomy.taxeditor.navigation.navigator.EmptyRoot;
 import eu.etaxonomy.taxeditor.navigation.navigator.Root;
 import eu.etaxonomy.taxeditor.navigation.navigator.TaxonNodeNavigatorComparator;
 import eu.etaxonomy.taxeditor.operation.IPostOperationEnabled;
-import eu.etaxonomy.taxeditor.preference.NavigatorOrderEnum;
 import eu.etaxonomy.taxeditor.preference.PreferencesUtil;
 import eu.etaxonomy.taxeditor.store.CdmStore;
 import eu.etaxonomy.taxeditor.store.LoginManager;
@@ -209,37 +203,37 @@ public class TaxonNavigatorE4 implements
 
        protected IAdaptable getInitialInput() {
                Comparator<TaxonNodeDto> comparator = PreferencesUtil.getNodeComparator();
-               
+
                TaxonNodeNavigatorComparator viewerComparator = new TaxonNodeNavigatorComparator(comparator);
                viewer.setComparator(viewerComparator);
                viewer.setComparer(new IElementComparer() {
 
-               @Override
-            public int hashCode(Object element) {
-                   if (element instanceof TaxonNodeDto){
-                   TaxonNodeDto nodeDto = (TaxonNodeDto)element;
-
-                   String s = nodeDto.getUuid().toString();
-                   if (s != null) {
-                       return s.hashCode();
+               @Override
+                public int hashCode(Object element) {
+                   if (element instanceof TaxonNodeDto){
+                           TaxonNodeDto nodeDto = (TaxonNodeDto)element;
+
+                           String s = nodeDto.getUuid().toString();
+                           if (s != null) {
+                               return s.hashCode();
+                           }
+                           return element.hashCode();
+                   }else{
+                       return element.toString().hashCode();
                    }
-                   return element.hashCode();
-                   }else{
-                       return element.toString().hashCode();
-                   }
-               }
-
-            @Override
-            public boolean equals(Object element1, Object element2) {
-                if (element1 instanceof TaxonNodeDto && element2 instanceof TaxonNodeDto){
-                    TaxonNodeDto node1 = (TaxonNodeDto)element1;
-                    TaxonNodeDto node2 = (TaxonNodeDto)element2;
-                    return (node1.getUuid().equals(node2.getUuid()));
-                }else {
-                    return element1.equals(element2);
+               }
+
+                @Override
+                public boolean equals(Object element1, Object element2) {
+                    if (element1 instanceof TaxonNodeDto && element2 instanceof TaxonNodeDto){
+                        TaxonNodeDto node1 = (TaxonNodeDto)element1;
+                        TaxonNodeDto node2 = (TaxonNodeDto)element2;
+                        return (node1.getUuid().equals(node2.getUuid()));
+                    }else {
+                        return element1.equals(element2);
+                    }
                 }
-            }
-               }
+               }
                );
 
                if (CdmStore.isActive()) {
@@ -595,6 +589,4 @@ public class TaxonNavigatorE4 implements
             viewer.setExpandedElements(expandedElements);
         }
     }
-
-       
 }
\ No newline at end of file
index dbb1ba20f8bce0476a849b13044a851dd3d221b0..f035a3000c1a73d6e64301220606edfbc37b93dc 100644 (file)
@@ -1,4 +1,3 @@
-// $Id$
 /**
  * Copyright (C) 2017 EDIT
  * European Distributed Institute of Taxonomy
@@ -25,34 +24,26 @@ import eu.etaxonomy.taxeditor.util.TaxonTreeNodeLabelProvider;
 /**
  * @author pplitzner
  * @date 05.09.2017
- *
  */
-public class TaxonNavigatorLabelProviderE4 extends TaxonTreeNodeLabelProvider
-implements IDescriptionProvider {
+public class TaxonNavigatorLabelProviderE4
+        extends TaxonTreeNodeLabelProvider
+        implements IDescriptionProvider {
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getText(Object element) {
-
             return super.getText(element);
     }
+
 //    @Override
 //    public Font getFont(Object element) {
-//
 //        return new Font(null, "Arial Unicode MS", 10, SWT.NORMAL);
-//
 //    }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getDescription(Object anElement) {
         //classification
         if (anElement instanceof Classification) {
-            return "Taxonomic Tree: " +  ((Classification) anElement).getTitleCache(); //$NON-NLS-1$
+            return "Classification: " +  ((Classification) anElement).getTitleCache(); //$NON-NLS-1$
         }
         //FIXME E4 show synonym in navigator?
         //synonym
@@ -69,9 +60,6 @@ implements IDescriptionProvider {
         return null;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public StyledString getStyledText(Object element) {
         return super.getStyledText(element);
@@ -95,6 +83,4 @@ implements IDescriptionProvider {
         }
         return notGrantedStyler;
     }
-
-
-}
+}
\ No newline at end of file
index 7044b08db673fc3eada00ef359ee82f9a038aa94..6dcee17c97fa8f65ff79c200dd79c16ed99c39da 100644 (file)
@@ -57,13 +57,12 @@ public abstract class AbstractEntityCollectionElement<ENTITY>
         * Composite "around" the actual content. Is used for control action like e.g. remove button
         */
        private final Composite box;
-       
-       private boolean isEnabled;
 
-       
+       private boolean isEnabled;
 
        private Button btnRemove;
-    protected Button btnChooseEntity;
+
+       private Button btnChooseEntity;
 
        private Color backgroundColor;
 
@@ -114,7 +113,7 @@ public abstract class AbstractEntityCollectionElement<ENTITY>
                        btnRemove.setEnabled(isEnabled);
                }
 
-               
+
 
                setEntity(entity);
                createControls(this, style);
@@ -257,7 +256,7 @@ public abstract class AbstractEntityCollectionElement<ENTITY>
             warnForReferencedObjects.setVisible(isVisible);
         }
     }
-    
+
     @Override
        public void setEnabled(boolean enabled) {
                this.isEnabled = enabled;
@@ -267,7 +266,7 @@ public abstract class AbstractEntityCollectionElement<ENTITY>
                if (btnChooseEntity != null){
                        btnChooseEntity.setEnabled(enabled);
                }
-               
+
                for (ICdmFormElement element:this.getElements()){
                        if (element instanceof IEnableableFormElement){
                                ((IEnableableFormElement)element).setEnabled(enabled);
index 42dadf9f336219e345a3cbccc94e892ff4f5412a..dd6ffc3f634f879cc63fbd3f542129f87b75dbc4 100644 (file)
@@ -19,45 +19,20 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractEntityCollectionElement;
 import eu.etaxonomy.taxeditor.ui.selection.EntitySelectionElement;
 
 /**
- * <p>
- * DescriptionSourceElement class.
- * </p>
- *
  * @author n.hoffmann
  * @created Mar 18, 2010
- * @version 1.0
  */
 public class DescriptionSourceElement extends
                AbstractEntityCollectionElement<Reference> {
 
        private EntitySelectionElement<Reference> selection_descriptionSource;
 
-       /**
-        * <p>
-        * Constructor for DescriptionSourceElement.
-        * </p>
-        *
-        * @param cdmFormFactory
-        *            a {@link eu.etaxonomy.taxeditor.ui.element.CdmFormFactory}
-        *            object.
-        * @param formElement
-        *            a {@link eu.etaxonomy.taxeditor.ui.element.AbstractFormSection}
-        *            object.
-        * @param element
-        *            a {@link eu.etaxonomy.cdm.model.reference.ReferenceBase}
-        *            object.
-        * @param removeListener
-        *            a {@link org.eclipse.swt.events.SelectionListener} object.
-        * @param style
-        *            a int.
-        */
        public DescriptionSourceElement(CdmFormFactory cdmFormFactory,
                        AbstractFormSection formElement, Reference element,
                        SelectionListener removeListener, int style) {
                super(cdmFormFactory, formElement, element, removeListener, null, style);
        }
 
-       /** {@inheritDoc} */
        @Override
        public void createControls(ICdmFormElement element, int style) {
                selection_descriptionSource = formFactory
@@ -69,7 +44,6 @@ public class DescriptionSourceElement extends
                }
        }
 
-       /** {@inheritDoc} */
        @Override
        public void setEntity(Reference element) {
                this.entity = element;
@@ -78,7 +52,6 @@ public class DescriptionSourceElement extends
                }
        }
 
-       /** {@inheritDoc} */
        @Override
        public void handleEvent(Object eventSource) {
 
index b657f6800d78027998c664f8c22b55f0aecef4f9..63d855623f9ab61c2bf59021525d126744c84b6a 100644 (file)
@@ -70,8 +70,6 @@ public class TaxonTreeNodeContentProvider implements ITreeContentProvider {
         return children != null ? children : NO_CHILDREN;
     }
 
-
-
     @Override
     public Object getParent(Object element) {
         if (taxonNodeService == null){
index f39bfddeb35ab71aac33daae63841fc55fa0bcac..97495dfb03066f9432b0cb5c3a258740e929cdbb 100644 (file)
@@ -1,4 +1,3 @@
-// $Id$
 /**
  * Copyright (C) 2017 EDIT
  * European Distributed Institute of Taxonomy
@@ -32,16 +31,13 @@ import eu.etaxonomy.taxeditor.store.StoreUtil;
 /**
  * @author pplitzner
  * @date 05.09.2017
- *
  */
-public class TaxonTreeNodeLabelProvider extends ColumnLabelProvider
-implements IStyledLabelProvider {
+public class TaxonTreeNodeLabelProvider
+        extends ColumnLabelProvider
+        implements IStyledLabelProvider {
 
     protected Styler notGrantedStyler = null;
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getText(Object element) {
         //classification
@@ -88,15 +84,15 @@ implements IStyledLabelProvider {
             if (taxonNode.isDoubtful()) {
                 text +=Character.toString((char)63) + " ";
             }
+            //TODO if symbols contain non-ASCII this may create problems
+            //     if so we may use ASCII like text +=Character.toString((char)248) + " ";
+
             text += taxonNode.getTitleCache();
             return text;
         }
         return new String();
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public StyledString getStyledText(Object element) {
         //classification
@@ -127,4 +123,4 @@ implements IStyledLabelProvider {
         }
         return notGrantedStyler;
     }
-}
+}
\ No newline at end of file
index 0a0d0600f4b69948b92c24d117121077b02375e9..bfc850870a8f26c633c3889a32cfd9abc7fc5444 100644 (file)
@@ -17,8 +17,6 @@ import org.junit.Before;
 
 import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.taxeditor.httpinvoker.RemotingSessionAwareTest;
-import eu.etaxonomy.taxeditor.operation.IPostOperationEnabled;
-import eu.etaxonomy.taxeditor.operation.CdmUpdateOperation;
 import eu.etaxonomy.taxeditor.session.ICdmEntitySessionEnabled;
 import eu.etaxonomy.taxeditor.test.MockConversationEnabled;
 
@@ -34,7 +32,7 @@ public abstract class BaseOperationTest extends RemotingSessionAwareTest {
        public static final IAdaptable info = null;
        public static final IPostOperationEnabled postOperation = null;
        public static final IConversationEnabled conversationEnabled = new MockConversationEnabled();
-       public static final ICdmEntitySessionEnabled cdmEntitySessionEnabled = null;
+       public static final ICdmEntitySessionEnabled<?> cdmEntitySessionEnabled = null;
 
        protected static AbstractOperation operation;
 
index be893408afb17b956090adc952de8c3e2b5158a7..6a77b722c187e6004dc9b635276698a18199218f 100644 (file)
@@ -14,19 +14,18 @@ import java.util.List;
 import java.util.Set;
 import java.util.UUID;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.eclipse.core.commands.ExecutionException;
 import org.junit.Assert;
 import org.junit.Ignore;
 import org.junit.Test;
 import org.unitils.dbunit.annotation.DataSet;
 
-import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
 import eu.etaxonomy.cdm.model.common.Annotation;
-import eu.etaxonomy.cdm.model.common.Language;
 import eu.etaxonomy.cdm.model.description.DescriptionElementSource;
 import eu.etaxonomy.cdm.model.description.Feature;
 import eu.etaxonomy.cdm.model.description.TaxonDescription;
@@ -54,11 +53,8 @@ public class TaxonNameEditorTest extends BaseOperationTest {
     @SuppressWarnings("unused")
        private static final Logger logger = LogManager.getLogger(TaxonNameEditorTest.class);
 
-    ITaxonNodeService taxonNodeService = getRemoteApplicationController().getTaxonNodeService();
-    ITaxonService taxonService = getRemoteApplicationController().getTaxonService();
-    IClassificationService classificationService = getRemoteApplicationController().getClassificationService();
-
-    Language english = Language.getLanguageFromUuid(Language.uuidEnglish);
+    private ITaxonNodeService taxonNodeService = getRemoteApplicationController().getTaxonNodeService();
+    private ITaxonService taxonService = getRemoteApplicationController().getTaxonService();
 
     @Test
     public void testAddHomotypicSynonym() throws ExecutionException {