ref #6694 Move menu item to "Term Editor"
authorPatrick Plitzner <p.plitzner@bgbm.org>
Fri, 16 Jun 2017 13:45:04 +0000 (15:45 +0200)
committerPatrick Plitzner <p.plitzner@bgbm.org>
Fri, 16 Jun 2017 13:45:04 +0000 (15:45 +0200)
eu.etaxonomy.taxeditor.store/fragment.e4xmi
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/editor/definedterm/DefinedTermMenu.java

index 5fd93b07ee10f39ee1d10912741efe8ccdccce73..b5ab73a129c81e93f8deb155f6b6eeda74135866 100644 (file)
@@ -28,9 +28,5 @@
       <visibleWhen xsi:type="ui:CoreExpression" xmi:id="_W-C-gCaJEeeTEd_pKXBflg" coreExpressionId="isCdmStoreConnected"/>
       <parameters xmi:id="_BylIUCZzEeeQLpuomSmVoQ" elementId="eu.etaxonomy.taxeditor.store.showView.parameter.sessionView" name="eu.etaxonomy.taxeditor.workbench.commandparameter.partName" value="eu.etaxonomy.taxeditor.view.sessions.SessionsViewPart"/>
     </elements>
-    <elements xsi:type="menu:HandledMenuItem" xmi:id="_VINAAEqgEeeN-dEYnw7m3g" elementId="eu.etaxonomy.taxeditor.store.showViewMenu.sessions" label="Feature Tree Editor" command="_bnVKsCZxEeeQLpuomSmVoQ">
-      <visibleWhen xsi:type="ui:CoreExpression" xmi:id="_VINAAUqgEeeN-dEYnw7m3g" coreExpressionId="isCdmStoreConnected"/>
-      <parameters xmi:id="_VINAAkqgEeeN-dEYnw7m3g" elementId="eu.etaxonomy.taxeditor.store.showView.parameter.sessionView" name="eu.etaxonomy.taxeditor.workbench.commandparameter.partName" value="eu.etaxonomy.taxeditor.featuretree.e4.FeatureTreeEditor"/>
-    </elements>
   </fragments>
 </fragment:ModelFragments>
index 5acacce6c03100d083026b86898febc4f53254a7..1a893caf487136d1ef1504e9f08fee98f8cccf26 100644 (file)
@@ -63,6 +63,8 @@ public class DefinedTermMenu extends CompoundContributionItem {
                     new MenuManager("Others","eu.etaxonomy.taxeditor.store.term.other.menu");
             otherMenuManager.setVisible(true);
             dtMenuManager.add(otherMenuManager);
+            //FIXME E4: This should be removed during e4 migration. dynamic menu should be declared in model fragment
+            dtMenuManager.add(createFeatureTreeMenuItem());
 
             List<TermType> ttList = new ArrayList<TermType>(EnumSet.allOf(TermType.class));
             Collections.sort(ttList,new SortByTermTypeMessage());
@@ -142,21 +144,21 @@ public class DefinedTermMenu extends CompoundContributionItem {
 
        }
 
-       private CommandContributionItem createDefaultMenuItem(TermType termType) {
+       private CommandContributionItem createFeatureTreeMenuItem() {
 
                Map<String, String> params = new HashMap<String, String>();
-               params.put("eu.etaxonomy.taxeditor.store.openDefinedTermEditor.termTypeUuid",
-                               termType.getUuid().toString());
+               params.put("eu.etaxonomy.taxeditor.workbench.commandparameter.partName",
+                               "eu.etaxonomy.taxeditor.featuretree.e4.FeatureTreeEditor");
 
         CommandContributionItemParameter p = new CommandContributionItemParameter(
                 PlatformUI.getWorkbench(),
-                "",
-                "eu.etaxonomy.taxeditor.store.openDefinedTermEditor",
+                "eu.etaxonomy.taxeditor.featuretree.commandContributionItemParameter",
+                "eu.etaxonomy.taxeditor.command.openPart",
                 params,
                 null,
                 null,
                 null,
-                "Other " + termType.getMessage() + "s",
+                "Feature Tree",
                 "",
                 "",
                 SWT.PUSH,
@@ -170,6 +172,34 @@ public class DefinedTermMenu extends CompoundContributionItem {
 
        }
 
+       private CommandContributionItem createDefaultMenuItem(TermType termType) {
+
+           Map<String, String> params = new HashMap<String, String>();
+           params.put("eu.etaxonomy.taxeditor.store.openDefinedTermEditor.termTypeUuid",
+                   termType.getUuid().toString());
+
+           CommandContributionItemParameter p = new CommandContributionItemParameter(
+                   PlatformUI.getWorkbench(),
+                   "",
+                   "eu.etaxonomy.taxeditor.store.openDefinedTermEditor",
+                   params,
+                   null,
+                   null,
+                   null,
+                   "Other " + termType.getMessage() + "s",
+                   "",
+                   "",
+                   SWT.PUSH,
+                   "",
+                   true);
+
+
+
+           CommandContributionItem item = new CommandContributionItem(p);
+           return item;
+
+       }
+
        private class SortByTermTypeMessage implements Comparator<TermType> {
            @Override
         public int compare(TermType t1, TermType t2) {