ref #10186: remove conversation holder
authorKatja Luther <k.luther@bgbm.org>
Fri, 18 Nov 2022 16:56:13 +0000 (17:56 +0100)
committerKatja Luther <k.luther@bgbm.org>
Fri, 18 Nov 2022 16:56:13 +0000 (17:56 +0100)
147 files changed:
eu.etaxonomy.taxeditor.bulkeditor/src/main/java/eu/etaxonomy/taxeditor/bulkeditor/e4/BulkEditor.java
eu.etaxonomy.taxeditor.bulkeditor/src/main/java/eu/etaxonomy/taxeditor/bulkeditor/input/AbstractBulkEditorInput.java
eu.etaxonomy.taxeditor.bulkeditor/src/main/java/eu/etaxonomy/taxeditor/bulkeditor/input/NameEditorInput.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/DescriptiveDataSetEditor.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/DescriptiveDataSetNavigator.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/character/CharacterEditor.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/handler/CreateDescriptiveDataSetHandler.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/handler/DeleteDescriptiveDataSetHandler.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/descriptiveDataSet/matrix/CharacterMatrixPart.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/e4/TaxonEditorInputDataChangeBehaviourE4_.java [moved from eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/e4/TaxonEditorInputDataChangeBehaviourE4.java with 67% similarity]
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/e4/TaxonEditorInputE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/group/authority/CdmAuthorityEditorInput.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/group/authority/e4/CdmAuthorityEditorE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/AbstractIdentificationEditorInput.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/e4/AbstractGraphKeyEditorE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/e4/KeyEditorDataChangeBehaviourE4_.java [moved from eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/e4/KeyEditorDataChangeBehaviourE4.java with 86% similarity]
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/polytomous/PolytomousKeyEditorInput.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/polytomous/e4/PolytomousKeyGraphEditorE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/key/polytomous/e4/PolytomousKeyListEditorE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/e4/TaxonNameEditorE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/e4/dnd/NameEditorDropTargetListenerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/e4/handler/ChangeSynonymToAcceptedTaxonHandlerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/e4/handler/MoveSynonymToAnotherAcceptedTaxonHandlerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/e4/operation/MoveSynonymToAnotherAcceptedTaxonOperationE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/operation/ChangeSynonymToAcceptedTaxonOperation.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/operation/DeleteMisapplicationOperation.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/operation/DeleteSynonymOperation.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/operation/DeleteTaxonBaseOperation.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/checklist/ChecklistEditorInput.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/checklist/e4/DistributionEditorPart.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/concept/e4/handler/CreateConceptRelationHandlerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/DerivateView.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/handler/AbstractAddDerivativeHandler.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/handler/CreateFieldUnitHandler.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/handler/SingleReadReuseHandler.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/operation/MoveDerivateOperation.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/derivate/searchFilter/DerivateSearchCompositeController.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/e4/handler/MoveDescriptionElementsHandlerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/e4/handler/MoveDescriptionElementsSetNameInSourceHandlerE5.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/e4/handler/MoveDescriptionToOtherTaxonHandlerE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/e4/handler/MoveDescriptionToOtherTaxonSetNameInSourceHandlerE5.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/operation/MoveDescriptionToOtherTaxonOperation.java
eu.etaxonomy.taxeditor.editor/src/test/java/eu/etaxonomy/taxeditor/editor/name/operation/DeleteMisapplicationOperationTest.java
eu.etaxonomy.taxeditor.editor/src/test/java/eu/etaxonomy/taxeditor/editor/name/operation/DeleteSynonymOperationTest.java
eu.etaxonomy.taxeditor.molecular/src/main/java/eu/etaxonomy/taxeditor/molecular/editor/e4/AlignmentEditorE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/key/polytomous/e4/PolytomousKeyViewPartDataChangeBehaviorE4_.java [moved from eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/key/polytomous/e4/PolytomousKeyViewPartDataChangeBehaviorE4.java with 92% similarity]
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/key/polytomous/e4/PolytomousKeyViewPartE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/key/polytomous/operation/DeleteOperation.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/EmptyRoot.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/Root.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/TaxonNavigatorDataChangeBehaviorE4_.java [moved from eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/TaxonNavigatorDataChangeBehaviorE4.java with 94% similarity]
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/TaxonNavigatorE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/handler/CloneClassificationHandlerE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/handler/CreateClassificationHierarchyHandlerE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/e4/handler/DeleteHandlerE4.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/operation/DeleteOperation.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/operation/CloneClassificationOperation.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/operation/CreateClassification.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/operation/CreateNewTaxonHierarchyOperation.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/operation/CreatePolytomousKey.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/operation/CreateTaxonNode.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/search/e4/SearchResultViewE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/editor/definedterm/e4/DefinedTermEditorE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/handler/e4/OpenPasswordWizzardHandlerE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/io/ExportManager.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/model/AbstractDataChangeBehaviour_.java [moved from eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/model/AbstractDataChangeBehaviour.java with 95% similarity]
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/AbstractNewEntityWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/AbstractNewEntityWizardParentChild.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/AmplificationGeneralWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewAmplificationWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewClassificationWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewCollectionWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewDerivedUnitBaseWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewFeatureVocabularyWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewGrantedAuthorityWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewGroupWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewInstitutionWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewNonViralNameWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewPersonWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewPolytomousKeyWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewPrimerWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewReferenceWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewTaxonNodeWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewTaxonWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewTeamWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/NewUserWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/PolytomousKeyWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/PrimerWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/newWizard/VocabularyWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/operation/AbstractPersistentPostOperation.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/wizard/AvailableDistributionPerAreaStatusWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/wizard/AvailableDistributionStatusAdminWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/wizard/AvailableDistributionStatusWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/wizard/AvailableVocabularyWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/wizard/VocabularyTermWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/store/LoginManager.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/store/SearchManager.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/store/TermManager.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/termtree/e4/TermTreeEditor.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/combo/AbstractComboElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/dialog/selection/AbstractFilteredCdmEnumSelectionDialog.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/dialog/selection/OriginalSourceTypeSelectionDialog.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/dialog/selection/SearchDialog.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/dialog/selection/SpecimenOrObservationTypeSelectionDialog.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/element/AbstractCdmEntityWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/element/AbstractFormSection.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/element/CdmFormFactory.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/element/MultilanguageTextElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/password/EditPasswordElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/password/PasswordWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/password/PasswordWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/AbstractCdmDetailElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/AbstractEntityCollectionElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/ICdmDetailElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/agent/InstitutionWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/agent/PersonWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/agent/TeamWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/AbstractEditWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/ClassificationWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/CloneClassificationWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/CloneClassificationWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/EditTaxonNodeWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/classification/TaxonNodeWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/grantedAuthority/GrantedAuthorityDetailWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/group/GroupDetailWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/name/AbstractTypeDesignationElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/name/NameRelationshipWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/name/NonViralNameWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/CollectionWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/DerivedUnitBaseWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/DerivedUnitGeneralWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/FieldUnitGeneralWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/FieldUnitWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/occurrence/GatheringEventWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/taxon/TaxonWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/user/UserDetailElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/section/user/UserDetailWizardPage.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/selection/EditFromSelectionWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/ui/selection/EntitySelectionElement.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/dataimport/e4/DataImportView.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/dataimport/e4/SpecimenSearchWizard.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/AbstractCdmDataViewer.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/AbstractCdmEditorPartE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/details/DetailsPartE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/details/DetailsViewerE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/supplementaldata/SupplementalDataViewerE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/search/derivative/DerivateLabelProvider.java

index fb9a1f739e5f9f0e5505e52d3f21a81bb5aad25b..d9f2705261cc7b33feaf0cbf0b967986f523ae00 100644 (file)
@@ -40,8 +40,6 @@ import org.eclipse.swt.SWT;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.ui.ide.undo.WorkspaceUndoUtil;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.cdm.hibernate.HibernateProxyHelper;
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -87,7 +85,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @author pplitzner
  * @since Sep 8, 2017
  */
-public class BulkEditor implements IPartContentHasDetails, IConversationEnabled, IPostOperationEnabled,
+public class BulkEditor implements IPartContentHasDetails, IPostOperationEnabled,
         IDirtyMarkable, IDerivedUnitFacadePart, IPartContentHasFactualData,
         IPartContentHasSupplementalData, IPartContentHasMedia, IE4SavablePart, ITaxonEditor, IBulkEditor {
 
@@ -96,8 +94,6 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
 
     private AbstractBulkEditorInput input;
 
-    private ConversationHolder conversation;
-
     @Inject
     private IEventBroker eventBroker;
 
@@ -119,7 +115,6 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
 
     public void init(AbstractBulkEditorInput<?> input){
            this.input = input;
-           this.conversation = input.getConversation();
            thisPart.setLabel(input.getEditorName());
 
            bulkEditorComposite.init(input);
@@ -167,12 +162,9 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
         }
         input.saveModel(resetMerge);
 
-//       IStructuredSelection selection = getSelection();
-
         dirty.setDirty(false);
         input.dispose();
         input.bind();
-        conversation.commit(true);
 
         if (lastQuery != null){
             bulkEditorComposite.performSearch(lastQuery, selection);
@@ -189,9 +181,7 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
     @Focus
        public void setFocus() {
         //make sure to bind again if maybe in another view the conversation was unbound
-        if(conversation!=null && !conversation.isBound()){
-            conversation.bind();
-        }
+
         if(input!=null && input.getCdmEntitySession()!= null) {
             input.getCdmEntitySession().bind();
         }
@@ -202,10 +192,6 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
 
        @PreDestroy
        public void dispose() {
-           if(conversation!=null){
-               conversation.unregisterForDataStoreChanges(this);
-               conversation.close();
-           }
            if(input!=null){
                input.dispose();
            }
@@ -267,10 +253,6 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
         bulkEditorComposite.copyDataToClipboard();
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
-
     @Override
     public boolean canAttachMedia() {
         return true;
@@ -402,10 +384,7 @@ public class BulkEditor implements IPartContentHasDetails, IConversationEnabled,
         return false;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
+    
 
     public BulkEditorQuery getLastQuery() {
        return lastQuery;
index 2d9c59d181f1335bd682252109bbad65fa8d4429..ebe1b8734aff3f9110c0583f7cde361d22821ca9 100644 (file)
@@ -25,7 +25,6 @@ import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jface.viewers.IStructuredSelection;
 
 import ca.odell.glazedlists.BasicEventList;
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.service.config.DeleteConfiguratorBase;
 import eu.etaxonomy.cdm.api.service.config.IIdentifiableEntityServiceConfigurator;
 import eu.etaxonomy.cdm.api.service.exception.ReferencedObjectUndeletableException;
@@ -81,13 +80,13 @@ public abstract class AbstractBulkEditorInput<T extends CdmBase>
        private HashMap<T, Set<T>> mergedEntities = new HashMap<>();
 
        private IEntityCreator<T> entityCreator;
-       private final ConversationHolder conversation;
+
 
     private Job searchJob;
 
        public AbstractBulkEditorInput() {
            super(true);
-           this.conversation = CdmStore.createConversation();
+
        }
 
        static public AbstractBulkEditorInput<?> NewInstance(BulkEditorInputType inputType) {
@@ -474,9 +473,7 @@ public abstract class AbstractBulkEditorInput<T extends CdmBase>
         return null;
     }
 
-       public ConversationHolder getConversation() {
-               return conversation;
-       }
+
 
        public Set<T> getSaveCandidates() {
         return saveCandidates;
index ecd3af8b118f6f6e9b39cf07c2e41dcf6974d4a5..c55908f46eb1900934c6a6c6f964ed80a178b31f 100644 (file)
@@ -143,7 +143,7 @@ public class NameEditorInput extends AbstractBulkEditorInput<TaxonName> {
        @Override
        public List listEntities(IIdentifiableEntityServiceConfigurator configurator) {
                configurator.setPropertyPaths(getPropertyPaths());
-               return CdmStore.getSearchManager().findNames(configurator, this.getConversation());
+               return CdmStore.getSearchManager().findNames(configurator);
        }
 
        @Override
index cd470efc8b799a742801445909b84abba94264fe..040322d0e976789f486d0d53f9f6042bce421dad 100644 (file)
@@ -53,8 +53,6 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Shell;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IDescriptiveDataSetService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.api.service.ITermService;
@@ -89,14 +87,12 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @since Nov 21, 2017
  *
  */
-public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEnabled, 
+public class DescriptiveDataSetEditor implements IE4SavablePart, 
                ICdmEntitySessionEnabled<DescriptiveDataSet>, IPartContentHasDetails, 
                IPartContentHasSupplementalData, IDirtyMarkable, IDescriptiveDataSetEditor {
 
     private DescriptiveDataSetComposite composite;
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     private DescriptiveDataSet descriptiveDataSet;
@@ -118,9 +114,6 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
     public void create(Composite parent, IEclipseContext context, @Named(IServiceConstants.ACTIVE_SHELL)Shell shell,
             EMenuService menuService){
         if (CdmStore.isActive()){
-            if(conversation == null){
-                conversation = CdmStore.createConversation();
-            }
             if(cdmEntitySession == null){
                 cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
             }
@@ -292,11 +285,6 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
     @Override
     public void save(IProgressMonitor monitor) {
 
-        if (!conversation.isBound()) {
-            conversation.bind();
-
-        }
-        conversation.commit(true);
         Collection<TermDto> areas = composite.getAreas();
         Object input = composite.getTaxonNodeTree().getInput();
         if(input!=null){
@@ -348,10 +336,6 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
 
     @PreDestroy
     public void dispose() {
-        if (conversation != null) {
-            conversation.close();
-            conversation = null;
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -365,9 +349,7 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
         if(composite!=null){
             composite.setFocus();
         }
-        if (getConversationHolder() != null) {
-            getConversationHolder().bind();
-        }
+
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -381,9 +363,7 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
         return descriptiveDataSet;
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
+    
 
     @Override
     public ICdmEntitySession getCdmEntitySession() {
@@ -400,11 +380,6 @@ public class DescriptiveDataSetEditor implements IE4SavablePart, IConversationEn
         return null;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
     @Override
     public void changed(Object element) {
         dirty.setDirty(true);
index 59ec521c504f549c8d6b1d19c4c52ebaf46cc055..a3999d53ede413bc1043f2fcbae0f2928ecfe59a 100644 (file)
@@ -38,8 +38,6 @@ import org.eclipse.jface.viewers.ViewerComparator;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.ui.IMemento;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IDescriptiveDataSetService;
 import eu.etaxonomy.cdm.model.common.CdmBase;
 import eu.etaxonomy.cdm.model.description.DescriptiveDataSet;
@@ -57,7 +55,7 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  *
  */
 public class DescriptiveDataSetNavigator 
-               implements IConversationEnabled, ICdmEntitySessionEnabled<DescriptiveDataSet>, IContextListener{
+               implements ICdmEntitySessionEnabled<DescriptiveDataSet>, IContextListener{
 
     private ListViewer viewer;
 
@@ -66,8 +64,6 @@ public class DescriptiveDataSetNavigator
 
     private ISelectionChangedListener selectionChangedListener;
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     private List<DescriptiveDataSet> descriptiveDataSets;
@@ -121,9 +117,9 @@ public class DescriptiveDataSetNavigator
 
     public void init(){
         if (CdmStore.isActive()){
-            if(conversation == null) {
-                conversation = CdmStore.createConversation();
-            }
+//            if(conversation == null) {
+//                conversation = CdmStore.createConversation();
+//            }
             if(cdmEntitySession == null){
                 cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
             }
@@ -165,9 +161,7 @@ public class DescriptiveDataSetNavigator
         refresh();
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
+    
 
     @Override
     public ICdmEntitySession getCdmEntitySession() {
@@ -184,21 +178,13 @@ public class DescriptiveDataSetNavigator
         return null;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
     public ESelectionService getSelService() {
         return selService;
     }
 
     @PreDestroy
     public void dispose() {
-        if (conversation != null) {
-            conversation.close();
-            conversation = null;
-        }
+        
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -207,9 +193,7 @@ public class DescriptiveDataSetNavigator
 
     @Focus
     public void setFocus() {
-        if (getConversationHolder() != null) {
-            getConversationHolder().bind();
-        }
+        
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
index 1502580c1e79b853d6560fa8af2fba874bef09fc..9e2a7847fdc805ef1a3f06831a7b74f281bac97f 100644 (file)
@@ -56,8 +56,6 @@ import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.forms.widgets.FormToolkit;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITermNodeService;
 import eu.etaxonomy.cdm.api.service.ITermTreeService;
 import eu.etaxonomy.cdm.api.service.IVocabularyService;
@@ -114,7 +112,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4ViewerPart;
  * @author pplitzner
  * @date 24.05.2017
  */
-public class CharacterEditor implements ICharacterEditor, IConversationEnabled, ISelectionChangedListener,
+public class CharacterEditor implements ICharacterEditor, ISelectionChangedListener,
         ModifyListener, IE4ViewerPart, IPartContentHasDetails, IPartContentHasSupplementalData,
         IDirtyMarkable, IE4SavablePart {
 
@@ -130,8 +128,6 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
     @Inject
     private MDirtyable dirty;
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     private TermVocabulary vocabulary;
@@ -155,9 +151,9 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
     @PostConstruct
     public void createControls(Composite parent, EMenuService menuService ) {
         if (CdmStore.isActive()){
-            if(conversation == null){
-                conversation = CdmStore.createConversation();
-            }
+//            if(conversation == null){
+//                conversation = CdmStore.createConversation();
+//            }
             if(cdmEntitySession==null){
                 cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
             }
@@ -422,9 +418,6 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
         if(characterTreeEditorComposite!=null){
             characterTreeEditorComposite.getViewer().getControl().setFocus();
         }
-        if(conversation!=null && !conversation.isBound()){
-            conversation.bind();
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -486,9 +479,7 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
     @Override
     @Persist
     public void save(IProgressMonitor monitor){
-        if (!conversation.isBound()) {
-            conversation.bind();
-        }
+        
         UpdateResult result = new UpdateResult();
         if (nodesToSave != null && this.getVocabulary() != null) {
             result.includeResult(CdmStore.getService(ITermNodeService.class).saveNewCharacterNodeDtoMap(this.nodesToSave, this.getVocabulary().getUuid()));
@@ -507,7 +498,7 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
         result.includeResult(CdmStore.getService(ITermNodeService.class).saveCharacterNodeDtoList(this.nodesToUpdate));
         nodesToUpdate.clear();
         // commit the conversation and start a new transaction immediately
-        conversation.commit(true);
+        //conversation.commit(true);
         if (result.getUpdatedObjects() != null && !result.getUpdatedObjects().isEmpty()){
             Object o = result.getUpdatedObjects().iterator().next();
             if (o instanceof TermNode){
@@ -538,10 +529,7 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
 
     @PreDestroy
     public void dispose(){
-        if(conversation!=null){
-            conversation.close();
-            conversation = null;
-        }
+       
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -592,9 +580,7 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
 
     @Focus
     public void setFocus() {
-        if(conversation!=null && !conversation.isBound()){
-            conversation.bind();
-        }
+       
     }
 
     @Override
@@ -675,14 +661,7 @@ public class CharacterEditor implements ICharacterEditor, IConversationEnabled,
         }
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
+    
 
     @Override
     public void changed(Object element) {
index ffad6db60f5ceb569ef4295f2d7378b589371057..8516e72569d8cb3a4540e1edfcff41eadb87d53b 100644 (file)
@@ -35,7 +35,6 @@ public class CreateDescriptiveDataSetHandler {
                DescriptiveDataSet descriptiveDataSet = DescriptiveDataSet.NewInstance();
                descriptiveDataSet.setLabel(dataSetName);
                CdmStore.getService(IDescriptiveDataSetService.class).merge(descriptiveDataSet, true);
-               navigator.getConversationHolder().commit();
                navigator.addDescriptiveDataSet(descriptiveDataSet);
                EditorUtil.openDescriptiveDataSetEditor(descriptiveDataSet.getUuid(), modelService, partService, application);
            }
index 18c8fd5c344ed5047e217d0a1dd2bb6592e14987..1b048e0bd18065c017d53a78041d7051a615ac56 100644 (file)
@@ -66,7 +66,6 @@ public class DeleteDescriptiveDataSetHandler {
                     deleteDescriptiveDataSet(((DescriptiveDataSet) next).getUuid(), deleteConfig);
                     DescriptiveDataSetNavigator navigator = (DescriptiveDataSetNavigator) object;
                     navigator.removeDescriptiveDataSet((DescriptiveDataSet) next);
-                    navigator.getConversationHolder().commit();
                     navigator.getSelService().setSelection(null);
                 }else{
                     MessagingUtils.errorDialog(Messages.DeleteDescriptiveDataSetHandler_DELETE_FAILED_TITLE, DeleteDescriptiveDataSetHandler.class, Messages.DeleteDescriptiveDataSetHandler_DELETE_FAILED_MESSAGE, TaxeditorEditorPlugin.PLUGIN_ID, null, false);
index d7928f70af33c2b18fad2b813a566f97f2541fe8..cb404c336bf933a9d2cd4bfeaf6d401b4a19c8ec 100644 (file)
@@ -38,8 +38,6 @@ import org.eclipse.swt.custom.StackLayout;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Label;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.DeleteResult;
 import eu.etaxonomy.cdm.api.service.IDescriptionService;
 import eu.etaxonomy.cdm.api.service.IDescriptiveDataSetService;
@@ -73,7 +71,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @author pplitzner
  * @since Nov 26, 2017
  */
-public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled, IDirtyMarkable,
+public class CharacterMatrixPart implements IE4SavablePart, IDirtyMarkable,
                ICdmEntitySessionEnabled<DescriptiveDataSet>, IPartContentHasSupplementalData,
                IPartContentHasDetails {
 
@@ -103,8 +101,6 @@ public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled
 
     private DescriptiveDataSetBaseDto descriptiveDataSet;
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     @Inject
@@ -127,10 +123,7 @@ public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled
 
     @PostConstruct
     public void create(Composite parent, IEclipseContext context) {
-        if(CdmStore.isActive() && conversation==null){
-            conversation = CdmStore.createConversation();
-        }
-        if(cdmEntitySession == null){
+       if(cdmEntitySession == null){
             cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
             cdmEntitySession.bind();
         }
@@ -258,9 +251,6 @@ public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled
 
     @Focus
     public void setFocus(){
-        if(conversation!=null){
-            conversation.bind();
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -268,10 +258,6 @@ public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled
 
     @PreDestroy
     public void dispose(){
-        if (conversation != null) {
-            conversation.close();
-            conversation = null;
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -281,15 +267,6 @@ public class CharacterMatrixPart implements IE4SavablePart, IConversationEnabled
         dirty.setDirty(false);
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
     @Override
     public void changed(Object element) {
         setDirty();
 package eu.etaxonomy.taxeditor.editor.e4;
 
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
-import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour;
+import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour_;
 
 /**
  * @author pplitzner
  * @date Aug 24, 2017
  */
-public class TaxonEditorInputDataChangeBehaviourE4 extends
-               AbstractDataChangeBehaviour {
+public class TaxonEditorInputDataChangeBehaviourE4_ extends
+               AbstractDataChangeBehaviour_ {
 
        private TaxonEditorInputE4 source;
 
-       public TaxonEditorInputDataChangeBehaviourE4(TaxonEditorInputE4 taxonEditorInput) {
+       public TaxonEditorInputDataChangeBehaviourE4_(TaxonEditorInputE4 taxonEditorInput) {
                source = taxonEditorInput;
        }
 
        @Override
        public void reactOnDataChange(CdmDataChangeMap events) {
-               source.update(events);
+               //source.update(events);
 
        }
 }
index 0a5a6f37690a219b80c97d7d8f713cf29d6cbd0a..b54daa0afa23954c012b4ca9cb4a4fc329fd5b3b 100644 (file)
@@ -28,8 +28,6 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.e4.ui.di.UISynchronize;
 import org.eclipse.ui.ide.undo.WorkspaceUndoUtil;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.api.service.INameService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
@@ -64,13 +62,10 @@ import eu.etaxonomy.taxeditor.store.internal.TaxeditorStorePlugin;
  * @author pplitzner
  * @date Aug 24, 2017
  */
-public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
-               implements IConversationEnabled {
+public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>{
 
     private static final String INCORRECT_STATE = Messages.TaxonEditorInput_INCORRECT_STATE;
 
-    private final ConversationHolder conversation;
-
     private TaxonNode taxonNode;
 
     private Map<TaxonBase, TaxonBaseDeletionConfigurator> toDeletes = new HashMap<>();
@@ -80,7 +75,7 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
 
     private Set<AbstractPostOperation> operations = new HashSet<>();
 
-    private TaxonEditorInputDataChangeBehaviourE4 dataChangeBehavior;
+//    private TaxonEditorInputDataChangeBehaviourE4 dataChangeBehavior;
 
     private TaxonBase<?> initiallySelectedTaxonBase;
 
@@ -99,8 +94,7 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
 
     private TaxonEditorInputE4(UUID uuid, CdmType type) {
         super(true);
-        this.conversation = CdmStore.createConversation();
-        switch(type) {
+       switch(type) {
         case PARENT_TAXON_NODE:
             initForParentTaxonNode(uuid);
             break;
@@ -151,10 +145,10 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
                     if (taxon.getTaxonNodes().size() > 0){
                         acceptedTaxa.add(taxon);
                     }
-                    setInputForRelatedTaxa(conversation, acceptedTaxa);
+                    setInputForRelatedTaxa(acceptedTaxa);
 
                 }else{
-                    setInputForMultipleNodes(conversation, taxon.getTaxonNodes());
+                    setInputForMultipleNodes(taxon.getTaxonNodes());
                 }
             }else if(taxonBase instanceof Synonym){
                 Synonym synonym = (Synonym) taxonBase;
@@ -164,7 +158,7 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
                 if (taxon != null){
                        taxa.add(taxon);
                 }
-                setInputForMultipleTaxa(conversation, taxa);
+                setInputForMultipleTaxa(taxa);
                 setInitiallySelectedTaxonBase(synonym);
             }
         }
@@ -184,7 +178,7 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
         initForTaxonNode(newTaxonNodeUuid);
     }
 
-    private void setInputForMultipleNodes(ConversationHolder conversation, Set<TaxonNode> taxonNodes){
+    private void setInputForMultipleNodes(Set<TaxonNode> taxonNodes){
         if(taxonNodes.size() == 1){
             TaxonNode taxonNode = taxonNodes.iterator().next();
             taxonNode = getCdmEntitySession().remoteLoad(CdmStore.getService(ITaxonNodeService.class), taxonNode.getUuid(), getTaxonNodePropertyPaths());
@@ -204,24 +198,24 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
         }
     }
 
-    private void setInputForMultipleTaxa(ConversationHolder conversation, Set<Taxon> taxa){
+    private void setInputForMultipleTaxa(Set<Taxon> taxa){
         if(taxa.size() == 1){
             Taxon taxon = taxa.iterator().next();
             Set<TaxonNode> nodes = taxon.getTaxonNodes();
-            setInputForMultipleNodes(conversation, nodes);
+            setInputForMultipleNodes(nodes);
         }else if(taxa.size() > 1){
             Set<TaxonNode> taxonNodes = new HashSet<TaxonNode>();
             for ( Taxon taxon : taxa ){
                 taxonNodes.addAll(taxon.getTaxonNodes());
             }
-            setInputForMultipleNodes(conversation, taxonNodes);
+            setInputForMultipleNodes(taxonNodes);
         }else if(taxa.size() == 0){
             // this is an undesired state
             MessagingUtils.warningDialog(INCORRECT_STATE, TaxonEditorInputE4.class, Messages.TaxonEditorInput_NO_ACCEPTED_TAXON_PRESENT);
         }
     }
 
-    private void setInputForRelatedTaxa(ConversationHolder conversation, Set<Taxon> taxa){
+    private void setInputForRelatedTaxa(Set<Taxon> taxa){
         if(taxa.size() == 1){
             Taxon taxon = taxa.iterator().next();
             Set<TaxonNode> nodes = taxon.getTaxonNodes();
@@ -311,20 +305,6 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
         return taxonNode;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
-    @Override
-    public void update(CdmDataChangeMap events) {
-        if(dataChangeBehavior == null){
-            dataChangeBehavior = new TaxonEditorInputDataChangeBehaviourE4(this);
-        }
-
-        DataChangeBridge.handleDataChange(events, dataChangeBehavior);
-    }
-
     public void setInitiallySelectedTaxonBase(TaxonBase taxonBase) {
         this.initiallySelectedTaxonBase = taxonBase;
     }
@@ -388,9 +368,7 @@ public class TaxonEditorInputE4  extends CdmEntitySessionInput<TaxonNode>
                 }
             }
         }
-//        for (TaxonName name:toSaveNewNames){
-//            name.get
-//        }
+
 
         if (!toSaveNewNames.isEmpty()){
                List<TaxonName> listNames = new ArrayList(toSaveNewNames);
index a6edaaa2832c1545e252109e4a61d7b020deb022..5694db462a73f4baca1f19cacc92c8d97b71f65a 100644 (file)
@@ -13,11 +13,8 @@ import java.util.Collection;
 import java.util.UUID;
 
 import eu.etaxonomy.cdm.api.application.CdmApplicationState;
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IGroupService;
 import eu.etaxonomy.cdm.model.permission.Group;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.CdmEntitySessionInput;
 import eu.etaxonomy.taxeditor.store.CdmStore;
 
@@ -28,15 +25,12 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @created Mar 28, 2013
  */
 public class CdmAuthorityEditorInput 
-               extends CdmEntitySessionInput<Group> 
-               implements IConversationEnabled {
+               extends CdmEntitySessionInput<Group> {
        
-       private ConversationHolder conversation;
        private Group group;
 
-       protected CdmAuthorityEditorInput(ConversationHolder conversation, Group group) {
+       protected CdmAuthorityEditorInput(Group group) {
            super(true);
-               this.conversation = conversation;
                this.group = CdmApplicationState.getCurrentAppConfig().getGroupService().load(group.getUuid());
 
        }
@@ -49,9 +43,8 @@ public class CdmAuthorityEditorInput
         * @throws Exception
         */
        public static CdmAuthorityEditorInput NewInstance(UUID groupUuid) throws Exception{
-               ConversationHolder conversation = CdmStore.createConversation();
                Group group = CdmStore.getService(IGroupService.class).load(groupUuid, null);
-               return new CdmAuthorityEditorInput(conversation, group);
+               return new CdmAuthorityEditorInput( group);
        }
 
        public Object getAdapter(Class adapter) {
@@ -62,16 +55,6 @@ public class CdmAuthorityEditorInput
                return null;
        }
 
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-               // TODO Auto-generated method stub
-       }
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return this.conversation;
-       }
-       
        public String getName() {
                return group.getName();
        }
index 7d9783cc7b7c625397a80a8c3fc52fcb8aff7bc8..3f65cdf3db235f8119d47ac677c067ee11af2c1c 100644 (file)
@@ -21,8 +21,6 @@ import org.eclipse.swt.SWT;
 import org.eclipse.swt.layout.FillLayout;
 import org.eclipse.swt.widgets.Composite;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.permission.Group;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.group.authority.CdmAuthorityEditorInput;
@@ -37,13 +35,12 @@ import eu.etaxonomy.taxeditor.ui.group.grantedauthority.CdmAuthorityCompositeVie
  * @created Mar 28, 2013
  *
  */
-public class CdmAuthorityEditorE4 implements IConversationEnabled, IDirtyMarkable {
+public class CdmAuthorityEditorE4 implements IDirtyMarkable {
 
        public static final String ID = "eu.etaxonomy.taxeditor.editor.group.authority"; //$NON-NLS-1$
 
        @Inject
        private MDirtyable dirty;
-       private ConversationHolder conversation;
        private CdmAuthorityCompositeViewer viewer;
 
        private CdmAuthorityEditorInput input;
@@ -80,7 +77,6 @@ public class CdmAuthorityEditorE4 implements IConversationEnabled, IDirtyMarkabl
        public void doSave(IProgressMonitor monitor) {
                try {
                        monitor.beginTask(Messages.CdmAuthorityEditor_SAVING_AUTHORITY_EDITOR, 1);
-                       getConversationHolder().commit(true);
                        input.merge();
                        dirty.setDirty(false);
                        monitor.worked(1);
@@ -92,9 +88,6 @@ public class CdmAuthorityEditorE4 implements IConversationEnabled, IDirtyMarkabl
 
        public void init(CdmAuthorityEditorInput input) {
            this.input = input;
-
-        conversation = input.getConversationHolder();
-
         this.viewer = new CdmAuthorityCompositeViewer(container, this,input.getGroup());
 
         thisPart.setLabel(input.getName());
@@ -109,10 +102,6 @@ public class CdmAuthorityEditorE4 implements IConversationEnabled, IDirtyMarkabl
         return input;
     }
 
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-       }
-
        @Override
        public void changed(Object element) {
                //FIXME : should be optimised to split changes into adding / removing authorities
@@ -133,18 +122,9 @@ public class CdmAuthorityEditorE4 implements IConversationEnabled, IDirtyMarkabl
            changed(null);
        }
 
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
        @PreDestroy
        public void dispose() {
-           if(conversation!=null){
-               conversation.unregisterForDataStoreChanges(this);
-               conversation.close();
-               conversation = null;
-           }
+           
                if(input!=null){
                    input.getCdmEntitySession().dispose();
                }
index bd28dd2e901dd22071e6f1a6ad63f9d430507637..39f4b18d4ac044b8b756ba78aa5c4ed10ad00b06 100644 (file)
@@ -8,36 +8,22 @@
 */
 package eu.etaxonomy.taxeditor.editor.key;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.description.IIdentificationKey;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.CdmEntitySessionInput;
 
 /**
  * @author n.hoffmann
  */
 public abstract class AbstractIdentificationEditorInput<T extends IIdentificationKey>
-               extends CdmEntitySessionInput implements IConversationEnabled {
+               extends CdmEntitySessionInput  {
 
-       private final ConversationHolder conversation;
-
-       protected AbstractIdentificationEditorInput(ConversationHolder conversation) {
+       protected AbstractIdentificationEditorInput() {
            super(true);
-               this.conversation = conversation;
-       }
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
        }
 
+       
        public abstract T getKey();
 
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-       }
-
        @Override
        public boolean equals(Object obj) {
                // TODO Auto-generated method stub
index fc4a43cc054c0f732e01a98576a9075422ac24ba..424d2bb0fc32198565ecce9c1fe59c5f54962dce 100644 (file)
@@ -25,10 +25,8 @@ import org.eclipse.zest.layouts.LayoutAlgorithm;
 import org.eclipse.zest.layouts.LayoutStyles;
 import org.eclipse.zest.layouts.algorithms.TreeLayoutAlgorithm;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.description.IIdentificationKey;
 import eu.etaxonomy.cdm.model.description.PolytomousKeyNode;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.PolytomousKeyEditorInput;
 import eu.etaxonomy.taxeditor.model.IDirtyMarkable;
 import eu.etaxonomy.taxeditor.operation.IPostOperationEnabled;
@@ -43,8 +41,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @param <T>
  */
 public abstract class AbstractGraphKeyEditorE4<T extends IIdentificationKey>
-implements IConversationEnabled, IE4SavablePart,
-               IZoomableWorkbenchPart, IPostOperationEnabled,
+implements IE4SavablePart, IZoomableWorkbenchPart, IPostOperationEnabled,
                IDirtyMarkable {
 
        protected CdmFormFactory formFactory;
@@ -72,7 +69,6 @@ implements IConversationEnabled, IE4SavablePart,
        @Override
     @Persist
        public void save(IProgressMonitor monitor) {
-               getConversationHolder().commit(true);
                setDirty(false);
                viewer.refresh();
        }
@@ -123,11 +119,6 @@ implements IConversationEnabled, IE4SavablePart,
                viewer.refresh();
        }
 
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-
-       }
-
        @Override
        public AbstractZoomableViewer getZoomableViewer() {
                return viewer;
@@ -17,18 +17,18 @@ import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeEvent.EventType;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.PolytomousKeyEditorInput;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.e4.PolytomousKeyListEditorE4;
-import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour;
+import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour_;
 
 /**
  * @author n.hoffmann
  * @created May 5, 2011
  */
-public class KeyEditorDataChangeBehaviourE4 extends AbstractDataChangeBehaviour {
+public class KeyEditorDataChangeBehaviourE4_ extends AbstractDataChangeBehaviour_ {
 
        private final PolytomousKeyListEditorE4 source;
        private PolytomousKeyEditorInput input;
 
-       public KeyEditorDataChangeBehaviourE4(PolytomousKeyListEditorE4 keyEditor) {
+       public KeyEditorDataChangeBehaviourE4_(PolytomousKeyListEditorE4 keyEditor) {
                source = keyEditor;
        }
 
index e1b8578389013a5883ca5e35792b888957f178e1..5682d947b3c1dd8579717b9f96333a22e6967f82 100644 (file)
@@ -29,9 +29,8 @@ public class PolytomousKeyEditorInput extends AbstractIdentificationEditorInput<
     private PolytomousKey key;
 
 
-    protected PolytomousKeyEditorInput(ConversationHolder conversation,
-            UUID polytomousKeyUuid) {
-        super(conversation);
+    protected PolytomousKeyEditorInput(UUID polytomousKeyUuid) {
+        super();
         List<String> propertyPath = new ArrayList<>();
         propertyPath.add("root");
         propertyPath.add("root.*");
@@ -40,8 +39,7 @@ public class PolytomousKeyEditorInput extends AbstractIdentificationEditorInput<
 
     public static PolytomousKeyEditorInput NewInstance(UUID polytomousKeyUuid) throws Exception{
         try{
-            ConversationHolder conversation = CdmStore.createConversation();
-            return new PolytomousKeyEditorInput(conversation, polytomousKeyUuid);
+               return new PolytomousKeyEditorInput( polytomousKeyUuid);
         }catch(Exception e){
             throw e;
         }
index 4c5c9f4e5517935d3b0de21de744370bb44fed28..15147ad9261f5eb32dbe6f74c0f8a2dbf75c6221 100644 (file)
@@ -93,12 +93,7 @@ public class PolytomousKeyGraphEditorE4
         });
     }
 
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return getEditorInput()
-                               .getConversationHolder();
-       }
-
+       
        @Override
        public PolytomousKey getKey() {
                return getEditorInput().getKey();
index 2705e692b08bbe8b6a42c162454c55fbbd4e1156..fbfec4dae20e147ed34fbc96b700b5d7737a9f12 100644 (file)
@@ -38,21 +38,16 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Table;
 import org.eclipse.swt.widgets.TableItem;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.hibernate.HibernateProxyHelper;
 import eu.etaxonomy.cdm.model.description.PolytomousKey;
 import eu.etaxonomy.cdm.model.description.PolytomousKeyNode;
 import eu.etaxonomy.cdm.model.taxon.Taxon;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.EditorUtil;
-import eu.etaxonomy.taxeditor.editor.key.e4.KeyEditorDataChangeBehaviourE4;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.IPolytomousKeyEditorPage;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.PolytomousKeyEditorInput;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.PolytomousKeyListContentProvider;
 import eu.etaxonomy.taxeditor.editor.key.polytomous.PolytomousKeyListLabelProvider;
 import eu.etaxonomy.taxeditor.editor.l10n.Messages;
-import eu.etaxonomy.taxeditor.model.DataChangeBridge;
 import eu.etaxonomy.taxeditor.model.IDirtyMarkable;
 import eu.etaxonomy.taxeditor.model.IPartContentHasDetails;
 import eu.etaxonomy.taxeditor.model.IPartContentHasSupplementalData;
@@ -63,7 +58,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @since Sep 28, 2017
  */
 public class PolytomousKeyListEditorE4 implements
-               IConversationEnabled, IDirtyMarkable, IPartContentHasDetails, IPartContentHasSupplementalData,
+               IDirtyMarkable, IPartContentHasDetails, IPartContentHasSupplementalData,
                IPolytomousKeyEditorPage, IE4SavablePart{
 
        private class LinkListener extends MouseAdapter {
@@ -137,9 +132,7 @@ public class PolytomousKeyListEditorE4 implements
 
        private TableViewer viewer;
 
-    private KeyEditorDataChangeBehaviourE4 dataChangeBehavior;
-
-    private PolytomousKeyEditorInput input;
+       private PolytomousKeyEditorInput input;
 
     @Inject
     private ESelectionService selService;
@@ -164,27 +157,12 @@ public class PolytomousKeyListEditorE4 implements
     @Inject
        public PolytomousKeyListEditorE4() {
        }
-
-       @Override
-       public void update(CdmDataChangeMap map) {
-           if(dataChangeBehavior == null){
-            dataChangeBehavior = new KeyEditorDataChangeBehaviourE4(this);
-        }
-        DataChangeBridge.handleDataChange(map, dataChangeBehavior);
-       }
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return input.getConversationHolder();
-       }
-
+       
        @Override
     @Persist
        public void save(IProgressMonitor monitor) {
         try {
             monitor.beginTask(Messages.KeyEditor_SAVING, 1);
-            getConversationHolder().bind();
-            getConversationHolder().commit(true);
             input.merge();
             dirty.setDirty(false);
             monitor.worked(1);
@@ -243,7 +221,6 @@ public class PolytomousKeyListEditorE4 implements
     public void dispose() {
         if(input!=null){
             input.dispose();
-            input.getConversationHolder().close();
         }
     }
 
index 71139af242d737f0727b9c970bed9f9883f5cd69..a47617b366c40c32c6972a3a4821a2c235fd6c4a 100644 (file)
@@ -53,8 +53,6 @@ import org.eclipse.ui.forms.widgets.FormToolkit;
 import org.eclipse.ui.forms.widgets.ScrolledForm;
 import org.eclipse.ui.forms.widgets.TableWrapLayout;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.DeleteResult;
 import eu.etaxonomy.cdm.hibernate.HibernateProxyHelper;
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -66,7 +64,6 @@ import eu.etaxonomy.cdm.model.taxon.TaxonBase;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
 import eu.etaxonomy.cdm.model.taxon.TaxonRelationship;
 import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.CdmDataTransfer;
 import eu.etaxonomy.taxeditor.editor.EditorUtil;
 import eu.etaxonomy.taxeditor.editor.ISecuredEditor;
@@ -105,7 +102,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @date Aug 24, 2017
  */
 public class TaxonNameEditorE4
-        implements IConversationEnabled, IDirtyMarkable, IPartContentHasDetails,
+        implements IDirtyMarkable, IPartContentHasDetails,
             IPartContentHasSupplementalData, IPartContentHasMedia, IPartContentHasFactualData, IPartChangeListener,
             ISelectionListener, ISecuredEditor, IE4SavablePart, ITaxonEditor, IDropTargetableE4 {
 
@@ -121,8 +118,6 @@ public class TaxonNameEditorE4
     private EPartService partService;
     private TaxonBase<?> selection;
 
-    private ConversationHolder conversation;
-
     private AcceptedGroupE4 acceptedGroup;
     private List<HomotypicalSynonymGroupE4> heterotypicSynonymGroups = new ArrayList<>();
     private MisappliedGroupE4 misappliedGroup;
@@ -256,9 +251,7 @@ public class TaxonNameEditorE4
         // unbound
 
         eventBroker.post(WorkbenchEventConstants.CURRENT_ACTIVE_EDITOR, this);
-        if (conversation != null && !conversation.isBound()) {
-            conversation.bind();
-        }
+        
         if (EditorUtil.isFactsVisible()){
             EditorUtil.showFacts(modelService, partService);
         }
@@ -269,17 +262,13 @@ public class TaxonNameEditorE4
             if (getSelectedContainer() == null) {
                 throw new IllegalStateException(Messages.TaxonNameEditor_THERE_SHOULD_ALWAYS_BE);
             }
-//            getSelectedContainer().setSelected();
+
             if (input.getCdmEntitySession() != null && !input.getCdmEntitySession().isActive()) {
                 input.bind();
             }
-//            if (!getSelectedContainer().isSelected()) {
-//             getSelectedContainer().setSelected();
-//            }
+
         }
-//        if(selection!=null){
-//            selService.setSelection(new StructuredSelection(selection));
-//        }
+
         // check permissions
         boolean doEnable = permissionsSatisfied();
         managedForm.getForm().setEnabled(doEnable);
@@ -296,16 +285,6 @@ public class TaxonNameEditorE4
         return doEnable;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
-    @Override
-    public void update(CdmDataChangeMap events) {
-        // redraw();
-    }
-
     /**
      * Redraws this editor return true on success
      *
@@ -381,11 +360,6 @@ public class TaxonNameEditorE4
     public void save(IProgressMonitor monitor) {
 
         monitor.beginTask(Messages.TaxonNameEditor_SAVING_NAMES, getGroupedContainers().size());
-        if (!conversation.isBound()) {
-            conversation.bind();
-
-        }
-        conversation.commit(true);
         monitor.worked(1);
 
         // check for empty names
@@ -413,9 +387,7 @@ public class TaxonNameEditorE4
         }
         input.setSync(sync);
         input.merge();
-        // commit the conversation and start a new transaction immediately
-        conversation.commit(true);
-
+       
         dirty.setDirty(false);
         EventUtility.postEvent(WorkbenchEventConstants.REFRESH_NAVIGATOR, new TaxonNodeDto(input.getTaxonNode().getParent()));
         EventUtility.postEvent(WorkbenchEventConstants.SAVE_TAXON, true);
@@ -444,8 +416,6 @@ public class TaxonNameEditorE4
         }
 
         this.input = input;
-        conversation = input.getConversationHolder();
-
         createOrUpdateNameComposites(true, true, true);
 
         createDragSupport();
@@ -547,10 +517,6 @@ public class TaxonNameEditorE4
 
     @PreDestroy
     public void dispose() {
-        if (conversation != null) {
-            conversation.unregisterForDataStoreChanges(this);
-            conversation.close();
-        }
         if (input != null) {
             input.dispose();
         }
index 0ac5711f15d3570fa2faa456f0b16399794571bb..733c22271eacd53d9e48332324cf170a0329005c 100644 (file)
@@ -105,15 +105,13 @@ public class NameEditorDropTargetListenerE4 extends DropTargetAdapter {
                                        return null;
                                    }
                                 } else{
-                    getEditor().getConversationHolder().commit();
-                    ((TaxonNameEditorE4) target).getConversationHolder().commit();
-                    UUID newSecUuid = null;
-                    try{
-                        newSecUuid = getNewSecRef(synonym);
-                    }catch (Exception e){
-                        return null;
-                    }
-                    return new MoveSynonymToAnotherAcceptedTaxonOperationE4(Messages.NameEditorDropTargetListener_CHANGE_ACC_TAXON, getEditor().getUndoContext(), synonym.getUuid(), ((TaxonNameEditorE4) target).getTaxon(), newSecUuid, (TaxonNameEditorE4) target, (TaxonNameEditorE4) target);
+                                        UUID newSecUuid = null;
+                                        try{
+                                                newSecUuid = getNewSecRef(synonym);
+                                        }catch (Exception e){
+                                                return null;
+                                        }
+                                        return new MoveSynonymToAnotherAcceptedTaxonOperationE4(Messages.NameEditorDropTargetListener_CHANGE_ACC_TAXON, getEditor().getUndoContext(), synonym.getUuid(), ((TaxonNameEditorE4) target).getTaxon(), newSecUuid, (TaxonNameEditorE4) target);
 
                 }
 
@@ -127,15 +125,13 @@ public class NameEditorDropTargetListenerE4 extends DropTargetAdapter {
                                        return new ChangeHomotypicGroupOperation(Messages.NameEditorDropTargetListener_CHANGE_HOMOTYPICAL_GROUP, getEditor().getUndoContext(),
                                                ((TaxonNameEditorE4) target).getTaxon(), synonym, null, target);
                                } else{
-                                       getEditor().getConversationHolder().commit();
-                                       ((TaxonNameEditorE4) target).getConversationHolder().commit();
                                        UUID newSecUuid = null;
                                        try{
                                            newSecUuid = getNewSecRef(synonym);
                                        }catch (Exception e){
                                            return null;
                                        }
-                                       return new MoveSynonymToAnotherAcceptedTaxonOperationE4(Messages.NameEditorDropTargetListener_CHANGE_ACC_TAXON, getEditor().getUndoContext(), synonym.getUuid(), ((TaxonNameEditorE4) target).getTaxon(), newSecUuid, (TaxonNameEditorE4) target, (TaxonNameEditorE4) target);
+                                       return new MoveSynonymToAnotherAcceptedTaxonOperationE4(Messages.NameEditorDropTargetListener_CHANGE_ACC_TAXON, getEditor().getUndoContext(), synonym.getUuid(), ((TaxonNameEditorE4) target).getTaxon(), newSecUuid, (TaxonNameEditorE4) target);
 
                                }
                        }
index ee8b44617e9a9ddd4126531ff4a9c693bff40506..d022b3dbfacb75e3d8b0540f96c355d4ad7dce07 100644 (file)
@@ -95,8 +95,7 @@ public class ChangeSynonymToAcceptedTaxonHandlerE4 implements IPostOperationEnab
                // Get taxon
                Taxon taxon = input.getTaxon();
 
-               TaxonNode newParentNode = TaxonNodeSelectionDialog.select(shell,// editor.getConversationHolder(),
-                       Messages.ChangeSynonymToAcceptedTaxonHandler_SELECT_PARENT, null, null, input.getTaxonNode().getClassification().getUuid(), true);
+               TaxonNode newParentNode = TaxonNodeSelectionDialog.select(shell, Messages.ChangeSynonymToAcceptedTaxonHandler_SELECT_PARENT, null, null, input.getTaxonNode().getClassification().getUuid(), true);
 
                if(newParentNode != null){
                    Reference parentSecRef = newParentNode.getTaxon() != null? newParentNode.getTaxon().getSec(): null;
@@ -159,7 +158,7 @@ public class ChangeSynonymToAcceptedTaxonHandlerE4 implements IPostOperationEnab
                        ChangeSynonymToAcceptedTaxonOperation operation = new ChangeSynonymToAcceptedTaxonOperation(Messages.ChangeSynonymToAcceptedTaxonHandler_CHANGE_SYN_TO_ACC_TAXON, EditorUtil.getUndoContext(),
                                        taxon, newParentNode, synonym,
                                        newSecUuid, secHandling,
-                                       this, editor, editor.getEditorInput()); //$NON-NLS-1$
+                                       this, editor.getEditorInput()); //$NON-NLS-1$
 
                        AbstractUtility.executeOperation(operation, sync);
                }
index 98d47070c32a358288c5e851e5bfe5c42e7acb42..c417056e0560d25bfbdd06ec688fb66139f744fb 100644 (file)
@@ -122,7 +122,7 @@ public class MoveSynonymToAnotherAcceptedTaxonHandlerE4 implements IPostOperatio
         }
                if(newParentNode!=null){
                   MoveSynonymToAnotherAcceptedTaxonOperationE4 operation = new MoveSynonymToAnotherAcceptedTaxonOperationE4(Messages.MoveSynonymToAnotherAcceptedTaxonHandler_CHANGE_ACC_TAXON, EditorUtil.getUndoContext(),
-                           synonym.getUuid(), newParentNode.getTaxon(),newSecUuid, this, editor);
+                           synonym.getUuid(), newParentNode.getTaxon(),newSecUuid, this);
 
                    AbstractUtility.executeOperation(operation, sync);
                }
index ca25ea9a502f8976cb8314199845f3a97210a1db..e74b03664d609b38bc42509eac8e9419c5c0a0ec 100644 (file)
@@ -12,7 +12,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
 import eu.etaxonomy.cdm.api.service.exception.HomotypicalGroupChangeException;
@@ -30,16 +29,15 @@ public class MoveSynonymToAnotherAcceptedTaxonOperationE4 extends
         * The synonym to be moved.
         */
        private final Synonym synonym;
-       private IConversationEnabled conversationEnabled;
        private UUID newSecUuid;
 
     public MoveSynonymToAnotherAcceptedTaxonOperationE4(String label, IUndoContext undoContext, UUID synonymUUID,
-            Taxon taxon, UUID newSecRefUuid, IPostOperationEnabled postOperationEnabled, IConversationEnabled conversationEnabled) {
+            Taxon taxon, UUID newSecRefUuid, IPostOperationEnabled postOperationEnabled) {
 
                super(label, undoContext, taxon, postOperationEnabled);
                List<String> propertyPaths =  new ArrayList<String>();
                propertyPaths.add("synonymRelations"); //$NON-NLS-1$
-               this.conversationEnabled = conversationEnabled;
+               
                this.element = (Taxon) CdmStore.getService(ITaxonService.class).load(taxon.getUuid(),propertyPaths);
                this.synonym = (Synonym) CdmStore.getService(ITaxonService.class).load(synonymUUID);
                this.newSecUuid = newSecRefUuid;
@@ -59,8 +57,6 @@ public class MoveSynonymToAnotherAcceptedTaxonOperationE4 extends
                monitor.beginTask("Move synonym to another taxon", 40);
                Taxon oldAccepted = synonym.getAcceptedTaxon();
 //             Reference secRef = CdmStore.getService(IReferenceService.class).load(newSecUuid);
-               conversationEnabled.getConversationHolder().commit();
-
                UpdateResult result = null;
                try {
                        result = CdmStore.getService(ITaxonService.class).moveSynonymToAnotherTaxon(synonym,
@@ -74,8 +70,6 @@ public class MoveSynonymToAnotherAcceptedTaxonOperationE4 extends
                        // TODO Auto-generated catch block
                        e.printStackTrace();
                }
-//             conversationEnabled.getConversationHolder().commit();
-
                monitor.worked(40);
                // Redraw editor if it exists
                Set<Taxon> taxa = new HashSet<>();
@@ -83,8 +77,6 @@ public class MoveSynonymToAnotherAcceptedTaxonOperationE4 extends
         taxa.add(oldAccepted);
 
         EditorUtil.updateNameEditors(taxa);
-//        ((TaxonNameEditorE4)EventUtility.getTaxonEditor()).getConversationHolder().commit();
-
 
                return postExecute(null);
        }
index fe5bc189f79dc154ff3e68d4bfdc13ffde63b242..16e75794645ca96a06cdc3c8dd9452c301a5d1c2 100644 (file)
@@ -17,7 +17,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
 import eu.etaxonomy.cdm.api.service.exception.HomotypicalGroupChangeException;
@@ -59,7 +58,6 @@ public class ChangeSynonymToAcceptedTaxonOperation extends AbstractPersistentPos
         * @param synonym a {@link eu.etaxonomy.cdm.model.taxon.Synonym} object.
         * @param synonymsInHomotypicalGroup an array of {@link eu.etaxonomy.cdm.model.taxon.Synonym} objects.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public ChangeSynonymToAcceptedTaxonOperation(String label,
                IUndoContext undoContext,
@@ -68,10 +66,9 @@ public class ChangeSynonymToAcceptedTaxonOperation extends AbstractPersistentPos
                        Synonym synonym,
                        UUID newSecUuid,
                SecReferenceHandlingEnum secHandling,
-                       IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
+                       IPostOperationEnabled postOperationEnabled,                     
                        ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+               super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
 
                this.element = taxon;
                this.parentNode = parentNode;
index 942abb4597397da40f5b142fa42468e638124b81..df39092fdf676375c57feb636c16f8080d82b1f6 100644 (file)
@@ -16,7 +16,6 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
 import eu.etaxonomy.cdm.api.application.ICdmRepository;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.api.service.config.TaxonBaseDeletionConfigurator;
 import eu.etaxonomy.cdm.api.service.config.TaxonDeletionConfigurator;
@@ -51,9 +50,9 @@ public class DeleteMisapplicationOperation extends DeleteTaxonBaseOperation {
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
         */
        public DeleteMisapplicationOperation(String label, IUndoContext undoContext, TaxonBaseDeletionConfigurator configurator,
-            Taxon taxon, Taxon misapplication, IPostOperationEnabled postOperationEnabled, IConversationEnabled conversationEnabled,ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               //super(label, undoContext, taxon, postOperationEnabled);
-           super(label, undoContext, configurator, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+            Taxon taxon, Taxon misapplication, IPostOperationEnabled postOperationEnabled, ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
+
+           super(label, undoContext, configurator, postOperationEnabled, cdmEntitySessionEnabled);
                this.misapplication = misapplication;
                this.element = taxon;
        }
index 662820d042d8b05d5ea055ab874ed2c9b76c61ff..3e6be8751a910e79323aaa574d05d6362a8189af 100644 (file)
@@ -17,7 +17,6 @@ import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 
 import eu.etaxonomy.cdm.api.application.ICdmRepository;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.DeleteResult;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.api.service.config.TaxonBaseDeletionConfigurator;
@@ -50,8 +49,8 @@ public class DeleteSynonymOperation extends DeleteTaxonBaseOperation {
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
         */
        public DeleteSynonymOperation(String label, IUndoContext undoContext, TaxonBaseDeletionConfigurator configurator,
-                       Taxon taxon, Synonym synonym, IPostOperationEnabled postOperationEnabled, IConversationEnabled conversationEnabled,ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, configurator, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+                       Taxon taxon, Synonym synonym, IPostOperationEnabled postOperationEnabled,  ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
+               super(label, undoContext, configurator, postOperationEnabled, cdmEntitySessionEnabled);
                this.synonym = synonym;
                this.element = taxon;
        }
index 997a5b45f86a0f3489b112a43383ae0f143e9886..fa585c7787a585afd6c27870a1942e7ed52665ef 100644 (file)
@@ -6,7 +6,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;\r
 import org.eclipse.core.runtime.IStatus;\r
 \r
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;\r
 import eu.etaxonomy.cdm.api.service.DeleteResult;\r
 import eu.etaxonomy.cdm.api.service.config.TaxonBaseDeletionConfigurator;\r
 import eu.etaxonomy.taxeditor.operation.AbstractPersistentPostOperation;\r
@@ -22,9 +21,8 @@ public class DeleteTaxonBaseOperation extends AbstractPersistentPostOperation {
                IUndoContext undoContext,\r
                TaxonBaseDeletionConfigurator configurator,\r
                IPostOperationEnabled postOperationEnabled,\r
-               IConversationEnabled conversationEnabled,\r
                ICdmEntitySessionEnabled cdmEntitySessionEnabled) {\r
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);\r
+               super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);\r
                this.configurator = configurator;\r
 \r
        }\r
index 32aa57761be1c2ab194381f3604438677d7859da..010855dc2b5d414a220560aa1f8fc4df5763b985 100644 (file)
@@ -42,8 +42,6 @@ public class ChecklistEditorInput extends CdmEntitySessionInput<TaxonNode> imple
 
     private Classification classification = null;
 
-    private final ConversationHolder conversation;
-
     private List<TaxonBase> taxaToSave = new ArrayList<>();
 
 
@@ -54,7 +52,6 @@ public class ChecklistEditorInput extends CdmEntitySessionInput<TaxonNode> imple
      */
     public ChecklistEditorInput(TaxonNode taxonNode){
         super(false);
-        this.conversation = CdmStore.createConversation();
         initSession();
         this.taxonNode =CdmStore.getService(ITaxonNodeService.class).load(taxonNode.getUuid(), getTaxonNodePropertyPaths());
         getChildTaxa(taxonNode);
@@ -79,7 +76,6 @@ public class ChecklistEditorInput extends CdmEntitySessionInput<TaxonNode> imple
      */
     public ChecklistEditorInput(Classification classification) {
         super(true);
-        this.conversation = CdmStore.createConversation();
         initSession();
         this.classification = CdmStore.getCurrentApplicationConfiguration().getClassificationService().load(classification.getUuid());
         getChildTaxa(classification.getRootNode());
@@ -106,19 +102,6 @@ public class ChecklistEditorInput extends CdmEntitySessionInput<TaxonNode> imple
        return classification;
     }
 
-//    public ConversationHolder getConversationHolder() {
-//        return conversationHolder;
-//    }
-
-//    @Override
-//    public int hashCode() {
-//        final int prime = 31;
-//        int result = 1;
-//        result = prime * result + ((classification == null) ? 0 : classification.hashCode());
-//        result = prime * result + ((taxonNode == null) ? 0 : taxonNode.hashCode());
-//        return result;
-//    }
-
     @Override
     public boolean equals(Object obj) {
         if (this == obj) {
@@ -167,7 +150,7 @@ public class ChecklistEditorInput extends CdmEntitySessionInput<TaxonNode> imple
     }
 
     public ConversationHolder getConversation() {
-        return conversation;
+        return null;
     }
 
     private List<String> getTaxonNodePropertyPaths() {
index 86db330609de2321be655fe53dc88f3caa0ca6c0..a993062a3892561feb7810ebef1778d375596ce1 100755 (executable)
@@ -34,8 +34,6 @@ import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
 import org.eclipse.swt.custom.StackLayout;
 import org.eclipse.swt.widgets.Composite;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IDescriptionService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
@@ -66,7 +64,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @since 28.11.2018
  */
 public class DistributionEditorPart
-        implements IE4SavablePart, IConversationEnabled, IDirtyMarkable,
+        implements IE4SavablePart, IDirtyMarkable,
                        ICdmEntitySessionEnabled<DescriptionBase>, IPartContentHasSupplementalData,
                        IPartContentHasDetails, IDistributionEditorPart {
 
@@ -86,8 +84,6 @@ public class DistributionEditorPart
 
     private Collection<Taxon> rootEntities;
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     @Inject
@@ -111,9 +107,6 @@ public class DistributionEditorPart
 
     @PostConstruct
     public void create(Composite parent, IEclipseContext context) {
-        if(CdmStore.isActive() && conversation==null){
-            conversation = CdmStore.createConversation();
-        }
         if(cdmEntitySession == null){
             cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
         }
@@ -165,9 +158,6 @@ public class DistributionEditorPart
 
     @Focus
     public void setFocus(){
-        if(conversation!=null){
-            conversation.bind();
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -179,17 +169,10 @@ public class DistributionEditorPart
         return editor;
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-        // TODO Auto-generated method stub
-    }
+   
 
     @PreDestroy
     public void dispose(){
-        if (conversation != null) {
-            conversation.close();
-            conversation = null;
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -226,12 +209,7 @@ public class DistributionEditorPart
     public void forceDirty() {
         // TODO Auto-generated method stub
     }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
+    
     @Persist
     @Override
     public void save(IProgressMonitor monitor) {
@@ -264,7 +242,7 @@ public class DistributionEditorPart
             cdmEntitySession.load(editor.getDefaultSource(), true);
         }
         editor.createTaxonDistributionMap();
-        conversation.commit();
+        
         this.dirty.setDirty(false);
         editor.getDescriptionsToSave().clear();
     }
index a552d4b0257af123984814d3cc23ebe6189203d6..7d19640e675f95b3e71ef4fb6f471737dc3e3042 100644 (file)
@@ -65,10 +65,10 @@ public class CreateConceptRelationHandlerE4 {
             editor = (TaxonNameEditorE4) e4WrappedPart;
 
             IUndoContext undoContext = null;
-            ConversationHolder conversationHolder = null;
+            
             Taxon taxon = null;
             taxon = editor.getTaxon();
-            conversationHolder = editor.getConversationHolder();
+            
             undoContext = editor.getUndoContext();
 
             //FIXME should this also be enabled for bulk editor
@@ -80,9 +80,7 @@ public class CreateConceptRelationHandlerE4 {
             //             undoContext = bulkEditor.getUndoContext();
             //         }
 
-            Taxon relatedConcept = TaxonSelectionDialog.selectTaxon(shell, //conversationHolder,
-                    taxon);
-
+            Taxon relatedConcept = TaxonSelectionDialog.selectTaxon(shell, taxon);
 
             if(relatedConcept == null){
                 return;
index 6e6b5f6b045ee00eb71ac1354ce6d3060e5eedfe..acd054c6c6917649319287c3c4d7a7d5ae728ea6 100644 (file)
@@ -63,7 +63,6 @@ import org.eclipse.ui.IMemento;
 import org.eclipse.ui.ide.undo.WorkspaceUndoUtil;
 
 import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IOccurrenceService;
 import eu.etaxonomy.cdm.api.service.ITaxonService;
 import eu.etaxonomy.cdm.hibernate.HibernateProxyHelper;
@@ -102,7 +101,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
 /**
  * Displays the derivate hierarchy of the specimen specified in the editor input.
  */
-public class DerivateView implements IPartContentHasFactualData, IConversationEnabled,
+public class DerivateView implements IPartContentHasFactualData, 
         ICdmEntitySessionEnabled<SpecimenOrObservationBase<?>>, IDirtyMarkable, IPostOperationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, IPartContentHasMedia,
         IContextListener, IE4SavablePart, ICollapsableExpandable {
 
@@ -131,10 +130,7 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
     });
 
        private static final int WARN_THRESHOLD = 200;
-
-
-       private ConversationHolder conversation;
-
+       
        private TreeViewer viewer;
 
     private final int dndOperations = DND.DROP_MOVE;
@@ -207,9 +203,6 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
     public void createPartControl(Composite parent, EMenuService menuService,
             IEclipseContext context) {
         if (CdmStore.isActive()){
-            if(conversation == null){
-                conversation = CdmStore.createConversation();
-            }
             if(cdmEntitySession == null){
                 cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
             }
@@ -241,7 +234,7 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
         contentProvider = new DerivateContentProvider();
         viewer.setContentProvider(contentProvider);
         labelProvider = new DerivateLabelProvider();
-        labelProvider.setConversation(conversation);
+        
         viewer.setLabelProvider(labelProvider);
         viewer.getTree().setEnabled(CdmStore.isActive());
 
@@ -265,35 +258,32 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
     }
 
     public void updateRootEntities(Collection<UUID> derivativeUuids) {
-        if(conversation!=null){
-            if (!conversation.isBound()) {
-                conversation.bind();
-            }
-            /*
-             * If the active session is not the session of the Derivative Editor
-             * then we will save the active session for later, bind temporarily
-             * to our session and rebind to the original session when we are
-             * done. This happens e.g. if a selection change happens in the
-             * taxon editor and "Link with editor" is enabled. The selection
-             * change event and thus the loading in updateRootEntities() happens
-             * in the session of the taxon editor.
-             */
-            ICdmEntitySession previousCdmEntitySession = CdmStore.getCurrentSessionManager().getActiveSession();
-            if(cdmEntitySession != null) {
-                cdmEntitySession.bind();
-            }
-            eventBroker.post(WorkbenchEventConstants.CURRENT_ACTIVE_EDITOR, null);
-            List<SpecimenOrObservationBase> derivates = null;
-            if(derivativeUuids!=null){
-                this.derivateToRootEntityMap = new HashMap<>();
-                this.rootElements = new HashSet<>();
-                derivates = CdmStore.getService(IOccurrenceService.class).load(new ArrayList(derivativeUuids), SPECIMEN_INIT_STRATEGY);
-            }
-            updateRootEntities(derivates);
-            if(previousCdmEntitySession!=null){
-                previousCdmEntitySession.bind();
-            }
+        
+        /*
+         * If the active session is not the session of the Derivative Editor
+         * then we will save the active session for later, bind temporarily
+         * to our session and rebind to the original session when we are
+         * done. This happens e.g. if a selection change happens in the
+         * taxon editor and "Link with editor" is enabled. The selection
+         * change event and thus the loading in updateRootEntities() happens
+         * in the session of the taxon editor.
+         */
+        ICdmEntitySession previousCdmEntitySession = CdmStore.getCurrentSessionManager().getActiveSession();
+        if(cdmEntitySession != null) {
+            cdmEntitySession.bind();
+        }
+        eventBroker.post(WorkbenchEventConstants.CURRENT_ACTIVE_EDITOR, null);
+        List<SpecimenOrObservationBase> derivates = null;
+        if(derivativeUuids!=null){
+            this.derivateToRootEntityMap = new HashMap<>();
+            this.rootElements = new HashSet<>();
+            derivates = CdmStore.getService(IOccurrenceService.class).load(new ArrayList(derivativeUuids), SPECIMEN_INIT_STRATEGY);
+        }
+        updateRootEntities(derivates);
+        if(previousCdmEntitySession!=null){
+            previousCdmEntitySession.bind();
         }
+        
     }
 
     public void updateRootEntities(List<SpecimenOrObservationBase> derivates) {
@@ -366,17 +356,13 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
     public void save(IProgressMonitor monitor) {
         String taskName = Messages.DerivateView_SAVING_HIERARCHY;
         monitor.beginTask(taskName, 3);
-        if (!conversation.isBound()) {
-            conversation.bind();
-            if (!cdmEntitySession.isActive()){
-                cdmEntitySession.bind();
-            }
+        
+        if (!cdmEntitySession.isActive()){
+               cdmEntitySession.bind();
         }
+        
         monitor.worked(1);
 
-        // commit the conversation and start a new transaction immediately
-        conversation.commit(true);
-
         for(AbstractPostOperation entry:operations){
             IStatus status = Status.CANCEL_STATUS;
             final IAdaptable uiInfoAdapter = WorkspaceUndoUtil
@@ -433,10 +419,8 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
 
     @Focus
     public void setFocus() {
-        //make sure to bind again if maybe in another view the conversation was unbound
-        if(conversation!=null && !conversation.isBound()){
-            conversation.bind();
-        }
+        //make sure to bind again if maybe in another view the session was unbound
+        
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -446,15 +430,6 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
         }
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
     @Override
     public void changed(Object element) {
         setDirty(true);
@@ -565,11 +540,7 @@ public class DerivateView implements IPartContentHasFactualData, IConversationEn
 
     @PreDestroy
     public void dispose() {
-        if(conversation!=null){
-            conversation.close();
-            conversation = null;
-        }
-        if(cdmEntitySession != null) {
+       if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
         }
index a33ef5b97035f17a33284bcbf6d0d50c31e7a949..8ce16d2b3fc25e1d3d4b98b86115d32e2edc2e26 100644 (file)
@@ -49,8 +49,7 @@ public abstract class AbstractAddDerivativeHandler {
 
     private void refreshView(DerivateView derivateView, Object createdElement) {
         if(derivateView!=null){
-            derivateView.getConversationHolder().commit();
-            derivateView.refreshTree(createdElement);
+               derivateView.refreshTree(createdElement);
         }
     }
 
index 66df9123f5a0c3d687980125cd23050d4efdc0e5..fadd15b4160c72c0190c2b41d4c4abd66e981cd3 100644 (file)
@@ -59,7 +59,6 @@ public class CreateFieldUnitHandler {
                 CdmStore.getService(ITaxonService.class).merge(taxon);
 
 
-                derivateView.getConversationHolder().commit();
                 derivateView.addFieldUnit(fieldUnit);
                 derivateView.updateRootEntities();
                 derivateView.refreshTree(fieldUnit);
@@ -73,7 +72,6 @@ public class CreateFieldUnitHandler {
             FieldUnit fieldUnit = FieldUnit.NewInstance();
             fieldUnit = CdmBase.deproxy(CdmStore.getService(IOccurrenceService.class).save(fieldUnit), FieldUnit.class);
 
-            derivateView.getConversationHolder().commit();
             derivateView.addFieldUnit(fieldUnit);
             derivateView.updateRootEntities();
             derivateView.refreshTree(fieldUnit);
index 707765445aa348abb24c4c40f119206b55e216b9..2f7e6a4d213a218be2ffdf037673b9d7c58a2ba2 100644 (file)
@@ -47,7 +47,6 @@ public class SingleReadReuseHandler {
             sequence.addSingleRead(singleRead);
             CdmStore.getService(ISequenceService.class).merge(sequence);
 
-            derivateView.getConversationHolder().commit();
             derivateView.refreshTree();
             LocalSelectionTransfer.getTransfer().setSelection(null);
         }
index fe4de88ffb8cc9ed70b74bf26cc91c26cde7fbf8..541924edfbb908670644c6db3d57c974bdcc5f75 100644 (file)
@@ -77,7 +77,6 @@ public class MoveDerivateOperation extends AbstractPostOperation<CdmBase>  {
                 derivateView.remove(draggedNode.getValue());
             }
             //update DerivateView
-            derivateView.getConversationHolder().commit();
             LocalSelectionTransfer.getTransfer().setSelection(null);
             return postExecute(null);
         }
index 7082e5a74f5ef9c85892cd4cd72239bb58762981..b6a895537ac49b896ee191cacf1a7faaa37b30d2 100644 (file)
@@ -123,8 +123,7 @@ public class DerivateSearchCompositeController implements Listener{
             searchDerivates();
         }
         else if(eventSource==derivateSearchComposite.getBtnBrowseTaxa()){
-            selectedTaxon = SelectionDialogFactory.getSelectionFromDialog(Taxon.class, this.derivateSearchComposite.getShell(), //derivativeEditor.getConversationHolder(),
-                    null);
+            selectedTaxon = SelectionDialogFactory.getSelectionFromDialog(Taxon.class, this.derivateSearchComposite.getShell(), null);
             if(selectedTaxon!=null){
                 derivateSearchComposite.getTextTaxonName().setText(selectedTaxon.getTitleCache());
             }
@@ -187,9 +186,7 @@ public class DerivateSearchCompositeController implements Listener{
         selectedTaxon = null;
     }
 
-    public void setConversation(ConversationHolder conversationHolder) {
-        labelProvider.setConversation(conversationHolder);
-    }
+   
 
     public void setTaxonFilter(UUID taxonUuid) {
         TaxonBase taxonBase = CdmStore.getService(ITaxonService.class).load(taxonUuid);
index 056573c58e6e0ecc30c38344e4c2cd8337b14844..7c0efa28bb77b9ab16b5304aafccaf7921a10aa5 100644 (file)
@@ -195,8 +195,6 @@ public class MoveDescriptionElementsHandlerE4 implements IPostOperationEnabled{
     @Override
     public boolean postOperation(Object objectAffectedByOperation) {
 
-        editor.getConversationHolder().bind();
-        editor.getConversationHolder().commit(true);
         Display.getDefault().asyncExec(new Runnable(){
 
             @Override
index b9d086078dc3be4e85ff485958e2e9db3aa96cbd..e05b54e1bd02851c49567c1dfa66a30705e032aa 100755 (executable)
@@ -195,8 +195,6 @@ public class MoveDescriptionElementsSetNameInSourceHandlerE5 implements IPostOpe
     @Override
     public boolean postOperation(Object objectAffectedByOperation) {
 
-        editor.getConversationHolder().bind();
-        editor.getConversationHolder().commit(true);
         Display.getDefault().asyncExec(new Runnable(){
 
             @Override
index c1467c0e2c9a11422184a350d4a9d9979259908d..360d2b61ed8b4bcfe043c9df65cdeb29f0f392ce 100644 (file)
@@ -108,7 +108,6 @@ public class MoveDescriptionToOtherTaxonHandlerE4 implements IPostOperationEnabl
         Set<UUID> excludeTaxa = new HashSet<>();
         excludeTaxa.add(oldAcceptedTaxonNodeUuid);
         TaxonNode newAcceptedTaxonNode = TaxonNodeSelectionDialog.select(shell,
-//                editor.getConversationHolder(),
                 Messages.MoveDescriptionToOtherTaxonHandler_CHOOSE_ACC_TAXON,
                 excludeTaxa,
                 node,
@@ -139,7 +138,6 @@ public class MoveDescriptionToOtherTaxonHandlerE4 implements IPostOperationEnabl
                     taxonDescription,
                     newAcceptedTaxonNode,
                     this,
-                    editor,
                     editor.getEditorInput(),
                     false);
             editor.getEditorInput().addOperation(operation);
index 97c4a56a2a19a9d03d213a035d5f2161256dfcc5..58887cc1c4419fb8f839546abceb56067472181c 100755 (executable)
@@ -108,7 +108,6 @@ public class MoveDescriptionToOtherTaxonSetNameInSourceHandlerE5 implements IPos
         Set<UUID> excludeTaxa = new HashSet<>();
         excludeTaxa.add(oldAcceptedTaxonNodeUuid);
         TaxonNode newAcceptedTaxonNode = TaxonNodeSelectionDialog.select(shell,
-//                editor.getConversationHolder(),
                 Messages.MoveDescriptionToOtherTaxonHandler_CHOOSE_ACC_TAXON,
                 excludeTaxa,
                 node,
@@ -139,7 +138,6 @@ public class MoveDescriptionToOtherTaxonSetNameInSourceHandlerE5 implements IPos
                     taxonDescription,
                     newAcceptedTaxonNode,
                     this,
-                    editor,
                     editor.getEditorInput(),
                     true);
             editor.getEditorInput().addOperation(operation);
index 864c2ff654de5846e894736c09d09819cd9eb91e..be45ffbba64d943c5c01436a2e6be76e46ce809d 100644 (file)
@@ -15,7 +15,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IDescriptionService;
 import eu.etaxonomy.cdm.model.description.TaxonDescription;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
@@ -47,17 +46,15 @@ public class MoveDescriptionToOtherTaxonOperation extends
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
         * @param description a {@link TaxonDescription} object.
         * @param targetTaxonNode a {@link eu.etaxonomy.cdm.model.taxon.TaxonNode} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public MoveDescriptionToOtherTaxonOperation(String label,
                        IUndoContext undoContext,
                        TaxonDescription description,
                        TaxonNode targetTaxonNode,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
-            ICdmEntitySessionEnabled cdmEntitySessionEnabled,
+                       ICdmEntitySessionEnabled cdmEntitySessionEnabled,
                boolean setNameInSource) {
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled); // FIXME is this the right constructor ???
+               super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled); // FIXME is this the right constructor ???
                this.description = description;
                this.setNameInSource = setNameInSource;
                this.newAcceptedTaxonNode = targetTaxonNode;
index d5b26cd1c3488c25e743f815b2a004e02b09c369..e6a8dcc21bea66a7662d4a89566b070f8db446b6 100644 (file)
@@ -37,7 +37,7 @@ public class DeleteMisapplicationOperationTest extends AbstractTaxeditorOperatio
 
                taxon.addMisappliedName(misapplication, null, null);
 
-               operation = new DeleteMisapplicationOperation("", undoContext, null, taxon, misapplication, postOperation,  null, null);
+               operation = new DeleteMisapplicationOperation("", undoContext, null, taxon, misapplication, postOperation,  null);
 
        }
 
index d46fe5849eccbc703df385e56870de73f3f5bc5a..b08f43b5e6f41c6011240acb6c2158f702a204fe 100644 (file)
@@ -40,7 +40,7 @@ public class DeleteSynonymOperationTest extends AbstractTaxeditorOperationTestBa
 
                taxon.addSynonym(synonym, synonymType);
 
-               operation = new DeleteSynonymOperation("", undoContext, new SynonymDeletionConfigurator(), taxon,synonym, postOperation, null, null);
+               operation = new DeleteSynonymOperation("", undoContext, new SynonymDeletionConfigurator(), taxon,synonym, postOperation, null);
 
        }
 
index 6ff0bc374f80a42871accb1dc203ea7b16b27bf6..ca9d5b67189d0d1e77d5989796924cf265917f04 100644 (file)
@@ -37,7 +37,6 @@ import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.commands.ICommandService;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.service.molecular.ISequenceService;
 import eu.etaxonomy.cdm.common.URI;
 import eu.etaxonomy.cdm.model.media.MediaUtils;
@@ -106,8 +105,7 @@ public class AlignmentEditorE4 {
        public static final String CONSENSUS_NAME = "Consensus"; //$NON-NLS-1$
 
 
-    private ConversationHolder conversationHolder;
-       private final AlignmentModelChangeListener DIRTY_LISTENER = new AlignmentModelChangeListener() {
+    private final AlignmentModelChangeListener DIRTY_LISTENER = new AlignmentModelChangeListener() {
                                @Override
                                public <T> void afterTokenChange(TokenChangeEvent<T> e) {
                                        setDirty();
@@ -318,7 +316,7 @@ public class AlignmentEditorE4 {
                for (SingleReadAlignment singleReadAlignment : sequenceNode.getSingleReadAlignments()) {
                        try {
                                SingleRead pherogramInfo = singleReadAlignment.getSingleRead();
-                               String id = addRead(DerivateLabelProvider.getDerivateText(pherogramInfo, conversationHolder),
+                               String id = addRead(DerivateLabelProvider.getDerivateText(pherogramInfo),
                                                getPherogramURI(pherogramInfo),
                                                singleReadAlignment.isReverseComplement(),
                                                singleReadAlignment.getEditedSequence(),
@@ -344,15 +342,7 @@ public class AlignmentEditorE4 {
 
     @PostConstruct
     public void createPartControl(Composite parent) {
-        if (CdmStore.isActive()){
-            if(conversationHolder == null){
-                conversationHolder = CdmStore.createConversation();
-            }
-        }
-        else{
-            return;
-        }
-        SWTComponentFactory.getInstance().getSWTComponent(getAlignmentsContainer(), parent, SWT.NONE);
+       SWTComponentFactory.getInstance().getSWTComponent(getAlignmentsContainer(), parent, SWT.NONE);
         Display.getCurrent().addFilter(SWT.FocusIn, ACTION_UPDATER);
         Display.getCurrent().addFilter(SWT.FocusOut, ACTION_UPDATER);
        }
@@ -365,10 +355,6 @@ public class AlignmentEditorE4 {
         CLIPBOARD.dispose();
         input.dispose();
 
-        if(conversationHolder!=null){
-            conversationHolder.close();
-            conversationHolder = null;
-        }
         if(input!=null){
             input.dispose();
         }
@@ -444,14 +430,9 @@ public class AlignmentEditorE4 {
             }
         }
 
-        if (!conversationHolder.isBound()) {
-            conversationHolder.bind();
-        }
         monitor.worked(1);
 
         input.merge();
-        // Commit the conversation and start a new transaction immediately:
-        conversationHolder.commit(true);
         monitor.worked(1);
 
         dirty.setDirty(false);
@@ -491,9 +472,6 @@ public class AlignmentEditorE4 {
 
     @Focus
     public void setFocus() {
-        if(conversationHolder != null){
-            conversationHolder.bind();
-        }
         if(input!=null){
             input.bind();
         }
@@ -20,7 +20,7 @@ import eu.etaxonomy.cdm.model.description.PolytomousKey;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeEvent;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeEvent.EventType;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
-import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour;
+import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour_;
 import eu.etaxonomy.taxeditor.navigation.l10n.Messages;
 
 /**
@@ -29,13 +29,13 @@ import eu.etaxonomy.taxeditor.navigation.l10n.Messages;
  * @since Sep 28, 2017
  *
  */
-public class PolytomousKeyViewPartDataChangeBehaviorE4 extends
-               AbstractDataChangeBehaviour {
+public class PolytomousKeyViewPartDataChangeBehaviorE4_ extends
+               AbstractDataChangeBehaviour_ {
 
     private static final String UPDATING_POLYTOMOUS_KEY_VIEWER = Messages.PolytomousKeyViewPartDataChangeBehavior_UPDATE;
     private final PolytomousKeyViewPartE4 source;
 
-       public PolytomousKeyViewPartDataChangeBehaviorE4(
+       public PolytomousKeyViewPartDataChangeBehaviorE4_(
                        PolytomousKeyViewPartE4 polytomousKeyViewPart) {
                source = polytomousKeyViewPart;
        }
@@ -56,7 +56,7 @@ public class PolytomousKeyViewPartDataChangeBehaviorE4 extends
                                        display.asyncExec(new Runnable() {
                                                 @Override
                         public void run() {
-                                                        source.getConversationHolder().clear();
+//                                                      source.getConversationHolder().clear();
                                                 }
                                        });
                                        // FIXME completely clearing the session is a brute force approach.
index f3ade0f40e85d1820cb6787c7105b0d7c3d39381..b02a7f700dd432979a867b8de3d6cd0c9acbf11d 100644 (file)
@@ -49,13 +49,9 @@ import eu.etaxonomy.cdm.api.application.CdmChangeEvent;
 import eu.etaxonomy.cdm.api.application.CdmChangeEvent.Action;
 import eu.etaxonomy.cdm.api.application.ICdmChangeListener;
 import eu.etaxonomy.cdm.api.application.ICdmDataChangeService;
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IPolytomousKeyService;
 import eu.etaxonomy.cdm.model.description.PolytomousKey;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.model.ContextListenerAdapter;
-import eu.etaxonomy.taxeditor.model.DataChangeBridge;
 import eu.etaxonomy.taxeditor.model.IContextListener;
 import eu.etaxonomy.taxeditor.model.MessagingUtils;
 import eu.etaxonomy.taxeditor.navigation.key.polytomous.PolytomousKeyContentProvider;
@@ -71,7 +67,7 @@ import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
  * @since Sep 28, 2017
  */
 public class PolytomousKeyViewPartE4 implements
-               IConversationEnabled, ICdmEntitySessionEnabled<PolytomousKey>, IPostOperationEnabled,
+               ICdmEntitySessionEnabled<PolytomousKey>, IPostOperationEnabled,
                ICdmChangeListener {
 
     private class FilterModifyListener implements ModifyListener{
@@ -120,13 +116,12 @@ public class PolytomousKeyViewPartE4 implements
     }
 
     private ListViewer viewer;
-    private ConversationHolder conversation;
     private IContextListener contextListener;
     private final CdmFormFactory formFactory;
     private Text text_filter;
     private ICdmEntitySession cdmEntitySession;
 
-    private PolytomousKeyViewPartDataChangeBehaviorE4 dataChangeBehavior;
+    //private PolytomousKeyViewPartDataChangeBehaviorE4 dataChangeBehavior;
 
 
     @Inject
@@ -207,8 +202,6 @@ public class PolytomousKeyViewPartE4 implements
     }
 
     private void setInput() {
-        conversation = CdmStore.createConversation();
-        conversation.registerForDataStoreChanges(this);
         cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
         CdmApplicationState.getCurrentDataChangeService().register(this);
 
@@ -228,29 +221,11 @@ public class PolytomousKeyViewPartE4 implements
         }
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-        if (dataChangeBehavior == null) {
-            dataChangeBehavior = new PolytomousKeyViewPartDataChangeBehaviorE4(this);
-        }
-
-        DataChangeBridge.handleDataChange(changeEvents, dataChangeBehavior);
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
     @PreDestroy
     public void dispose() {
-        if(conversation!=null){
-            conversation.unregisterForDataStoreChanges(this);
-            conversation.close();
-            CdmStore.getContextManager().removeContextListener(contextListener);
-            conversation = null;
-        }
+        
         if(cdmEntitySession != null) {
+               CdmStore.getContextManager().removeContextListener(contextListener);
             cdmEntitySession.dispose();
             cdmEntitySession = null;
         }
@@ -262,8 +237,6 @@ public class PolytomousKeyViewPartE4 implements
 
     @Override
     public boolean postOperation(Object objectAffectedByOperation) {
-        getConversationHolder().bind();
-        getConversationHolder().commit(true);
         viewer.refresh();
         return true;
     }
@@ -274,9 +247,6 @@ public class PolytomousKeyViewPartE4 implements
     }
 
     public void refresh() {
-        getConversationHolder().bind();
-        //FIXME : Need to make sure this is a stable fix (ticket 3822)
-        getConversationHolder().commit();
         List<PolytomousKey> input = CdmStore.getService(IPolytomousKeyService.class).list(PolytomousKey.class, null, null, null, null);
         if(!viewer.getControl().isDisposed()){
             viewer.setInput(input);
index 7df83b76449801d93e8cb8613febc614707e0fe0..a465f8cc2484ced7d14c71260406871746374f0d 100644 (file)
@@ -16,7 +16,6 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.jface.dialogs.MessageDialog;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.DeleteResult;
 import eu.etaxonomy.cdm.api.service.IPolytomousKeyService;
 import eu.etaxonomy.cdm.model.description.PolytomousKey;
@@ -45,9 +44,8 @@ public class DeleteOperation extends AbstractPersistentPostOperation {
        public DeleteOperation(String label, IUndoContext undoContext,
                        PolytomousKey key,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
                        ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+               super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
                this.key = key;
                this.cdmEntitySessionEnabled = cdmEntitySessionEnabled;
        }
index daf9c589b35c72172e3827e9755f75a04395710e..681a055f651489a9a731fbba94b842f32578408e 100644 (file)
@@ -27,7 +27,7 @@ public class EmptyRoot extends Root {
         * <p>Constructor for EmptyRoot.</p>
         */
        public EmptyRoot() {
-               super(null);
+               super();
        }
 
        /**
index 93b9386818d69b7b6eddf0f62e7f30930dfa7d32..a0b39726079f122dbecef424c4e668329083c04e 100644 (file)
@@ -19,8 +19,6 @@ import org.eclipse.ui.IElementFactory;
 import org.eclipse.ui.IMemento;
 import org.eclipse.ui.IPersistableElement;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.model.taxon.Classification;
 import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
@@ -34,9 +32,9 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @created 02.06.2009
  * @version 1.0
  */
-public class Root extends PlatformObject implements IAdaptable, IPersistableElement, IElementFactory, IConversationEnabled {
+public class Root extends PlatformObject implements IAdaptable, IPersistableElement, IElementFactory {
 
-       private final ConversationHolder conversation;
+//     private final ConversationHolder conversation;
        private List<TaxonNodeDto> rootNodes = new ArrayList<>();
 
        /**
@@ -44,8 +42,8 @@ public class Root extends PlatformObject implements IAdaptable, IPersistableElem
         *
         * @param conversation a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
         */
-       public Root (ConversationHolder conversation){
-               this.conversation = conversation;
+       public Root () {//ConversationHolder conversation){
+//             this.conversation = conversation;
        }
 
        /**
@@ -108,20 +106,7 @@ public class Root extends PlatformObject implements IAdaptable, IPersistableElem
                return null;
        }
 
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.persistence.hibernate.ICdmPostDataChangeObserver#update(eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap)
-        */
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {}
-
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.api.conversation.IConversationEnabled#getConversationHolder()
-        */
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
+               
        public void addRootNode(Classification newClassification){
            newClassification = CdmStore.getService(IClassificationService.class).load(newClassification.getUuid());
            boolean exist = false;
@@ -26,7 +26,7 @@ import eu.etaxonomy.cdm.model.taxon.Taxon;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeEvent;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeEvent.EventType;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
-import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour;
+import eu.etaxonomy.taxeditor.model.AbstractDataChangeBehaviour_;
 import eu.etaxonomy.taxeditor.model.IDataChangeBehavior;
 import eu.etaxonomy.taxeditor.navigation.l10n.Messages;
 
@@ -37,7 +37,7 @@ import eu.etaxonomy.taxeditor.navigation.l10n.Messages;
  * @created 01.04.2009
  * @version 1.0
  */
-public class TaxonNavigatorDataChangeBehaviorE4 extends AbstractDataChangeBehaviour implements
+public class TaxonNavigatorDataChangeBehaviorE4_ extends AbstractDataChangeBehaviour_ implements
                IDataChangeBehavior {
 
     private static final String UPDATING_TAXON_NAVIGATOR = Messages.TaxonNavigatorDataChangeBehavior_UPDATE_NAVIGATOR;
@@ -51,7 +51,7 @@ public class TaxonNavigatorDataChangeBehaviorE4 extends AbstractDataChangeBehavi
         *
         * @param taxonNavigator a {@link eu.etaxonomy.taxeditor.navigation.navigator.TaxonNavigator} object.
         */
-       public TaxonNavigatorDataChangeBehaviorE4(TaxonNavigatorE4 taxonNavigator) {
+       public TaxonNavigatorDataChangeBehaviorE4_(TaxonNavigatorE4 taxonNavigator) {
                source = taxonNavigator;
        }
 
@@ -155,7 +155,9 @@ public class TaxonNavigatorDataChangeBehaviorE4 extends AbstractDataChangeBehavi
                                        display.asyncExec(new Runnable() {
                                                 @Override
                                                 public void run() {
-                                                        source.getConversationHolder().clear();
+                                                        //TODO: check wether we can remove this
+                                                        
+                                                        //source.getConversationHolder().clear();
                                                 }
                                        });
                                        // FIXME completely clearing the session is a brute force approach.
index 6b36ee4147d7bb866a7606a4d9c95aee1b28651c..ebf20c4faf17003b7b58074f96744f0370fadeea 100644 (file)
@@ -59,8 +59,6 @@ import eu.etaxonomy.cdm.api.application.CdmApplicationState;
 import eu.etaxonomy.cdm.api.application.CdmChangeEvent;
 import eu.etaxonomy.cdm.api.application.CdmChangeEvent.Action;
 import eu.etaxonomy.cdm.api.application.ICdmChangeListener;
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -68,13 +66,11 @@ import eu.etaxonomy.cdm.model.common.ICdmBase;
 import eu.etaxonomy.cdm.model.taxon.Classification;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
 import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.editor.ITaxonEditor;
 import eu.etaxonomy.taxeditor.editor.name.e4.TaxonNameEditorE4;
 import eu.etaxonomy.taxeditor.event.EventUtility;
 import eu.etaxonomy.taxeditor.event.WorkbenchEventConstants;
 import eu.etaxonomy.taxeditor.model.AbstractUtility;
-import eu.etaxonomy.taxeditor.model.DataChangeBridge;
 import eu.etaxonomy.taxeditor.model.IContextListener;
 import eu.etaxonomy.taxeditor.model.IDataChangeBehavior;
 import eu.etaxonomy.taxeditor.navigation.AppModelId;
@@ -95,7 +91,7 @@ import eu.etaxonomy.taxeditor.workbench.part.ICollapsableExpandable;
  * @since Sep 7, 2017
  */
 public class TaxonNavigatorE4 implements
-               IPostOperationEnabled, IConversationEnabled, Observer,
+               IPostOperationEnabled, Observer,
                ICdmChangeListener, IContextListener,
                ICollapsableExpandable {
 
@@ -107,7 +103,7 @@ public class TaxonNavigatorE4 implements
 
        private final int dndOperations = DND.DROP_MOVE;
 
-       private ConversationHolder conversation;
+//     private ConversationHolder conversation;
 
        private IDataChangeBehavior dataChangeBehavior;
 
@@ -242,7 +238,7 @@ public class TaxonNavigatorE4 implements
                        // we do not preserve state. Closing the view, in contrary to
                        // closing the whole application
                        // should be handled by the state manager too
-                   root = new Root(conversation);
+                   root = new Root();
 
                        return root;
                }
@@ -250,10 +246,10 @@ public class TaxonNavigatorE4 implements
        }
 
        public void init() {
-               if (CdmStore.isActive() && conversation == null) {
-                       conversation = CdmStore.createConversation();
-                       conversation.registerForDataStoreChanges(TaxonNavigatorE4.this);
-               }
+//             if (CdmStore.isActive() && conversation == null) {
+//                     conversation = CdmStore.createConversation();
+//                     conversation.registerForDataStoreChanges(TaxonNavigatorE4.this);
+//             }
                if (CdmStore.isActive()) {
 //                 cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
                    CdmApplicationState.getCurrentDataChangeService().register(this);
@@ -310,13 +306,7 @@ public class TaxonNavigatorE4 implements
         * Refresh this navigators viewer
         */
        public void refresh() {
-               if(getConversationHolder() != null){
-                       getConversationHolder().bind();
-                       //FIXME : Need to make sure this is a stable fix (ticket 3822)
-                       if(!getConversationHolder().isCompleted()){
-                           getConversationHolder().commit();
-                       }
-               }
+               
                if(!viewer.getTree().isDisposed()){
                    if (CdmStore.isActive()){
 
@@ -354,7 +344,7 @@ public class TaxonNavigatorE4 implements
        }
 
        private void restore(IMemento memento, IProgressMonitor monitor) {
-           root = new Root(conversation);
+           root = new Root();//conversation);
                if (memento == null) {
                    viewer.setInput(root);
                        return;
@@ -380,9 +370,9 @@ public class TaxonNavigatorE4 implements
                subProgressMonitor.subTask(RESTORING_TAXON_NAVIGATOR);
                subProgressMonitor.worked(1);
 
-               conversation = CdmStore.createConversation();
+               //conversation = CdmStore.createConversation();
                subProgressMonitor.worked(1);
-               conversation.registerForDataStoreChanges(TaxonNavigatorE4.this);
+               //conversation.registerForDataStoreChanges(TaxonNavigatorE4.this);
                subProgressMonitor.worked(1);
                viewer.setInput(root);
                subProgressMonitor.worked(1);
@@ -444,18 +434,15 @@ public class TaxonNavigatorE4 implements
            viewer.expandAll();
        }
 
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
+       
 
        @PreDestroy
        public void dispose() {
                dataChangeBehavior = null;
-               if (conversation != null) {
-                       conversation.unregisterForDataStoreChanges(this);
-                       conversation.close();
-               }
+//             if (conversation != null) {
+//                     conversation.unregisterForDataStoreChanges(this);
+//                     conversation.close();
+//             }
                if(CdmApplicationState.getCurrentDataChangeService() != null) {
                    CdmApplicationState.getCurrentDataChangeService().unregister(this);
                }
@@ -463,9 +450,7 @@ public class TaxonNavigatorE4 implements
 
        @Focus
        public void setFocus() {
-               if (getConversationHolder() != null) {
-                       getConversationHolder().bind();
-               }
+
        }
 
     public UISynchronize getSync() {
@@ -498,16 +483,16 @@ public class TaxonNavigatorE4 implements
                }
        }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-        if (dataChangeBehavior == null) {
-            dataChangeBehavior = new TaxonNavigatorDataChangeBehaviorE4(this);
-        }
-
-        DataChangeBridge.handleDataChange(changeEvents, dataChangeBehavior);
-        updateSyncButton();
-
-    }
+//    @Override
+//    public void update(CdmDataChangeMap changeEvents) {
+//        if (dataChangeBehavior == null) {
+//            dataChangeBehavior = new TaxonNavigatorDataChangeBehaviorE4(this);
+//        }
+//
+//        DataChangeBridge.handleDataChange(changeEvents, dataChangeBehavior);
+//        updateSyncButton();
+//
+//    }
 
     public List<TaxonNodeDto> getRootEntities() {
         if(root != null) {
index 8bb116d1636222ad815d9842f39336e01c588ceb..5b5031bf787ac74e69b0463cc616fde10712583f 100644 (file)
@@ -61,7 +61,7 @@ public class CloneClassificationHandlerE4 {
 
             CloneClassificationOperation operation = new CloneClassificationOperation(Messages.CloneClassificationHandler_CLONE_CLASSIFICATION,
                     StoreUtil.getUndoContext(), classification, classificationName, reference, relationType,
-                    taxonNavigator, taxonNavigator);
+                    taxonNavigator);
 
             AbstractUtility.executeOperation(operation, sync);
             taxonNavigator.refresh();
index af27b35e4a05de68e66910f2c33cd12f5f745993..a588c5bf246cb0f709de3cc8e54c22a1f76f0a67 100644 (file)
@@ -41,7 +41,7 @@ public class CreateClassificationHierarchyHandlerE4 {
         if (selectedElement instanceof TaxonNode && !((TaxonNode)selectedElement).hasTaxon()) {
             Classification classification = ((TaxonNode) selectedElement).getClassification();
             try {
-                CreateNewTaxonHierarchyOperation operation = new CreateNewTaxonHierarchyOperation(Messages.CreateClassificationHierarchyHandler_CREATE_HIERARCHY, StoreUtil.getUndoContext(),classification, taxonNavigator, taxonNavigator);
+                CreateNewTaxonHierarchyOperation operation = new CreateNewTaxonHierarchyOperation(Messages.CreateClassificationHierarchyHandler_CREATE_HIERARCHY, StoreUtil.getUndoContext(),classification, taxonNavigator);
                 AbstractUtility.executeOperation(operation, sync);
                 taxonNavigator.refresh();
             } catch (Exception e) {
index 8ed66caac9991ab0ce3ce4eb284a2a98c561c6b4..8501dd22c4ce1019861a362ceecf470e454fe4ab 100644 (file)
@@ -145,7 +145,6 @@ public class DeleteHandlerE4 {
                                                                taxonNode,
                                                                config,
                                                                taxonNavigator,
-                                                               taxonNavigator,
                                                                null);
 
                                                AbstractUtility.executeOperation(operation, sync);
@@ -170,7 +169,6 @@ public class DeleteHandlerE4 {
                                                        treeNodes,
                                                        new TaxonDeletionConfigurator(),
                                                        taxonNavigator,
-                                                       taxonNavigator,
                                                        null);
 
                                        AbstractUtility.executeOperation(operation, sync);
index d5227c00cf2445af371c357b68977be02e833d7f..ed91db4e3369011bd5dc0380df9db76e4645c821 100644 (file)
@@ -20,7 +20,6 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
 import eu.etaxonomy.cdm.api.application.ICdmRepository;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.DeleteResult;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
@@ -55,15 +54,13 @@ public class DeleteOperation extends AbstractPersistentPostOperation{
      * @param label a {@link java.lang.String} object.
      * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
      * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-     * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
      * @param treeNodes a {@link java.util.Set} object.
      */
     public DeleteOperation(String label, IUndoContext undoContext,
             TaxonNodeDto taxonNode, TaxonDeletionConfigurator config,
             IPostOperationEnabled postOperationEnabled,
-            IConversationEnabled conversationEnabled,
             ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-        super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+        super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
         this.taxonNode = taxonNode;
         this.config = config;
         this.cdmEntitySessionEnabled = cdmEntitySessionEnabled;
@@ -75,15 +72,13 @@ public class DeleteOperation extends AbstractPersistentPostOperation{
      * @param label a {@link java.lang.String} object.
      * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
      * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-     * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
      * @param treeNodes a {@link java.util.Set} object.
      */
     public DeleteOperation(String label, IUndoContext undoContext,
             Set<TaxonNodeDto> treeNodes, TaxonDeletionConfigurator config,
             IPostOperationEnabled postOperationEnabled,
-            IConversationEnabled conversationEnabled,
             ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-        super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+        super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
         this.treeNodes = treeNodes;
         this.config = config;
         this.cdmEntitySessionEnabled = cdmEntitySessionEnabled;
index f56202746b692f1878d3e8b0b4aa818455f2b6a8..b5e20608f546c1c90e4292036f4ad526823be0e9 100644 (file)
@@ -14,7 +14,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.config.SubtreeCloneConfigurator;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
@@ -42,9 +41,8 @@ public class CloneClassificationOperation extends AbstractPersistentPostOperatio
 
     public CloneClassificationOperation(String label, IUndoContext undoContext, Classification classification,
             String classificationName, Reference sec, TaxonRelationshipType relationType,
-            IPostOperationEnabled postOperationEnabled,
-            IConversationEnabled conversationEnabled) {
-        super(label, undoContext, postOperationEnabled, conversationEnabled);
+            IPostOperationEnabled postOperationEnabled) {
+        super(label, undoContext, postOperationEnabled);
 
         this.classification = classification;
         this.classificationName = classificationName;
index 107b311faa6ae5545454baa70d75dff1429b1658..fa39d05fbaba6e937de7e9dbaa3167fa76067b89 100644 (file)
@@ -15,7 +15,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.model.reference.Reference;
 import eu.etaxonomy.cdm.model.reference.ReferenceFactory;
@@ -44,13 +43,11 @@ public class CreateClassification extends AbstractPersistentPostOperation {
         * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
         * @param classification a {@link eu.etaxonomy.cdm.model.taxon.TaxonomicTree} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public CreateClassification(String label, IUndoContext undoContext, Classification classification,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
                        ICdmEntitySessionEnabled cdmEntitiySessionEnabled) {
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitiySessionEnabled);
+               super(label, undoContext, postOperationEnabled, cdmEntitiySessionEnabled);
 
                this.classification = classification;
 
index 5d736690339ebaf98b82f16947f2bfc1498eea23..8d24a50aa5fada3b740bfeece7ef9923afaded6d 100644 (file)
@@ -16,7 +16,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IClassificationService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -43,9 +42,8 @@ public class CreateNewTaxonHierarchyOperation extends AbstractPersistentPostOper
      * @param undoContext
      */
     public CreateNewTaxonHierarchyOperation(String label, IUndoContext undoContext, Classification classification,
-            IPostOperationEnabled postOperationEnabled,
-            IConversationEnabled conversationEnabled) {
-        super(label, undoContext, postOperationEnabled, conversationEnabled);
+            IPostOperationEnabled postOperationEnabled) {
+        super(label, undoContext, postOperationEnabled);
 
         this.classification = classification;
         this.service = CdmStore.getService(IClassificationService.class);
index c64bc4da55f4451e887a46574395f278dafa7443..a30d278fe35531b3fbb452d548151647197e3062 100644 (file)
@@ -15,7 +15,6 @@ import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IPolytomousKeyService;
 import eu.etaxonomy.cdm.model.description.PolytomousKey;
 import eu.etaxonomy.taxeditor.operation.AbstractPersistentPostOperation;
@@ -43,9 +42,8 @@ public class CreatePolytomousKey extends AbstractPersistentPostOperation {
                        IUndoContext undoContext,
                        PolytomousKey key,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
                        ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+               super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
                this.key = key;
        }
 
index 67f4a13486f9fb7ef66e9fba646ae991e2ed4939..cf73f045f1d762f0b807e126ef2dd0bf42e55533 100644 (file)
@@ -15,7 +15,6 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITaxonNodeService;
 import eu.etaxonomy.cdm.model.name.TaxonName;
 import eu.etaxonomy.cdm.model.taxon.Taxon;
@@ -49,15 +48,13 @@ public class CreateTaxonNode extends AbstractPersistentPostOperation {
         * @param name a {@link eu.etaxonomy.cdm.model.name.TaxonNameBase} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
         * @param parentNode a {@link eu.etaxonomy.cdm.model.taxon.ITaxonTreeNode} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public CreateTaxonNode(String label,
                IUndoContext undoContext,
                TaxonNodeDto parentNode, TaxonName name,
                IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
-            ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, parentNode, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+                       ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
+               super(label, undoContext, parentNode, postOperationEnabled, cdmEntitySessionEnabled);
 
                newTaxon = Taxon.NewInstance(name, null);
        }
@@ -70,16 +67,14 @@ public class CreateTaxonNode extends AbstractPersistentPostOperation {
         * @param taxon a {@link eu.etaxonomy.cdm.model.taxon.Taxon} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
         * @param parentNode a {@link eu.etaxonomy.cdm.model.taxon.ITaxonTreeNode} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public CreateTaxonNode(String label,
                IUndoContext undoContext,
                TaxonNodeDto parentNode,
                Taxon taxon,
                IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
-            ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
-               super(label, undoContext, parentNode, postOperationEnabled, conversationEnabled, cdmEntitySessionEnabled);
+                       ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
+               super(label, undoContext, parentNode, postOperationEnabled, cdmEntitySessionEnabled);
 
                this.newTaxon = taxon;
        }
index 1775bc50bc14aa53f3e40042304dd823d15dd82e..b76e67ef5aacda017ee0ddc803cdc1d3cedeebdf 100644 (file)
@@ -43,8 +43,6 @@ import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.IMemento;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.config.IFindTaxaAndNamesConfigurator;
 import eu.etaxonomy.cdm.model.common.IdentifiableEntity;
 import eu.etaxonomy.cdm.persistence.dto.UuidAndTitleCache;
@@ -65,7 +63,7 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @since Sep 27, 2017
  *
  */
-public class SearchResultViewE4 implements IConversationEnabled{
+public class SearchResultViewE4 {
 
        private static Object[] EMPTY = new Object[0];
 
@@ -91,8 +89,6 @@ public class SearchResultViewE4 implements IConversationEnabled{
 
        private TableViewer resultViewer;
 
-       private ConversationHolder conversation;
-
        private Text searchString;
 
        private Text configurationLabel;
@@ -120,15 +116,7 @@ public class SearchResultViewE4 implements IConversationEnabled{
        /** {@inheritDoc} */
        @PostConstruct
        public void createPartControl(Composite parent, EMenuService menuService) {
-        if (CdmStore.isActive()){
-            if(conversation == null){
-                conversation = getConversation_internal();
-            }
-        }
-        else{
-            return;
-        }
-               contextListener = new ContextListener();
+               contextListener = new ContextListener();
                CdmStore.getContextManager().addContextListener(contextListener);
 
                GridLayout layout = new GridLayout();
@@ -261,55 +249,23 @@ public class SearchResultViewE4 implements IConversationEnabled{
        @Focus
        public void setFocus() {
                //logger.warn("Setting focus to search result viewer");
-               ConversationHolder conversation_internal = getConversation_internal();
-               if(conversation_internal!=null){
-                   conversation_internal.bind();
-               }
+               
                // pass focus to resultViewer
                if(resultViewer!=null && resultViewer.getControl()!=null && !resultViewer.getControl().isDisposed()){
                    resultViewer.getControl().setFocus();
                }
        }
 
-       /**
-        * <p>getConversationHolder</p>
-        *
-        * @return a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
-        */
-       @Override
-    public ConversationHolder getConversationHolder() {
-               return this.conversation;
-       }
-
-       /** {@inheritDoc} */
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {
-               // TODO Auto-generated method stub
-
-       }
+       
 
        /** {@inheritDoc} */
        @PreDestroy
        public void dispose() {
-               if(conversation!=null){
-                   conversation.close();
-                   conversation = null;
-               }
                if(searchJob != null) {
             searchJob.cancel();
         }
        }
 
-       private ConversationHolder getConversation_internal(){
-           if(conversation==null && CdmStore.isActive()){
-               try {
-                   conversation = CdmStore.createConversation();
-            } catch (Exception e) {
-                //nothing
-            }
-           }
-           return conversation;
-       }
 
        /**
         *
index 7802a6e363b72bf02e0d695b333ec9d4005c73cd..f6aee554c88545d84876662301779de5d75197ea 100644 (file)
@@ -41,8 +41,6 @@ import org.eclipse.swt.widgets.Tree;
 import org.eclipse.swt.widgets.TreeItem;
 import org.eclipse.ui.IMemento;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITermService;
 import eu.etaxonomy.cdm.api.service.IVocabularyService;
 import eu.etaxonomy.cdm.model.term.DefinedTermBase;
@@ -74,7 +72,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4SavablePart;
  * @since Aug 22, 2017
  *
  */
-public class DefinedTermEditorE4 implements IConversationEnabled, IDirtyMarkable, IPostOperationEnabled,
+public class DefinedTermEditorE4 implements IDirtyMarkable, IPostOperationEnabled,
 IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContextListener {
 
        public static final String OPEN_COMMAND_ID = "eu.etaxonomy.taxeditor.store.openDefinedTermEditor"; //$NON-NLS-1$
@@ -82,9 +80,7 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
 
        protected TreeViewer viewer;
 
-       protected ConversationHolder conversation;
-
-    @Inject
+       @Inject
     private ESelectionService selService;
 
     @Inject
@@ -109,14 +105,7 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
        @PostConstruct
        public void createPartControl(Composite parent, EMenuService menuService,
                IEclipseContext context) {
-           if (CdmStore.isActive()){
-            if(conversation == null){
-                conversation = CdmStore.createConversation();
-            }
-        }
-        else{
-            return;
-        }
+           
            FillLayout layout = new FillLayout();
            layout.marginHeight = 0;
            layout.marginWidth = 0;
@@ -197,7 +186,6 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
        @Override
     @Persist
        public void save(IProgressMonitor monitor) {
-               getConversationHolder().commit();
                List<DefinedTermBase> terms = new ArrayList<>();
                List<TermVocabulary> vocs = new ArrayList<>();
                for(TermBase term:changedTerms){
@@ -234,10 +222,7 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
            if(viewer!=null && viewer.getControl() != null && !viewer.getControl().isDisposed()){
                viewer.getControl().setFocus();
            }
-           if(conversation!=null){
-               conversation.bind();
-           }
-               if(input!=null){
+           if(input!=null){
                    input.bind();
                }
 
@@ -246,15 +231,6 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
                }
        }
 
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-       }
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
        @Override
        public void changed(Object element) {
            if(element instanceof DefinedTermBase){
@@ -295,11 +271,6 @@ IPartContentHasDetails, IPartContentHasSupplementalData, IE4SavablePart, IContex
 
        @PreDestroy
        public void dispose() {
-           if(conversation!=null){
-               conversation.unregisterForDataStoreChanges(this);
-               conversation.close();
-               conversation = null;
-           }
            if(input!=null){
                input.dispose();
            }
index 1c2799873e288b398501ef9c40e8551551f4bf6a..235c2e9ddde3a5ec578e76bff1e559b2c14ff2a7 100644 (file)
@@ -34,7 +34,7 @@ public class OpenPasswordWizzardHandlerE4 {
 
            if(principal instanceof User){
 
-               PasswordWizard wizard = new PasswordWizard((User)principal, null);
+               PasswordWizard wizard = new PasswordWizard((User)principal);
                WizardDialog dialog = new WizardDialog(shell, wizard);
 
                dialog.open();
index 3279d8b49627c945049ddaa89b4f309dde244375..c46fdfd3845f556f526bbb3b757b62c47d286fa0 100644 (file)
@@ -34,7 +34,6 @@ import org.eclipse.swt.widgets.Display;
 
 import eu.etaxonomy.cdm.api.application.CdmApplicationState;
 import eu.etaxonomy.cdm.api.application.ICdmRepository;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.common.monitor.IRemotingProgressMonitor;
 import eu.etaxonomy.cdm.io.cdmLight.CdmLightExportConfigurator;
 import eu.etaxonomy.cdm.io.common.CdmDefaultExport;
@@ -127,28 +126,28 @@ public class ExportManager
                                                                        + "Please check error log for details.", e);
                                }
 
-                               display.asyncExec(()-> {
-                                       Object activePart = EventUtility.getActivePart();
-                                       if (activePart instanceof IConversationEnabled) {
-                                               // terminate any open transactions
-                                               IConversationEnabled conversationEnabled = (IConversationEnabled) activePart;
-                                               // restarting transaction and committing it to
-                                               // trigger
-                                               // change listener
-                                               // TODO verify correct behaviour
-
-                                               try{
-                                                       conversationEnabled.getConversationHolder()
-                                                               .startTransaction();
-
-                                                       conversationEnabled.getConversationHolder()
-                                                               .commit();
-                                               }catch(RuntimeException e){
-                                                       MessagingUtils.messageDialog("Error starting conversation handling", this, "" +
-                                                                       "Conversation Error: "+ e);
-                                               }
-                                       }
-                               });
+//                             display.asyncExec(()-> {
+//                                     Object activePart = EventUtility.getActivePart();
+//                                     if (activePart instanceof IConversationEnabled) {
+//                                             // terminate any open transactions
+//                                             IConversationEnabled conversationEnabled = (IConversationEnabled) activePart;
+//                                             // restarting transaction and committing it to
+//                                             // trigger
+//                                             // change listener
+//                                             // TODO verify correct behaviour
+//
+//                                             try{
+//                                                     conversationEnabled.getConversationHolder()
+//                                                             .startTransaction();
+//
+//                                                     conversationEnabled.getConversationHolder()
+//                                                             .commit();
+//                                             }catch(RuntimeException e){
+//                                                     MessagingUtils.messageDialog("Error starting conversation handling", this, "" +
+//                                                                     "Conversation Error: "+ e);
+//                                             }
+//                                     }
+//                             });
                                monitor.worked(10);
 
                                return Status.OK_STATUS;
similarity index 95%
rename from eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/model/AbstractDataChangeBehaviour.java
rename to eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/model/AbstractDataChangeBehaviour_.java
index 0e2834915c2fb9cd3eb8e5b66d922aa230d70e00..6526e366b7eff2fec520707704fe07d38dbb90f5 100644 (file)
@@ -21,7 +21,7 @@ import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
  * @created 09.04.2009
  * @version 1.0
  */
-public abstract class AbstractDataChangeBehaviour implements IDataChangeBehavior {
+public abstract class AbstractDataChangeBehaviour_ implements IDataChangeBehavior {
        
        /* (non-Javadoc)
         * @see eu.etaxonomy.taxeditor.store.model.IDataChangeBehavior#reactOnDataChange(java.lang.Object, java.util.List)
index 70bfa7b97fba97864217f18249fd891ca5802392..dee0978a7e8bd89c828cbe78c31bfc4fef788ea2 100644 (file)
@@ -13,10 +13,6 @@ import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.wizard.Wizard;
 import org.eclipse.swt.widgets.Display;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
-import eu.etaxonomy.taxeditor.store.CdmStore;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
 
 /**
@@ -24,10 +20,7 @@ import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
  * @created Jun 1, 2010
  */
 public abstract class AbstractNewEntityWizard<T>
-        extends Wizard
-        implements IConversationEnabled {
-
-       protected ConversationHolder conversation;
+        extends Wizard {
 
        protected CdmFormFactory formFactory;
 
@@ -47,10 +40,6 @@ public abstract class AbstractNewEntityWizard<T>
        @Override
        public boolean performFinish() {
                saveEntity();
-
-               conversation.commit();
-               conversation.close();
-               conversation = null;
                return true;
        }
 
@@ -69,7 +58,6 @@ public abstract class AbstractNewEntityWizard<T>
 
        public void init(IWorkbench workbench, IStructuredSelection selection) {
            formFactory = new CdmFormFactory(Display.getCurrent(), null);
-           conversation = CdmStore.createConversation();
            this.selection = selection;
                entity = createNewEntity();
 
@@ -77,14 +65,6 @@ public abstract class AbstractNewEntityWizard<T>
 
        protected abstract T createNewEntity();
 
-       @Override
-    public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {}
-
        public IStructuredSelection getSelection() {
                return selection;
        }
index cd6ed01ea13c1be7587ada78a6b744be36e472de..606f5a7b71abd543cb60248066abb743ffd5986b 100755 (executable)
@@ -14,8 +14,6 @@ import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.wizard.Wizard;
 import org.eclipse.swt.widgets.Display;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.store.CdmStore;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -26,10 +24,7 @@ import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
  * @created Jun 1, 2010
  * @version 1.0
  */
-public abstract class AbstractNewEntityWizardParentChild<T> extends Wizard implements
-               IConversationEnabled {
-
-       private ConversationHolder conversation;
+public abstract class AbstractNewEntityWizardParentChild<T> extends Wizard {
 
        protected CdmFormFactory formFactory;
 
@@ -58,11 +53,6 @@ public abstract class AbstractNewEntityWizardParentChild<T> extends Wizard imple
                return true;
            }
                saveEntity();
-
-               conversation.commit();
-               conversation.close();
-               conversation = null;
-
                finished = true;
                return true;
        }
@@ -92,7 +82,6 @@ public abstract class AbstractNewEntityWizardParentChild<T> extends Wizard imple
        /** {@inheritDoc} */
        public void init(IWorkbench workbench, IStructuredSelection selection) {
            formFactory = new CdmFormFactory(Display.getCurrent(), null);
-           conversation = CdmStore.createConversation();
            this.selection = selection;
 
            createParentEntity();
@@ -100,19 +89,8 @@ public abstract class AbstractNewEntityWizardParentChild<T> extends Wizard imple
 
        }
 
-
-
        protected abstract void createParentEntity();
 
-       @Override
-    public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
-       /** {@inheritDoc} */
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {}
-
        public IStructuredSelection getSelection() {
                return selection;
        }
index bc1f0011b223da65a055d8ee233c5f6e354a0215..7a968133d315e4336006b411f01401b9404fe9be 100644 (file)
@@ -8,7 +8,6 @@
  */
 package eu.etaxonomy.taxeditor.newWizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.molecular.Amplification;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -28,9 +27,8 @@ public class AmplificationGeneralWizardPage extends AbstractCdmEntityWizardPage<
      * @param conversation
      * @param entity
      */
-    public AmplificationGeneralWizardPage(CdmFormFactory formFactory,
-            ConversationHolder conversation, Amplification entity) {
-        super(formFactory, conversation, entity);
+    public AmplificationGeneralWizardPage(CdmFormFactory formFactory, Amplification entity) {
+        super(formFactory, entity);
         setTitle("General Amplification Data");
     }
 
index 78b79339fa3c1c713eac78b51efca613c3182dbf..b8577246b376e8a6354931b965e2c100d6e3ac1f 100644 (file)
@@ -24,7 +24,7 @@ public class NewAmplificationWizard  extends AbstractNewEntityWizard<Amplificati
     /** {@inheritDoc} */
     @Override
     public void addPages() {
-        amplificationGeneralPage = new AmplificationGeneralWizardPage(formFactory, getConversationHolder(), getEntity());
+        amplificationGeneralPage = new AmplificationGeneralWizardPage(formFactory, getEntity());
         addPage(amplificationGeneralPage);
     }
 
index 7085e5554946a84a12a1c8824a805b322836d797..90a39cf776bf6c647709a4ad1c8eba1db4042a51 100644 (file)
@@ -41,7 +41,7 @@ public class NewClassificationWizard extends AbstractNewEntityWizard<Classificat
 
        @Override
        public void addPages() {
-               classificationWizardPage = new ClassificationWizardPage(formFactory, getConversationHolder(), getEntity());
+               classificationWizardPage = new ClassificationWizardPage(formFactory, getEntity());
                addPage(classificationWizardPage);
        }
 
index 697705e2f54d4108ac0c477fb6e8f20d21bb22d8..1b2d132aaebd1bd5f5dde76f814e09f02589caed 100644 (file)
@@ -26,7 +26,7 @@ public class NewCollectionWizard extends AbstractNewEntityWizard<Collection> {
        /** {@inheritDoc} */
        @Override
        public void addPages() {
-               addPage(new CollectionWizardPage(formFactory, getConversationHolder(), getEntity()));
+               addPage(new CollectionWizardPage(formFactory,  getEntity()));
        }
 
        /* (non-Javadoc)
index 513f38bd031982cc98171c5cd126548bafb42312..2aa27923ae9e6714f27786ad673ca72076803599 100644 (file)
@@ -50,16 +50,16 @@ public class NewDerivedUnitBaseWizard extends AbstractNewEntityWizard<SpecimenOr
         try {
             if(getEntity() instanceof DerivedUnit) {
                 facade = DerivedUnitFacade.NewInstance((DerivedUnit)getEntity(), PreferencesUtil.getDerivedUnitConfigurator());
-                addPage(new DerivedUnitGeneralWizardPage(formFactory, getConversationHolder(), facade));
-                addPage(new GatheringEventWizardPage(formFactory, getConversationHolder(), facade));
-                addPage(new FieldUnitWizardPage(formFactory, getConversationHolder(), facade));
-                addPage(new DerivedUnitBaseWizardPage(formFactory, getConversationHolder(), facade));
+                addPage(new DerivedUnitGeneralWizardPage(formFactory, facade));
+                addPage(new GatheringEventWizardPage(formFactory, facade));
+                addPage(new FieldUnitWizardPage(formFactory, facade));
+                addPage(new DerivedUnitBaseWizardPage(formFactory, facade));
             }
             else if(getEntity() instanceof FieldUnit){
                 facade = DerivedUnitFacade.NewInstance(SpecimenOrObservationType.FieldUnit, (FieldUnit)getEntity(), PreferencesUtil.getDerivedUnitConfigurator());
-                addPage(new FieldUnitGeneralWizardPage(formFactory, getConversationHolder(), facade));
-                addPage(new GatheringEventWizardPage(formFactory, getConversationHolder(), facade));
-                addPage(new FieldUnitWizardPage(formFactory, getConversationHolder(), facade));
+                addPage(new FieldUnitGeneralWizardPage(formFactory, facade));
+                addPage(new GatheringEventWizardPage(formFactory, facade));
+                addPage(new FieldUnitWizardPage(formFactory, facade));
             }
         } catch (DerivedUnitFacadeNotSupportedException e) {
             // we should never get here
index 1134ce0da956ba82c900a3d93db44c0a1cc3dd28..f04e20116b0e8b53302b7062750ba96d306d4325 100644 (file)
@@ -31,7 +31,7 @@ public class NewFeatureVocabularyWizard  extends AbstractNewEntityWizard<TermVoc
 
     @Override
     public void addPages() {
-        vocabularyPage = new VocabularyWizardPage(formFactory, getConversationHolder(), getEntity());
+        vocabularyPage = new VocabularyWizardPage(formFactory, getEntity());
         addPage(vocabularyPage);
     }
 
index 54efda3b6494ae6b33af3a8b74d3e1cbda06035a..233983cad0d237fd58de2189228dc86a6e2c14d9 100644 (file)
@@ -26,7 +26,7 @@ public class NewGrantedAuthorityWizard extends AbstractNewEntityWizard<GrantedAu
 
        @Override
        public void addPages() {
-               authorityPage = new GrantedAuthorityDetailWizardPage(formFactory, getConversationHolder(), getEntity());
+               authorityPage = new GrantedAuthorityDetailWizardPage(formFactory, getEntity());
                super.addPage(authorityPage);
        }
 
index 015a2e8a8bf2ee6586cef2c1382c97d285a1d1da..7f9d877cdf2b3212c500c58433a14b72654cc61c 100644 (file)
@@ -28,7 +28,7 @@ public class NewGroupWizard extends AbstractNewEntityWizard<Group> {
         */
        @Override
        public void addPages() {
-               groupPage = new GroupDetailWizardPage(formFactory, getConversationHolder(), getEntity());
+               groupPage = new GroupDetailWizardPage(formFactory, getEntity());
                super.addPage(groupPage);
        }
 
index 8d532da19e90ea7266d662c4bb15b9c8d5ca4560..afa55f54ae915a0abe4f6896d9fe618892f8773b 100644 (file)
@@ -21,7 +21,7 @@ public class NewInstitutionWizard extends AbstractNewEntityWizard<Institution> {
 
        @Override
        public void addPages() {
-               addPage(new InstitutionWizardPage(formFactory, getConversationHolder(), getEntity()));
+               addPage(new InstitutionWizardPage(formFactory, getEntity()));
        }
 
        @Override
index 023b13b428e0f2f75f595669a52b9cfdbfe1da26..4ae3567895dc702e12f5a95e6184ee8221b3e117 100644 (file)
@@ -29,7 +29,7 @@ public class NewNonViralNameWizard extends AbstractNewEntityWizard<TaxonName> {
        /** {@inheritDoc} */
        @Override
        public void addPages() {
-               addPage(new NonViralNameWizardPage(formFactory, getConversationHolder(), getEntity()));
+               addPage(new NonViralNameWizardPage(formFactory, getEntity()));
        }
 
        /** {@inheritDoc} */
index 3b396913eb7971ddd752b639042dfcf12beaec76..127b5277cd380d823ccc80b1ac641cc58046d094 100644 (file)
@@ -26,7 +26,7 @@ public class NewPersonWizard extends AbstractNewEntityWizard<Person> {
        /** {@inheritDoc} */
        @Override
        public void addPages() {
-               addPage(new PersonWizardPage(formFactory, getConversationHolder(), getEntity()));
+               addPage(new PersonWizardPage(formFactory, getEntity()));
        }
 
        /** {@inheritDoc} */
index 23cca956bb89108af50e040f2ae967318db5345a..9bb11dea9e90ce1d917f46a712ba57e2cd2e58ee 100644 (file)
@@ -18,7 +18,7 @@ public class NewPolytomousKeyWizard extends AbstractNewEntityWizard<PolytomousKe
 
        @Override
        public void addPages() {
-               polytomousKeyPage = new PolytomousKeyWizardPage(formFactory, getConversationHolder(), getEntity());
+               polytomousKeyPage = new PolytomousKeyWizardPage(formFactory, getEntity());
                super.addPage(polytomousKeyPage);
        }
 
index a00e275d9198a72179604691c824c5e5eeca7e7c..c4e980bd6f9523b7ea278f6cc8c8fd47caf0dcbf 100644 (file)
@@ -24,7 +24,7 @@ public class NewPrimerWizard  extends AbstractNewEntityWizard<Primer> {
     /** {@inheritDoc} */
     @Override
     public void addPages() {
-        primerPage = new PrimerWizardPage(formFactory, getConversationHolder(), getEntity());
+        primerPage = new PrimerWizardPage(formFactory, getEntity());
         addPage(primerPage);
     }
 
index 70f37d6edc8d0b17ec61496c564d258cdebe8d99..ee9d37d2f28c40bf1c08ea2c083036dc4c973fb1 100644 (file)
@@ -39,7 +39,6 @@ public class NewReferenceWizard extends AbstractNewEntityWizard<Reference> {
        @Override
        public void init(IWorkbench workbench, IStructuredSelection selection) {
         formFactory = new CdmFormFactory(Display.getCurrent(), null);
-        conversation = CdmStore.createConversation();
         this.selection = selection;
         setEntity(createNewEntity());
 
@@ -49,7 +48,7 @@ public class NewReferenceWizard extends AbstractNewEntityWizard<Reference> {
        public void addPages() {
                // TODO disabling external service wizard page for now
 //             addPage(new ExternalReferenceServiceWizardPage(formFactory, getConversationHolder(), entity));
-               referencePage = new ReferenceWizardPage(formFactory, getConversationHolder(), getEntity(), false);
+               referencePage = new ReferenceWizardPage(formFactory, getEntity(), false);
                addPage(referencePage);
        }
 
index 0cb41587224de38f6e527f759adfc6472f1f6213..206eb8a1d9d35ea69d771c07c9b23cf4b491556f 100644 (file)
@@ -54,7 +54,7 @@ public class NewTaxonNodeWizard extends AbstractNewEntityWizardParentChild<Taxon
 
     @Override
     public void addPages() {
-        taxonNodePage = new TaxonNodeWizardPage(formFactory, getConversationHolder(), getParentEntity(), wizardPageListener, true);
+        taxonNodePage = new TaxonNodeWizardPage(formFactory, getParentEntity(), wizardPageListener, true);
         addPage(taxonNodePage);
     }
 
@@ -64,8 +64,7 @@ public class NewTaxonNodeWizard extends AbstractNewEntityWizardParentChild<Taxon
         if(taxon == null ){
             openEmptyEditor = true;
         }else{
-            getConversationHolder().bind();
-            try{
+           try{
                UpdateResult result;
                TaxonNode parent = getParentEntity();
 
index a3aa31281a13aaccd197d5e0641e48db09065f87..c44ceb5cb2385527d9b890462b23fab013c3e5a5 100644 (file)
@@ -33,8 +33,8 @@ public class NewTaxonWizard extends AbstractNewEntityWizard<Taxon> {
        /** {@inheritDoc} */
        @Override
        public void addPages() {
-           addPage(new TaxonWizardPage(formFactory, getConversationHolder(), getEntity()));
-           addPage(new NonViralNameWizardPage(formFactory, getConversationHolder(), getEntity().getName()));
+           addPage(new TaxonWizardPage(formFactory, getEntity()));
+           addPage(new NonViralNameWizardPage(formFactory, getEntity().getName()));
        }
 
        /** {@inheritDoc} */
index b513886f27e84e58de23fb9850aa04626db3785d..09ef95411a2b41c880ba42dae1a3ecf83d5677c4 100644 (file)
@@ -37,7 +37,7 @@ public class NewTeamWizard extends AbstractNewEntityWizard<Team> {
        /** {@inheritDoc} */
        @Override
        public void addPages() {
-               addPage(new TeamWizardPage(formFactory, getConversationHolder(), getEntity(), isNomenclaturalTeam, isCollectorTeam));
+               addPage(new TeamWizardPage(formFactory, getEntity(), isNomenclaturalTeam, isCollectorTeam));
        }
 
        /* (non-Javadoc)
index 95baf5fe82c35d133e4b097259d2dd29e8cd6b98..4f6de340403aa1974d92bd8ca30d36fc51f3708b 100644 (file)
@@ -18,7 +18,7 @@ public class NewUserWizard extends AbstractNewEntityWizard<User> {
 
        @Override
        public void addPages() {
-               userPage = new UserDetailWizardPage(formFactory, getConversationHolder(), getEntity());
+               userPage = new UserDetailWizardPage(formFactory, getEntity());
                addPage(userPage);
        }
 
index c4248413cede4919ff5940f006c0588161632b9d..41d4bcdf38411c7fce88d0de92ae44274ee7e425 100644 (file)
@@ -3,7 +3,6 @@
  */
 package eu.etaxonomy.taxeditor.newWizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.description.PolytomousKey;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -17,9 +16,8 @@ import eu.etaxonomy.taxeditor.ui.section.key.PolytomousKeyDetailElement;
  */
 public class PolytomousKeyWizardPage extends AbstractCdmEntityWizardPage<PolytomousKey> {
 
-       public PolytomousKeyWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, PolytomousKey entity) {
-               super(formFactory, conversation, entity);
+       public PolytomousKeyWizardPage(CdmFormFactory formFactory, PolytomousKey entity) {
+               super(formFactory, entity);
        }
 
        @Override
index f9874848d1a3a87cbba90fcc0c60753f86116888..2a0becbdb2fa7a00db5ad07a471facf781bad340 100644 (file)
@@ -8,7 +8,6 @@
  */
 package eu.etaxonomy.taxeditor.newWizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.molecular.Primer;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -28,9 +27,8 @@ public class PrimerWizardPage extends AbstractCdmEntityWizardPage<Primer> {
      * @param conversation
      * @param entity
      */
-    public PrimerWizardPage(CdmFormFactory formFactory,
-            ConversationHolder conversation, Primer entity) {
-        super(formFactory, conversation, entity);
+    public PrimerWizardPage(CdmFormFactory formFactory, Primer entity) {
+        super(formFactory, entity);
         setTitle("General Primer Data");
     }
 
index 3344a7ab806134620063710a45bcf00f7a57ea50..1f6b658dacc602e7820d8c50de305c82d372315f 100644 (file)
@@ -8,7 +8,6 @@
  */
 package eu.etaxonomy.taxeditor.newWizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.term.TermVocabulary;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.vocabulary.TermVocabularyDetailElement;
  */
 public class VocabularyWizardPage extends AbstractCdmEntityWizardPage<TermVocabulary> {
 
-    public VocabularyWizardPage(CdmFormFactory formFactory,
-            ConversationHolder conversation, TermVocabulary entity) {
-        super(formFactory, conversation, entity);
+    public VocabularyWizardPage(CdmFormFactory formFactory, TermVocabulary entity) {
+        super(formFactory, entity);
         setTitle("General Vocabulary Data");
     }
 
index 7c949d73115b821cc5a7efdcb0ce15b90a23d1ae..499a34ec71234f8c07cab1a8aca5117b751b06f6 100644 (file)
 package eu.etaxonomy.taxeditor.operation;
 
 import org.eclipse.core.commands.operations.IUndoContext;
-import org.eclipse.core.runtime.Assert;
 import org.eclipse.core.runtime.IStatus;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.persistence.dto.TaxonNodeDto;
 import eu.etaxonomy.taxeditor.session.ICdmEntitySessionEnabled;
 
@@ -29,8 +27,6 @@ import eu.etaxonomy.taxeditor.session.ICdmEntitySessionEnabled;
  * @version 1.0
  */
 public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonOperation {
-       private final IConversationEnabled conversationEnabled;
-
        protected TaxonNodeDto parentNode;
 
           /**
@@ -39,12 +35,10 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
      * @param label a {@link java.lang.String} object.
      * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
      * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-     * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
      */
     protected AbstractPersistentPostOperation(String label, IUndoContext undoContext,
-            IPostOperationEnabled postOperationEnabled,
-            IConversationEnabled conversationEnabled) {
-        this(label, undoContext, postOperationEnabled, conversationEnabled, null);
+            IPostOperationEnabled postOperationEnabled) {
+        this(label, undoContext, postOperationEnabled, null);
     }
 
        /**
@@ -53,14 +47,11 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
         * @param label a {@link java.lang.String} object.
         * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        protected AbstractPersistentPostOperation(String label, IUndoContext undoContext,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
                        ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
                super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
-               this.conversationEnabled = conversationEnabled;
        }
 
        /**
@@ -70,16 +61,12 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
         * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
         * @param taxonNode a {@link eu.etaxonomy.cdm.model.taxon.TaxonNode} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         */
        public AbstractPersistentPostOperation(String label,
                        IUndoContext undoContext, TaxonNodeDto taxonNode,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
                        ICdmEntitySessionEnabled cdmEntitySessionEnabled) {
                super(label, undoContext, taxonNode, postOperationEnabled, cdmEntitySessionEnabled);
-               this.conversationEnabled = conversationEnabled;
-
        }
 
        /**
@@ -88,18 +75,14 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
         * @param label a {@link java.lang.String} object.
         * @param undoContext a {@link org.eclipse.core.commands.operations.IUndoContext} object.
         * @param postOperationEnabled a {@link eu.etaxonomy.taxeditor.operation.IPostOperationEnabled} object.
-        * @param conversationEnabled a {@link eu.etaxonomy.cdm.api.conversation.IConversationEnabled} object.
         * @param parentNode a {@link eu.etaxonomy.cdm.model.taxon.ITaxonTreeNode} object.
         */
        public AbstractPersistentPostOperation(String label,
                        IUndoContext undoContext,
                        IPostOperationEnabled postOperationEnabled,
-                       IConversationEnabled conversationEnabled,
-            ICdmEntitySessionEnabled cdmEntitySessionEnabled, TaxonNodeDto parentNode) {
+                       ICdmEntitySessionEnabled cdmEntitySessionEnabled, TaxonNodeDto parentNode) {
                super(label, undoContext, postOperationEnabled, cdmEntitySessionEnabled);
                this.parentNode = parentNode;
-               this.conversationEnabled = conversationEnabled;
-
        }
 
        /* (non-Javadoc)
@@ -108,15 +91,7 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
        /** {@inheritDoc} */
        @Override
     protected IStatus postExecute(Object objectAffectedByOperation) {
-               Assert.isNotNull(conversationEnabled, "Operation has to have a valid conversation attached.");
-
-
-               if (!conversationEnabled.getConversationHolder().isClosed()){
-                       conversationEnabled.getConversationHolder().bind();
-                       conversationEnabled.getConversationHolder().commit(true);
-               }
                IStatus status = super.postExecute(objectAffectedByOperation);
-
                return status;
        }
 
@@ -124,7 +99,6 @@ public abstract class AbstractPersistentPostOperation extends AbstractPostTaxonO
         * Binds the conversation that was attached to this operation.
         */
        public void bind(){
-               conversationEnabled.getConversationHolder().bind();
                if(getCdmEntitySessionEnabled() != null && getCdmEntitySessionEnabled().getCdmEntitySession()!=null) {
                    getCdmEntitySessionEnabled().getCdmEntitySession().bind();
         }
index 6d761f7d49e7c0a45000a4743c7fc54a6634b7e4..81275425d2722572991cb17d929042bc74d3deef 100755 (executable)
@@ -16,8 +16,6 @@ import org.eclipse.jface.wizard.Wizard;
 import org.osgi.service.prefs.BackingStoreException;
 import org.osgi.service.prefs.Preferences;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.location.NamedArea;
 import eu.etaxonomy.cdm.model.metadata.CdmPreference;
 import eu.etaxonomy.cdm.model.metadata.CdmPreference.PrefKey;
@@ -34,8 +32,7 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @since 05.10.2018
  *
  */
-public class AvailableDistributionPerAreaStatusWizard extends Wizard implements IConversationEnabled{
-    private ConversationHolder conversation;
+public class AvailableDistributionPerAreaStatusWizard extends Wizard {
     private final AvailableDistributionPerAreaStatusPage aPage;
     List<CdmPreference> prefs;
     private boolean isAdmin;
@@ -140,17 +137,4 @@ public class AvailableDistributionPerAreaStatusWizard extends Wizard implements
         return true;
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if (conversation == null) {
-            conversation = CdmStore.createConversation();
-        }
-        return conversation;
-    }
-
 }
index 5b32eb1f8377e18ce9c6efef68a9b44dda2faea6..e8dbfc70ebd7dcc67d58bf45b1208fb206bb2761 100755 (executable)
@@ -16,14 +16,11 @@ import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jface.wizard.IWizardPage;
 import org.eclipse.jface.wizard.Wizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITermService;
 import eu.etaxonomy.cdm.model.term.DefinedTermBase;
 import eu.etaxonomy.cdm.model.metadata.CdmPreference;
 import eu.etaxonomy.cdm.model.metadata.PreferencePredicate;
 import eu.etaxonomy.cdm.persistence.dto.TermDto;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.l10n.Messages;
 import eu.etaxonomy.taxeditor.preference.PreferencesUtil;
 import eu.etaxonomy.taxeditor.store.CdmStore;
@@ -33,8 +30,8 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @since 19.11.2018
  *
  */
-public class AvailableDistributionStatusAdminWizard extends Wizard implements IConversationEnabled{
-    private ConversationHolder conversation;
+public class AvailableDistributionStatusAdminWizard extends Wizard {
+    
     private final AvailableDistributionStatusPage aPage;
     CdmPreference pref;
 
@@ -110,17 +107,6 @@ public class AvailableDistributionStatusAdminWizard extends Wizard implements IC
         return true;
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if (conversation == null) {
-            conversation = CdmStore.createConversation();
-        }
-        return conversation;
-    }
+    
 
 }
index e4ba273af0d7539ac76ff3d698983849dd5ab4b3..2c901a44be88b08ee7234579a69f17ac3829fe31 100755 (executable)
@@ -16,8 +16,6 @@ import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jface.wizard.IWizardPage;
 import org.eclipse.jface.wizard.Wizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.metadata.CdmPreference;
 import eu.etaxonomy.cdm.model.metadata.PreferencePredicate;
 import eu.etaxonomy.cdm.model.term.TermType;
@@ -32,8 +30,8 @@ import eu.etaxonomy.taxeditor.store.CdmStore;
  * @since 05.10.2018
  *
  */
-public class AvailableDistributionStatusWizard extends Wizard implements IConversationEnabled{
-    private ConversationHolder conversation;
+public class AvailableDistributionStatusWizard extends Wizard {
+    
     private final AvailableDistributionStatusPage aPage;
     CdmPreference pref;
 
@@ -117,17 +115,5 @@ public class AvailableDistributionStatusWizard extends Wizard implements IConver
         return true;
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if (conversation == null) {
-            conversation = CdmStore.createConversation();
-        }
-        return conversation;
-    }
-
+    
 }
index 872e96799f6998cb48eb2a17b42fdb3bf90cf5d7..ee918dbbf6dc03a4157fa99433bb887ce4cf7e2a 100755 (executable)
@@ -15,25 +15,20 @@ import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jface.wizard.IWizardPage;
 import org.eclipse.jface.wizard.Wizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.metadata.CdmPreference;
 import eu.etaxonomy.cdm.model.metadata.PreferencePredicate;
 import eu.etaxonomy.cdm.model.metadata.PreferenceSubject;
 import eu.etaxonomy.cdm.persistence.dto.TermVocabularyDto;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.l10n.Messages;
 import eu.etaxonomy.taxeditor.preference.PreferencesUtil;
-import eu.etaxonomy.taxeditor.store.CdmStore;
 
 /**
  * @author k.luther
  * @since 04.06.2018
  *
  */
-public class AvailableVocabularyWizard extends Wizard implements IConversationEnabled {
+public class AvailableVocabularyWizard extends Wizard  {
 
-    private ConversationHolder conversation;
     private final AvailableAreaVocabulariesPage aPage;
     private boolean localPref = true;
     private CdmPreference pref;
@@ -123,16 +118,5 @@ public class AvailableVocabularyWizard extends Wizard implements IConversationEn
         return true;
     }
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-    }
-
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if (conversation == null) {
-            conversation = CdmStore.createConversation();
-        }
-        return conversation;
-    }
-
+    
 }
index 5d6a7265d30757e5a8198ee5306950ceee7e725d..5ce0601592a690d2502ce8d00ef0ade56d4a9ff6 100644 (file)
@@ -11,8 +11,6 @@ package eu.etaxonomy.taxeditor.preference.wizard;
 
 import org.eclipse.jface.wizard.Wizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITermService;
 import eu.etaxonomy.cdm.model.term.DefinedTermBase;
 import eu.etaxonomy.cdm.model.term.Representation;
@@ -28,7 +26,7 @@ import eu.etaxonomy.taxeditor.store.TermStore;
  * @created 12.06.2009
  * @version 1.0
  */
-public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard implements IConversationEnabled {
+public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard  {
        
        public T term = null;
        
@@ -36,15 +34,12 @@ public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard impl
 
        private Class<T> termClass;
 
-       private ConversationHolder conversation;
-
        /**
         * <p>Constructor for VocabularyTermWizard.</p>
         *
         * @param vocabularyClass a {@link java.lang.Class} object.
         */
-       public VocabularyTermWizard(Class<T> vocabularyClass, ConversationHolder conversation){ 
-               this.conversation = conversation;
+       public VocabularyTermWizard(Class<T> vocabularyClass){  
                termClass = vocabularyClass;
        }
        
@@ -54,8 +49,8 @@ public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard impl
         * @param vocabularyClass a {@link java.lang.Class} object.
         * @param selectedTerm a T object.
         */
-       public VocabularyTermWizard(Class<T> vocabularyClass, T selectedTerm, ConversationHolder conversation){
-               this(vocabularyClass, conversation);            
+       public VocabularyTermWizard(Class<T> vocabularyClass, T selectedTerm){
+               this(vocabularyClass);          
                term = (T) CdmStore.getService(ITermService.class).load(selectedTerm.getUuid());
                editMode = true;
        }
@@ -83,9 +78,7 @@ public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard impl
                }else{
                        TermStore.saveTerm(getTerm());
                }
-               
-               getConversationHolder().commit(true);
-               
+       
                return true;
        }
 
@@ -152,22 +145,6 @@ public class VocabularyTermWizard<T extends DefinedTermBase> extends Wizard impl
         */
        public Class<T> getTermClass() {
                return termClass;
-       }
-
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.persistence.hibernate.ICdmPostDataChangeObserver#update(eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap)
-        */
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-               // not needed
-       }
-
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.api.conversation.IConversationEnabled#getConversationHolder()
-        */
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
+       }       
 
 }
index 36b8adffd81adbc8611434f7758b82f169037ae6..734a24a1f3a1e9d1a558b026d97d0266b4d17dca 100644 (file)
@@ -22,8 +22,6 @@ import org.springframework.security.core.GrantedAuthority;
 import org.springframework.security.core.context.SecurityContextHolder;
 
 import eu.etaxonomy.cdm.api.application.CdmApplicationState;
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.util.CdmUserHelper;
 import eu.etaxonomy.cdm.api.util.RoleProberImpl;
 import eu.etaxonomy.cdm.api.util.UserHelper;
@@ -41,11 +39,11 @@ import eu.etaxonomy.taxeditor.model.MessagingUtils;
  * @created 03.07.2009
  * @version 1.0
  */
-public class LoginManager extends Observable implements IConversationEnabled, IContextListener{
+public class LoginManager extends Observable implements IContextListener{
 
        public static final Logger logger = LogManager.getLogger(LoginManager.class);
 
-       private ConversationHolder conversation;
+//     private ConversationHolder conversation;
 
        public static final String INCORRECT_CREDENTIALS_MESSAGE = "Login and/or Password incorrect";
        public static final String ACCOUNT_LOCKED_MESSAGE = "Account is locked";
@@ -156,23 +154,7 @@ public class LoginManager extends Observable implements IConversationEnabled, IC
                notifyObservers();
        }
 
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.persistence.hibernate.ICdmPostDataChangeObserver#update(eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap)
-        */
-       @Override
-       public void update(CdmDataChangeMap arg) {}
-
-       /* (non-Javadoc)
-        * @see eu.etaxonomy.cdm.api.conversation.IConversationEnabled#getConversationHolder()
-        */
-       @Override
-       public ConversationHolder getConversationHolder() {
-               if(conversation == null){
-                       conversation = CdmStore.createConversation();
-               }
-               return conversation;
-       }
-
+       
        /**
         * Whether the current user has the role admin
         *
@@ -205,12 +187,12 @@ public class LoginManager extends Observable implements IConversationEnabled, IC
 
        @Override
        public void contextStart(IMemento memento, IProgressMonitor monitor){
-               conversation = CdmStore.createConversation();
+               //conversation = CdmStore.createConversation();
        }
 
        @Override
        public void contextRefresh(IProgressMonitor monitor) {
-               conversation = CdmStore.createConversation();
+               //conversation = CdmStore.createConversation();
        }
 
        @Override
index 50735c5652a481492e2780a5a5995d2e6a4e045f..04fe41a4cc8c8738f67222e8f94dd711259d3f52 100644 (file)
@@ -60,7 +60,7 @@ public class SearchManager {
 
     private static final int MAX_RESULTS_BEFORE_WARNING = 500;
 
-       public List<TaxonName> findNames(IIdentifiableEntityServiceConfigurator configurator, ConversationHolder conversation){
+       public List<TaxonName> findNames(IIdentifiableEntityServiceConfigurator configurator){
            List<TaxonName> records = CdmStore.getService(INameService.class).findByFullTitle(configurator.getClazz(), configurator.getTitleSearchStringSqlized(), configurator.getMatchMode(), configurator.getCriteria(), configurator.getPageSize(), configurator.getPageNumber(), configurator.getOrderHints(), configurator.getPropertyPaths());
            return records;
        }
index 4649f7af42f8eb4750310c48d955634a050cc1c2..0e71ec7593fb071e960dec333900cce1bfa4edef 100644 (file)
@@ -407,12 +407,10 @@ public class TermManager {
         if (uuidList == null || uuidList.isEmpty()){
             return terms;
         }
-        Set<UUID> alreadyAdded = new HashSet<>();
-        Set<UUID> temp = new HashSet<>();
+       
         for (T term : terms){
             if(uuidList.contains(term.getUuid())){
                 filteredTerms.add(term);
-                alreadyAdded.add(term.getUuid());
             }
         } 
         return filteredTerms;
index 2f460357e896fe2765a1bc75fad38781fac3e8a0..ab0081056d23e5c447c11153c444126269bc29a4 100644 (file)
@@ -46,8 +46,6 @@ import org.eclipse.swt.layout.FillLayout;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.ui.IMemento;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.ITermNodeService;
 import eu.etaxonomy.cdm.api.service.ITermTreeService;
 import eu.etaxonomy.cdm.api.service.UpdateResult;
@@ -86,7 +84,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IE4ViewerPart;
 public class TermTreeEditor<T extends DefinedTermBase>
                implements ITermTreeEditor, ISelectionChangedListener,
                IE4ViewerPart, IPartContentHasDetails, IPartContentHasSupplementalData,
-               IContextListener, IConversationEnabled, IDirtyMarkable {
+               IContextListener, IDirtyMarkable {
 
     public static final String OPEN_COMMAND_ID = "eu.etaxonomy.taxeditor.store.openTermTreeEditor";
 
@@ -101,8 +99,6 @@ public class TermTreeEditor<T extends DefinedTermBase>
             "root.children.onlyApplicableIf.state", //$NON-NLS-1$
     });
 
-    private ConversationHolder conversation;
-
     private ICdmEntitySession cdmEntitySession;
 
     @Inject
@@ -219,19 +215,12 @@ public class TermTreeEditor<T extends DefinedTermBase>
     }
 
     private void initSession(){
-        if(conversation == null){
-            conversation = CdmStore.createConversation();
-        }
         if(cdmEntitySession==null){
             cdmEntitySession = CdmStore.getCurrentSessionManager().newSession(this, true);
         }
     }
 
     private void clearSession() {
-        if(conversation!=null){
-            conversation.close();
-            conversation = null;
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.dispose();
             cdmEntitySession = null;
@@ -262,9 +251,6 @@ public class TermTreeEditor<T extends DefinedTermBase>
            if(viewer!=null){
                viewer.getControl().setFocus();
            }
-        if(conversation!=null && !conversation.isBound()){
-            conversation.bind();
-        }
         if(cdmEntitySession != null) {
             cdmEntitySession.bind();
         }
@@ -288,21 +274,15 @@ public class TermTreeEditor<T extends DefinedTermBase>
            return (IStructuredSelection) viewer.getSelection();
        }
 
-       @Override
-       public ConversationHolder getConversationHolder() {
-           return conversation;
-       }
+       
 
        @Override
     @Persist
        public void save(IProgressMonitor monitor){
-        if (!conversation.isBound()) {
-            conversation.bind();
-        }
-
-        // commit the conversation and start a new transaction immediately
+        
+        
         ISelection sel = this.viewer.getSelection();
-        conversation.commit(true);
+        
         if (createOperationList != null && !createOperationList.isEmpty()){
             for (CreateFeatureTreeOperation operation: createOperationList.values()){
                 TermTreeDto termDto = getTreeDtoForUuid(operation.getElementUuid());
@@ -326,7 +306,7 @@ public class TermTreeEditor<T extends DefinedTermBase>
         listToUpdate.clear();
         List<TermTreeDto> rootEntities = getRootEntities();
         UpdateResult result = CdmStore.getService(ITermTreeService.class).saveOrUpdateTermTreeDtoList(rootEntities);
-        conversation.commit(true);
+       
         this.setDirty(false);
         initializeTrees();
         this.viewer.setSelection(sel);
@@ -396,10 +376,6 @@ public class TermTreeEditor<T extends DefinedTermBase>
     public void workbenchShutdown(IMemento memento, IProgressMonitor monitor) {
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
-
     @Override
     public void changed(Object element) {
         dirty.setDirty(true);
index 5ff533fda0a199d8ec24b26f8b0655c7f3aff93e..12ec9be6cbc044e9b8fdfad02d1b92ab22d5a4dc 100644 (file)
@@ -148,7 +148,7 @@ public abstract class AbstractComboElement<T>
             @SuppressWarnings("unchecked")
             @Override
             public void proposalAccepted(IContentProposal proposal) {
-                setSelection((T)combo.getData(proposal.getContent()));
+                setSelection((T)combo.getData(proposal.getContent()));                
                 firePropertyChangeEvent(new CdmPropertyChangeEvent(getComboElement(), null));
             }
         });
index e99f3b8a48773ed305ca773d9971057dead134f1..ebc6984b5bba9fc88b5a9e0b7a3898e033c143a5 100644 (file)
@@ -35,8 +35,6 @@ import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.IMemento;
 import org.eclipse.ui.dialogs.FilteredItemsSelectionDialog;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.term.IEnumTerm;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.model.MessagingUtils;
@@ -50,9 +48,7 @@ import eu.etaxonomy.taxeditor.store.internal.TaxeditorStorePlugin;
 * @created 18.07.2013
 */
 public abstract class AbstractFilteredCdmEnumSelectionDialog<T extends IEnumTerm> extends
-               FilteredItemsSelectionDialog implements IConversationEnabled {
-
-       private ConversationHolder conversation;
+               FilteredItemsSelectionDialog {
 
        protected List<T> model;
        private String settings;
@@ -69,7 +65,6 @@ public abstract class AbstractFilteredCdmEnumSelectionDialog<T extends IEnumTerm
         * @param <T> a T object.
         */
        protected AbstractFilteredCdmEnumSelectionDialog(Shell shell,
-                       ConversationHolder conversation,
                        String title,
                        boolean multi,
                        String settings,
@@ -78,9 +73,6 @@ public abstract class AbstractFilteredCdmEnumSelectionDialog<T extends IEnumTerm
                setTitle(title);
                setMessage("Use * for wildcard, or ? to see all entries");
                this.settings = settings;
-
-               this.conversation = conversation;
-
                init();
 
                initModel();
@@ -391,23 +383,11 @@ public abstract class AbstractFilteredCdmEnumSelectionDialog<T extends IEnumTerm
                                        T entity = (T) wizard.getEntity();
 
                                        refresh();
-                                       setPattern(entity);
-                                       getConversationHolder().bind();
+                                       setPattern(entity);                                     
                                }
                        }
                };
        }
 
-       /**
-        * <p>getConversationHolder</p>
-        *
-        * @return a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
-        */
-       @Override
-    public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {}
+       
 }
\ No newline at end of file
index f9942d69ab01ee62810314bf240c2fdc6f71c16c..fbc2c32bc97eb8ddbe476ba8abca722b33f06ae2 100644 (file)
@@ -35,10 +35,9 @@ public class OriginalSourceTypeSelectionDialog extends
         * @param conversation a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
         * @return a {@link eu.etaxonomy.cdm.model.reference.OriginalSourceType} object.
         */
-       public static OriginalSourceType select(Shell shell, ConversationHolder conversation){
+       public static OriginalSourceType select(Shell shell){
                OriginalSourceTypeSelectionDialog dialog =
-                               new OriginalSourceTypeSelectionDialog(shell,
-                                               conversation,
+                               new OriginalSourceTypeSelectionDialog(shell,                                            
                                                "Choose Original Source Type",
                                                false,
                                                OriginalSourceTypeSelectionDialog.class.getCanonicalName());
@@ -55,11 +54,10 @@ public class OriginalSourceTypeSelectionDialog extends
         * @param settings a {@link java.lang.String} object.
         */
        protected OriginalSourceTypeSelectionDialog(Shell shell,
-                       ConversationHolder conversation,
                        String title,
                        boolean multi,
                        String settings) {
-               super(shell, conversation, title, multi, settings, OriginalSourceType.PrimaryTaxonomicSource);
+               super(shell,  title, multi, settings, OriginalSourceType.PrimaryTaxonomicSource);
        }
 
 
index 0786eac362dfc5fc0ba4c1ce307262acb7f39898..9972a6d6a3e9ec446af1afaf6548b71d9cd0a3b2 100644 (file)
@@ -87,7 +87,7 @@ import eu.etaxonomy.taxeditor.ui.dialog.selection.CdmFilteredItemsSelectionDialo
  * @author k.luther
  * @date 15.11.2017d
  */
-public abstract class SearchDialog<T extends ICdmBase> extends Dialog{// implements IConversationEnabled{
+public abstract class SearchDialog<T extends ICdmBase> extends Dialog{
 
     private TableViewer list;
     private Text searchField;
index 15df121d38aacdc3933ed050316a2685db300904..ab08c8d7c9513d4892f51c026b966a1b7083584a 100644 (file)
@@ -31,7 +31,6 @@ public class SpecimenOrObservationTypeSelectionDialog extends
        public static SpecimenOrObservationType select(Shell shell, ConversationHolder conversation){
                SpecimenOrObservationTypeSelectionDialog dialog =
                                new SpecimenOrObservationTypeSelectionDialog(shell,
-                                               conversation,
                                                "Choose Specimen / Observation Type",
                                                false,
                                                SpecimenOrObservationTypeSelectionDialog.class.getCanonicalName());
@@ -48,11 +47,10 @@ public class SpecimenOrObservationTypeSelectionDialog extends
         * @param settings a {@link java.lang.String} object.
         */
        protected SpecimenOrObservationTypeSelectionDialog(Shell shell,
-                       ConversationHolder conversation,
                        String title,
                        boolean multi,
                        String settings) {
-               super(shell, conversation, title, multi, settings, SpecimenOrObservationType.Unknown);
+               super(shell, title, multi, settings, SpecimenOrObservationType.Unknown);
        }
 
 
index 6d0a3a6923162263a6675355c5260d8d38e402ad..ae64f95adeda1dd337f6720d5064e8bbea8584fd 100644 (file)
@@ -18,10 +18,7 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.ui.forms.widgets.ScrolledForm;
 import org.eclipse.ui.forms.widgets.TableWrapLayout;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.common.IIdentifiableEntity;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
 
 /**
@@ -33,14 +30,13 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  * @created Jun 1, 2010
  */
 public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
-               implements IConversationEnabled, IPropertyChangeListener {
+               implements IPropertyChangeListener {
 
        protected CdmFormFactory formFactory;
        protected T entity;
 
        AbstractCdmDetailElement<T> detailElement;
-       private final ConversationHolder conversation;
-
+       
        /**
         * <p>
         * Constructor for AbstractCdmEntityWizardPage.
@@ -57,12 +53,10 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
         * @param <T>
         *            a T object.
         */
-       protected AbstractCdmEntityWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, T entity) {
+       protected AbstractCdmEntityWizardPage(CdmFormFactory formFactory, T entity) {
                super("page");
                this.formFactory = formFactory;
                this.entity = entity;
-               this.conversation = conversation;
                setDescription(getEntityTitle());
 
                formFactory.addPropertyChangeListener(this);
@@ -93,7 +87,7 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
                layout.bottomMargin = 25;
         control.setLayout(layout);
                WizardPageRootElement rootElement = new WizardPageRootElement(
-                               formFactory, control, getConversationHolder());
+                               formFactory, control);
 
                Color bgColor = getShell().getBackground();
 
@@ -130,15 +124,11 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
        public abstract AbstractCdmDetailElement<T> createElement(
                        ICdmFormElement rootElement);
 
-       protected class WizardPageRootElement extends RootElement implements
-                       IConversationEnabled {
-
-               private final ConversationHolder conversation;
+       protected class WizardPageRootElement extends RootElement {
 
-               public WizardPageRootElement(CdmFormFactory formFactory,
-                               Composite layoutComposite, ConversationHolder conversation) {
+               public WizardPageRootElement(CdmFormFactory formFactory, Composite layoutComposite) {
                        super(formFactory, layoutComposite);
-                       this.conversation = conversation;
+                       
                }
 
                @Override
@@ -148,15 +138,7 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
                        detailElement = createElement(this);
                        ((Composite) getControl()).layout();
                }
-
-               @Override
-               public ConversationHolder getConversationHolder() {
-                       return conversation;
-               }
-
-               @Override
-               public void update(CdmDataChangeMap changeEvents) {
-               }
+               
        }
 
        @Override
@@ -193,19 +175,7 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
                return true;
        }
 
-       /**
-        * <p>
-        * getConversationHolder
-        * </p>
-        *
-        * @return a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder}
-        *         object.
-        */
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
+       
        /** {@inheritDoc} */
        @Override
        public void dispose() {
@@ -229,8 +199,5 @@ public abstract class AbstractCdmEntityWizardPage<T> extends WizardPage
                return detailElement;
        }
 
-       /** {@inheritDoc} */
-       @Override
-       public void update(CdmDataChangeMap changeEvents) {
-       }
+       
 }
index 10584bab3a597aebe15b48911c24eb0d53275661..595708563df95c52e859c3ec43529433fb9b291d 100644 (file)
@@ -35,8 +35,6 @@ import org.eclipse.ui.forms.widgets.Section;
 import org.eclipse.ui.forms.widgets.TableWrapLayout;
 import org.eclipse.ui.forms.widgets.ToggleHyperlink;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.model.AbstractUtility;
 import eu.etaxonomy.taxeditor.model.MessagingUtils;
@@ -55,7 +53,7 @@ import eu.etaxonomy.taxeditor.model.MessagingUtils;
 //TODO shouldn't ENTITY be bound with super class ICdmBase for example (AbstractFormSection<ENTITY extends ICdmBase>)?
 public abstract class AbstractFormSection<ENTITY>
         extends Section
-        implements ISelectionChangedListener, IEntityElement<ENTITY>, IConversationEnabled {
+        implements ISelectionChangedListener, IEntityElement<ENTITY> {
 
     /**
      * The default number of columns in detail sections
@@ -385,30 +383,4 @@ public abstract class AbstractFormSection<ENTITY>
                // empty default implementation
        }
 
-       @Override
-    public ConversationHolder getConversationHolder() {
-           if(AbstractUtility.getActivePart() instanceof IConversationEnabled){
-            return ((IConversationEnabled) AbstractUtility.getActivePart()).getConversationHolder();
-        }
-           if(getParentElement() instanceof RootElement || getParentElement() == null){
-
-               Object activeEditor = AbstractUtility.getActiveEditor();
-               if(activeEditor instanceof IConversationEnabled){
-                   ConversationHolder conversation = ((IConversationEnabled) AbstractUtility.getActiveEditor()).getConversationHolder();
-                   return conversation;
-               }
-           }else if(getParentElement() instanceof IConversationEnabled){
-               return ((IConversationEnabled) getParentElement()).getConversationHolder();
-           }
-               MessagingUtils.error(getClass(), "Could not get conversation for AbstractFormSection. There is an error in the implementation. There should have been an active editor but it wasn't",
-                               new IllegalArgumentException());
-               return null;
-
-       }
-
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {
-
-       }
-
 }
index d6b696c3e6243a56ef0f1e2a63bdd60cf892ecf6..99a17bbf66a761755a7935b908bc73e595177fcd 100755 (executable)
@@ -897,9 +897,8 @@ public class CdmFormFactory extends FormToolkit {
         return element;
     }
 
-    public EditPasswordElement createEditPasswordElement(ICdmFormElement parentElement, String labelString,
-            ConversationHolder conversation, User user, int style) {
-        EditPasswordElement element = new EditPasswordElement(this, parentElement, labelString, user, conversation);
+    public EditPasswordElement createEditPasswordElement(ICdmFormElement parentElement, String labelString, User user, int style) {
+        EditPasswordElement element = new EditPasswordElement(this, parentElement, labelString, user);
         adapt(element);
         parentElement.addElement(element);
         return element;
index d98749970d9c050052983d121dd6dbaf5950712f..aaf2f27de47c3df229720016671768d9eb3f7f54 100644 (file)
@@ -124,7 +124,7 @@ public class MultilanguageTextElement extends AbstractCdmFormElement implements
                combo_language = formFactory.createDefinedTermComboElement(TermType.Language, formElement,
                                                "", null, false, style);
                combo_language.addSelectionListener(this);
-
+               
                button = formFactory.createButton(getLayoutComposite(),
                                "Open In Translation Editor", SWT.PUSH);
                addControl(button);
@@ -199,7 +199,7 @@ public class MultilanguageTextElement extends AbstractCdmFormElement implements
            }
        }
 
-       private void updateControls() {
+       public void updateControls() {
                LanguageString preferredLanguageString = MultilanguageTextHelper
                                .getPreferredLanguageString(getMultilanguageText(),
                                                Arrays.asList(new Language[] { CdmStore
index 2c4919a191803ca0e20d9e0d3aae424f008d715e..d808b155844d48abe97cd1b712bbe5a1dfcebbf4 100644 (file)
@@ -15,8 +15,6 @@ import org.eclipse.swt.events.SelectionListener;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Label;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IUserService;
 import eu.etaxonomy.cdm.model.permission.User;
 import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
@@ -34,18 +32,15 @@ import eu.etaxonomy.taxeditor.ui.element.LayoutConstants;
  */
 public class EditPasswordElement
         extends AbstractCdmFormElement
-        implements SelectionListener, IConversationEnabled{
+        implements SelectionListener{
 
        private User user;
        private Button button;
 
-       private ConversationHolder conversation;
-
        public EditPasswordElement(CdmFormFactory formFactory,
-                       ICdmFormElement formElement, String labelString, User user, ConversationHolder conversation) {
+                       ICdmFormElement formElement, String labelString, User user) {
                super(formFactory, formElement);
 
-               this.conversation = conversation;
                this.user = user;
 
                Label label = formFactory.createLabel(getLayoutComposite(), null);
@@ -65,7 +60,7 @@ public class EditPasswordElement
                if(!CdmStore.getService(IUserService.class).userExists(user.getUsername())) {
                        MessagingUtils.warningDialog(Messages.EditPasswordElement_USERNAME_DOES_NOT_EXIST, this, String.format(Messages.EditPasswordElement_PLEASE_CREATE_OR_SAVE_USER, user.getUsername()));
                } else {
-                       PasswordWizard wizard = new PasswordWizard(user, conversation);
+                       PasswordWizard wizard = new PasswordWizard(user);
                        WizardDialog dialog = new WizardDialog(getLayoutComposite().getShell(), wizard);
                        dialog.open();
                }
@@ -74,11 +69,5 @@ public class EditPasswordElement
        @Override
        public void widgetDefaultSelected(SelectionEvent e) {}
 
-       @Override
-       public void update(CdmDataChangeMap arg0) {}
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
+       
 }
\ No newline at end of file
index 94dc0fb8193d2bc627438802dda8f4602628592e..f56f7eaef9c469b2046234bfaf8895d2bfba2132 100644 (file)
@@ -14,11 +14,8 @@ import org.eclipse.swt.widgets.Display;
 import org.springframework.security.access.AccessDeniedException;
 import org.springframework.security.core.AuthenticationException;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.api.service.IUserService;
 import eu.etaxonomy.cdm.model.permission.User;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.l10n.Messages;
 import eu.etaxonomy.taxeditor.model.MessagingUtils;
 import eu.etaxonomy.taxeditor.store.CdmStore;
@@ -29,19 +26,17 @@ import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
  * @created Mar 10, 2011
  * @version 1.0
  */
-public class PasswordWizard extends Wizard implements IConversationEnabled{
+public class PasswordWizard extends Wizard {
 
        private PasswordWizardPage passwordPage;
        private final User user;
-       private final ConversationHolder conversation;
-
+       
        /**
         * @param user the user to change the password for
         * @param conversation this optional parameter can be null. Only supply conversation if you
         * need to run this wizard is a nested conversation
         */
-       public PasswordWizard(User user, ConversationHolder conversation){
-               this.conversation = conversation;
+       public PasswordWizard(User user){
                this.user = user;
                setWindowTitle(Messages.PasswordWizardPage_CHANGE_PASSWORD);
        }
@@ -50,16 +45,13 @@ public class PasswordWizard extends Wizard implements IConversationEnabled{
        public void addPages() {
                CdmFormFactory formFactory = new CdmFormFactory(Display.getDefault());
 
-               passwordPage = new PasswordWizardPage(formFactory, getConversationHolder(), user);
+               passwordPage = new PasswordWizardPage(formFactory, user);
                addPage(passwordPage);
        }
 
        @Override
        public boolean performFinish() {
 
-               ConversationHolder internalConversation = CdmStore.getCurrentApplicationConfiguration().NewConversation();
-           internalConversation.bind();
-           internalConversation.startTransaction();
                String warningTitle = Messages.PasswordWizard_COULD_NOT_CHANGE_PWD;
         String warningMessage = Messages.PasswordWizard_OLD_PWD_INCORRECT;
         try{
@@ -74,10 +66,7 @@ public class PasswordWizard extends Wizard implements IConversationEnabled{
                        if (user.equals(CdmStore.getLoginManager().getAuthenticatedUser())){
                                CdmStore.getLoginManager().authenticate(user.getUsername(), passwordPage.getNewPassword());
                        }
-                   internalConversation.commit(false);
-                   internalConversation.unbind();
-                   internalConversation.close();
-                       return true;
+                       return true;
                }catch(AccessDeniedException e){
                        MessagingUtils.warningDialog(warningTitle, this, warningMessage);
                        return false;
@@ -88,20 +77,8 @@ public class PasswordWizard extends Wizard implements IConversationEnabled{
                }catch(Exception e){
                        MessagingUtils.warningDialog(Messages.PasswordWizard_PROBLEM_WITH_CHANGING_PWD, this, Messages.PasswordWizard_PWD_COULD_NOT_BE_CHANGED + e.getMessage());
                        return false;
-               }finally{
-                   if(conversation != null){
-                       conversation.bind();
-                   }
                }
        }
 
-       @Override
-       public void update(CdmDataChangeMap arg0) {
-       }
-
-       @Override
-       public ConversationHolder getConversationHolder() {
-               return conversation;
-       }
-
+       
 }
index ef2f695602e866d9e3f98fa51b56c896ad20ff97..28fe9e3f299dce53ffaf46f56fca1ab15268192c 100644 (file)
@@ -17,7 +17,6 @@ import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Text;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.permission.User;
 import eu.etaxonomy.taxeditor.l10n.Messages;
 import eu.etaxonomy.taxeditor.store.CdmStore;
@@ -40,9 +39,8 @@ public class PasswordWizardPage extends AbstractCdmEntityWizardPage<User> implem
        private TextWithLabelElement text_passwordRepeat;
        private final PasswordValidator passwordValidator;
 
-       protected PasswordWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, User entity) {
-               super(formFactory, conversation, entity);
+       protected PasswordWizardPage(CdmFormFactory formFactory, User entity) {
+               super(formFactory, entity);
 
                passwordValidator = new PasswordValidator();
 
@@ -58,7 +56,7 @@ public class PasswordWizardPage extends AbstractCdmEntityWizardPage<User> implem
                setPageComplete(false);
 
                control.setLayout(LayoutConstants.LAYOUT(2, false));
-               WizardPageRootElement rootElement = new WizardPageRootElement(formFactory, control, getConversationHolder());
+               WizardPageRootElement rootElement = new WizardPageRootElement(formFactory, control);
 
                if(isChangingOwnPassword()) {
                    text_oldPassword = formFactory.createTextWithLabelElement(rootElement, Messages.PasswordWizardPage_OLD_PASSWORD, null, SWT.PASSWORD);
index 015649846834d8277a83d48988e970cf804ce93b..6241b28a09aae4e612764d2a4d408842dd1c534a 100644 (file)
@@ -18,8 +18,6 @@ import org.eclipse.swt.SWT;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.common.CdmUtils;
 import eu.etaxonomy.cdm.model.common.CdmBase;
 import eu.etaxonomy.cdm.model.name.TaxonName;
@@ -244,19 +242,7 @@ public abstract class AbstractCdmDetailElement<T>
                MessagingUtils.error(event.getSource().getClass(), event.getException());
        }
 
-       @Override
-    public ConversationHolder getConversationHolder() {
-               if (getParentElement() instanceof IConversationEnabled) {
-                       return ((IConversationEnabled) getParentElement())
-                                       .getConversationHolder();
-               }
-               throw new IllegalArgumentException(
-                               "Parent element should be IConversationEnabled");
-       }
 
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {
-       }
 
        @Override
     public void update(Observable o, Object arg){
index 6dcee17c97fa8f65ff79c200dd79c16ed99c39da..589f5892dab1a7b96abbe481b4204f18f124e3ca 100644 (file)
@@ -18,11 +18,8 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.ui.forms.widgets.TableWrapLayout;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.common.CdmUtils;
 import eu.etaxonomy.cdm.model.common.CdmBase;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.model.ImageResources;
 import eu.etaxonomy.taxeditor.store.CdmStore;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement;
@@ -46,8 +43,7 @@ import eu.etaxonomy.taxeditor.ui.element.LayoutConstants;
  */
 public abstract class AbstractEntityCollectionElement<ENTITY>
         extends AbstractCdmFormElement
-        implements IEntityElement<ENTITY>, SelectionListener,
-              IConversationEnabled, IEnableableFormElement {
+        implements IEntityElement<ENTITY>, SelectionListener, IEnableableFormElement {
 
        protected ENTITY entity;
 
@@ -213,20 +209,6 @@ public abstract class AbstractEntityCollectionElement<ENTITY>
         return box;
     }
 
-       @Override
-    public ConversationHolder getConversationHolder() {
-               if (getParentElement() instanceof IConversationEnabled) {
-                       return ((IConversationEnabled) getParentElement())
-                                       .getConversationHolder();
-               }
-               throw new IllegalArgumentException(
-                               "Parent element should be IConversationEnabled");
-       }
-
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {
-       }
-
     public void setWarnForReferencedObjects(LabelElement warnForReferencedObjects) {
         this.warnForReferencedObjects = warnForReferencedObjects;
     }
index bdaa815ebf9fd29cd012ad77b24ae0688d0b1cda..e6ded9cb8c5b65cf51ea3efe106172ec0c11d8d9 100644 (file)
@@ -8,7 +8,6 @@
 */
 package eu.etaxonomy.taxeditor.ui.section;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.taxeditor.ui.element.IEnableableFormElement;
 import eu.etaxonomy.taxeditor.ui.element.IEntityElement;
 
@@ -17,7 +16,7 @@ import eu.etaxonomy.taxeditor.ui.element.IEntityElement;
  * @date 30.07.2013
  */
 public interface ICdmDetailElement<T>
-               extends IEntityElement<T>, IEnableableFormElement, IConversationEnabled{
+               extends IEntityElement<T>, IEnableableFormElement{
 
     public abstract void setEntity(T entity);
 }
\ No newline at end of file
index 1de47180332344d8a3a2fb2720ad04066d679c45..f926dd5b770b5d73a9d73883f81eb64e5897eb3c 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.agent;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.agent.Institution;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -29,9 +28,8 @@ public class InstitutionWizardPage extends
         * @param conversation
         * @param entity
         */
-       public InstitutionWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Institution entity) {
-               super(formFactory, conversation, entity);
+       public InstitutionWizardPage(CdmFormFactory formFactory, Institution entity) {
+               super(formFactory, entity);
        }
 
            /*
index 8852940808a415d5da322bb1cb4a95531ab83c1d..4538f8b7a6961b093063c3dd2d3930bb03fd1308 100644 (file)
@@ -12,7 +12,6 @@ package eu.etaxonomy.taxeditor.ui.section.agent;
 import org.apache.commons.lang3.StringUtils;
 import org.eclipse.swt.SWT;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.agent.AgentBase;
 import eu.etaxonomy.cdm.model.agent.Person;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
@@ -39,9 +38,8 @@ public class PersonWizardPage extends AbstractCdmEntityWizardPage<Person> {
         * @param conversation a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
         * @param entity a {@link eu.etaxonomy.cdm.model.agent.Person} object.
         */
-       public PersonWizardPage(CdmFormFactory formFactory, ConversationHolder conversation,
-                       Person entity) {
-               super(formFactory, conversation, entity);
+       public PersonWizardPage(CdmFormFactory formFactory, Person entity) {
+               super(formFactory, entity);
                setTitle("Person");
        }
 
index 13e64eae84e8cec23c9bace0341312a9dd0811d9..5eea80a9d968b167117e353e8000753c4f9f7f35 100644 (file)
@@ -11,7 +11,6 @@ package eu.etaxonomy.taxeditor.ui.section.agent;
 
 import org.eclipse.swt.SWT;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.agent.Team;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -46,9 +45,8 @@ public class TeamWizardPage extends AbstractCdmEntityWizardPage<Team> {
         * @param entity
         *            a {@link eu.etaxonomy.cdm.model.agent.Team} object.
         */
-       public TeamWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Team entity, boolean isNomenclaturalTeam, boolean isCollectorTeam) {
-               super(formFactory, conversation, entity);
+       public TeamWizardPage(CdmFormFactory formFactory, Team entity, boolean isNomenclaturalTeam, boolean isCollectorTeam) {
+               super(formFactory, entity);
                setTitle("Team");
                setIsNomenclaturalTeam(isNomenclaturalTeam);
                setIsCollectorTeam(isCollectorTeam);
index aff83e4aaa2310d656471eed90db11011a4a2df9..374ef3aa2b5c016e2d699035542d01233b086654 100644 (file)
@@ -18,20 +18,13 @@ import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.INewWizard;
 import org.eclipse.ui.IWorkbench;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
-import eu.etaxonomy.taxeditor.store.CdmStore;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
 /**
  * @author k.luther
  * @date 23.03.2016
  *
  */
-public abstract class AbstractEditWizard<T> extends Wizard implements
-INewWizard, IConversationEnabled{
-
-    private ConversationHolder conversation;
+public abstract class AbstractEditWizard<T> extends Wizard implements INewWizard{
 
     protected CdmFormFactory formFactory;
 
@@ -64,9 +57,6 @@ INewWizard, IConversationEnabled{
     @Override
     public boolean performFinish() {
         saveEntity();
-
-        conversation.commit();
-        conversation.close();
         return true;
     }
 
@@ -100,23 +90,7 @@ INewWizard, IConversationEnabled{
     @Override
     public void init(IWorkbench workbench, IStructuredSelection selection) {
         formFactory = new CdmFormFactory(context.get(Shell.class).getDisplay());
-        conversation = CdmStore.createConversation();
     }
-
-
-
-    /**
-     * <p>getConversationHolder</p>
-     *
-     * @return a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
-     */
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return conversation;
-    }
-
-    /** {@inheritDoc} */
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {}
+    
 
 }
index dc4b7afc49b62776a2b2101d761cbc3fef17fddb..d378b4896564c6cd613ecf1c9d3df5327bc5a5e4 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.classification;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.taxon.Classification;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -42,8 +41,8 @@ public class ClassificationWizardPage extends
         *            a {@link eu.etaxonomy.cdm.model.taxon.TaxonomicTree} object.
         */
        public ClassificationWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Classification entity) {
-               super(formFactory, conversation, entity);
+                       Classification entity) {
+               super(formFactory, entity);
                setTitle("Classification");
 
        }
index 55e7c2a219d2f22f56f85a347c23a8b31e736393..2cc53532f0f94ea19f8783421db91da6d5e661fa 100644 (file)
@@ -33,8 +33,6 @@ public class CloneClassificationWizard extends Wizard{
 
        private CloneClassificationWizardPage cloneClassificationWizardPage;
 
-    private ConversationHolder conversationHolder;
-
     private CdmFormFactory formFactory;
 
     private String classificationName;
@@ -49,13 +47,11 @@ public class CloneClassificationWizard extends Wizard{
     @Inject
     public CloneClassificationWizard() {
         super();
-        conversationHolder = CdmStore.createConversation();
-
     }
 
     public void init(Classification classification){
         formFactory = new CdmFormFactory(context.get(Shell.class).getDisplay());
-        cloneClassificationWizardPage = new CloneClassificationWizardPage(formFactory, conversationHolder, classification);
+        cloneClassificationWizardPage = new CloneClassificationWizardPage(formFactory, classification);
         addPage(cloneClassificationWizardPage);
     }
 
index 6019f7dc888ef2cbfd9a07bbbe04b692257bc546..b18df42f65516bad4814ab8b960c4001884b2f19 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.classification;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.reference.Reference;
 import eu.etaxonomy.cdm.model.taxon.Classification;
 import eu.etaxonomy.cdm.model.taxon.TaxonRelationshipType;
@@ -29,9 +28,8 @@ public class CloneClassificationWizardPage extends
 
        private CloneClassificationDetailElement detailElement;
 
-    public CloneClassificationWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Classification entity) {
-               super(formFactory, conversation, entity);
+    public CloneClassificationWizardPage(CdmFormFactory formFactory, Classification entity) {
+               super(formFactory, entity);
                setTitle("Clone Classification");
        }
 
index 550e8d50ebf7dc1d7fa535b66608f0587482c925..18bdb9966ac9531744e40d78e3d75fd9ab4ce033 100644 (file)
@@ -49,7 +49,6 @@ public class EditTaxonNodeWizard
 
     @Override
     protected void saveEntity() {
-        getConversationHolder().bind();
         TaxonNode node = getEntity();
         if (node.getSource().checkEmpty()){
             node.setSource(null);
@@ -60,7 +59,7 @@ public class EditTaxonNodeWizard
     }
     @Override
     public void addPages() {
-        taxonNodePage = new TaxonNodeWizardPage(formFactory, getConversationHolder(), getEntity(), wizardPageListener, false);
+        taxonNodePage = new TaxonNodeWizardPage(formFactory, getEntity(), wizardPageListener, false);
 
         addPage(taxonNodePage);
     }
index d1e6dcfa5a1b935f7488199879f8c41f41f4953d..45b3e198757abd9e3e63d1327ded512151fb4498 100644 (file)
@@ -15,7 +15,6 @@ import org.eclipse.swt.SWT;
 import org.eclipse.swt.widgets.Event;
 import org.eclipse.swt.widgets.Listener;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.service.dto.CreateTaxonDTO;
 import eu.etaxonomy.cdm.common.CdmUtils;
 import eu.etaxonomy.cdm.model.taxon.Taxon;
@@ -38,8 +37,8 @@ public class TaxonNodeWizardPage extends AbstractCdmEntityWizardPage<TaxonNode>
     private final boolean isCreateNew;
 
        public TaxonNodeWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, TaxonNode entity, IWizardPageListener closeOnEnterListener, boolean isCreateNew) {
-               super(formFactory, conversation, entity);
+                       TaxonNode entity, IWizardPageListener closeOnEnterListener, boolean isCreateNew) {
+               super(formFactory, entity);
                this.wizardPageListener = closeOnEnterListener;
 
                if (isCreateNew){
index adbe10c1d13786c0d3a2c619c7f25ca21d86ae10..752a91a2c5a38645a0fdd6d6bccaf50ce8091154 100644 (file)
@@ -8,7 +8,6 @@
 */
 package eu.etaxonomy.taxeditor.ui.section.grantedAuthority;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.permission.GrantedAuthorityImpl;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -21,9 +20,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class GrantedAuthorityDetailWizardPage extends AbstractCdmEntityWizardPage<GrantedAuthorityImpl> {
 
-       public GrantedAuthorityDetailWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, GrantedAuthorityImpl entity) {
-               super(formFactory, conversation, entity);
+       public GrantedAuthorityDetailWizardPage(CdmFormFactory formFactory, GrantedAuthorityImpl entity) {
+               super(formFactory,  entity);
                setTitle("Granted Authority");
        }
 
index a6f3d4a342e14b0fffbe6743a2b48ebfff277529..cdad799dab624b1afadb93f84b2769ccf9ad83a7 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.group;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.permission.Group;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -28,9 +27,8 @@ public class GroupDetailWizardPage  extends AbstractCdmEntityWizardPage<Group>{
         * @param conversation
         * @param entity
         */
-       public GroupDetailWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Group entity) {
-               super(formFactory, conversation, entity);
+       public GroupDetailWizardPage(CdmFormFactory formFactory, Group entity) {
+               super(formFactory, entity);
                setTitle("Group");
        }
 
index dc11774ccd53fc49dc5fa7ce9eaf38cde89bf318..c3f94a94760dfe479e764ad7f6edd97ca346c5b8 100644 (file)
@@ -70,17 +70,10 @@ public abstract class AbstractTypeDesignationElement<T extends TypeDesignationBa
            removeSourcesControls();
            removeNotDesignatedControls();
            if (this.entity != null && this.entity.hasDesignationSource()){
-               if (singleSourceElement == null){
-
+               if (singleSourceElement == null){            
                    singleSourceElement = formFactory.createOriginalSourceElement(formElement, entity, "Status Reference");
-//             selection_reference = formFactory
-//                        .createSelectionElement(Reference.class, formElement, "Status Reference",
-//                                entity.getCitation(), EntitySelectionElement.ALL, style);
-//
-//                text_referenceDetail = formFactory.createTextWithLabelElement(
-//                    formElement, "Reference Detail", entity.getCitationMicroReference(), style);
-
                }
+               singleSourceElement.setEntity(entity.getDesignationSource(true));
         }else{
             if (singleSourceElement != null){
                 removeReferenceControls();
@@ -90,10 +83,7 @@ public abstract class AbstractTypeDesignationElement<T extends TypeDesignationBa
                     this.entity.setCitationMicroReference(null);
                 }
             }
-        }
-           if (entity.hasDesignationSource()){
-            singleSourceElement.setEntity(entity.getDesignationSource(true));
-        }
+        }   
            checkbox_notDesignated = formFactory.createCheckbox(formElement, "Not Designated", entity.isNotDesignated(), style);
            sourceSection = formFactory.createSourceSection(formElement, StoreUtil.getSectionStyle(SourceSection.class, IdentifiableSource.class.getCanonicalName()));
         sourceSection.setLayoutData(LayoutConstants.FILL_HORIZONTALLY(2, 1));
index 92e5786deb87c9a192e9965949c1d7ecdb184ebb..96326a630eb10687c3da7799f5a02935a58f4080 100644 (file)
@@ -11,11 +11,8 @@ package eu.etaxonomy.taxeditor.ui.section.name;
 
 import org.eclipse.jface.wizard.Wizard;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.common.CdmBase;
 import eu.etaxonomy.cdm.model.name.NameRelationship;
-import eu.etaxonomy.cdm.persistence.hibernate.CdmDataChangeMap;
 import eu.etaxonomy.taxeditor.session.ICdmEntitySession;
 
 /**
@@ -25,7 +22,7 @@ import eu.etaxonomy.taxeditor.session.ICdmEntitySession;
  * @created Jun 1, 2010
  * @version 1.0
  */
-public class NameRelationshipWizard extends Wizard implements IConversationEnabled{
+public class NameRelationshipWizard extends Wizard {
 
        private static NameRelationshipDetailSection callingSection;
 
@@ -76,20 +73,4 @@ public class NameRelationshipWizard extends Wizard implements IConversationEnabl
        public NameRelationship getNameRelationship() {
                return page.getNameRelationship();
        }
-
-       /**
-        * <p>getConversationHolder</p>
-        *
-        * @return a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
-        */
-       @Override
-    public ConversationHolder getConversationHolder() {
-               return callingSection.getConversationHolder();
-       }
-
-       /** {@inheritDoc} */
-       @Override
-    public void update(CdmDataChangeMap changeEvents) {}
-
-
 }
index b577414fbd9bf7507ce01ac9f285a0fd049c47ec..a98ca7a287d9bb3a68bfaa4403da8a776e0c1be5 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.name;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.name.TaxonName;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -33,9 +32,8 @@ public class NonViralNameWizardPage extends AbstractCdmEntityWizardPage<TaxonNam
         * @param conversation a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
         * @param entity a {@link eu.etaxonomy.cdm.model.name.NonViralName} object.
         */
-       public NonViralNameWizardPage(CdmFormFactory formFactory, ConversationHolder conversation,
-                       TaxonName entity) {
-               super(formFactory, conversation, entity);
+       public NonViralNameWizardPage(CdmFormFactory formFactory, TaxonName entity) {
+               super(formFactory, entity);
                setTitle("Name");
        }
 
index d875d3529f2eb322228939501cd75679740575c8..5130f4d9ce8835a57b3772c0753e0de3ca57fffa 100644 (file)
@@ -8,7 +8,6 @@
 */
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.occurrence.Collection;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -30,9 +29,8 @@ public class CollectionWizardPage extends AbstractCdmEntityWizardPage<Collection
         * @param conversation a {@link eu.etaxonomy.cdm.api.conversation.ConversationHolder} object.
         * @param entity a {@link eu.etaxonomy.cdm.model.occurrence.Collection} object.
         */
-       public CollectionWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, Collection entity) {
-               super(formFactory, conversation, entity);
+       public CollectionWizardPage(CdmFormFactory formFactory, Collection entity) {
+               super(formFactory, entity);
                setPageComplete(true);
        }
 
index b215a2ec8d973c6e6104e89925aea80d261766a2..6cb595a6ca769f3ddccf61d22f778f6cf8710221 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class DerivedUnitBaseWizardPage extends AbstractCdmEntityWizardPage<DerivedUnitFacade> {
 
-       public DerivedUnitBaseWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, DerivedUnitFacade entity) {
-               super(formFactory, conversation, entity);
+       public DerivedUnitBaseWizardPage(CdmFormFactory formFactory, DerivedUnitFacade entity) {
+               super(formFactory, entity);
                setTitle("Derived Unit Details");
                setPageComplete(true);
        }
index 7f658046160f7d8a9fef3d1b9e046fe23901627e..da8a31c54cc7c87a3c272a689325f7b7a087620d 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class DerivedUnitGeneralWizardPage extends AbstractCdmEntityWizardPage<DerivedUnitFacade> {
 
-       public DerivedUnitGeneralWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, DerivedUnitFacade entity) {
-               super(formFactory, conversation, entity);
+       public DerivedUnitGeneralWizardPage(CdmFormFactory formFactory, DerivedUnitFacade entity) {
+               super(formFactory, entity);
                setTitle("General Specimen Data");
        }
 
index 99af179fc1360bd36164698b713a75ed687996d1..a2f56a19fcb3f6d789e8548d0c16b98b3afc66f5 100644 (file)
@@ -8,7 +8,6 @@
 */
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -25,9 +24,8 @@ public class FieldUnitGeneralWizardPage extends AbstractCdmEntityWizardPage<Deri
      * @param conversation
      * @param entity
      */
-    public FieldUnitGeneralWizardPage(CdmFormFactory formFactory,
-            ConversationHolder conversation, DerivedUnitFacade entity) {
-        super(formFactory, conversation, entity);
+    public FieldUnitGeneralWizardPage(CdmFormFactory formFactory, DerivedUnitFacade entity) {
+        super(formFactory,  entity);
         setTitle("General FieldUnit Data");
     }
 
index f76adabb6819b189f75a5a00e63816a7790ac709..6769c4192802930aa4d8abc750102bfb2a0f1929 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class FieldUnitWizardPage extends AbstractCdmEntityWizardPage<DerivedUnitFacade> {
 
-       public FieldUnitWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, DerivedUnitFacade entity) {
-               super(formFactory, conversation, entity);
+       public FieldUnitWizardPage(CdmFormFactory formFactory, DerivedUnitFacade entity) {
+               super(formFactory, entity);
                setTitle("Field Unit Details");
                setPageComplete(true);
        }
index aa4bee581dd18bf39e9020d4589e77c2c57a56d9..5a556be6f03984fff0e4d050f36c5324d87e5415 100644 (file)
@@ -9,7 +9,6 @@
 
 package eu.etaxonomy.taxeditor.ui.section.occurrence;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.api.facade.DerivedUnitFacade;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class GatheringEventWizardPage extends AbstractCdmEntityWizardPage<DerivedUnitFacade> {
 
-       public GatheringEventWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, DerivedUnitFacade entity) {
-               super(formFactory, conversation, entity);
+       public GatheringEventWizardPage(CdmFormFactory formFactory, DerivedUnitFacade entity) {
+               super(formFactory, entity);
                setTitle("Gathering Event Details");
                setPageComplete(true);
        }
index 6e4350ef6fcac7a86e3f873506a6fe309da9ceca..298e7b2a3fbcbb4cd0d30ebc113afc891df01d07 100644 (file)
@@ -10,7 +10,6 @@ package eu.etaxonomy.taxeditor.ui.section.taxon;
 
 import org.eclipse.swt.SWT;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.taxon.TaxonBase;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -23,9 +22,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class TaxonWizardPage extends AbstractCdmEntityWizardPage<TaxonBase<?>> {
 
-       public TaxonWizardPage(CdmFormFactory formFactory, ConversationHolder conversation,
-               TaxonBase<?> entity) {
-               super(formFactory, conversation, entity);
+       public TaxonWizardPage(CdmFormFactory formFactory, TaxonBase<?> entity) {
+               super(formFactory, entity);
                setTitle("Taxon");
        }
 
index 5fe9bcd870b2d89896f15598e4e0744f9b2e62be..d6f2f84e15d422d4a1d7e618a1e632b582c4ebea 100644 (file)
@@ -46,8 +46,7 @@ public class UserDetailElement extends AbstractCdmDetailElement<User> {
 
                if (userIsAuthenticated() || CdmStore.getLoginManager().isUserManager() || CdmStore.getLoginManager().isAdmin() ) {
                        formFactory.createEditPasswordElement(
-                                       formElement, "Change Password", getConversationHolder(),
-                                       entity, style);
+                                       formElement, "Change Password", entity, style);
                }
 
                text_emailAdress = formFactory.createTextWithLabelElement(formElement,
index 8e622e7ac2f03a1509d30d3e7ae0e82f6fe0ba0f..cbd44f8e1feee00a6a3b4e6ffd0e8d4f524e87a8 100644 (file)
@@ -3,7 +3,6 @@
  */
 package eu.etaxonomy.taxeditor.ui.section.user;
 
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;
 import eu.etaxonomy.cdm.model.permission.User;
 import eu.etaxonomy.taxeditor.ui.element.AbstractCdmEntityWizardPage;
 import eu.etaxonomy.taxeditor.ui.element.CdmFormFactory;
@@ -16,9 +15,8 @@ import eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement;
  */
 public class UserDetailWizardPage extends AbstractCdmEntityWizardPage<User> {
 
-       public UserDetailWizardPage(CdmFormFactory formFactory,
-                       ConversationHolder conversation, User entity) {
-               super(formFactory, conversation, entity);
+       public UserDetailWizardPage(CdmFormFactory formFactory, User entity) {
+               super(formFactory, entity);
                setTitle("User");
        }
 
index 222d470b43925a7d66f8e3d1e1e6783cbc2fe8f3..11140b45cecd00530859374e3f5cc6b01de648c6 100644 (file)
@@ -98,31 +98,28 @@ public class EditFromSelectionWizard extends Wizard implements
                        rootElement = service.load(entity.getUuid());
                }
                if (rootElement.isInstanceOf(Reference.class)&& selectionElement instanceof EntitySelectionElementWithAbbreviatedTitle<?>) {
-                       addPage(new ReferenceWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(),
+                       addPage(new ReferenceWizardPage(formFactory,                                    
                                        HibernateProxyHelper.deproxy(rootElement, Reference.class), true));
                } else if (rootElement.isInstanceOf(Reference.class) ) {
                        addPage(new ReferenceWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), HibernateProxyHelper.deproxy(rootElement, Reference.class), false));
+                                       HibernateProxyHelper.deproxy(rootElement, Reference.class), false));
                } else if (rootElement.isInstanceOf(Team.class) && (selectionElement instanceof EntitySelectionElementWithAbbreviatedTitle<?> )) {
                        addPage(new TeamWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), HibernateProxyHelper.deproxy(rootElement, Team.class), true, false));
+                                       HibernateProxyHelper.deproxy(rootElement, Team.class), true, false));
                } else if (rootElement.isInstanceOf(Team.class) && (selectionElement.getClass().equals(CollectorSelectionElement.class)) ){
                        addPage(new TeamWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), HibernateProxyHelper.deproxy(rootElement, Team.class), false, true));
+                                       HibernateProxyHelper.deproxy(rootElement, Team.class), false, true));
                } else if (rootElement.isInstanceOf(Team.class) && (selectionElement instanceof EntitySelectionElement<?>)) {
             addPage(new TeamWizardPage(formFactory,
-                    selectionElement.getConversationHolder(), HibernateProxyHelper.deproxy(rootElement, Team.class), false, false));
+                    HibernateProxyHelper.deproxy(rootElement, Team.class), false, false));
         } else if (rootElement.isInstanceOf(Person.class)) {
                        addPage(new PersonWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), HibernateProxyHelper.deproxy(rootElement, Person.class)));
+                                       HibernateProxyHelper.deproxy(rootElement, Person.class)));
                } else if (rootElement.isInstanceOf(TaxonName.class)) {
                        addPage(new NonViralNameWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(),
                                        HibernateProxyHelper.deproxy(rootElement, TaxonName.class)));
                } else if (rootElement.isInstanceOf(TaxonBase.class)) {
             addPage(new TaxonWizardPage(formFactory,
-                    selectionElement.getConversationHolder(),
                     HibernateProxyHelper.deproxy(rootElement, TaxonBase.class)));
         }  else if (rootElement.isInstanceOf(SpecimenOrObservationBase.class)) {
 
@@ -144,39 +141,29 @@ public class EditFromSelectionWizard extends Wizard implements
                                throw new IllegalStateException();
                        }
 
-                       addPage(new DerivedUnitGeneralWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), facade));
-                       addPage(new GatheringEventWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), facade));
-                       addPage(new FieldUnitWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(), facade));
+                       addPage(new DerivedUnitGeneralWizardPage(formFactory,facade));
+                       addPage(new GatheringEventWizardPage(formFactory, facade));
+                       addPage(new FieldUnitWizardPage(formFactory, facade));
                        if(facade.innerDerivedUnit()!=null){
-                           addPage(new DerivedUnitBaseWizardPage(formFactory,
-                                   selectionElement.getConversationHolder(), facade));
+                           addPage(new DerivedUnitBaseWizardPage(formFactory, facade));
                        }
                } else if (rootElement.isInstanceOf(Collection.class)) {
-                       addPage(new CollectionWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(),
+                       addPage(new CollectionWizardPage(formFactory,                                   
                                        HibernateProxyHelper.deproxy(rootElement, Collection.class)));
                } else if (rootElement instanceof Institution) {
                        addPage(new InstitutionWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(),
                                        HibernateProxyHelper.deproxy(rootElement, Institution.class)));
                } else if (rootElement instanceof User) {
                        addPage(new UserDetailWizardPage(formFactory,
-                                       selectionElement.getConversationHolder(),
                                        HibernateProxyHelper.deproxy(rootElement, User.class)));
                } else if (rootElement instanceof Primer) {
             addPage(new PrimerWizardPage(formFactory,
-                    selectionElement.getConversationHolder(),
                     HibernateProxyHelper.deproxy(rootElement, Primer.class)));
         } else if (rootElement instanceof Amplification) {
             addPage(new AmplificationGeneralWizardPage(formFactory,
-                    selectionElement.getConversationHolder(),
                     HibernateProxyHelper.deproxy(rootElement, Amplification.class)));
         } else if (rootElement instanceof PolytomousKey) {
             addPage(new PolytomousKeyWizardPage(formFactory,
-                    selectionElement.getConversationHolder(),
                     HibernateProxyHelper.deproxy(rootElement, PolytomousKey.class)));
         } else {
                        MessagingUtils.warningDialog("Missing interface", this,
index 5a39e8433f24f809fd9a1f087ad3fb763f25e230..9ca35a2bbf91c5106e98fb6a02e9ea4bd745b2a8 100644 (file)
@@ -27,8 +27,6 @@ import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.forms.widgets.TableWrapData;\r
 import org.springframework.security.core.GrantedAuthority;\r
 \r
-import eu.etaxonomy.cdm.api.conversation.ConversationHolder;\r
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;\r
 import eu.etaxonomy.cdm.api.service.IService;\r
 import eu.etaxonomy.cdm.common.CdmUtils;\r
 import eu.etaxonomy.cdm.model.common.CdmBase;\r
@@ -408,13 +406,7 @@ public class EntitySelectionElement<T extends CdmBase>
        public void widgetDefaultSelected(SelectionEvent e) {\r
        }\r
 \r
-//     @Override\r
-       public ConversationHolder getConversationHolder() {\r
-           if(getParentElement() instanceof IConversationEnabled) {\r
-            return ((IConversationEnabled)getParentElement()).getConversationHolder();\r
-        }\r
-           return null;\r
-       }\r
+\r
 \r
        @Override\r
        public void setBackground(Color color) {\r
index a37f910c16bb2dc24ecb638aae9330af079821ca..e57f7bed814b08b2e532459e5bd732f82c105507 100644 (file)
@@ -57,8 +57,7 @@ import eu.etaxonomy.taxeditor.workbench.part.IEditorAreaPart;
  *
  * @param <T> the CDM type that will be handled by this view
  */
-public abstract class DataImportView<T> implements IPartContentHasFactualData,
-IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, IContextListener, Listener, IEditorAreaPart{
+public abstract class DataImportView<T> implements IPartContentHasFactualData, IPartContentHasDetails, IPartContentHasSupplementalData, IContextListener, Listener, IEditorAreaPart{
 
     protected final Logger logger = LogManager.getLogger(DataImportView.class);
 
@@ -68,18 +67,11 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
 
     protected OccurenceQuery query;
 
-    private static ConversationHolder conversationHolder;
-
     private SaveImportedSpecimenAction saveImportedSpecimenAction;
 
-//    private Text textClassification;
-
-//    private Classification classification;
-
     protected Text textReferenceString;
 
     private Button selectAllButton;
-    //private Button selectNoneButton;
 
     private Button importButton;
 
@@ -89,14 +81,6 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
 
     private Abcd206ImportConfigurator config;
 
-//    public Classification getClassification() {
-//             return classification;
-//     }
-//
-//     public void setClassification(Classification classification) {
-//             this.classification = classification;
-//     }
-
        private Button btnBrowseClassification;
 
        private Button btnClear;
@@ -119,12 +103,7 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
      */
     @PostConstruct
     public void createPartControl(Composite parent) {
-        if(CdmStore.isActive()){
-            initConversation();
-        }
-        else{
-            return;
-        }
+        
         parent.setLayout(new GridLayout(1, false));
         Composite composite = new Composite(parent, SWT.NONE);
         composite.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true, 1, 1));
@@ -301,11 +280,6 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
 
     public abstract void query();
 
-    @Override
-    public void update(CdmDataChangeMap changeEvents) {
-        //nothing
-    }
-
     /**
      * Returns the text label of the given item.
      * @param item the item for which the label should be returns
@@ -318,10 +292,7 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
         if(getTable()!=null){
             getTable().setFocus();
         }
-        //make sure to bind again if maybe in another view the conversation was unbound
-        if(getConversationHolder()!=null && !getConversationHolder().isBound()){
-            getConversationHolder().bind();
-        }
+        
     }
 
     @Override
@@ -334,32 +305,15 @@ IConversationEnabled, IPartContentHasDetails, IPartContentHasSupplementalData, I
 
     @Override
     public void contextStart(IMemento memento, IProgressMonitor monitor) {
-        initConversation();
-    }
-
-    private void initConversation(){
-        if(conversationHolder==null){
-            conversationHolder = CdmStore.createConversation();
-        }
+       
     }
 
     @Override
     public void workbenchShutdown(IMemento memento, IProgressMonitor monitor) {
-        if(getConversationHolder()!=null && getConversationHolder().isBound() && !getConversationHolder().isClosed()) {
-            getConversationHolder().close();
-        }
+        
     }
 
-    /**
-     * @return the conversationHolder
-     */
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if(CdmStore.isActive() && conversationHolder==null){
-            initConversation();
-        }
-        return conversationHolder;
-    }
+    
 
     @Override
        public void handleEvent(Event event) {
index 8518ccdc8e8779eae386878631c4cea59f6ce366..b2bba93c6893670bf23418b72940d486e336eb0c 100644 (file)
@@ -189,7 +189,6 @@ public class SpecimenSearchWizard extends Wizard {
 
         @Override
         protected IStatus run(IProgressMonitor monitor) {
-            view.getConversationHolder().bind();
             view.query();
             Display.getDefault().asyncExec(new Runnable() {
 
index 19f81d003788bbfaea8db656a7ffc862e8d04421..df5c2c85bde09c890caf9b4c9e6746e883d92aa9 100644 (file)
@@ -43,7 +43,7 @@ import eu.etaxonomy.taxeditor.view.detail.CdmSectionPart;
  * @date 18.07.2017
  *
  */
-public abstract class AbstractCdmDataViewer extends Viewer implements IConversationEnabled{
+public abstract class AbstractCdmDataViewer extends Viewer {
         @Inject
         private Logger logger;
 
@@ -237,9 +237,6 @@ public abstract class AbstractCdmDataViewer extends Viewer implements IConversat
                formFactory.addPropertyChangeListener(sectionPart);
        }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        return null;
-       }
+    
 
 }
index 78976a08fae6adc89d9f87b0b54f080adb32afb1..d4c963ca9fed11c323e2445ed9091f391b7eacd1 100644 (file)
@@ -64,7 +64,7 @@ import eu.etaxonomy.taxeditor.workbench.part.ISelectionElementEditingPart;
  * @since Aug 10, 2017
  */
 public abstract class AbstractCdmEditorPartE4
-        implements IConversationEnabled, IDirtyMarkable, ISelectionElementEditingPart, IPostOperationEnabled{
+        implements IDirtyMarkable, ISelectionElementEditingPart, IPostOperationEnabled{
 
        private static final Logger logger = LogManager.getLogger(AbstractCdmEditorPartE4.class);
 
@@ -87,7 +87,6 @@ public abstract class AbstractCdmEditorPartE4
         private MPart thisPart;
 
         public DelaySelection(Object selection, MPart activePart, MPart thisPart) {
-            super();
             this.selection = selection;
             this.activePart= activePart;
             this.thisPart = thisPart;
@@ -189,10 +188,15 @@ public abstract class AbstractCdmEditorPartE4
             delaySelection.setActivePart(activePart);
             delaySelection.setThisPart(thisPart);
         }
+        //as long as the delay thread is running, 
         if(!isInDelay){
+               System.err.println("test: "+ this.getViewName()+ " - " + isInDelay);
             isInDelay = true;
             sync.asyncExec(delaySelection);
             previousSelection = selection;
+            System.err.println("after running delay: "+ this.getViewName()+ " - " + isInDelay);
+        }else {
+               System.err.println("another time: " + this.getViewName()+ " - " + isInDelay);
         }
     }
 
@@ -362,21 +366,10 @@ public abstract class AbstractCdmEditorPartE4
         return structuredSelection;
     }
 
-    @Override
-    public ConversationHolder getConversationHolder() {
-        if(selectionProvidingPart != null && selectionProvidingPart instanceof IConversationEnabled) {
-            return ((IConversationEnabled) selectionProvidingPart).getConversationHolder();
-        }
-        return null;
-    }
 
     @Override
     public boolean postOperation(Object objectAffectedByOperation) {
         changed(objectAffectedByOperation);
-//        Object part = selectionProvidingPart.getObject();
-//        if (part instanceof IBulkEditor){
-//             ((IBulkEditor)part).setSelection(createSelection(objectAffectedByOperation));
-//        }
         return true;
     }
 
@@ -407,10 +400,6 @@ public abstract class AbstractCdmEditorPartE4
 
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-    }
-
     @Override
     public void forceDirty() {
     }
index e3fbf613ebcece2c96c21f5a85c90fff1e03aebb..fd44c2a8587bf7f8402e16114a37772215678937 100644 (file)
@@ -19,7 +19,6 @@ import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.swt.SWTException;
 import org.eclipse.swt.widgets.Composite;
 
-import eu.etaxonomy.cdm.api.conversation.IConversationEnabled;
 import eu.etaxonomy.cdm.model.description.Feature;
 import eu.etaxonomy.taxeditor.l10n.Messages;
 import eu.etaxonomy.taxeditor.model.AbstractUtility;
@@ -74,12 +73,7 @@ public class DetailsPartE4 extends AbstractCdmEditorPartE4 implements IPartConte
                 showEmptyPage();
                 return;
             }
-            if(!(partObject instanceof ISelectionElementEditingPart) &&
-                    partObject instanceof IConversationEnabled && ((IConversationEnabled) partObject).getConversationHolder()==null) {
-                //TODO show specific message (refactor EmptyElement to allow specific messages)
-                showEmptyPage();
-                return;
-            }
+
             // do not show details for feature nodes TODO strange check to avoid having shown the distribution map for every FeatureNodeContainer
             if(structuredSelection.getFirstElement() instanceof FeatureNodeContainer){
                 // do show the map for distributions
@@ -96,9 +90,7 @@ public class DetailsPartE4 extends AbstractCdmEditorPartE4 implements IPartConte
             viewer.setSelection(structuredSelection, false);
 
             showViewer(structuredSelection, activePart, viewer);
-
-
-
+            
             return;
         }
         else{
index 949b392689a995551c23676091c06a4c89659194..01d91a36addf2b1348879cb813d39bf74571f26b 100755 (executable)
@@ -985,10 +985,7 @@ public class DetailsViewerE4 extends AbstractCdmDataViewer {
         addPart(termMediaSection);
     }
 
-    @Override
-    public void update(CdmDataChangeMap arg0) {
-
-    }
+   
     @Inject
     @Optional
     private void updateView(@UIEventTopic(WorkbenchEventConstants.REFRESH_DETAILS)boolean refresh){
index 7bc9e34e8641a0787057b64e9e42792ab2c5017c..ce3a383be648f7fc11e7e48f6fd06c0020b911f0 100644 (file)
@@ -188,9 +188,7 @@ public class SupplementalDataViewerE4 extends AbstractCdmDataViewer {
                addPart(cdmBaseSection);
        }
 
-       @Override
-       public void update(CdmDataChangeMap arg0) {
-       }
+       
 
        @Inject
     @Optional
index 3bb7814d2cb0dfdf15e64cacc4b32424c2756a16..244c68df6e23da583b0f1c4ee7cd4bf53b07869b 100644 (file)
@@ -67,7 +67,7 @@ public class DerivateLabelProvider extends ColumnLabelProvider {
 
     private static Map<DerivedUnit, Collection<SpecimenTypeDesignation>> typeDesignations;
 
-    private ConversationHolder conversation;
+//    private ConversationHolder conversation;
 
     private static DefinedTerm photoTerm = null;
     private static DefinedTerm drawingTerm = null;
@@ -213,17 +213,9 @@ public class DerivateLabelProvider extends ColumnLabelProvider {
         return getDerivateText(element);
     }
 
-    public void setConversation(ConversationHolder conversation) {
-        this.conversation = conversation;
-    }
-
-    public String getDerivateText(Object element){
-        return getDerivateText(element, conversation);
-    }
-
     //Note AM: not sure what this method is really used for, why do we need an explicit
     //         formatting for those few use-cases where this is used?
-    public static String getDerivateText(Object element, ConversationHolder conversation){
+    public static String getDerivateText(Object element){
         //TODO: use list of strings to assemble labels to avoid adding the separator every time and to allow null values
         TreeNode parentNode = null;
         TreeNode node = null;
@@ -235,10 +227,6 @@ public class DerivateLabelProvider extends ColumnLabelProvider {
             derivate = node.getValue();
         }
 
-        if(conversation!=null){
-            conversation.bind();
-        }
-
         final String emptyString = StringUtils.EMPTY;
         final String separator = " ";