Project

General

Profile

Actions

bug #10476

closed

Sources with name in source are not correctly deduplicated in footnotes

Added by Katja Luther 3 months ago. Updated 3 days ago.

Status:
Closed
Priority:
New
Assignee:
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

mail NaK:

Und manchmal wird die selbe Referenz zweimal in der Bibliographie angezeigt, hier z.B. https://caryophyllales.org/cdm_dataportal/taxon/382d5128-d409-4dac-be4b-a1a3df7fbcfc unter C und D. Ist das noch ein Bug?

This problem appears because the html strings are compared and the cdm-render-path is not the same:

for example:

<span class="reference">A. A. Anderberg, B. Axelius, R. Lundin, A. Tehler, H.-E. Wantorp & A. Wiklund, Onosma orientale (L.) L. (Boraginaceae) collected in Cyprus in Kew Bull. 47. 1992<a href="/algaterra-new/cdm_dataportal/reference/dacf8897-0619-41ae-bc12-c320bb9d0d04">
<i  class="superscript icon-interal-link-alt-solid"></i></a></span>
 <span class="nameUsedInSource">(as <a href="http://dataportal.test/algaterra-new/cdm_dataportal/name/96dc242d-f2bd-4dab-a9e1-7b62e7db5621/null/null/">
<span class="cdm:TaxonName uuid:96dc242d-f2bd-4dab-a9e1-7b62e7db5621" data-cdm-ref="/name/96dc242d-f2bd-4dab-a9e1-7b62e7db5621" 

data-cdm-render-path="1a28ed59-e15f-4001-b5c2-ea89f0012671">

<span class="name">
<span class="TaxonName">
<span class="name">Asparagus acutifolius</span>
<span class="authors"> L.</span></span></span>
<span class="reference"></span></span></span></a>)</span>

vs.

<span class="reference">A. A. Anderberg, B. Axelius, R. Lundin, A. Tehler, H.-E. Wantorp & A. Wiklund, Onosma orientale (L.) L. (Boraginaceae) collected in Cyprus in Kew Bull. 47. 1992<a href="/algaterra-new/cdm_dataportal/reference/dacf8897-0619-41ae-bc12-c320bb9d0d04">
<i  class="superscript icon-interal-link-alt-solid"></i></a></span>
 <span class="nameUsedInSource">(as <a href="http://dataportal.test/algaterra-new/cdm_dataportal/name/96dc242d-f2bd-4dab-a9e1-7b62e7db5621/null/null/">
<span class="cdm:TaxonName uuid:96dc242d-f2bd-4dab-a9e1-7b62e7db5621" data-cdm-ref="/name/96dc242d-f2bd-4dab-a9e1-7b62e7db5621" 

data-cdm-render-path="fb16929f-bc9c-456f-9d40-dec987b36438" >

<span class="name"><span class="TaxonName">
<span class="name">Asparagus acutifolius</span>
<span class="authors"> L.</span></span></span>
<span class="reference"></span></span></span></a>)</span>
Actions #1

Updated by Katja Luther 3 months ago

I already removed it in 10634f7c6b2e5c64b97ef6d6e324924a43fa8c70, but added it again. Have to check why.

Actions #2

Updated by Andreas Müller 3 months ago

  • Target version changed from Unassigned CDM tickets to Release 5.43
Actions #3

Updated by Katja Luther 2 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This is fixed by removing render path from footnote html code. Please review.

See on test server: https://test.e-taxonomy.eu/dataportal/preview/caryophyllales_spp/cdm_dataportal/taxon/382d5128-d409-4dac-be4b-a1a3df7fbcfc

Actions #4

Updated by Andreas Müller 3 days ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

The result looks as expected so I guess we can close the ticket.

Actions #5

Updated by Andreas Müller 3 days ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions

Also available in: Atom PDF